René's URL Explorer Experiment


Title: fix(webapp): require explicit native button types by carderne · Pull Request #4692 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(webapp): require explicit native button types by carderne · Pull Request #4692 · triggerdotdev/trigger.dev

X Title: fix(webapp): require explicit native button types by carderne · Pull Request #4692 · triggerdotdev/trigger.dev

Description: Trigger.dev – build and deploy durable AI agents and workflows - fix(webapp): require explicit native button types by carderne · Pull Request #4692 · triggerdotdev/trigger.dev

Open Graph Description: Summary Add explicit types to native dashboard buttons and enforce react/button-has-type. This prevents action buttons from accidentally submitting a surrounding form. Shared button primitives reta...

X Description: Summary Add explicit types to native dashboard buttons and enforce react/button-has-type. This prevents action buttons from accidentally submitting a surrounding form. Shared button primitives reta...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4692

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:02eb9c63-bc3f-0d18-0e5f-6cb2f869b60b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9A4C:1A28DE:349BF09:4B19193:6AFB0837
html-safe-nonce9fbee18b3544e959a495b50826d03892800cb2bc0b8dc77938c0cc81add5fd31
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTRDOjFBMjhERTozNDlCRjA5OjRCMTkxOTM6NkFGQjA4MzciLCJ2aXNpdG9yX2lkIjoiMjU5MTUwNzIyMDQ4Mzk1MzE5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacfadf000258eb3649ada0f1d2fa792880adb4bd486002a8804bd7ee268e06bd67
hovercard-subject-tagpull_request:4312883227
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/triggerdotdev/trigger.dev/4692/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/236a79b43aef5846f131308e7bd449e4da21170725f28f3823987cf3aba40bcb/triggerdotdev/trigger.dev/pull/4692
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/236a79b43aef5846f131308e7bd449e4da21170725f28f3823987cf3aba40bcb/triggerdotdev/trigger.dev/pull/4692
og:image:altSummary Add explicit types to native dashboard buttons and enforce react/button-has-type. This prevents action buttons from accidentally submitting a surrounding form. Shared button primitives reta...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecarderne
hostnamegithub.com
expected-hostnamegithub.com
None76fb13cb43f1834708971f45a9cfcab5df3177a7582086613d7cdc6e98c4bfde
turbo-cache-controlno-cache
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseafc998826cdd963c8f91a96ae5372809ab5e296b
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4692#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4692
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4692
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4692
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4692
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4692
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
https://github.com/triggerdotdev/trigger.dev
cardernehttps://github.com/carderne
refactor/webapp-redundant-fragments-tri-13381https://github.com/triggerdotdev/trigger.dev/tree/refactor/webapp-redundant-fragments-tri-13381
fix/webapp-explicit-button-types-tri-13381https://github.com/triggerdotdev/trigger.dev/tree/fix/webapp-explicit-button-types-tri-13381
Conversationhttps://github.com/triggerdotdev/trigger.dev/pull/4692
Commits1 (1)https://github.com/triggerdotdev/trigger.dev/pull/4692/commits
Checkshttps://github.com/triggerdotdev/trigger.dev/pull/4692/checks
Files changedhttps://github.com/triggerdotdev/trigger.dev/pull/4692/files
fix(webapp): require explicit native button typeshttps://github.com/triggerdotdev/trigger.dev/pull/4692#top
cardernehttps://github.com/carderne
refactor/webapp-redundant-fragments-tri-13381https://github.com/triggerdotdev/trigger.dev/tree/refactor/webapp-redundant-fragments-tri-13381
fix/webapp-explicit-button-types-tri-13381https://github.com/triggerdotdev/trigger.dev/tree/fix/webapp-explicit-button-types-tri-13381
https://github.com/carderne
cardernehttps://github.com/carderne
Aug 19, 2026https://github.com/triggerdotdev/trigger.dev/pull/4692#issue-5191626343
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4692
#4691https://github.com/triggerdotdev/trigger.dev/pull/4691
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4692
https://github.com/apps/changeset-bot
changeset-bothttps://github.com/apps/changeset-bot
Aug 19, 2026https://github.com/triggerdotdev/trigger.dev/pull/4692#issuecomment-5340843274
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4692
d7f329dhttps://github.com/triggerdotdev/trigger.dev/commit/d7f329dc118c5c2922ce358b7cbc2d8926c8e428
Click here to learn what changesets are, and how to add onehttps://changesets.dev/faq
Click here if you're a maintainer who wants to add a changeset to this PRhttps://github.com/triggerdotdev/trigger.dev/new/fix/webapp-explicit-button-types-tri-13381?filename=.changeset/bold-hoops-fly.md&value=---%0A%22webapp%22%3A%20patch%0A---%0A%0Afix(webapp)%3A%20require%20explicit%20native%20button%20types%0A
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4692
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Aug 19, 2026https://github.com/triggerdotdev/trigger.dev/pull/4692#issuecomment-5340845269
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4692
CodeRabbithttps://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=triggerdotdev/trigger.dev&utm_content=4692
Xhttps://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai
Mastodonhttps://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai
Reddithttps://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai
LinkedInhttps://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4692
https://github.com/carderne
cardernehttps://github.com/carderne
Aug 19, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4692#ref-pullrequest-5191637785
fix(webapp): enforce accessible image and role semantics #4693 https://github.com/triggerdotdev/trigger.dev/pull/4693
https://github.com/carderne
cardernehttps://github.com/carderne
August 19, 2026 11:23https://github.com/triggerdotdev/trigger.dev/pull/4692#event-29678219377
https://github.com/apps/devin-ai-integration
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4692
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4692
https://github.com/carderne
cardernehttps://github.com/carderne
force-pushedhttps://github.com/triggerdotdev/trigger.dev/compare/939d50907edee3a036bc6937143c1a79dde4d14b..6232bbcad627d0a89cab948c5893a0a292b0c15b
939d509https://github.com/triggerdotdev/trigger.dev/commit/939d50907edee3a036bc6937143c1a79dde4d14b
6232bbchttps://github.com/triggerdotdev/trigger.dev/commit/6232bbcad627d0a89cab948c5893a0a292b0c15b
Compare https://github.com/triggerdotdev/trigger.dev/compare/939d50907edee3a036bc6937143c1a79dde4d14b..6232bbcad627d0a89cab948c5893a0a292b0c15b
August 19, 2026 11:48https://github.com/triggerdotdev/trigger.dev/pull/4692#event-29679344810
https://github.com/carderne
cardernehttps://github.com/carderne
force-pushedhttps://github.com/triggerdotdev/trigger.dev/compare/6232bbcad627d0a89cab948c5893a0a292b0c15b..f9f586bb7fd6cf529f3484297a1ccba9db153ae2
6232bbchttps://github.com/triggerdotdev/trigger.dev/commit/6232bbcad627d0a89cab948c5893a0a292b0c15b
f9f586bhttps://github.com/triggerdotdev/trigger.dev/commit/f9f586bb7fd6cf529f3484297a1ccba9db153ae2
Compare https://github.com/triggerdotdev/trigger.dev/compare/6232bbcad627d0a89cab948c5893a0a292b0c15b..f9f586bb7fd6cf529f3484297a1ccba9db153ae2
August 19, 2026 11:49https://github.com/triggerdotdev/trigger.dev/pull/4692#event-29679394672
https://github.com/nicktrn
nicktrnhttps://github.com/nicktrn
Aug 19, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4692#pullrequestreview-4972615765
View reviewed changes https://github.com/triggerdotdev/trigger.dev/pull/4692/files
https://github.com/carderne
fix(webapp): require explicit native button typeshttps://github.com/triggerdotdev/trigger.dev/pull/4692/commits/d7f329dc118c5c2922ce358b7cbc2d8926c8e428
d7f329dhttps://github.com/triggerdotdev/trigger.dev/pull/4692/commits/d7f329dc118c5c2922ce358b7cbc2d8926c8e428
https://github.com/carderne
cardernehttps://github.com/carderne
force-pushedhttps://github.com/triggerdotdev/trigger.dev/compare/f9f586bb7fd6cf529f3484297a1ccba9db153ae2..d7f329dc118c5c2922ce358b7cbc2d8926c8e428
f9f586bhttps://github.com/triggerdotdev/trigger.dev/commit/f9f586bb7fd6cf529f3484297a1ccba9db153ae2
d7f329dhttps://github.com/triggerdotdev/trigger.dev/commit/d7f329dc118c5c2922ce358b7cbc2d8926c8e428
Compare https://github.com/triggerdotdev/trigger.dev/compare/f9f586bb7fd6cf529f3484297a1ccba9db153ae2..d7f329dc118c5c2922ce358b7cbc2d8926c8e428
August 19, 2026 14:54https://github.com/triggerdotdev/trigger.dev/pull/4692#event-29689522102
https://github.com/apps/pkg-pr-new
pkg-pr-newhttps://github.com/apps/pkg-pr-new
Aug 19, 2026https://github.com/triggerdotdev/trigger.dev/pull/4692#issuecomment-5343916792
Open in StackBlitzhttps://pkg.pr.new/template/389b9ee6-3af5-42ea-b2d9-3a172c96aaaf
d7f329dhttps://github.com/triggerdotdev/trigger.dev/runs/96114177446
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4692
https://github.com/carderne
cardernehttps://github.com/carderne
dda9504https://github.com/triggerdotdev/trigger.dev/commit/dda9504bdd9c219f55d0aa091684b4e8a02fbf40
Aug 19, 2026https://github.com/triggerdotdev/trigger.dev/pull/4692#event-29691938151
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4692
https://github.com/carderne
cardernehttps://github.com/carderne
August 19, 2026 15:36https://github.com/triggerdotdev/trigger.dev/pull/4692#event-29691949043
cardernehttps://github.com/carderne
Aug 19, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4692#ref-commit-4592fdf
https://github.com/carderne
fix(webapp): enforce accessible image and role semantics (https://github.com/triggerdotdev/trigger.dev/commit/4592fdf4d642053bd6f1f8933321df08184382a1
#4693https://github.com/triggerdotdev/trigger.dev/pull/4693
)https://github.com/triggerdotdev/trigger.dev/commit/4592fdf4d642053bd6f1f8933321df08184382a1
4592fdfhttps://github.com/triggerdotdev/trigger.dev/commit/4592fdf4d642053bd6f1f8933321df08184382a1
#4692https://github.com/triggerdotdev/trigger.dev/pull/4692
#4692https://github.com/triggerdotdev/trigger.dev/pull/4692
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4692
https://github.com/apps/devin-ai-integration
devin-ai-integration[bot] https://github.com/apps/devin-ai-integration
https://github.com/triggerdotdev/trigger.dev/pull/4692/files/939d50907edee3a036bc6937143c1a79dde4d14b
https://github.com/nicktrn
nicktrn https://github.com/nicktrn
https://github.com/triggerdotdev/trigger.dev/pull/4692/files/f9f586bb7fd6cf529f3484297a1ccba9db153ae2
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4692
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4692
https://github.com/carderne
https://github.com/nicktrn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.