René's URL Explorer Experiment


Title: fix(run-engine): stop a '*' concurrency key stranding its whole base queue by 1stvamp · Pull Request #4628 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(run-engine): stop a '*' concurrency key stranding its whole base queue by 1stvamp · Pull Request #4628 · triggerdotdev/trigger.dev

X Title: fix(run-engine): stop a '*' concurrency key stranding its whole base queue by 1stvamp · Pull Request #4628 · triggerdotdev/trigger.dev

Description: The bug A concurrency key is an unrestricted client string (ConcurrencyKeySchema is z.union([z.string(), z.number()]).transform(String)), and concurrencyKeySection does no escaping, so * reaches the queue raw. queueKey then renders it as ...:queue::ck:*, which is byte-identical to the wildcard member the CK scripts keep in the master queue to mean "this base queue has concurrency-key work". Every CK script ends with the same pair: -- Rebalance master queue with ck:* member redis.call('ZADD', masterQueueKey, earliestIdx[2], ckWildcardName) -- Remove old-format entry from master queue (transition cleanup) redis.call('ZREM', masterQueueKey, queueName) ckWildcardName is toCkWildcard(message.queue), and for a *-keyed run that returns the identical string, so the cleanup on the second line deletes what the rebalance on the first line just wrote. The master queue then has no entry for that base queue, while ckIndex and the variant queues still hold the work. Every concurrency key on the queue stops being dequeued, not just the * one. It is silent, and it only recovers if some later write happens to re-add the member. Reproduced before the fix: master queue AFTER normal ck enqueue: ["{org:...}:queue:task/my-task:ck:*"] master queue AFTER ck='*' enqueue: [] ckIndex members (work still queued): [":ck:user-1", ":ck:*"] dequeued: [] Blast radius is bounded to the environment that triggers it, so it is self-inflicted rather than cross-tenant, but a single trigger stalls the queue for everything on it. The fix Guard the cleanup so it never removes the wildcard member: if queueName ~= ckWildcardName then redis.call('ZREM', masterQueueKey, queueName) end Applied to all 10 CK scripts (4 enqueue, 6 ack/nack/dead-letter). No key-format change and no migration: a queue already stranded in Redis is repaired by its next write. I considered rejecting * at the API boundary instead and rejected it. Existing Redis state and TaskRun.concurrencyKey rows already hold raw :-bearing and * keys, so changing key construction would orphan in-flight messages and split concurrency accounting mid-deploy. Boundary validation would still be reasonable as belt-and-braces later, but the Lua guard alone fixes it including for state already out there. Testing ckWildcardKey.test.ts covers the enqueue, ack and nack paths. All three pass with the guard and all three fail without it, verified by reverting. Full src/run-queue/ suite is green (166 tests). Note for #4367 The virtual-time branch adds three more CK scripts with the same pattern (enqueueMessageCkVtimeTracked, enqueueMessageWithTtlCkVtimeTracked, nackMessageCkVtimeTracked). They do not exist on main so they are not in this PR; the same guard needs applying there, and I will do that on that branch.

Open Graph Description: The bug A concurrency key is an unrestricted client string (ConcurrencyKeySchema is z.union([z.string(), z.number()]).transform(String)), and concurrencyKeySection does no escaping, so * reaches th...

X Description: The bug A concurrency key is an unrestricted client string (ConcurrencyKeySchema is z.union([z.string(), z.number()]).transform(String)), and concurrencyKeySection does no escaping, so * reaches th...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4628

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0f4a1ec5-dfc7-59c4-c6ab-507203985478
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id92C2:226200:4632B40:5F7BF5C:6AFAF2D6
html-safe-noncea2d1001a289d91a6408b9652aaf2d152ba30339fed1aa2bf02a26558db7efa65
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkMyOjIyNjIwMDo0NjMyQjQwOjVGN0JGNUM6NkFGQUYyRDYiLCJ2aXNpdG9yX2lkIjoiNzc4MzY3NDAyNTc5NTU4MDYzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac250746bc0582081e9003985f487da53faf24deed931916dfbeae6c5f5184c082
hovercard-subject-tagpull_request:4284549700
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4628/files
twitter:imagehttps://avatars.githubusercontent.com/u/35831?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/35831?s=400&v=4
og:image:altThe bug A concurrency key is an unrestricted client string (ConcurrencyKeySchema is z.union([z.string(), z.number()]).transform(String)), and concurrencyKeySection does no escaping, so * reaches th...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea85e96a83bed7871993e6b1ffda24105928eee17
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4628/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4628%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4628%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4628/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4628/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4628/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
1stvamphttps://github.com/1stvamp
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
fix/ck-wildcard-master-queue-strandhttps://github.com/triggerdotdev/trigger.dev/tree/fix/ck-wildcard-master-queue-strand
Conversation 6 https://github.com/triggerdotdev/trigger.dev/pull/4628
Commits 1 https://github.com/triggerdotdev/trigger.dev/pull/4628/commits
Checks 44 https://github.com/triggerdotdev/trigger.dev/pull/4628/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/4628/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4628/files
fix(run-engine): stop a '*' concurrency key stranding its whole base queue https://github.com/triggerdotdev/trigger.dev/pull/4628/files#top
Show all changes 1 commit https://github.com/triggerdotdev/trigger.dev/pull/4628/files
5cd8c9a fix(run-engine): stop a '*' concurrency key stranding its whole base … 1stvamp Aug 15, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4628/commits/5cd8c9a66355fadcb230bf5f2ad49e9d53a82d6a
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/4628/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4628/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4628/files
ck-wildcard-queue-strand.md https://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-e4d875fcab07b5fc718c37c13c6e3718592da115ed1883e9f10b324e8b44026b
index.ts https://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-0365b31224e46e323c8868fee705d14146349e29abd175070c7e7a49e9cb73ae
ckWildcardKey.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-e54c8fa798b685ae6502824f930f302c2f7f948871d2a9eced888de7bdbde048
.server-changes/ck-wildcard-queue-strand.mdhttps://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-e4d875fcab07b5fc718c37c13c6e3718592da115ed1883e9f10b324e8b44026b
View file https://github.com/triggerdotdev/trigger.dev/blob/5cd8c9a66355fadcb230bf5f2ad49e9d53a82d6a/.server-changes/ck-wildcard-queue-strand.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4628/{{ revealButtonHref }}
internal-packages/run-engine/src/run-queue/index.tshttps://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-0365b31224e46e323c8868fee705d14146349e29abd175070c7e7a49e9cb73ae
View file https://github.com/triggerdotdev/trigger.dev/blob/5cd8c9a66355fadcb230bf5f2ad49e9d53a82d6a/internal-packages/run-engine/src/run-queue/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4628/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-0365b31224e46e323c8868fee705d14146349e29abd175070c7e7a49e9cb73ae
https://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-0365b31224e46e323c8868fee705d14146349e29abd175070c7e7a49e9cb73ae
https://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-0365b31224e46e323c8868fee705d14146349e29abd175070c7e7a49e9cb73ae
https://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-0365b31224e46e323c8868fee705d14146349e29abd175070c7e7a49e9cb73ae
https://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-0365b31224e46e323c8868fee705d14146349e29abd175070c7e7a49e9cb73ae
https://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-0365b31224e46e323c8868fee705d14146349e29abd175070c7e7a49e9cb73ae
https://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-0365b31224e46e323c8868fee705d14146349e29abd175070c7e7a49e9cb73ae
https://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-0365b31224e46e323c8868fee705d14146349e29abd175070c7e7a49e9cb73ae
https://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-0365b31224e46e323c8868fee705d14146349e29abd175070c7e7a49e9cb73ae
https://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-0365b31224e46e323c8868fee705d14146349e29abd175070c7e7a49e9cb73ae
https://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-0365b31224e46e323c8868fee705d14146349e29abd175070c7e7a49e9cb73ae
https://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-0365b31224e46e323c8868fee705d14146349e29abd175070c7e7a49e9cb73ae
https://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-0365b31224e46e323c8868fee705d14146349e29abd175070c7e7a49e9cb73ae
https://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-0365b31224e46e323c8868fee705d14146349e29abd175070c7e7a49e9cb73ae
https://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-0365b31224e46e323c8868fee705d14146349e29abd175070c7e7a49e9cb73ae
https://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-0365b31224e46e323c8868fee705d14146349e29abd175070c7e7a49e9cb73ae
https://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-0365b31224e46e323c8868fee705d14146349e29abd175070c7e7a49e9cb73ae
https://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-0365b31224e46e323c8868fee705d14146349e29abd175070c7e7a49e9cb73ae
https://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-0365b31224e46e323c8868fee705d14146349e29abd175070c7e7a49e9cb73ae
https://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-0365b31224e46e323c8868fee705d14146349e29abd175070c7e7a49e9cb73ae
internal-packages/run-engine/src/run-queue/tests/ckWildcardKey.test.tshttps://github.com/triggerdotdev/trigger.dev/pull/4628/files#diff-e54c8fa798b685ae6502824f930f302c2f7f948871d2a9eced888de7bdbde048
View file https://github.com/triggerdotdev/trigger.dev/blob/5cd8c9a66355fadcb230bf5f2ad49e9d53a82d6a/internal-packages/run-engine/src/run-queue/tests/ckWildcardKey.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4628/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.