René's URL Explorer Experiment


Title: fix(core): don't assume a 64-character idempotency key is pre-hashed on reset by claude[bot] · Pull Request #4626 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(core): don't assume a 64-character idempotency key is pre-hashed on reset by claude[bot] · Pull Request #4626 · triggerdotdev/trigger.dev

X Title: fix(core): don't assume a 64-character idempotency key is pre-hashed on reset by claude[bot] · Pull Request #4626 · triggerdotdev/trigger.dev

Description: Requested by Matt Aitken · Slack thread idempotencyKeys.reset() now honours an explicitly passed scope even when the key material happens to be 64 characters long. Before: resetIdempotencyKey treated any 64-character string as an already-computed hash and sent it to the API verbatim. That short-circuit ran before the scope logic, so if your key material is itself a 64-character digest (a common pattern when you hash your own dedup identity) the scope you passed was silently discarded and the un-hashed material went on the wire. The server stores the hash, so the reset matched no run and returned 404 every single time. Key material of any other length worked fine, which made this look arbitrary. After: a 64-character key with an explicit scope is sent verbatim first and, only when that attempt comes back a definitive not-found, retried as the derived scope hash. Every call that worked before behaves identically, and the previously impossible case now resolves on the fallback. How A 64-character string is forwarded unchanged, exactly as before, when: the idempotency key catalog recognises it (it came from idempotencyKeys.create() in this process), or no scope was passed, so there is nothing to derive a hash from, or the scope hash cannot be derived (e.g. scope: "run" outside a task context with no parentRunId). Otherwise the key is ambiguous: it may be raw material the caller wants hashed with the scope, or it may already be the stored hash. Reset sends the verbatim value first because that is what every previous version sent, so anything that resolved before still resolves with the same single request, the same target run, and the same errors. The derived hash is the new behaviour, so it only runs once the verbatim attempt has failed with a 404, a definitive "no run under this key". Any other error (a 503, a connection error) leaves the verbatim key's state unknown, and resetting a different key on unknown state would be an untargeted write the caller never asked for, so those errors surface unchanged. That has an honest cost: when the endpoint answers 503 for a miss it cannot confirm, the caller sees the 503 and retries rather than silently falling through to the derived key. When both attempts miss, the verbatim attempt's 404 is surfaced, again matching what previous versions threw. A side benefit of this order: a key from idempotencyKeys.create() reset with a scope from a cold process resolves in a single request, because the created key is itself the stored value. isIdempotencyKey is deliberately left alone: it applies the same length rule on the trigger path, but it is self-consistent there, and changing it would invalidate already-stored keys. The attachedOptions?.key / attachedOptions?.scope fallbacks below the old guard were unreachable (every catalog entry is a 64-character digest, so it always hit the short-circuit first) and re-deriving from them produces the identical hash anyway. They are removed rather than left as dead code. ✅ Checklist I have followed every step in the contributing guide The PR title follows the convention. I ran and tested the code works Testing Tests in packages/core/src/v3/idempotencyKeys.test.ts drive the real resetIdempotencyKey against a local HTTP server and assert on the exact values that reach the wire, in order. Nothing is mocked. They cover: 64-character material + explicit scope derives the global- and run-scoped hash once the verbatim key misses (fails without this change) the verbatim key wins when runs exist under both the verbatim value and the derived hash, so the pre-existing target is preserved keys from idempotencyKeys.create() are forwarded unchanged: catalog hit, no scope, and scope with a cold catalog (the last now a single request) a transient failure of the verbatim attempt surfaces its error without ever touching the derived key error surfacing: a double miss reports the key the caller passed, and a non-404 from the fallback is not swallowed ordinary short material is still hashed, and underivable run/attempt scopes still send a 64-character key verbatim while still throwing for shorter material pnpm run test ./src/v3/idempotencyKeys.test.ts --run # 18 passed pnpm run build --filter @trigger.dev/core # clean pnpm run format && pnpm run lint # clean Changelog idempotencyKeys.reset() now works when your idempotency key is itself 64 characters long. Previously any 64-character key was assumed to be already hashed, so passing one along with a scope silently ignored the scope and the reset never found a matching run. Follow-ups (not in this PR) docs/idempotency.mdx describes the idempotencyKey parameter of reset() as "the 64-character hash string" in one place while showing raw material plus { scope: "global" } a few lines later. Worth reconciling. No surface currently exposes the stored hash that the reset endpoint matches on: ctx.run.idempotencyKey, the run page and the idempotency_key query column all show the user-provided key. That is what leads people to send a value reset cannot match.

Open Graph Description: Requested by Matt Aitken · Slack thread idempotencyKeys.reset() now honours an explicitly passed scope even when the key material happens to be 64 characters long. Before: resetIdempotencyKey treat...

X Description: Requested by Matt Aitken · Slack thread idempotencyKeys.reset() now honours an explicitly passed scope even when the key material happens to be 64 characters long. Before: resetIdempotencyKey treat...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4626

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:941633e0-ffbd-ca06-30b0-e1f99300165d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8580:1B1C0F:6CA871:A07170:6AFAF502
html-safe-nonce5d531effccd808c70675c70698ecbd4ebdbdfb66209a60f72df16d3332efaab7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTgwOjFCMUMwRjo2Q0E4NzE6QTA3MTcwOjZBRkFGNTAyIiwidmlzaXRvcl9pZCI6IjQ2Mzk0NjM4MDI4MTM0NzgxNDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf271ec1ef345ab17435b103d43055005517c3e4e7e6a8e5f5af25832014c408b
hovercard-subject-tagpull_request:4283520381
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4626/files
twitter:imagehttps://avatars.githubusercontent.com/in/1236702?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/in/1236702?s=400&v=4
og:image:altRequested by Matt Aitken · Slack thread idempotencyKeys.reset() now honours an explicitly passed scope even when the key material happens to be 64 characters long. Before: resetIdempotencyKey treat...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea85e96a83bed7871993e6b1ffda24105928eee17
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4626/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4626%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4626%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4626/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4626/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4626/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
matt-aitkenhttps://github.com/matt-aitken
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
fix/idempotency-reset-64-char-keyhttps://github.com/triggerdotdev/trigger.dev/tree/fix/idempotency-reset-64-char-key
Conversation 27 https://github.com/triggerdotdev/trigger.dev/pull/4626
Commits 6 https://github.com/triggerdotdev/trigger.dev/pull/4626/commits
Checks 62 https://github.com/triggerdotdev/trigger.dev/pull/4626/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/4626/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4626/files
fix(core): don't assume a 64-character idempotency key is pre-hashed on reset https://github.com/triggerdotdev/trigger.dev/pull/4626/files#top
Show all changes 6 commits https://github.com/triggerdotdev/trigger.dev/pull/4626/files
ee13674 fix(core): don't assume a 64-character idempotency key is pre-hashed … claude Aug 14, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4626/commits/ee13674b1844818e300b365afadac8dd84067475
a92c878 chore: trim comments claude Aug 14, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4626/commits/a92c878f6f6292c43a4f656e2915a96ca02f50b7
1a28453 fix(core): retry a 64-character idempotency key verbatim when the der… claude Aug 15, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4626/commits/1a28453c56f1e1763efd1ad01eec9dd78c27b5bc
8744482 fix(core): don't let a failed speculative reset attempt abort the fal… claude Aug 15, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4626/commits/8744482e68e07ccfd6bdf361f1f0209207bdd0e6
fa7634f fix(core): try a 64-character reset key verbatim before the derived hash matt-aitken Aug 19, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4626/commits/fa7634f8c64d0191af0481dbc46a332dcc0c2042
dc081e5 fix(core): only fall back to the derived hash on a definitive not-found matt-aitken Aug 19, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4626/commits/dc081e578bc40ca80666aa110952eb399fb5efb8
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/4626/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4626/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4626/files
reset-idempotency-key-64-char.md https://github.com/triggerdotdev/trigger.dev/pull/4626/files#diff-601b8ea364800f80c5c9d96cfd384d924c6db36aec74dd67fdc8cbdf23fb08a0
idempotencyKeys.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4626/files#diff-2747f86d205c0dd7e05db148d09a881b336f2ad1ba6056fb56dac7a6fecadcaf
idempotencyKeys.ts https://github.com/triggerdotdev/trigger.dev/pull/4626/files#diff-3f23a45f5d6702f2db897ee0aafe6712095444c4ff47315358ff9c9f884291fd
.changeset/reset-idempotency-key-64-char.mdhttps://github.com/triggerdotdev/trigger.dev/pull/4626/files#diff-601b8ea364800f80c5c9d96cfd384d924c6db36aec74dd67fdc8cbdf23fb08a0
View file https://github.com/triggerdotdev/trigger.dev/blob/dc081e578bc40ca80666aa110952eb399fb5efb8/.changeset/reset-idempotency-key-64-char.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4626/{{ revealButtonHref }}
packages/core/src/v3/idempotencyKeys.test.tshttps://github.com/triggerdotdev/trigger.dev/pull/4626/files#diff-2747f86d205c0dd7e05db148d09a881b336f2ad1ba6056fb56dac7a6fecadcaf
View file https://github.com/triggerdotdev/trigger.dev/blob/dc081e578bc40ca80666aa110952eb399fb5efb8/packages/core/src/v3/idempotencyKeys.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4626/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4626/files#diff-2747f86d205c0dd7e05db148d09a881b336f2ad1ba6056fb56dac7a6fecadcaf
https://github.com/triggerdotdev/trigger.dev/pull/4626/files#diff-2747f86d205c0dd7e05db148d09a881b336f2ad1ba6056fb56dac7a6fecadcaf
packages/core/src/v3/idempotencyKeys.tshttps://github.com/triggerdotdev/trigger.dev/pull/4626/files#diff-3f23a45f5d6702f2db897ee0aafe6712095444c4ff47315358ff9c9f884291fd
View file https://github.com/triggerdotdev/trigger.dev/blob/dc081e578bc40ca80666aa110952eb399fb5efb8/packages/core/src/v3/idempotencyKeys.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4626/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4626/files#diff-3f23a45f5d6702f2db897ee0aafe6712095444c4ff47315358ff9c9f884291fd
https://github.com/triggerdotdev/trigger.dev/pull/4626/files#diff-3f23a45f5d6702f2db897ee0aafe6712095444c4ff47315358ff9c9f884291fd
https://github.com/triggerdotdev/trigger.dev/pull/4626/files#diff-3f23a45f5d6702f2db897ee0aafe6712095444c4ff47315358ff9c9f884291fd
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4626/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4626/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4626/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4626/files
https://github.com/triggerdotdev/trigger.dev/pull/4626/files#diff-3f23a45f5d6702f2db897ee0aafe6712095444c4ff47315358ff9c9f884291fd
https://github.com/triggerdotdev/trigger.dev/pull/4626/files#diff-3f23a45f5d6702f2db897ee0aafe6712095444c4ff47315358ff9c9f884291fd
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4626/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4626/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4626/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4626/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4626/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.