Title: perf(webapp): bound checkSchedule environment load to the requested ids by ericallam · Pull Request #4598 · triggerdotdev/trigger.dev · GitHub
Open Graph Title: perf(webapp): bound checkSchedule environment load to the requested ids by ericallam · Pull Request #4598 · triggerdotdev/trigger.dev
X Title: perf(webapp): bound checkSchedule environment load to the requested ids by ericallam · Pull Request #4598 · triggerdotdev/trigger.dev
Description: What CheckScheduleService.call loaded every environment of a project ({ id, type, archivedAt }, no filter) and then immediately narrowed to just the requested environmentIds via resolveProjectScopedEnvironments. It only ever uses the requested envs (to reject foreign env ids and reject archived branches). On a preview-heavy project that meant loading hundreds of archived branch rows to validate one, on a path called in a per-scheduled-task loop on the deploy path (createBackgroundWorker -> syncDeclarativeSchedules) and from upsertTaskSchedule. The query is index-backed and individually fast (rows_read/returned = 1 per predicate), so this is about result-set width / egress and wasted work at scale (~580k calls/24h observed via Insights), not a slow plan. Change Bound the environments relation load to boundedIn(environmentIds): environments: { where: { id: { in: boundedIn(environmentIds) } }, select: { id: true, type: true, archivedAt: true }, } Returns <= the number of requested envs (usually 1) instead of the whole project. Both existing behaviors are preserved: Foreign-id rejection: the relation is still scoped to the project, so a requested id belonging to another project never comes back and resolveProjectScopedEnvironments reports it as foreign (a missing requested id is already treated as foreign). Archived-branch rejection: a requested id that is an archived branch still comes back with archivedAt set, so the downstream Can't add or edit a schedule for an archived branch check still fires. archivedAt is kept in the select deliberately, so this bounds by id rather than filtering archived rows out. Evidence (isolated stack, seeded 1 prod env + 40 archived branch envs) Local EXPLAIN (ANALYZE) of the exact environments sub-select: rows returned buffers before (unbounded) 41 shared hit=12 after (id IN (requested)) 1 (Rows Removed by Filter: 40) shared hit=4 Same RuntimeEnvironment_projectId_idx, no plan change. Rows to the client drop to len(environmentIds), which is the point. Unit (vitest, testcontainers, real Postgres): apps/webapp/test/checkSchedule.test.ts extended to prove, on real rows, that the bounded load returns only the requested env (1 of 10), still reports a foreign id as foreign, and still surfaces an archived branch when it is the requested one. 5/5 pass. Full e2e (both execution modes, real stack): a purpose-built project with two declarative schedules.tasks. trigger dev: dev worker created, both schedules synced through the edited checkSchedule loop, no errors. trigger deploy (managed deployment): PRODUCTION worker registered, both schedules synced against the prod environment through the same loop, prod + dev schedule instances active, no errors. typecheck --filter webapp clean. Rollout / rollback Straight deploy, no flag, no migration. Rollback is revert-only (read-path narrowing, no data change). Old and in-flight rows read correctly under both the old and new code. Out of scope The two lower-priority sibling reads in the ticket (the Query/metrics env id->slug map and the env-var repository fan-out) are left for follow-ups; they need caching / per-method scoping rather than this single bound.
Open Graph Description: What CheckScheduleService.call loaded every environment of a project ({ id, type, archivedAt }, no filter) and then immediately narrowed to just the requested environmentIds via resolveProjectScope...
X Description: What CheckScheduleService.call loaded every environment of a project ({ id, type, archivedAt }, no filter) and then immediately narrowed to just the requested environmentIds via resolveProjectScope...
Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4598
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:42af6b9a-7cea-a021-adde-30078cb80210 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ADFE:18E4C3:77750:A9053:6AFAF167 |
| html-safe-nonce | 8ac550fd8d74c6308941739b230f005e6018fc8591eaea0fd5c1b768dd39043d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBREZFOjE4RTRDMzo3Nzc1MDpBOTA1Mzo2QUZBRjE2NyIsInZpc2l0b3JfaWQiOiIxNzcyNTMxNTg3NTE0ODIzMDE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | fcf9b1899db62d86bc4798733a495aff8d19a93193749425177a10d744fc2794 |
| hovercard-subject-tag | pull_request:4266571719 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4598/files |
| twitter:image | https://avatars.githubusercontent.com/u/534?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/534?s=400&v=4 |
| og:image:alt | What CheckScheduleService.call loaded every environment of a project ({ id, type, archivedAt }, no filter) and then immediately narrowed to just the requested environmentIds via resolveProjectScope... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git |
| octolytics-dimension-user_id | 95297378 |
| octolytics-dimension-user_login | triggerdotdev |
| octolytics-dimension-repository_id | 572570113 |
| octolytics-dimension-repository_nwo | triggerdotdev/trigger.dev |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 572570113 |
| octolytics-dimension-repository_network_root_nwo | triggerdotdev/trigger.dev |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a85e96a83bed7871993e6b1ffda24105928eee17 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width