René's URL Explorer Experiment


Title: perf(webapp): bound checkSchedule environment load to the requested ids by ericallam · Pull Request #4598 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: perf(webapp): bound checkSchedule environment load to the requested ids by ericallam · Pull Request #4598 · triggerdotdev/trigger.dev

X Title: perf(webapp): bound checkSchedule environment load to the requested ids by ericallam · Pull Request #4598 · triggerdotdev/trigger.dev

Description: What CheckScheduleService.call loaded every environment of a project ({ id, type, archivedAt }, no filter) and then immediately narrowed to just the requested environmentIds via resolveProjectScopedEnvironments. It only ever uses the requested envs (to reject foreign env ids and reject archived branches). On a preview-heavy project that meant loading hundreds of archived branch rows to validate one, on a path called in a per-scheduled-task loop on the deploy path (createBackgroundWorker -> syncDeclarativeSchedules) and from upsertTaskSchedule. The query is index-backed and individually fast (rows_read/returned = 1 per predicate), so this is about result-set width / egress and wasted work at scale (~580k calls/24h observed via Insights), not a slow plan. Change Bound the environments relation load to boundedIn(environmentIds): environments: { where: { id: { in: boundedIn(environmentIds) } }, select: { id: true, type: true, archivedAt: true }, } Returns <= the number of requested envs (usually 1) instead of the whole project. Both existing behaviors are preserved: Foreign-id rejection: the relation is still scoped to the project, so a requested id belonging to another project never comes back and resolveProjectScopedEnvironments reports it as foreign (a missing requested id is already treated as foreign). Archived-branch rejection: a requested id that is an archived branch still comes back with archivedAt set, so the downstream Can't add or edit a schedule for an archived branch check still fires. archivedAt is kept in the select deliberately, so this bounds by id rather than filtering archived rows out. Evidence (isolated stack, seeded 1 prod env + 40 archived branch envs) Local EXPLAIN (ANALYZE) of the exact environments sub-select: rows returned buffers before (unbounded) 41 shared hit=12 after (id IN (requested)) 1 (Rows Removed by Filter: 40) shared hit=4 Same RuntimeEnvironment_projectId_idx, no plan change. Rows to the client drop to len(environmentIds), which is the point. Unit (vitest, testcontainers, real Postgres): apps/webapp/test/checkSchedule.test.ts extended to prove, on real rows, that the bounded load returns only the requested env (1 of 10), still reports a foreign id as foreign, and still surfaces an archived branch when it is the requested one. 5/5 pass. Full e2e (both execution modes, real stack): a purpose-built project with two declarative schedules.tasks. trigger dev: dev worker created, both schedules synced through the edited checkSchedule loop, no errors. trigger deploy (managed deployment): PRODUCTION worker registered, both schedules synced against the prod environment through the same loop, prod + dev schedule instances active, no errors. typecheck --filter webapp clean. Rollout / rollback Straight deploy, no flag, no migration. Rollback is revert-only (read-path narrowing, no data change). Old and in-flight rows read correctly under both the old and new code. Out of scope The two lower-priority sibling reads in the ticket (the Query/metrics env id->slug map and the env-var repository fan-out) are left for follow-ups; they need caching / per-method scoping rather than this single bound.

Open Graph Description: What CheckScheduleService.call loaded every environment of a project ({ id, type, archivedAt }, no filter) and then immediately narrowed to just the requested environmentIds via resolveProjectScope...

X Description: What CheckScheduleService.call loaded every environment of a project ({ id, type, archivedAt }, no filter) and then immediately narrowed to just the requested environmentIds via resolveProjectScope...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4598

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:42af6b9a-7cea-a021-adde-30078cb80210
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idADFE:18E4C3:77750:A9053:6AFAF167
html-safe-nonce8ac550fd8d74c6308941739b230f005e6018fc8591eaea0fd5c1b768dd39043d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBREZFOjE4RTRDMzo3Nzc1MDpBOTA1Mzo2QUZBRjE2NyIsInZpc2l0b3JfaWQiOiIxNzcyNTMxNTg3NTE0ODIzMDE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacfcf9b1899db62d86bc4798733a495aff8d19a93193749425177a10d744fc2794
hovercard-subject-tagpull_request:4266571719
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4598/files
twitter:imagehttps://avatars.githubusercontent.com/u/534?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/534?s=400&v=4
og:image:altWhat CheckScheduleService.call loaded every environment of a project ({ id, type, archivedAt }, no filter) and then immediately narrowed to just the requested environmentIds via resolveProjectScope...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea85e96a83bed7871993e6b1ffda24105928eee17
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4598/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4598%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4598%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4598/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4598/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4598/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
ericallamhttps://github.com/ericallam
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
feature/tri-13187-perfcontrol-plane-checkschedule-loads-all-projecthttps://github.com/triggerdotdev/trigger.dev/tree/feature/tri-13187-perfcontrol-plane-checkschedule-loads-all-project
Conversation 3 https://github.com/triggerdotdev/trigger.dev/pull/4598
Commits 1 https://github.com/triggerdotdev/trigger.dev/pull/4598/commits
Checks 48 https://github.com/triggerdotdev/trigger.dev/pull/4598/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/4598/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4598/files
perf(webapp): bound checkSchedule environment load to the requested ids https://github.com/triggerdotdev/trigger.dev/pull/4598/files#top
Show all changes 1 commit https://github.com/triggerdotdev/trigger.dev/pull/4598/files
0873f09 perf(webapp): bound checkSchedule environment load to the requested ids ericallam Aug 12, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4598/commits/0873f09f457333f3daa4258e1ad8be13ba232924
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/4598/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4598/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4598/files
bound-checkschedule-environment-load.md https://github.com/triggerdotdev/trigger.dev/pull/4598/files#diff-221ef7e2e9fe618998cc53b635ab9a6036dae0e3ca0671a78dbf2597a0d76aca
checkSchedule.server.ts https://github.com/triggerdotdev/trigger.dev/pull/4598/files#diff-d09d176be0e62f7550b0a1fa3d70c9550990df9f485e0dc86ef44c241abf9641
checkSchedule.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4598/files#diff-dfca5f8ae1bbd6bf1e24c101572975406481065279679c0c961b440879de3103
.server-changes/bound-checkschedule-environment-load.mdhttps://github.com/triggerdotdev/trigger.dev/pull/4598/files#diff-221ef7e2e9fe618998cc53b635ab9a6036dae0e3ca0671a78dbf2597a0d76aca
View file https://github.com/triggerdotdev/trigger.dev/blob/0873f09f457333f3daa4258e1ad8be13ba232924/.server-changes/bound-checkschedule-environment-load.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4598/{{ revealButtonHref }}
apps/webapp/app/v3/services/checkSchedule.server.tshttps://github.com/triggerdotdev/trigger.dev/pull/4598/files#diff-d09d176be0e62f7550b0a1fa3d70c9550990df9f485e0dc86ef44c241abf9641
View file https://github.com/triggerdotdev/trigger.dev/blob/0873f09f457333f3daa4258e1ad8be13ba232924/apps/webapp/app/v3/services/checkSchedule.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4598/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4598/files#diff-d09d176be0e62f7550b0a1fa3d70c9550990df9f485e0dc86ef44c241abf9641
https://github.com/triggerdotdev/trigger.dev/pull/4598/files#diff-d09d176be0e62f7550b0a1fa3d70c9550990df9f485e0dc86ef44c241abf9641
https://github.com/triggerdotdev/trigger.dev/pull/4598/files#diff-d09d176be0e62f7550b0a1fa3d70c9550990df9f485e0dc86ef44c241abf9641
https://github.com/triggerdotdev/trigger.dev/pull/4598/files#diff-d09d176be0e62f7550b0a1fa3d70c9550990df9f485e0dc86ef44c241abf9641
apps/webapp/test/checkSchedule.test.tshttps://github.com/triggerdotdev/trigger.dev/pull/4598/files#diff-dfca5f8ae1bbd6bf1e24c101572975406481065279679c0c961b440879de3103
View file https://github.com/triggerdotdev/trigger.dev/blob/0873f09f457333f3daa4258e1ad8be13ba232924/apps/webapp/test/checkSchedule.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4598/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4598/files#diff-dfca5f8ae1bbd6bf1e24c101572975406481065279679c0c961b440879de3103
https://github.com/triggerdotdev/trigger.dev/pull/4598/files#diff-dfca5f8ae1bbd6bf1e24c101572975406481065279679c0c961b440879de3103
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4598/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.