Title: fix(webapp): drop unused OrgMember _count aggregate from org-list presenter by ericallam · Pull Request #4587 · triggerdotdev/trigger.dev · GitHub
Open Graph Title: fix(webapp): drop unused OrgMember _count aggregate from org-list presenter by ericallam · Pull Request #4587 · triggerdotdev/trigger.dev
X Title: fix(webapp): drop unused OrgMember _count aggregate from org-list presenter by ericallam · Pull Request #4587 · triggerdotdev/trigger.dev
Description: What OrganizationsPresenter.#getOrganizations selected a Prisma _count.members relation on every org-list load (hit on nearly every dashboard navigation). Prisma lowers that relation _count to a whole-OrgMember-table GROUP BY organizationId aggregate joined onto Organization. The computed membersCount field is read by nothing in the webapp, so the entire aggregate scan is wasted work. This removes the _count select and the membersCount field. The query keeps only the indexed EXISTS membership filter and the org/project selects. Why it's safe membersCount has zero consumers (whole-webapp grep finds the name only at the point of assignment). It was added in #1796 (2023) and has been unused since. The member count shown on the org settings/team page comes from a separate presenter query, not this one. No user-visible change. Evidence (generated SQL, before/after, seeded isolated stack) Before (with _count.members): SELECT ..., COALESCE(aggr._aggr_count_members, 0) FROM "Organization" LEFT JOIN (SELECT "organizationId", COUNT(*) AS _aggr_count_members FROM "OrgMember" GROUP BY "organizationId") aggr ON ... WHERE EXISTS (... "userId" = $1 ...) AND "deletedAt" IS NULL ORDER BY "createdAt" DESC After: SELECT id, slug, title, avatar, "featureFlags" FROM "Organization" WHERE EXISTS (... "userId" = $1 ...) AND "deletedAt" IS NULL ORDER BY "createdAt" DESC The whole-table GROUP BY aggregate is gone. The only remaining OrgMember access is the EXISTS on the caller's own membership (indexed by userId, a handful of rows). This is the single largest read-amplification query on the control-plane database (~1.39B rows read/day, ~719s DB CPU/day per Insights); removing it takes that portion to zero. Webapp typecheck passes. Rollout Straight deploy, zero blast radius. Rollback is a plain revert, no data migration. refs TRI-13170
Open Graph Description: What OrganizationsPresenter.#getOrganizations selected a Prisma _count.members relation on every org-list load (hit on nearly every dashboard navigation). Prisma lowers that relation _count to a wh...
X Description: What OrganizationsPresenter.#getOrganizations selected a Prisma _count.members relation on every org-list load (hit on nearly every dashboard navigation). Prisma lowers that relation _count to a wh...
Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4587
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5510a0db-c2a4-9a84-2064-bf21e6a60de0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D654:18F46D:7363A:A2755:6AFAF3DD |
| html-safe-nonce | 9e5e3c319c926b924947b3ca805bbfb482f8e4665f3950b7ca64c7d28426959a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjU0OjE4RjQ2RDo3MzYzQTpBMjc1NTo2QUZBRjNERCIsInZpc2l0b3JfaWQiOiIzODg3NjgzNTg5MjkzOTI5NDM4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 36934abfb810bf6e85b8ef89ff468b5e94c6754a53c940fa40ec63c01fb1101e |
| hovercard-subject-tag | pull_request:4262291317 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4587/files |
| twitter:image | https://avatars.githubusercontent.com/u/534?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/534?s=400&v=4 |
| og:image:alt | What OrganizationsPresenter.#getOrganizations selected a Prisma _count.members relation on every org-list load (hit on nearly every dashboard navigation). Prisma lowers that relation _count to a wh... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git |
| octolytics-dimension-user_id | 95297378 |
| octolytics-dimension-user_login | triggerdotdev |
| octolytics-dimension-repository_id | 572570113 |
| octolytics-dimension-repository_nwo | triggerdotdev/trigger.dev |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 572570113 |
| octolytics-dimension-repository_network_root_nwo | triggerdotdev/trigger.dev |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a85e96a83bed7871993e6b1ffda24105928eee17 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width