René's URL Explorer Experiment


Title: fix(webapp): accept Plain customers without an external id on customer cards by isshaddad · Pull Request #4575 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(webapp): accept Plain customers without an external id on customer cards by isshaddad · Pull Request #4575 · triggerdotdev/trigger.dev

X Title: fix(webapp): accept Plain customers without an external id on customer cards by isshaddad · Pull Request #4575 · triggerdotdev/trigger.dev

Description: Plain sends customer.externalId as an explicit null rather than omitting the key. The schema validated it with z.string().optional(), which accepts undefined but rejects null, so every customer we don't set an externalId for got a 400 instead of a card — while the rest worked, which made it look intermittent. email, externalId and thread are now nullish. One of email/externalId is still required, and the route's existing email fallback resolves these customers. Three related fixes in the same path: The route returned { cards: [] } when no user matched. Plain records an integration error for any requested key it doesn't get back, so that surfaced as a broken card rather than a hidden one. Every requested key is now answered, with components: null where there's no data. The impersonation link is offered only when the customer matched on externalId — a value we set ourselves. An email match is a weaker claim, since the address on a Plain customer isn't verified and for customers created outside our own writes it comes from whoever sent the message. Email-matched customers get the account rows without a one-click impersonation link. The not-found log recorded raw customer identifiers; it now keeps presence flags only. The schema and the response helper moved to app/utils/plainCustomerCards.ts so they can be unit-tested without pulling in the db and env modules. Testing app/utils/plainCustomerCards.test.ts — 11 tests covering the null shapes, the every-key-answered response, and the missing-vs-zero distinction. Verified locally. Split out of #4571, which bundled this with an unrelated impersonation fix.

Open Graph Description: Plain sends customer.externalId as an explicit null rather than omitting the key. The schema validated it with z.string().optional(), which accepts undefined but rejects null, so every customer we ...

X Description: Plain sends customer.externalId as an explicit null rather than omitting the key. The schema validated it with z.string().optional(), which accepts undefined but rejects null, so every customer we ...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4575

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f95953a5-5fe9-c0d4-f15f-124743515e53
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD10E:36B3B0:10DE4A:17EFEA:6AFAF3EE
html-safe-noncec23d83836f1ce7d12057ab6f99210f59a94d4911840ad5cb6d9e85cbec008cbe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTBFOjM2QjNCMDoxMERFNEE6MTdFRkVBOjZBRkFGM0VFIiwidmlzaXRvcl9pZCI6IjEzNTM2MDg0Mjc0NDc0NDg1NTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2c90bee321dfc719334ef630265b0b6f8323725c02d24fa36423c16b63347fef
hovercard-subject-tagpull_request:4257370304
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4575/files
twitter:imagehttps://avatars.githubusercontent.com/u/74388823?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/74388823?s=400&v=4
og:image:altPlain sends customer.externalId as an explicit null rather than omitting the key. The schema validated it with z.string().optional(), which accepts undefined but rejects null, so every customer we ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea85e96a83bed7871993e6b1ffda24105928eee17
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4575/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4575%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4575%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4575/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4575/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4575/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
isshaddadhttps://github.com/isshaddad
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
fix/plain-customer-cards-null-external-idhttps://github.com/triggerdotdev/trigger.dev/tree/fix/plain-customer-cards-null-external-id
Conversation 28 https://github.com/triggerdotdev/trigger.dev/pull/4575
Commits 6 https://github.com/triggerdotdev/trigger.dev/pull/4575/commits
Checks 45 https://github.com/triggerdotdev/trigger.dev/pull/4575/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/4575/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4575/files
fix(webapp): accept Plain customers without an external id on customer cards https://github.com/triggerdotdev/trigger.dev/pull/4575/files#top
Show all changes 6 commits https://github.com/triggerdotdev/trigger.dev/pull/4575/files
02a1f5e fix(webapp): accept Plain customers without an external id on custome… isshaddad Aug 11, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4575/commits/02a1f5e73558d5fcef330d6f570cfac3de6d2d06
b41af49 fix(webapp): normalize the email before looking up a card's customer isshaddad Aug 11, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4575/commits/b41af4929524d49dc124b47ca4a6e9921f1afba3
7367118 fix(webapp): cap how long an empty customer card is cached, add relea… isshaddad Aug 12, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4575/commits/7367118e2fb8cffa27247247b5af9b210cedfec8
d1cb098 fix(webapp): look a card's customer up by both sent and lowercased email isshaddad Aug 12, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4575/commits/d1cb09885f501359677e95d18a6c9a65d531b8cb
78330f2 Merge branch 'main' into fix/plain-customer-cards-null-external-id isshaddad Aug 12, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4575/commits/78330f221af6d2f4b519945489b93ab40098ba19
98d6b40 fix(webapp): stop rejecting card requests for customers with no ident… isshaddad Aug 12, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4575/commits/98d6b40c3899277c961279726520a4da4888d6da
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/4575/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4575/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4575/files
plain-customer-card-external-id.md https://github.com/triggerdotdev/trigger.dev/pull/4575/files#diff-abf0eb8587ade80f96e6f1435e1c41508d5fcda1a65cca9a51c23581e4700341
api.v1.plain.customer-cards.ts https://github.com/triggerdotdev/trigger.dev/pull/4575/files#diff-9cabdbddbef6674ed0b379d8f795e54b121c0dbabe025e99cdf8d738a0d0ffbb
plainCustomerCards.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4575/files#diff-62c4b97f4be53e16c6034a3007e7baabcc4fc221aa0ed88e8562a15ff2c219f1
plainCustomerCards.ts https://github.com/triggerdotdev/trigger.dev/pull/4575/files#diff-25836046fbf9ffe5bc4a43e49b3715999fdb635aaf165ff5a5c4dd0df1c7ae62
.server-changes/plain-customer-card-external-id.mdhttps://github.com/triggerdotdev/trigger.dev/pull/4575/files#diff-abf0eb8587ade80f96e6f1435e1c41508d5fcda1a65cca9a51c23581e4700341
View file https://github.com/triggerdotdev/trigger.dev/blob/98d6b40c3899277c961279726520a4da4888d6da/.server-changes/plain-customer-card-external-id.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4575/{{ revealButtonHref }}
apps/webapp/app/routes/api.v1.plain.customer-cards.tshttps://github.com/triggerdotdev/trigger.dev/pull/4575/files#diff-9cabdbddbef6674ed0b379d8f795e54b121c0dbabe025e99cdf8d738a0d0ffbb
View file https://github.com/triggerdotdev/trigger.dev/blob/98d6b40c3899277c961279726520a4da4888d6da/apps/webapp/app/routes/api.v1.plain.customer-cards.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4575/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4575/files#diff-9cabdbddbef6674ed0b379d8f795e54b121c0dbabe025e99cdf8d738a0d0ffbb
https://github.com/triggerdotdev/trigger.dev/pull/4575/files#diff-9cabdbddbef6674ed0b379d8f795e54b121c0dbabe025e99cdf8d738a0d0ffbb
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4575/files
https://github.com/triggerdotdev/trigger.dev/pull/4575/files#diff-9cabdbddbef6674ed0b379d8f795e54b121c0dbabe025e99cdf8d738a0d0ffbb
https://github.com/triggerdotdev/trigger.dev/pull/4575/files#diff-9cabdbddbef6674ed0b379d8f795e54b121c0dbabe025e99cdf8d738a0d0ffbb
https://github.com/triggerdotdev/trigger.dev/pull/4575/files#diff-9cabdbddbef6674ed0b379d8f795e54b121c0dbabe025e99cdf8d738a0d0ffbb
https://github.com/triggerdotdev/trigger.dev/pull/4575/files#diff-9cabdbddbef6674ed0b379d8f795e54b121c0dbabe025e99cdf8d738a0d0ffbb
https://github.com/triggerdotdev/trigger.dev/pull/4575/files#diff-9cabdbddbef6674ed0b379d8f795e54b121c0dbabe025e99cdf8d738a0d0ffbb
https://github.com/triggerdotdev/trigger.dev/pull/4575/files#diff-9cabdbddbef6674ed0b379d8f795e54b121c0dbabe025e99cdf8d738a0d0ffbb
apps/webapp/app/utils/plainCustomerCards.test.tshttps://github.com/triggerdotdev/trigger.dev/pull/4575/files#diff-62c4b97f4be53e16c6034a3007e7baabcc4fc221aa0ed88e8562a15ff2c219f1
View file https://github.com/triggerdotdev/trigger.dev/blob/98d6b40c3899277c961279726520a4da4888d6da/apps/webapp/app/utils/plainCustomerCards.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4575/{{ revealButtonHref }}
apps/webapp/app/utils/plainCustomerCards.tshttps://github.com/triggerdotdev/trigger.dev/pull/4575/files#diff-25836046fbf9ffe5bc4a43e49b3715999fdb635aaf165ff5a5c4dd0df1c7ae62
View file https://github.com/triggerdotdev/trigger.dev/blob/98d6b40c3899277c961279726520a4da4888d6da/apps/webapp/app/utils/plainCustomerCards.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4575/{{ revealButtonHref }}
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4575/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4575/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4575/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.