René's URL Explorer Experiment


Title: fix(webapp): two customer-card and impersonation fixes by isshaddad · Pull Request #4571 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(webapp): two customer-card and impersonation fixes by isshaddad · Pull Request #4571 · triggerdotdev/trigger.dev

X Title: fix(webapp): two customer-card and impersonation fixes by isshaddad · Pull Request #4571 · triggerdotdev/trigger.dev

Description: Trigger.dev – build and deploy durable AI agents and workflows - fix(webapp): two customer-card and impersonation fixes by isshaddad · Pull Request #4571 · triggerdotdev/trigger.dev

Open Graph Description: Two unrelated bugs in admin tooling 1. Customer cards 400'd for customers with no external id api/v1/plain/customer-cards validated customer.email and customer.externalId with z.string().option...

X Description: Two unrelated bugs in admin tooling 1. Customer cards 400'd for customers with no external id api/v1/plain/customer-cards validated customer.email and customer.externalId with z.string().op...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4571

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:a48ef766-4ce8-05ea-b8c0-12045db65f52
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEB84:358701:67B4005:8A4D03A:6AFAFD99
html-safe-noncec8c77f8d94ce2050d91c1cea8dffef29ddf938adbdc746503f616bb19c04b64f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjg0OjM1ODcwMTo2N0I0MDA1OjhBNEQwM0E6NkFGQUZEOTkiLCJ2aXNpdG9yX2lkIjoiMjIxMzUxMzg1NDIzMzI3OTg5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac31f188b42665d6bd72cdf9392e43cda1ae6c3bfd806e4a7639dc6a653a899802
hovercard-subject-tagpull_request:4255109539
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4571/commits
twitter:imagehttps://opengraph.githubassets.com/1a17365a029490b489faf732665e295bf07f53a5bb9a970ba21cd4dd40b7af75/triggerdotdev/trigger.dev/pull/4571
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1a17365a029490b489faf732665e295bf07f53a5bb9a970ba21cd4dd40b7af75/triggerdotdev/trigger.dev/pull/4571
og:image:altTwo unrelated bugs in admin tooling 1. Customer cards 400'd for customers with no external id api/v1/plain/customer-cards validated customer.email and customer.externalId with z.string().option...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameisshaddad
hostnamegithub.com
expected-hostnamegithub.com
None54f7a6886649661c85eee945cca0773566bfb4065370e0429b7c8f7204184650
turbo-cache-controlno-cache
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecf8450eb633ec589502c42ff6f4072e40db65da3
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4571/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4571%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4571%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4571/commits
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4571/commits
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4571/commits
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
https://github.com/triggerdotdev/trigger.dev
isshaddadhttps://github.com/isshaddad
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
fix/plain-card-and-impersonation-switchhttps://github.com/triggerdotdev/trigger.dev/tree/fix/plain-card-and-impersonation-switch
Conversationhttps://github.com/triggerdotdev/trigger.dev/pull/4571
Commits9 (9)https://github.com/triggerdotdev/trigger.dev/pull/4571/commits
Checkshttps://github.com/triggerdotdev/trigger.dev/pull/4571/checks
Files changedhttps://github.com/triggerdotdev/trigger.dev/pull/4571/files
fix(webapp): two customer-card and impersonation fixeshttps://github.com/triggerdotdev/trigger.dev/pull/4571/commits#top
isshaddadhttps://github.com/isshaddad
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
fix/plain-card-and-impersonation-switchhttps://github.com/triggerdotdev/trigger.dev/tree/fix/plain-card-and-impersonation-switch
fix(webapp): accept Plain customers without an external id on customer cardshttps://github.com/triggerdotdev/trigger.dev/pull/4571/commits/cb6088cf1fa8a79d73f0238972b77920cc34c3c0
https://github.com/isshaddad
isshaddadhttps://github.com/triggerdotdev/trigger.dev/commits?author=isshaddad
cb6088chttps://github.com/triggerdotdev/trigger.dev/pull/4571/commits/cb6088cf1fa8a79d73f0238972b77920cc34c3c0
https://github.com/triggerdotdev/trigger.dev/tree/cb6088cf1fa8a79d73f0238972b77920cc34c3c0
fix(webapp): let an admin switch impersonation target without stopping firsthttps://github.com/triggerdotdev/trigger.dev/pull/4571/commits/5dc5f70010467ffe4da0853db0935b44727028e5
https://github.com/isshaddad
isshaddadhttps://github.com/triggerdotdev/trigger.dev/commits?author=isshaddad
5dc5f70https://github.com/triggerdotdev/trigger.dev/pull/4571/commits/5dc5f70010467ffe4da0853db0935b44727028e5
https://github.com/triggerdotdev/trigger.dev/tree/5dc5f70010467ffe4da0853db0935b44727028e5
fix(webapp): scope impersonation to id-matched customers and enforce session controlshttps://github.com/triggerdotdev/trigger.dev/pull/4571/commits/6551a587aa3da4da0dbb8438904b8624e4f82c19
https://github.com/isshaddad
isshaddadhttps://github.com/triggerdotdev/trigger.dev/commits?author=isshaddad
6551a58https://github.com/triggerdotdev/trigger.dev/pull/4571/commits/6551a587aa3da4da0dbb8438904b8624e4f82c19
https://github.com/triggerdotdev/trigger.dev/tree/6551a587aa3da4da0dbb8438904b8624e4f82c19
chore(webapp): drop the now-unused requireUser importhttps://github.com/triggerdotdev/trigger.dev/pull/4571/commits/3c90ce311643c58d39a121a2c73f25e06dcde65c
https://github.com/isshaddad
isshaddadhttps://github.com/triggerdotdev/trigger.dev/commits?author=isshaddad
3c90ce3https://github.com/triggerdotdev/trigger.dev/pull/4571/commits/3c90ce311643c58d39a121a2c73f25e06dcde65c
https://github.com/triggerdotdev/trigger.dev/tree/3c90ce311643c58d39a121a2c73f25e06dcde65c
fix(webapp): keep the impersonation link through login, order audit rowshttps://github.com/triggerdotdev/trigger.dev/pull/4571/commits/4aadcd56fdc62ff8409a5afe0ee81a3b9c9a7858
https://github.com/isshaddad
isshaddadhttps://github.com/triggerdotdev/trigger.dev/commits?author=isshaddad
4aadcd5https://github.com/triggerdotdev/trigger.dev/pull/4571/commits/4aadcd56fdc62ff8409a5afe0ee81a3b9c9a7858
https://github.com/triggerdotdev/trigger.dev/tree/4aadcd56fdc62ff8409a5afe0ee81a3b9c9a7858
fix(webapp): write the impersonation audit pair atomicallyhttps://github.com/triggerdotdev/trigger.dev/pull/4571/commits/f1c6eb383007f6fd4a63cde41dcc9aaa7ee76ec0
https://github.com/isshaddad
isshaddadhttps://github.com/triggerdotdev/trigger.dev/commits?author=isshaddad
f1c6eb3https://github.com/triggerdotdev/trigger.dev/pull/4571/commits/f1c6eb383007f6fd4a63cde41dcc9aaa7ee76ec0
https://github.com/triggerdotdev/trigger.dev/tree/f1c6eb383007f6fd4a63cde41dcc9aaa7ee76ec0
fix(webapp): reset the view-as-user flag when switching impersonation targethttps://github.com/triggerdotdev/trigger.dev/pull/4571/commits/4f7fc9609d7448ea0fe1107e36fec349525bb894
https://github.com/isshaddad
isshaddadhttps://github.com/triggerdotdev/trigger.dev/commits?author=isshaddad
4f7fc96https://github.com/triggerdotdev/trigger.dev/pull/4571/commits/4f7fc9609d7448ea0fe1107e36fec349525bb894
https://github.com/triggerdotdev/trigger.dev/tree/4f7fc9609d7448ea0fe1107e36fec349525bb894
fix(webapp): take the impersonate route out of the admin layouthttps://github.com/triggerdotdev/trigger.dev/pull/4571/commits/7be4c3bde00f3b635df79423bbc6f54b1531a03d
https://github.com/isshaddad
isshaddadhttps://github.com/triggerdotdev/trigger.dev/commits?author=isshaddad
7be4c3bhttps://github.com/triggerdotdev/trigger.dev/pull/4571/commits/7be4c3bde00f3b635df79423bbc6f54b1531a03d
https://github.com/triggerdotdev/trigger.dev/tree/7be4c3bde00f3b635df79423bbc6f54b1531a03d
fix(webapp): gate the impersonate route on canSuper, not the admin columnhttps://github.com/triggerdotdev/trigger.dev/pull/4571/commits/e5e910bd0abd159f125b76098e3fcc20c5648982
https://github.com/isshaddad
isshaddadhttps://github.com/triggerdotdev/trigger.dev/commits?author=isshaddad
e5e910bhttps://github.com/triggerdotdev/trigger.dev/pull/4571/commits/e5e910bd0abd159f125b76098e3fcc20c5648982
https://github.com/triggerdotdev/trigger.dev/tree/e5e910bd0abd159f125b76098e3fcc20c5648982
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.