| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/commits(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:a48ef766-4ce8-05ea-b8c0-12045db65f52 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EB84:358701:67B4005:8A4D03A:6AFAFD99 |
| html-safe-nonce | c8c77f8d94ce2050d91c1cea8dffef29ddf938adbdc746503f616bb19c04b64f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjg0OjM1ODcwMTo2N0I0MDA1OjhBNEQwM0E6NkFGQUZEOTkiLCJ2aXNpdG9yX2lkIjoiMjIxMzUxMzg1NDIzMzI3OTg5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 31f188b42665d6bd72cdf9392e43cda1ae6c3bfd806e4a7639dc6a653a899802 |
| hovercard-subject-tag | pull_request:4255109539 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/commits |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4571/commits |
| twitter:image | https://opengraph.githubassets.com/1a17365a029490b489faf732665e295bf07f53a5bb9a970ba21cd4dd40b7af75/triggerdotdev/trigger.dev/pull/4571 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1a17365a029490b489faf732665e295bf07f53a5bb9a970ba21cd4dd40b7af75/triggerdotdev/trigger.dev/pull/4571 |
| og:image:alt | Two unrelated bugs in admin tooling
1. Customer cards 400'd for customers with no external id
api/v1/plain/customer-cards validated customer.email and customer.externalId with
z.string().option... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | isshaddad |
| hostname | github.com |
| expected-hostname | github.com |
| None | 54f7a6886649661c85eee945cca0773566bfb4065370e0429b7c8f7204184650 |
| turbo-cache-control | no-cache |
| go-import | github.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git |
| octolytics-dimension-user_id | 95297378 |
| octolytics-dimension-user_login | triggerdotdev |
| octolytics-dimension-repository_id | 572570113 |
| octolytics-dimension-repository_nwo | triggerdotdev/trigger.dev |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 572570113 |
| octolytics-dimension-repository_network_root_nwo | triggerdotdev/trigger.dev |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cf8450eb633ec589502c42ff6f4072e40db65da3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/triggerdotdev/trigger.dev/pull/4571/commits#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4571%2Fcommits |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4571%2Fcommits |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev |
| Reload | https://github.com/triggerdotdev/trigger.dev/pull/4571/commits |
| Reload | https://github.com/triggerdotdev/trigger.dev/pull/4571/commits |
| Reload | https://github.com/triggerdotdev/trigger.dev/pull/4571/commits |
| triggerdotdev | https://github.com/triggerdotdev |
| trigger.dev | https://github.com/triggerdotdev/trigger.dev |
| Code | https://github.com/triggerdotdev/trigger.dev |
| Issues203 (203) | https://github.com/triggerdotdev/trigger.dev/issues |
| Pull requests67 (67) | https://github.com/triggerdotdev/trigger.dev/pulls |
| Discussions | https://github.com/triggerdotdev/trigger.dev/discussions |
| Actions | https://github.com/triggerdotdev/trigger.dev/actions |
| Projects | https://github.com/triggerdotdev/trigger.dev/projects |
| Security and quality39 (39) | https://github.com/triggerdotdev/trigger.dev/security |
| Insights | https://github.com/triggerdotdev/trigger.dev/pulse |
| https://github.com/triggerdotdev/trigger.dev |
| isshaddad | https://github.com/isshaddad |
| main | https://github.com/triggerdotdev/trigger.dev/tree/main |
| fix/plain-card-and-impersonation-switch | https://github.com/triggerdotdev/trigger.dev/tree/fix/plain-card-and-impersonation-switch |
| Conversation | https://github.com/triggerdotdev/trigger.dev/pull/4571 |
| Commits9 (9) | https://github.com/triggerdotdev/trigger.dev/pull/4571/commits |
| Checks | https://github.com/triggerdotdev/trigger.dev/pull/4571/checks |
| Files changed | https://github.com/triggerdotdev/trigger.dev/pull/4571/files |
| fix(webapp): two customer-card and impersonation fixes | https://github.com/triggerdotdev/trigger.dev/pull/4571/commits#top |
| isshaddad | https://github.com/isshaddad |
| main | https://github.com/triggerdotdev/trigger.dev/tree/main |
| fix/plain-card-and-impersonation-switch | https://github.com/triggerdotdev/trigger.dev/tree/fix/plain-card-and-impersonation-switch |
| fix(webapp): accept Plain customers without an external id on customer cards | https://github.com/triggerdotdev/trigger.dev/pull/4571/commits/cb6088cf1fa8a79d73f0238972b77920cc34c3c0 |
| https://github.com/isshaddad |
| isshaddad | https://github.com/triggerdotdev/trigger.dev/commits?author=isshaddad |
| cb6088c | https://github.com/triggerdotdev/trigger.dev/pull/4571/commits/cb6088cf1fa8a79d73f0238972b77920cc34c3c0 |
| https://github.com/triggerdotdev/trigger.dev/tree/cb6088cf1fa8a79d73f0238972b77920cc34c3c0 |
| fix(webapp): let an admin switch impersonation target without stopping first | https://github.com/triggerdotdev/trigger.dev/pull/4571/commits/5dc5f70010467ffe4da0853db0935b44727028e5 |
| https://github.com/isshaddad |
| isshaddad | https://github.com/triggerdotdev/trigger.dev/commits?author=isshaddad |
| 5dc5f70 | https://github.com/triggerdotdev/trigger.dev/pull/4571/commits/5dc5f70010467ffe4da0853db0935b44727028e5 |
| https://github.com/triggerdotdev/trigger.dev/tree/5dc5f70010467ffe4da0853db0935b44727028e5 |
| fix(webapp): scope impersonation to id-matched customers and enforce session controls | https://github.com/triggerdotdev/trigger.dev/pull/4571/commits/6551a587aa3da4da0dbb8438904b8624e4f82c19 |
| https://github.com/isshaddad |
| isshaddad | https://github.com/triggerdotdev/trigger.dev/commits?author=isshaddad |
| 6551a58 | https://github.com/triggerdotdev/trigger.dev/pull/4571/commits/6551a587aa3da4da0dbb8438904b8624e4f82c19 |
| https://github.com/triggerdotdev/trigger.dev/tree/6551a587aa3da4da0dbb8438904b8624e4f82c19 |
| chore(webapp): drop the now-unused requireUser import | https://github.com/triggerdotdev/trigger.dev/pull/4571/commits/3c90ce311643c58d39a121a2c73f25e06dcde65c |
| https://github.com/isshaddad |
| isshaddad | https://github.com/triggerdotdev/trigger.dev/commits?author=isshaddad |
| 3c90ce3 | https://github.com/triggerdotdev/trigger.dev/pull/4571/commits/3c90ce311643c58d39a121a2c73f25e06dcde65c |
| https://github.com/triggerdotdev/trigger.dev/tree/3c90ce311643c58d39a121a2c73f25e06dcde65c |
| fix(webapp): keep the impersonation link through login, order audit rows | https://github.com/triggerdotdev/trigger.dev/pull/4571/commits/4aadcd56fdc62ff8409a5afe0ee81a3b9c9a7858 |
| https://github.com/isshaddad |
| isshaddad | https://github.com/triggerdotdev/trigger.dev/commits?author=isshaddad |
| 4aadcd5 | https://github.com/triggerdotdev/trigger.dev/pull/4571/commits/4aadcd56fdc62ff8409a5afe0ee81a3b9c9a7858 |
| https://github.com/triggerdotdev/trigger.dev/tree/4aadcd56fdc62ff8409a5afe0ee81a3b9c9a7858 |
| fix(webapp): write the impersonation audit pair atomically | https://github.com/triggerdotdev/trigger.dev/pull/4571/commits/f1c6eb383007f6fd4a63cde41dcc9aaa7ee76ec0 |
| https://github.com/isshaddad |
| isshaddad | https://github.com/triggerdotdev/trigger.dev/commits?author=isshaddad |
| f1c6eb3 | https://github.com/triggerdotdev/trigger.dev/pull/4571/commits/f1c6eb383007f6fd4a63cde41dcc9aaa7ee76ec0 |
| https://github.com/triggerdotdev/trigger.dev/tree/f1c6eb383007f6fd4a63cde41dcc9aaa7ee76ec0 |
| fix(webapp): reset the view-as-user flag when switching impersonation target | https://github.com/triggerdotdev/trigger.dev/pull/4571/commits/4f7fc9609d7448ea0fe1107e36fec349525bb894 |
| https://github.com/isshaddad |
| isshaddad | https://github.com/triggerdotdev/trigger.dev/commits?author=isshaddad |
| 4f7fc96 | https://github.com/triggerdotdev/trigger.dev/pull/4571/commits/4f7fc9609d7448ea0fe1107e36fec349525bb894 |
| https://github.com/triggerdotdev/trigger.dev/tree/4f7fc9609d7448ea0fe1107e36fec349525bb894 |
| fix(webapp): take the impersonate route out of the admin layout | https://github.com/triggerdotdev/trigger.dev/pull/4571/commits/7be4c3bde00f3b635df79423bbc6f54b1531a03d |
| https://github.com/isshaddad |
| isshaddad | https://github.com/triggerdotdev/trigger.dev/commits?author=isshaddad |
| 7be4c3b | https://github.com/triggerdotdev/trigger.dev/pull/4571/commits/7be4c3bde00f3b635df79423bbc6f54b1531a03d |
| https://github.com/triggerdotdev/trigger.dev/tree/7be4c3bde00f3b635df79423bbc6f54b1531a03d |
| fix(webapp): gate the impersonate route on canSuper, not the admin column | https://github.com/triggerdotdev/trigger.dev/pull/4571/commits/e5e910bd0abd159f125b76098e3fcc20c5648982 |
| https://github.com/isshaddad |
| isshaddad | https://github.com/triggerdotdev/trigger.dev/commits?author=isshaddad |
| e5e910b | https://github.com/triggerdotdev/trigger.dev/pull/4571/commits/e5e910bd0abd159f125b76098e3fcc20c5648982 |
| https://github.com/triggerdotdev/trigger.dev/tree/e5e910bd0abd159f125b76098e3fcc20c5648982 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |