René's URL Explorer Experiment


Title: fix(webapp): keep session runs off the legacy realtime streams backend by matt-aitken · Pull Request #4564 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(webapp): keep session runs off the legacy realtime streams backend by matt-aitken · Pull Request #4564 · triggerdotdev/trigger.dev

X Title: fix(webapp): keep session runs off the legacy realtime streams backend by matt-aitken · Pull Request #4564 · triggerdotdev/trigger.dev

Description: Trigger.dev – build and deploy durable AI agents and workflows - fix(webapp): keep session runs off the legacy realtime streams backend by matt-aitken · Pull Request #4564 · triggerdotdev/trigger.dev

Open Graph Description: Summary Runs created for a Session were triggered without a realtime streams version, so they fell through to the realtimeStreamsVersion column default of v1. A Session's own .in / .out channel...

X Description: Summary Runs created for a Session were triggered without a realtime streams version, so they fell through to the realtimeStreamsVersion column default of v1. A Session's own .in / .out cha...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4564

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:6e1d2495-fb92-7d91-cee9-e7f59394256c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAB4C:1F63:C4E733:1244577:6AFAFE23
html-safe-nonce6bd7ec42d6683fce54cde50b06111c9d71195a4698822e134c2868da4745a0db
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjRDOjFGNjM6QzRFNzMzOjEyNDQ1Nzc6NkFGQUZFMjMiLCJ2aXNpdG9yX2lkIjoiODUyODA1MDgxNTIwODQ1NTcxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7494edba33e32a74966998721485e67b2389d086b1dc74108d5b3fd2fa44340e
hovercard-subject-tagpull_request:4252107367
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4564/commits
twitter:imagehttps://opengraph.githubassets.com/878a66c63b5f73d18ca01e6df522f0c097681da2e41830556d5a5b6b0424b97f/triggerdotdev/trigger.dev/pull/4564
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/878a66c63b5f73d18ca01e6df522f0c097681da2e41830556d5a5b6b0424b97f/triggerdotdev/trigger.dev/pull/4564
og:image:altSummary Runs created for a Session were triggered without a realtime streams version, so they fell through to the realtimeStreamsVersion column default of v1. A Session's own .in / .out channel...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamematt-aitken
hostnamegithub.com
expected-hostnamegithub.com
None54f7a6886649661c85eee945cca0773566bfb4065370e0429b7c8f7204184650
turbo-cache-controlno-cache
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3a69df62e401f1cbe8bd1ad791845bb4fc5b1c1d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4564/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4564%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4564%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4564/commits
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4564/commits
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4564/commits
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
https://github.com/triggerdotdev/trigger.dev
matt-aitkenhttps://github.com/matt-aitken
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
fix/streams-version-guardhttps://github.com/triggerdotdev/trigger.dev/tree/fix/streams-version-guard
Conversationhttps://github.com/triggerdotdev/trigger.dev/pull/4564
Commits11 (11)https://github.com/triggerdotdev/trigger.dev/pull/4564/commits
Checkshttps://github.com/triggerdotdev/trigger.dev/pull/4564/checks
Files changedhttps://github.com/triggerdotdev/trigger.dev/pull/4564/files
fix(webapp): keep session runs off the legacy realtime streams backendhttps://github.com/triggerdotdev/trigger.dev/pull/4564/commits#top
matt-aitkenhttps://github.com/matt-aitken
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
fix/streams-version-guardhttps://github.com/triggerdotdev/trigger.dev/tree/fix/streams-version-guard
fix(webapp): never resolve realtime streams v2 without S2 configuredhttps://github.com/triggerdotdev/trigger.dev/pull/4564/commits/2eb19be5fc096dcce823c179d1f93d03b4d49a5f
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
2eb19behttps://github.com/triggerdotdev/trigger.dev/pull/4564/commits/2eb19be5fc096dcce823c179d1f93d03b4d49a5f
https://github.com/triggerdotdev/trigger.dev/tree/2eb19be5fc096dcce823c179d1f93d03b4d49a5f
fix(webapp): count per-org basins as S2 being configuredhttps://github.com/triggerdotdev/trigger.dev/pull/4564/commits/dab295751b0c8543dbd3ee636d1395c9c28de06d
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
dab2957https://github.com/triggerdotdev/trigger.dev/pull/4564/commits/dab295751b0c8543dbd3ee636d1395c9c28de06d
https://github.com/triggerdotdev/trigger.dev/tree/dab295751b0c8543dbd3ee636d1395c9c28de06d
fix(webapp): require a basin that resolves, not the per-org flaghttps://github.com/triggerdotdev/trigger.dev/pull/4564/commits/6780a977480e5c1a0ff086b6f60714c9b25f1d78
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
6780a97https://github.com/triggerdotdev/trigger.dev/pull/4564/commits/6780a977480e5c1a0ff086b6f60714c9b25f1d78
https://github.com/triggerdotdev/trigger.dev/tree/6780a977480e5c1a0ff086b6f60714c9b25f1d78
fix(webapp): keep session runs off the legacy realtime streams backendhttps://github.com/triggerdotdev/trigger.dev/pull/4564/commits/1f90e9c62d94e4a26dbcd55ad255c8795ccac125
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
1f90e9chttps://github.com/triggerdotdev/trigger.dev/pull/4564/commits/1f90e9c62d94e4a26dbcd55ad255c8795ccac125
https://github.com/triggerdotdev/trigger.dev/tree/1f90e9c62d94e4a26dbcd55ad255c8795ccac125
test(webapp): prove session runs route run-scoped streams to S2https://github.com/triggerdotdev/trigger.dev/pull/4564/commits/542dcc1b6cc95ee99cb743d96dd9d6ae3f9d4361
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
542dcc1https://github.com/triggerdotdev/trigger.dev/pull/4564/commits/542dcc1b6cc95ee99cb743d96dd9d6ae3f9d4361
https://github.com/triggerdotdev/trigger.dev/tree/542dcc1b6cc95ee99cb743d96dd9d6ae3f9d4361
fix(webapp): follow the session's basin and consolidate the streams-version workhttps://github.com/triggerdotdev/trigger.dev/pull/4564/commits/493d2836aad5c5c751b67fad5223d3d7301502a9
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
493d283https://github.com/triggerdotdev/trigger.dev/pull/4564/commits/493d2836aad5c5c751b67fad5223d3d7301502a9
https://github.com/triggerdotdev/trigger.dev/tree/493d2836aad5c5c751b67fad5223d3d7301502a9
fix(webapp): resolve a session run's version from the session's own basinhttps://github.com/triggerdotdev/trigger.dev/pull/4564/commits/afaf3b4c2522c42b47d077355ca8c20cd817a301
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
afaf3b4https://github.com/triggerdotdev/trigger.dev/pull/4564/commits/afaf3b4c2522c42b47d077355ca8c20cd817a301
https://github.com/triggerdotdev/trigger.dev/tree/afaf3b4c2522c42b47d077355ca8c20cd817a301
fix(webapp): gate the session run's version on the basin the run will carryhttps://github.com/triggerdotdev/trigger.dev/pull/4564/commits/c36fecbd074a4b6b320647a7a1d0e77c84746503
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
c36fecbhttps://github.com/triggerdotdev/trigger.dev/pull/4564/commits/c36fecbd074a4b6b320647a7a1d0e77c84746503
https://github.com/triggerdotdev/trigger.dev/tree/c36fecbd074a4b6b320647a7a1d0e77c84746503
test(webapp): cover the basin configuration that hid two bugs in reviewhttps://github.com/triggerdotdev/trigger.dev/pull/4564/commits/ea239f242e8da2875d9b7aa935ba3ad45f67ce23
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
ea239f2https://github.com/triggerdotdev/trigger.dev/pull/4564/commits/ea239f242e8da2875d9b7aa935ba3ad45f67ce23
https://github.com/triggerdotdev/trigger.dev/tree/ea239f242e8da2875d9b7aa935ba3ad45f67ce23
test(webapp): remove assertions that could not fail and claims the tests do not makehttps://github.com/triggerdotdev/trigger.dev/pull/4564/commits/e48296727290ed25d5c95994357e035542acb0b6
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
e482967https://github.com/triggerdotdev/trigger.dev/pull/4564/commits/e48296727290ed25d5c95994357e035542acb0b6
https://github.com/triggerdotdev/trigger.dev/tree/e48296727290ed25d5c95994357e035542acb0b6
refactor(webapp): move the pure streams-version resolver out of the env-bound modulehttps://github.com/triggerdotdev/trigger.dev/pull/4564/commits/ec290c676badb8334106b7430079c7289bdf8a87
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
ec290c6https://github.com/triggerdotdev/trigger.dev/pull/4564/commits/ec290c676badb8334106b7430079c7289bdf8a87
https://github.com/triggerdotdev/trigger.dev/tree/ec290c676badb8334106b7430079c7289bdf8a87
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.