René's URL Explorer Experiment


Title: perf(database): index EnvironmentVariableValue.valueReferenceId so secret deletes stop seq-scanning by ericallam · Pull Request #4555 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: perf(database): index EnvironmentVariableValue.valueReferenceId so secret deletes stop seq-scanning by ericallam · Pull Request #4555 · triggerdotdev/trigger.dev

X Title: perf(database): index EnvironmentVariableValue.valueReferenceId so secret deletes stop seq-scanning by ericallam · Pull Request #4555 · triggerdotdev/trigger.dev

Description: Why this change EnvironmentVariableValue.valueReference is an onDelete: SetNull foreign key. Deleting a SecretReference (the env var edit/delete path for secret values) fires the cascade UPDATE ONLY "EnvironmentVariableValue" SET "valueReferenceId" = NULL WHERE $1 = "valueReferenceId". That cascade is scan-shaped: with no index on valueReferenceId, it reads the entire table to find the rows referencing the deleted secret. The parent SecretReference delete does almost no work itself; its latency is dominated by this cascade. Diagnosis EnvironmentVariableValue was indexed on environmentId and (variableId, environmentId), but not on valueReferenceId. The SET NULL cascade therefore did a full sequential scan of the whole table. Two sibling SET NULL cascades on the same delete (OrganizationIntegration.tokenReferenceId, User.mfaSecretReferenceId) are index-backed and stay fast, which isolates the missing index as the cause. Change Add @@index([valueReferenceId]) on EnvironmentVariableValue, created with CREATE INDEX CONCURRENTLY IF NOT EXISTS so prisma migrate deploy stays safe on a live table. Benchmark (local, seeded) Local Postgres seeded with 1,000,000 EnvironmentVariableValue rows, EXPLAIN (ANALYZE, BUFFERS) on the SET NULL cascade with zero matching rows (the worst case: reads the whole table, affects nothing): before after plan Seq Scan (1M rows) Bitmap Index Scan execution 183 ms 2.8 ms In a variant where the secret matched several thousand rows, the parent SecretReference delete's EnvironmentVariableValue_valueReferenceId_fkey trigger dropped from 216 ms to 88 ms (the residual is the heap work of nulling those rows). Expected impact The cascade drops from a full-table sequential scan to a targeted index lookup. The win grows with the table, so the benefit is larger than the seeded numbers above. Risks One extra btree to maintain on EnvironmentVariableValue writes; small, single-column, and it should be pre-created before the migration deploys (per the repo index rules). No behavior change: same rows nulled, no ordering or result-set change, read paths untouched. Companion to the same fix on ProjectAlert.channelId.

Open Graph Description: Why this change EnvironmentVariableValue.valueReference is an onDelete: SetNull foreign key. Deleting a SecretReference (the env var edit/delete path for secret values) fires the cascade UPDATE ONL...

X Description: Why this change EnvironmentVariableValue.valueReference is an onDelete: SetNull foreign key. Deleting a SecretReference (the env var edit/delete path for secret values) fires the cascade UPDATE ONL...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4555

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a59a5996-5ba0-ec72-316e-2ee84d222650
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C7E:3776CB:3403A8F:4706C8F:6AFAF194
html-safe-noncef91ef368aadf194ec4970acda8aaa67272919347091322bd5ee03d59e0f1f25c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzdFOjM3NzZDQjozNDAzQThGOjQ3MDZDOEY6NkFGQUYxOTQiLCJ2aXNpdG9yX2lkIjoiNTkxMzQxNzIzMjQxODUzMzc4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4ee53306e899ce19fe96a6bf2eef7c07b026be572ce3bfa17af67adf0e87ecc9
hovercard-subject-tagpull_request:4244225984
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4555/files
twitter:imagehttps://avatars.githubusercontent.com/u/534?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/534?s=400&v=4
og:image:altWhy this change EnvironmentVariableValue.valueReference is an onDelete: SetNull foreign key. Deleting a SecretReference (the env var edit/delete path for secret values) fires the cascade UPDATE ONL...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea85e96a83bed7871993e6b1ffda24105928eee17
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4555/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4555%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4555%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4555/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4555/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4555/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
ericallamhttps://github.com/ericallam
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
feature/tri-13097-index-environmentvariablevaluevaluereferenceid-so-secrethttps://github.com/triggerdotdev/trigger.dev/tree/feature/tri-13097-index-environmentvariablevaluevaluereferenceid-so-secret
Conversation 3 https://github.com/triggerdotdev/trigger.dev/pull/4555
Commits 1 https://github.com/triggerdotdev/trigger.dev/pull/4555/commits
Checks 48 https://github.com/triggerdotdev/trigger.dev/pull/4555/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/4555/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4555/files
perf(database): index EnvironmentVariableValue.valueReferenceId so secret deletes stop seq-scanning https://github.com/triggerdotdev/trigger.dev/pull/4555/files#top
Show all changes 1 commit https://github.com/triggerdotdev/trigger.dev/pull/4555/files
e9a2db1 perf(database): index EnvironmentVariableValue.valueReferenceId so se… ericallam Aug 10, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4555/commits/e9a2db1ff8a64794c87104375ed7b2a4a6a6603f
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/4555/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4555/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4555/files
environment-variable-value-reference-id-index.md https://github.com/triggerdotdev/trigger.dev/pull/4555/files#diff-d28da4414be03ba7824e8d134da5addd50d8519e3ec1d033c79cc7d79dc91392
migration.sql https://github.com/triggerdotdev/trigger.dev/pull/4555/files#diff-99d93a3a1bc347cc898c00e3e0b96386970cf4e9a48d20a4fdc6582ac439dce6
schema.prisma https://github.com/triggerdotdev/trigger.dev/pull/4555/files#diff-6b8eefc1da429865c9493bbac9d2c4d00d1cfe2f2231f6474b9692f13b88e419
.server-changes/environment-variable-value-reference-id-index.mdhttps://github.com/triggerdotdev/trigger.dev/pull/4555/files#diff-d28da4414be03ba7824e8d134da5addd50d8519e3ec1d033c79cc7d79dc91392
View file https://github.com/triggerdotdev/trigger.dev/blob/e9a2db1ff8a64794c87104375ed7b2a4a6a6603f/.server-changes/environment-variable-value-reference-id-index.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4555/{{ revealButtonHref }}
...migrations/20260810130000_add_environment_variable_value_reference_id_index/migration.sqlhttps://github.com/triggerdotdev/trigger.dev/pull/4555/files#diff-99d93a3a1bc347cc898c00e3e0b96386970cf4e9a48d20a4fdc6582ac439dce6
View file https://github.com/triggerdotdev/trigger.dev/blob/e9a2db1ff8a64794c87104375ed7b2a4a6a6603f/internal-packages/database/prisma/migrations/20260810130000_add_environment_variable_value_reference_id_index/migration.sql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4555/{{ revealButtonHref }}
internal-packages/database/prisma/schema.prismahttps://github.com/triggerdotdev/trigger.dev/pull/4555/files#diff-6b8eefc1da429865c9493bbac9d2c4d00d1cfe2f2231f6474b9692f13b88e419
View file https://github.com/triggerdotdev/trigger.dev/blob/e9a2db1ff8a64794c87104375ed7b2a4a6a6603f/internal-packages/database/prisma/schema.prisma
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4555/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4555/files#diff-6b8eefc1da429865c9493bbac9d2c4d00d1cfe2f2231f6474b9692f13b88e419
https://github.com/triggerdotdev/trigger.dev/pull/4555/files#diff-6b8eefc1da429865c9493bbac9d2c4d00d1cfe2f2231f6474b9692f13b88e419
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4555/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.