René's URL Explorer Experiment


Title: perf(database): index ProjectAlert.channelId so alert-channel deletes stop seq-scanning by ericallam · Pull Request #4554 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: perf(database): index ProjectAlert.channelId so alert-channel deletes stop seq-scanning by ericallam · Pull Request #4554 · triggerdotdev/trigger.dev

X Title: perf(database): index ProjectAlert.channelId so alert-channel deletes stop seq-scanning by ericallam · Pull Request #4554 · triggerdotdev/trigger.dev

Description: Why this change Deleting a ProjectAlertChannel fires the FK cascade DELETE FROM ONLY "ProjectAlert" WHERE $1 = "channelId". That cascade is scan-shaped: with no index on channelId, it reads the entire ProjectAlert table to find the few child rows belonging to the deleted channel. The parent DELETE ProjectAlertChannel does almost no work itself; its latency is dominated by this cascade. ProjectAlert is append-heavy and grows over time, so the scan cost only increases. Diagnosis ProjectAlert had no index on channelId (only pkey + a friendlyId unique). The cascade therefore did a full sequential scan of the whole table. The sibling ProjectAlertStorage cascade on the same delete is index-backed and stays fast, which isolates the missing index as the cause. Change Add @@index([channelId]) on ProjectAlert, created with CREATE INDEX CONCURRENTLY IF NOT EXISTS so prisma migrate deploy stays safe on a live table. Benchmark (local, seeded) Local Postgres seeded with 1,000,000 ProjectAlert rows across 50 channels (~20k rows per channel), EXPLAIN (ANALYZE, BUFFERS) on the cascade delete: before after plan Seq Scan (1M rows) Bitmap Index Scan direct child delete 740 ms 22 ms parent delete ProjectAlert_channelId_fkey trigger 77.7 ms 23.8 ms Expected impact The cascade drops from a full-table sequential scan to a targeted index lookup. The win grows with the table: the more rows in ProjectAlert, the more a scan costs and the more the index saves, so the benefit is larger than the seeded numbers above. Risks One extra btree to maintain on every ProjectAlert insert; acceptable for a single-column index on a high-insert table, and it should be pre-created before the migration deploys (per the repo index rules). No behavior change: no rows orphaned, no ordering or result-set change, read paths untouched. Follow-up ProjectAlert's other cascade FK columns (projectId, environmentId, workerDeploymentId) are also unindexed, but their parents are soft-deleted rather than physically removed, so those cascades do not currently fire. Lower priority unless a hard-delete path is introduced.

Open Graph Description: Why this change Deleting a ProjectAlertChannel fires the FK cascade DELETE FROM ONLY "ProjectAlert" WHERE $1 = "channelId". That cascade is scan-shaped: with no index on channel...

X Description: Why this change Deleting a ProjectAlertChannel fires the FK cascade DELETE FROM ONLY "ProjectAlert" WHERE $1 = "channelId". That cascade is scan-shaped: with no ...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4554

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e9a8ee04-7462-2b6d-1925-b13cead4d148
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD4DA:C0C1E:1B9150:2739D7:6AFAF1E7
html-safe-nonce5c40d65591aaf1709506c7826425c086c525ec81edd559efb7607d38b43eaa9d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENERBOkMwQzFFOjFCOTE1MDoyNzM5RDc6NkFGQUYxRTciLCJ2aXNpdG9yX2lkIjoiNjk5MTc5MTQ5NjQ3NDg0OTc2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1b458fed5c6c6c6a722e92f32652279e8c033b218bc25dfe2e2edc76e240f80e
hovercard-subject-tagpull_request:4244163467
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4554/files
twitter:imagehttps://avatars.githubusercontent.com/u/534?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/534?s=400&v=4
og:image:altWhy this change Deleting a ProjectAlertChannel fires the FK cascade DELETE FROM ONLY "ProjectAlert" WHERE $1 = "channelId". That cascade is scan-shaped: with no index on channel...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea85e96a83bed7871993e6b1ffda24105928eee17
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4554/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4554%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4554%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4554/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4554/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4554/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
ericallamhttps://github.com/ericallam
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
feature/tri-13095-index-projectalertchannelid-so-alert-channel-deletes-stophttps://github.com/triggerdotdev/trigger.dev/tree/feature/tri-13095-index-projectalertchannelid-so-alert-channel-deletes-stop
Conversation 5 https://github.com/triggerdotdev/trigger.dev/pull/4554
Commits 1 https://github.com/triggerdotdev/trigger.dev/pull/4554/commits
Checks 49 https://github.com/triggerdotdev/trigger.dev/pull/4554/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/4554/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4554/files
perf(database): index ProjectAlert.channelId so alert-channel deletes stop seq-scanning https://github.com/triggerdotdev/trigger.dev/pull/4554/files#top
Show all changes 1 commit https://github.com/triggerdotdev/trigger.dev/pull/4554/files
a059460 perf(database): index ProjectAlert.channelId so alert-channel deletes… ericallam Aug 10, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4554/commits/a059460bd264308db022a85a308f4d1dcf72519e
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/4554/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4554/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4554/files
project-alert-channel-id-index.md https://github.com/triggerdotdev/trigger.dev/pull/4554/files#diff-9211ccb2a9607ff13a332c89f73d0e11ef3f111f285557f15c120391a6baf439
migration.sql https://github.com/triggerdotdev/trigger.dev/pull/4554/files#diff-b9806bbc16248e5305fe9ea405db96a24aaef91630a9de8eb3bb1e82fbac1236
schema.prisma https://github.com/triggerdotdev/trigger.dev/pull/4554/files#diff-6b8eefc1da429865c9493bbac9d2c4d00d1cfe2f2231f6474b9692f13b88e419
.server-changes/project-alert-channel-id-index.mdhttps://github.com/triggerdotdev/trigger.dev/pull/4554/files#diff-9211ccb2a9607ff13a332c89f73d0e11ef3f111f285557f15c120391a6baf439
View file https://github.com/triggerdotdev/trigger.dev/blob/a059460bd264308db022a85a308f4d1dcf72519e/.server-changes/project-alert-channel-id-index.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4554/{{ revealButtonHref }}
...atabase/prisma/migrations/20260810120000_add_project_alert_channel_id_index/migration.sqlhttps://github.com/triggerdotdev/trigger.dev/pull/4554/files#diff-b9806bbc16248e5305fe9ea405db96a24aaef91630a9de8eb3bb1e82fbac1236
View file https://github.com/triggerdotdev/trigger.dev/blob/a059460bd264308db022a85a308f4d1dcf72519e/internal-packages/database/prisma/migrations/20260810120000_add_project_alert_channel_id_index/migration.sql
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4554/{{ revealButtonHref }}
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4554/files
internal-packages/database/prisma/schema.prismahttps://github.com/triggerdotdev/trigger.dev/pull/4554/files#diff-6b8eefc1da429865c9493bbac9d2c4d00d1cfe2f2231f6474b9692f13b88e419
View file https://github.com/triggerdotdev/trigger.dev/blob/a059460bd264308db022a85a308f4d1dcf72519e/internal-packages/database/prisma/schema.prisma
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4554/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4554/files#diff-6b8eefc1da429865c9493bbac9d2c4d00d1cfe2f2231f6474b9692f13b88e419
https://github.com/triggerdotdev/trigger.dev/pull/4554/files#diff-6b8eefc1da429865c9493bbac9d2c4d00d1cfe2f2231f6474b9692f13b88e419
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4554/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.