René's URL Explorer Experiment


Title: fix(redis-worker): stop fair queue leaking concurrency slots by matt-aitken · Pull Request #4540 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(redis-worker): stop fair queue leaking concurrency slots by matt-aitken · Pull Request #4540 · triggerdotdev/trigger.dev

X Title: fix(redis-worker): stop fair queue leaking concurrency slots by matt-aitken · Pull Request #4540 · triggerdotdev/trigger.dev

Description: Trigger.dev – build and deploy durable AI agents and workflows - fix(redis-worker): stop fair queue leaking concurrency slots by matt-aitken · Pull Request #4540 · triggerdotdev/trigger.dev

Open Graph Description: Summary Fair queue consumers could leak the per-tenant concurrency slots that gate admission. Slots were freed on some paths and skipped on others, and once enough leaked slots accumulated for a te...

X Description: Summary Fair queue consumers could leak the per-tenant concurrency slots that gate admission. Slots were freed on some paths and skipped on others, and once enough leaked slots accumulated for a te...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4540

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:752def82-438c-a441-21f9-b07f041c126c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id919E:85CDC:12CD9:19BE3:6AFB08FB
html-safe-noncef73d0ed2f6fa32af17992af2ac8c29cd7b0eaf7fa344ac68f0d5e6051a9b1ba7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MTlFOjg1Q0RDOjEyQ0Q5OjE5QkUzOjZBRkIwOEZCIiwidmlzaXRvcl9pZCI6IjYxODUxOTA3NjcwNjU3NjIwNDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf5966514291cf44e62c4a10eec7f323be608b769dc8c545bd23f3cfd0ef3c1d7
hovercard-subject-tagpull_request:4235961735
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4540/commits
twitter:imagehttps://opengraph.githubassets.com/add2a64d9307fc39bb5bbb28fd01f2b69645aa946332700633d5547878199420/triggerdotdev/trigger.dev/pull/4540
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/add2a64d9307fc39bb5bbb28fd01f2b69645aa946332700633d5547878199420/triggerdotdev/trigger.dev/pull/4540
og:image:altSummary Fair queue consumers could leak the per-tenant concurrency slots that gate admission. Slots were freed on some paths and skipped on others, and once enough leaked slots accumulated for a te...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamematt-aitken
hostnamegithub.com
expected-hostnamegithub.com
None76fb13cb43f1834708971f45a9cfcab5df3177a7582086613d7cdc6e98c4bfde
turbo-cache-controlno-cache
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseafc998826cdd963c8f91a96ae5372809ab5e296b
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4540/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4540%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4540%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4540/commits
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4540/commits
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4540/commits
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
https://github.com/triggerdotdev/trigger.dev
matt-aitkenhttps://github.com/matt-aitken
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
fix/fair-queue-concurrency-slot-leakhttps://github.com/triggerdotdev/trigger.dev/tree/fix/fair-queue-concurrency-slot-leak
Conversationhttps://github.com/triggerdotdev/trigger.dev/pull/4540
Commits13 (13)https://github.com/triggerdotdev/trigger.dev/pull/4540/commits
Checkshttps://github.com/triggerdotdev/trigger.dev/pull/4540/checks
Files changedhttps://github.com/triggerdotdev/trigger.dev/pull/4540/files
fix(redis-worker): stop fair queue leaking concurrency slotshttps://github.com/triggerdotdev/trigger.dev/pull/4540/commits#top
matt-aitkenhttps://github.com/matt-aitken
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
fix/fair-queue-concurrency-slot-leakhttps://github.com/triggerdotdev/trigger.dev/tree/fix/fair-queue-concurrency-slot-leak
fix(redis-worker): stop fair queue leaking concurrency slotshttps://github.com/triggerdotdev/trigger.dev/pull/4540/commits/4df6cda09dbe42868bd2f38bfb21b6993319a917
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
4df6cdahttps://github.com/triggerdotdev/trigger.dev/pull/4540/commits/4df6cda09dbe42868bd2f38bfb21b6993319a917
https://github.com/triggerdotdev/trigger.dev/tree/4df6cda09dbe42868bd2f38bfb21b6993319a917
fix(redis-worker): keep metadata-derived concurrency groups on the release pathhttps://github.com/triggerdotdev/trigger.dev/pull/4540/commits/35568a32e7ad4762ba9c44eab12d370476c15eae
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
35568a3https://github.com/triggerdotdev/trigger.dev/pull/4540/commits/35568a32e7ad4762ba9c44eab12d370476c15eae
https://github.com/triggerdotdev/trigger.dev/tree/35568a32e7ad4762ba9c44eab12d370476c15eae
fix(redis-worker): close the remaining concurrency slot leaks in fair queuehttps://github.com/triggerdotdev/trigger.dev/pull/4540/commits/b2ebf18abc314a633e515594c8ca5ec26dbf38e3
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
b2ebf18https://github.com/triggerdotdev/trigger.dev/pull/4540/commits/b2ebf18abc314a633e515594c8ca5ec26dbf38e3
https://github.com/triggerdotdev/trigger.dev/tree/b2ebf18abc314a633e515594c8ca5ec26dbf38e3
fix(redis-worker): stop losing dead-lettered messages when the DLQ write failshttps://github.com/triggerdotdev/trigger.dev/pull/4540/commits/c6524ca51592d7ef50ac11d95a46fefdf1c22110
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
c6524cahttps://github.com/triggerdotdev/trigger.dev/pull/4540/commits/c6524ca51592d7ef50ac11d95a46fefdf1c22110
https://github.com/triggerdotdev/trigger.dev/tree/c6524ca51592d7ef50ac11d95a46fefdf1c22110
fix(redis-worker,run-engine): close the remaining ways a batch item is stranded or run twicehttps://github.com/triggerdotdev/trigger.dev/pull/4540/commits/3f8ed8b05d8eae6f0814e49310879a6dc95255d8
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
3f8ed8bhttps://github.com/triggerdotdev/trigger.dev/pull/4540/commits/3f8ed8b05d8eae6f0814e49310879a6dc95255d8
https://github.com/triggerdotdev/trigger.dev/tree/3f8ed8b05d8eae6f0814e49310879a6dc95255d8
fix(redis-worker,run-engine): give the item heartbeat real margin and stop one bad key stalling a shardhttps://github.com/triggerdotdev/trigger.dev/pull/4540/commits/a2f12f2b5d983ead4dbc29a345fa58cf83dae229
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
a2f12f2https://github.com/triggerdotdev/trigger.dev/pull/4540/commits/a2f12f2b5d983ead4dbc29a345fa58cf83dae229
https://github.com/triggerdotdev/trigger.dev/tree/a2f12f2b5d983ead4dbc29a345fa58cf83dae229
fix(run-engine,redis-worker): drop a batch item result once its lease is losthttps://github.com/triggerdotdev/trigger.dev/pull/4540/commits/ff348c4822eb6d4489d571a2f6ed474c8bf1bfd9
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
ff348c4https://github.com/triggerdotdev/trigger.dev/pull/4540/commits/ff348c4822eb6d4489d571a2f6ed474c8bf1bfd9
https://github.com/triggerdotdev/trigger.dev/tree/ff348c4822eb6d4489d571a2f6ed474c8bf1bfd9
docs(run-engine): state what the lease signal actually guaranteeshttps://github.com/triggerdotdev/trigger.dev/pull/4540/commits/1b2491520ed4433ab10a0efbd3285f01b2a0d2da
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
1b24915https://github.com/triggerdotdev/trigger.dev/pull/4540/commits/1b2491520ed4433ab10a0efbd3285f01b2a0d2da
https://github.com/triggerdotdev/trigger.dev/tree/1b2491520ed4433ab10a0efbd3285f01b2a0d2da
chore(run-engine): move batch item heartbeating to its own branchhttps://github.com/triggerdotdev/trigger.dev/pull/4540/commits/01d06660054ae64c6b3f6bf99ddfaa9dce5e98da
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
01d0666https://github.com/triggerdotdev/trigger.dev/pull/4540/commits/01d06660054ae64c6b3f6bf99ddfaa9dce5e98da
https://github.com/triggerdotdev/trigger.dev/tree/01d06660054ae64c6b3f6bf99ddfaa9dce5e98da
test(redis-worker): assert reclaim recovery on a stable signalhttps://github.com/triggerdotdev/trigger.dev/pull/4540/commits/72947fe22689272cb1411b3700ca0d3eab518b00
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
72947fehttps://github.com/triggerdotdev/trigger.dev/pull/4540/commits/72947fe22689272cb1411b3700ca0d3eab518b00
https://github.com/triggerdotdev/trigger.dev/tree/72947fe22689272cb1411b3700ca0d3eab518b00
fix(redis-worker): heal leaked concurrency slots instead of blocking on release failureshttps://github.com/triggerdotdev/trigger.dev/pull/4540/commits/e7c3c86307dac25eb3ecfb1329312205a9faefee
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
e7c3c86https://github.com/triggerdotdev/trigger.dev/pull/4540/commits/e7c3c86307dac25eb3ecfb1329312205a9faefee
https://github.com/triggerdotdev/trigger.dev/tree/e7c3c86307dac25eb3ecfb1329312205a9faefee
fix(redis-worker): bound the reconcile sweep cost and write the release note for usershttps://github.com/triggerdotdev/trigger.dev/pull/4540/commits/21eb0d330f0ca1139aae9d860911c4e0ad836079
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
21eb0d3https://github.com/triggerdotdev/trigger.dev/pull/4540/commits/21eb0d330f0ca1139aae9d860911c4e0ad836079
https://github.com/triggerdotdev/trigger.dev/tree/21eb0d330f0ca1139aae9d860911c4e0ad836079
fix(redis-worker): make the orphan sweep fail safe and page set membershttps://github.com/triggerdotdev/trigger.dev/pull/4540/commits/ba57004b972abdbf51eb800c86daa67b9763a142
https://github.com/matt-aitken
matt-aitkenhttps://github.com/triggerdotdev/trigger.dev/commits?author=matt-aitken
ba57004https://github.com/triggerdotdev/trigger.dev/pull/4540/commits/ba57004b972abdbf51eb800c86daa67b9763a142
https://github.com/triggerdotdev/trigger.dev/tree/ba57004b972abdbf51eb800c86daa67b9763a142
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.