René's URL Explorer Experiment


Title: fix(webapp): stop api inheriting inbound sampled traceparents so trace sampling applies by ericallam · Pull Request #4532 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(webapp): stop api inheriting inbound sampled traceparents so trace sampling applies by ericallam · Pull Request #4532 · triggerdotdev/trigger.dev

X Title: fix(webapp): stop api inheriting inbound sampled traceparents so trace sampling applies by ericallam · Pull Request #4532 · triggerdotdev/trigger.dev

Description: What The internal tracing ParentBasedSampler in tracer.server.ts left remoteParentSampled at its default of AlwaysOn. Any request arriving with a traceparent whose sampled flag was set got recorded in full, bypassing INTERNAL_OTEL_TRACE_SAMPLING_RATE entirely. Because the SDK propagates its (always-sampled) trace context on calls back to the platform from inside running tasks, the large majority of API server spans inherited a sampled parent and ignored the divisor. The sampling knob was effectively inert on the busiest service. This registers a custom propagator (NonInheritingTraceContextPropagator) that stops adopting the inbound trace as the parent: inject still delegates to the standard W3C trace + baggage propagators, so outbound propagation is unchanged. extract drops the parent span (trace.deleteSpan) while preserving baggage, so every incoming request roots its own trace and the ratio sampler applies uniformly. remoteParentSampled is also set to the ratio sampler as a belt-and-suspenders fallback, in case an inbound sampled parent ever reaches the sampler another way. Two effects: the divisor becomes effective on the API server, and the API no longer stitches onto (and inflates) the propagated task-run traces, which is where the very large, un-thinnable trace chains came from. Rooting each request removes those chains rather than only diluting them. Only the internal APM trace pipeline (INTERNAL_OTEL_TRACE_EXPORTER_URL) is affected. The user-facing run-trace pipeline (otel.v1.traces -> ClickHouse) is a separate path and is untouched. The only consumer of the global propagator's extract is the OTel HTTP/Express auto-instrumentation, so the blast radius is inbound-request trace shape. Evidence (local full-stack red/green, divisor 10) A local OTLP/JSON sink counting spans; a driver fires N requests at a real endpoint, each carrying a distinct sampled traceparent, then counts how many spans/traces carry that run's marker. run code sent kept traces kept fraction before unmodified 500 500 1.00 after this PR 500 67 0.134 after this PR 2000 213 0.1065 Before: 100% of inherited-sampled requests kept, divisor ignored. After: ~10% kept (the divisor), converging on it at larger N. In every after-run each kept request is a single self-rooted trace (kept spans == kept distinct traces), confirming the inherited chains are gone, not just thinned. typecheck passes. Rollout / rollback No flag. Behavior stays governed by the existing INTERNAL_OTEL_TRACE_SAMPLING_RATE. Rollback is a straight revert with no data migration. Notes Internal dashboards that count raw span or request volume from this pipeline will read lower once this ships. That is expected: those counts were inflated by the bypass, not a real drop in traffic. Latency/percentile monitors retain plenty of samples at the current divisor. refs TRI-13031

Open Graph Description: What The internal tracing ParentBasedSampler in tracer.server.ts left remoteParentSampled at its default of AlwaysOn. Any request arriving with a traceparent whose sampled flag was set got recorded...

X Description: What The internal tracing ParentBasedSampler in tracer.server.ts left remoteParentSampled at its default of AlwaysOn. Any request arriving with a traceparent whose sampled flag was set got recorded...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4532

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1ca62f56-3525-0901-d503-db8556874b25
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEE14:3552AC:346DF2E:4A0C9D6:6AFAF3C1
html-safe-nonce20b307b62248d8fb331073cc340a5b3a5b49e146c6eeda1b972ed6ae5a024054
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRTE0OjM1NTJBQzozNDZERjJFOjRBMEM5RDY6NkFGQUYzQzEiLCJ2aXNpdG9yX2lkIjoiNjc2MTcyMTgwNjUwODk3OTEzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac84a506e01a26cd3d7579bd5571c5cdc185cbedc865f3ec4771b4d6be85b9b9d5
hovercard-subject-tagpull_request:4228949780
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4532/files
twitter:imagehttps://avatars.githubusercontent.com/u/534?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/534?s=400&v=4
og:image:altWhat The internal tracing ParentBasedSampler in tracer.server.ts left remoteParentSampled at its default of AlwaysOn. Any request arriving with a traceparent whose sampled flag was set got recorded...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea85e96a83bed7871993e6b1ffda24105928eee17
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4532/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4532%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4532%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4532/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4532/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4532/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
ericallamhttps://github.com/ericallam
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
feature/tri-13031-api-trace-sampling-is-inert-996-of-its-spans-bypass-thehttps://github.com/triggerdotdev/trigger.dev/tree/feature/tri-13031-api-trace-sampling-is-inert-996-of-its-spans-bypass-the
Conversation 6 https://github.com/triggerdotdev/trigger.dev/pull/4532
Commits 1 https://github.com/triggerdotdev/trigger.dev/pull/4532/commits
Checks 49 https://github.com/triggerdotdev/trigger.dev/pull/4532/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/4532/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4532/files
fix(webapp): stop api inheriting inbound sampled traceparents so trace sampling applies https://github.com/triggerdotdev/trigger.dev/pull/4532/files#top
Show all changes 1 commit https://github.com/triggerdotdev/trigger.dev/pull/4532/files
b9f887d fix(webapp): stop api inheriting inbound sampled traceparents so trac… ericallam Aug 7, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4532/commits/b9f887d4a4cdb044ee5d313f88a318ed8ba0b6df
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/4532/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4532/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4532/files
reduce-api-tracing-overhead.md https://github.com/triggerdotdev/trigger.dev/pull/4532/files#diff-1eb96da592f1ade602e5d4badec3168ce9f53210d9fabaaa798f089cb9da92a9
tracer.server.ts https://github.com/triggerdotdev/trigger.dev/pull/4532/files#diff-746e75ef48528afe08bbadc078c7c25e75fdc178a0f706b614860816c4ea5eaf
.server-changes/reduce-api-tracing-overhead.mdhttps://github.com/triggerdotdev/trigger.dev/pull/4532/files#diff-1eb96da592f1ade602e5d4badec3168ce9f53210d9fabaaa798f089cb9da92a9
View file https://github.com/triggerdotdev/trigger.dev/blob/b9f887d4a4cdb044ee5d313f88a318ed8ba0b6df/.server-changes/reduce-api-tracing-overhead.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4532/{{ revealButtonHref }}
apps/webapp/app/v3/tracer.server.tshttps://github.com/triggerdotdev/trigger.dev/pull/4532/files#diff-746e75ef48528afe08bbadc078c7c25e75fdc178a0f706b614860816c4ea5eaf
View file https://github.com/triggerdotdev/trigger.dev/blob/b9f887d4a4cdb044ee5d313f88a318ed8ba0b6df/apps/webapp/app/v3/tracer.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4532/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4532/files#diff-746e75ef48528afe08bbadc078c7c25e75fdc178a0f706b614860816c4ea5eaf
https://github.com/triggerdotdev/trigger.dev/pull/4532/files#diff-746e75ef48528afe08bbadc078c7c25e75fdc178a0f706b614860816c4ea5eaf
https://github.com/triggerdotdev/trigger.dev/pull/4532/files#diff-746e75ef48528afe08bbadc078c7c25e75fdc178a0f706b614860816c4ea5eaf
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4532/files
https://github.com/triggerdotdev/trigger.dev/pull/4532/files#diff-746e75ef48528afe08bbadc078c7c25e75fdc178a0f706b614860816c4ea5eaf
https://github.com/triggerdotdev/trigger.dev/pull/4532/files#diff-746e75ef48528afe08bbadc078c7c25e75fdc178a0f706b614860816c4ea5eaf
https://github.com/triggerdotdev/trigger.dev/pull/4532/files#diff-746e75ef48528afe08bbadc078c7c25e75fdc178a0f706b614860816c4ea5eaf
https://github.com/triggerdotdev/trigger.dev/pull/4532/files#diff-746e75ef48528afe08bbadc078c7c25e75fdc178a0f706b614860816c4ea5eaf
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4532/files
https://github.com/triggerdotdev/trigger.dev/pull/4532/files#diff-746e75ef48528afe08bbadc078c7c25e75fdc178a0f706b614860816c4ea5eaf
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4532/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.