René's URL Explorer Experiment


Title: feat(webapp): share rate limit bucket across additional API keys per environment by carderne · Pull Request #4508 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: feat(webapp): share rate limit bucket across additional API keys per environment by carderne · Pull Request #4508 · triggerdotdev/trigger.dev

X Title: feat(webapp): share rate limit bucket across additional API keys per environment by carderne · Pull Request #4508 · triggerdotdev/trigger.dev

Description: What Rate-limit the API by environment rather than per API key. Previously the limiter keyed its bucket on the hash of the full Authorization header — one bucket per key. With additional environment API keys (tr_*_sk_*), an environment can mint many keys and each got its own full bucket, so more keys = higher effective rate limit. This collapses all of an environment's keys onto a single shared per-environment bucket, so the ceiling is exactly the configured limit regardless of key mix. How authorizationRateLimitMiddleware now lets the override return { config?, identifier? }. identifier, when present, is the rate limit bucket key; otherwise it falls back to the hashed Authorization header (unchanged legacy behavior, still used by engineRateLimiter and any unauthenticated fallthrough). apiRateLimiter's override resolves the environment id and uses it as the identifier: Additional keys (isAdditionalApiKey) resolve via a new resolveAdditionalApiKeyRateLimitScope() — a scope-agnostic keyHash → (environmentId, org limiter config) lookup. It is deliberately permissive (restricted keys resolve too) because it's used only for bucketing, never as an auth decision — request auth still goes through the RBAC bearer controller, which enforces scopes. Revoked/expired keys are excluded so they can't hold a bucket warm. Root/legacy keys reuse the environment already resolved by authenticateAuthorizationHeader and key on environment.id too. The identifier is always the stable environment id, never the secret key (which can rotate and would split the bucket). The whole override result is cached per key by the existing SWR cache, so no extra per-request lookup and no separate Redis mapping is added. Behavior notes Root + additional keys of the same environment now share one bucket (ceiling = configured limit, not a multiple of it). Restricted additional keys are included — they were the biggest gap, since they authenticate via the RBAC controller and previously fell back to per-key buckets. Public JWTs keep their existing fixed-window, per-token bucketing. One-time bucket reset on deploy (bucket keys change); harmless. Tests New: two tokens resolving to the same identifier share one bucket. New: with no identifier, bucketing stays per-key (legacy behavior preserved). Updated existing override tests to the new { config } return shape. Base: feat/multi-keys-surface. Closes TRI-12888.

Open Graph Description: What Rate-limit the API by environment rather than per API key. Previously the limiter keyed its bucket on the hash of the full Authorization header — one bucket per key. With additional environmen...

X Description: What Rate-limit the API by environment rather than per API key. Previously the limiter keyed its bucket on the hash of the full Authorization header — one bucket per key. With additional environmen...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4508

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a3dfc7db-9bd8-8162-5022-62c7fb851e3e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB66:3098FD:6A7B48:9CC7E0:6AFAF485
html-safe-nonce9167c3e07f04817a7f68e15f4023d09ed515a0770b5139e224f116f84a2c8286
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjY2OjMwOThGRDo2QTdCNDg6OUNDN0UwOjZBRkFGNDg1IiwidmlzaXRvcl9pZCI6Ijg2MTI3NTQ3MzQyOTEwMjI5ODEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7343236db1e309caf90f1506545d0c6080916bd30931587ff8775a3ba50bbed7
hovercard-subject-tagpull_request:4210829089
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4508/files
twitter:imagehttps://avatars.githubusercontent.com/u/19817302?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/19817302?s=400&v=4
og:image:altWhat Rate-limit the API by environment rather than per API key. Previously the limiter keyed its bucket on the hash of the full Authorization header — one bucket per key. With additional environmen...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea85e96a83bed7871993e6b1ffda24105928eee17
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4508/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4508%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4508%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4508/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4508/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4508/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
cardernehttps://github.com/carderne
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
feature/tri-12888-add-redis-cache-for-additional-api-key-environment-lookuphttps://github.com/triggerdotdev/trigger.dev/tree/feature/tri-12888-add-redis-cache-for-additional-api-key-environment-lookup
Conversation 27 https://github.com/triggerdotdev/trigger.dev/pull/4508
Commits 2 https://github.com/triggerdotdev/trigger.dev/pull/4508/commits
Checks 42 https://github.com/triggerdotdev/trigger.dev/pull/4508/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/4508/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4508/files
feat(webapp): share rate limit bucket across additional API keys per environment https://github.com/triggerdotdev/trigger.dev/pull/4508/files#top
Show all changes 2 commits https://github.com/triggerdotdev/trigger.dev/pull/4508/files
ee84c89 feat(webapp): share rate limit bucket across additional API keys per … carderne Aug 5, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4508/commits/ee84c89213d30a02a58f453d636b643d4d595735
5a6a191 remove crumbs carderne Aug 6, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4508/commits/5a6a1914dcaf82ee5e20bfd251e02023f1144af9
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/4508/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4508/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4508/files
additional-api-key-rate-limit-bucket.md https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-61a721f8bed1e207855e6838e2d58226aeb51760683c9880bf90802e99e5dc1b
api-key.server.ts https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-1208c7eaa60d0167df6a17fc81d9e74f26b49bde8ef27711ddf4b41395278585
runtimeEnvironment.server.ts https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-15cc1b2976807e5d2a9e65b1565c47ac285fa77a082e0169438173af9b125e21
LimitsPresenter.server.ts https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-379f787e0a11a814e4427bda5a316d33bb37199158f4d2565cbd7b35027e7bca
route.tsx https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-fe95039e5d6f5a5a5b9c767dfc5d2247e58ba59d63307aa1e8c5aac63961869e
apiRateLimit.server.ts https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-181a4e4183b5e4afca1fbd0cfd8bfb42d29f39de02382feaea563534391f5776
authorizationRateLimitMiddleware.server.ts https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-c4549ae7233cfb0801a4c86e46c91c99146e3666ee45bb0b72f78efda1e80ed3
authorizationRateLimitMiddleware.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-05040d54d4839d44ab9136a374966cc67febe957ec1a1ecc799740ebba2cce86
findEnvironmentByApiKey.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-e4fd83e3c341663ce96b088b2ba33b1f1287efccae6b13d66c79e9e9af81dd9d
.server-changes/additional-api-key-rate-limit-bucket.mdhttps://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-61a721f8bed1e207855e6838e2d58226aeb51760683c9880bf90802e99e5dc1b
View file https://github.com/triggerdotdev/trigger.dev/blob/5a6a1914dcaf82ee5e20bfd251e02023f1144af9/.server-changes/additional-api-key-rate-limit-bucket.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4508/{{ revealButtonHref }}
apps/webapp/app/models/api-key.server.tshttps://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-1208c7eaa60d0167df6a17fc81d9e74f26b49bde8ef27711ddf4b41395278585
View file https://github.com/triggerdotdev/trigger.dev/blob/5a6a1914dcaf82ee5e20bfd251e02023f1144af9/apps/webapp/app/models/api-key.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4508/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-1208c7eaa60d0167df6a17fc81d9e74f26b49bde8ef27711ddf4b41395278585
https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-1208c7eaa60d0167df6a17fc81d9e74f26b49bde8ef27711ddf4b41395278585
https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-1208c7eaa60d0167df6a17fc81d9e74f26b49bde8ef27711ddf4b41395278585
https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-1208c7eaa60d0167df6a17fc81d9e74f26b49bde8ef27711ddf4b41395278585
https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-1208c7eaa60d0167df6a17fc81d9e74f26b49bde8ef27711ddf4b41395278585
https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-1208c7eaa60d0167df6a17fc81d9e74f26b49bde8ef27711ddf4b41395278585
apps/webapp/app/models/runtimeEnvironment.server.tshttps://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-15cc1b2976807e5d2a9e65b1565c47ac285fa77a082e0169438173af9b125e21
View file https://github.com/triggerdotdev/trigger.dev/blob/5a6a1914dcaf82ee5e20bfd251e02023f1144af9/apps/webapp/app/models/runtimeEnvironment.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4508/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-15cc1b2976807e5d2a9e65b1565c47ac285fa77a082e0169438173af9b125e21
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4508/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4508/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4508/files
https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-15cc1b2976807e5d2a9e65b1565c47ac285fa77a082e0169438173af9b125e21
apps/webapp/app/presenters/v3/LimitsPresenter.server.tshttps://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-379f787e0a11a814e4427bda5a316d33bb37199158f4d2565cbd7b35027e7bca
View file https://github.com/triggerdotdev/trigger.dev/blob/5a6a1914dcaf82ee5e20bfd251e02023f1144af9/apps/webapp/app/presenters/v3/LimitsPresenter.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4508/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-379f787e0a11a814e4427bda5a316d33bb37199158f4d2565cbd7b35027e7bca
https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-379f787e0a11a814e4427bda5a316d33bb37199158f4d2565cbd7b35027e7bca
https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-379f787e0a11a814e4427bda5a316d33bb37199158f4d2565cbd7b35027e7bca
https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-379f787e0a11a814e4427bda5a316d33bb37199158f4d2565cbd7b35027e7bca
https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-379f787e0a11a814e4427bda5a316d33bb37199158f4d2565cbd7b35027e7bca
https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-379f787e0a11a814e4427bda5a316d33bb37199158f4d2565cbd7b35027e7bca
https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-379f787e0a11a814e4427bda5a316d33bb37199158f4d2565cbd7b35027e7bca
https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-379f787e0a11a814e4427bda5a316d33bb37199158f4d2565cbd7b35027e7bca
https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-379f787e0a11a814e4427bda5a316d33bb37199158f4d2565cbd7b35027e7bca
.../routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.limits/route.tsxhttps://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-fe95039e5d6f5a5a5b9c767dfc5d2247e58ba59d63307aa1e8c5aac63961869e
View file https://github.com/triggerdotdev/trigger.dev/blob/5a6a1914dcaf82ee5e20bfd251e02023f1144af9/apps/webapp/app/routes/_app.orgs.%24organizationSlug.projects.%24projectParam.env.%24envParam.limits/route.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4508/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-fe95039e5d6f5a5a5b9c767dfc5d2247e58ba59d63307aa1e8c5aac63961869e
https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-fe95039e5d6f5a5a5b9c767dfc5d2247e58ba59d63307aa1e8c5aac63961869e
apps/webapp/app/services/apiRateLimit.server.tshttps://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-181a4e4183b5e4afca1fbd0cfd8bfb42d29f39de02382feaea563534391f5776
View file https://github.com/triggerdotdev/trigger.dev/blob/5a6a1914dcaf82ee5e20bfd251e02023f1144af9/apps/webapp/app/services/apiRateLimit.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4508/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-181a4e4183b5e4afca1fbd0cfd8bfb42d29f39de02382feaea563534391f5776
https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-181a4e4183b5e4afca1fbd0cfd8bfb42d29f39de02382feaea563534391f5776
https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-181a4e4183b5e4afca1fbd0cfd8bfb42d29f39de02382feaea563534391f5776
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4508/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4508/files
https://github.com/triggerdotdev/trigger.dev/pull/4508/files#diff-181a4e4183b5e4afca1fbd0cfd8bfb42d29f39de02382feaea563534391f5776
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4508/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4508/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.