René's URL Explorer Experiment


Title: feat(supervisor): configurable tolerations for run pods by nicktrn · Pull Request #4491 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: feat(supervisor): configurable tolerations for run pods by nicktrn · Pull Request #4491 · triggerdotdev/trigger.dev

X Title: feat(supervisor): configurable tolerations for run pods by nicktrn · Pull Request #4491 · triggerdotdev/trigger.dev

Description: Summary Self-hosted Kubernetes deployments can now add tolerations to run pods, so runs can schedule onto tainted nodes. Previously the only way to do this was to patch the supervisor. KUBERNETES_RUNNER_TOLERATIONS takes a comma separated list of key=value:effect, or key:effect to tolerate any value. It applies to every run pod, and for runs from a schedule tree it merges with the existing KUBERNETES_SCHEDULED_RUN_TOLERATIONS. Left unset, nothing changes: no tolerations are added and the pod spec leaves the field off entirely. The Helm chart takes it as a list: supervisor: config: kubernetes: runnerTolerations: - dedicated=runs:NoSchedule - spot:NoExecute Naming The issue proposed KUBERNETES_WORKER_TOLERATIONS. This ships as KUBERNETES_RUNNER_TOLERATIONS instead, because RUNNER_* is already the prefix for run pod settings (RUNNER_HEARTBEAT_INTERVAL_SECONDS, RUNNER_ADDITIONAL_ENV_VARS, and DOCKER_RUNNER_NETWORKS for the Docker equivalent), whereas "worker" refers to the supervisor itself throughout this app. Validation Keys and values are checked against the Kubernetes naming rules when the supervisor starts, so dedicated=prod runs:NoSchedule fails immediately with a message naming the offending entry. Without that check a bad value is accepted at startup and then rejected by the API server on every pod create, which stops all runs with the cause buried in an API error. KUBERNETES_WORKER_NODETYPE_LABEL is trimmed and validated for the same reason: surrounding whitespace is not valid in a label value, so a padded value fails every pod create today. Node selector off switch KUBERNETES_WORKER_NODETYPE_LABEL accepts an empty string to skip the node selector entirely, so runs schedule on any node. This already worked and the Helm chart has always shipped it empty, but it was not documented. It is now. The issue also asked for general node affinity configuration. That is not included: the node selector off switch plus tolerations covers the reported problem, and a free form affinity setting is a much larger config surface to commit to. Fixes #4458

Open Graph Description: Summary Self-hosted Kubernetes deployments can now add tolerations to run pods, so runs can schedule onto tainted nodes. Previously the only way to do this was to patch the supervisor. KUBERNETES_R...

X Description: Summary Self-hosted Kubernetes deployments can now add tolerations to run pods, so runs can schedule onto tainted nodes. Previously the only way to do this was to patch the supervisor. KUBERNETES_R...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4491

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:77433240-e55f-5909-493f-ad5eae8a853a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD248:29AB00:69614E:9C5A35:6AFAF453
html-safe-noncef6904e293f594385f9c26b4f377c32b0c42136996a6c9227f5663c8d2b3d6503
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjQ4OjI5QUIwMDo2OTYxNEU6OUM1QTM1OjZBRkFGNDUzIiwidmlzaXRvcl9pZCI6IjY1NzY3NjUzMzIwMzM4Mjc5MjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd776af902a59c6647a415730a405b81de2a853f6051f2a5e28c35aee56e97e4d
hovercard-subject-tagpull_request:4195504481
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4491/files
twitter:imagehttps://avatars.githubusercontent.com/u/55853254?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/55853254?s=400&v=4
og:image:altSummary Self-hosted Kubernetes deployments can now add tolerations to run pods, so runs can schedule onto tainted nodes. Previously the only way to do this was to patch the supervisor. KUBERNETES_R...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea85e96a83bed7871993e6b1ffda24105928eee17
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4491/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4491%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4491%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4491/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4491/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4491/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
nicktrnhttps://github.com/nicktrn
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
feat/k8s-runner-tolerationshttps://github.com/triggerdotdev/trigger.dev/tree/feat/k8s-runner-tolerations
Conversation 18 https://github.com/triggerdotdev/trigger.dev/pull/4491
Commits 5 https://github.com/triggerdotdev/trigger.dev/pull/4491/commits
Checks 30 https://github.com/triggerdotdev/trigger.dev/pull/4491/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/4491/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4491/files
feat(supervisor): configurable tolerations for run pods https://github.com/triggerdotdev/trigger.dev/pull/4491/files#top
Show all changes 5 commits https://github.com/triggerdotdev/trigger.dev/pull/4491/files
ad21b6e feat(supervisor): configurable tolerations for run pods nicktrn Aug 3, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4491/commits/ad21b6eb8767ecb93c631791242c0b24f6141b5e
af73c53 test(supervisor): pin the empty toleration value as an exact valueles… nicktrn Aug 3, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4491/commits/af73c538a232379085fe5a47f1fdf6b6d3976823
0b28b7f fix(supervisor): reject an empty toleration value nicktrn Aug 3, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4491/commits/0b28b7f78089b052d4c6c708c8b6b8aafdce64fd
470971b fix(supervisor): warn on an empty toleration value instead of rejecti… nicktrn Aug 3, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4491/commits/470971b40e8dd48ee4d31efada1d10c119afd851
4447ebc docs(supervisor): note that an invalid toleration now blocks startup nicktrn Aug 3, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4491/commits/4447ebc9baf4a14766f824c5bc5169679ab58638
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/4491/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4491/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4491/files
supervisor-run-pod-tolerations.md https://github.com/triggerdotdev/trigger.dev/pull/4491/files#diff-8a0cf82d7df088844050ccf00602e77ef6edc9d29c26a46fb81b718cb3960f5c
env.ts https://github.com/triggerdotdev/trigger.dev/pull/4491/files#diff-5b22f3c3d43f6c9ba3f07c3af9327db486b2cf0b5b666041e6b1f72b8836c13f
envUtil.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4491/files#diff-fb197fca3c1256b4529845afe7653514fb48d96c180e617a5f2002d3dd612dab
envUtil.ts https://github.com/triggerdotdev/trigger.dev/pull/4491/files#diff-93b720756af7b46bfc155af7a901a60444d1902ec98595b21646e606e9069ae0
kubernetes.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4491/files#diff-b80ea17feb730130b3652c0466aeb906b7b52b63b19b98f1d619938860fe9b35
kubernetes.ts https://github.com/triggerdotdev/trigger.dev/pull/4491/files#diff-de57d327745df5f9c0bd3f7178a3eff3ccb2513bae48431363e5676bad81caff
kubernetesPodSpec.ts https://github.com/triggerdotdev/trigger.dev/pull/4491/files#diff-337525dde4a13f9aeb2cfd4e178c0525f3a8737d7520f89dc9b1647fa5ddf7c5
supervisor.mdx https://github.com/triggerdotdev/trigger.dev/pull/4491/files#diff-9807c150956709f2a0220dfb6f2730aff57637ca2f6e09ce8b1020bd59f34621
supervisor.yaml https://github.com/triggerdotdev/trigger.dev/pull/4491/files#diff-ba551785f6eb5c50a1bd443523e2cbf760a903a3b5ada9b672b8a110008f91ba
values.yaml https://github.com/triggerdotdev/trigger.dev/pull/4491/files#diff-514687561b9e801baafa9932d906e0a9d89f5f30243cd4ba8067f7c1f34377e4
.server-changes/supervisor-run-pod-tolerations.mdhttps://github.com/triggerdotdev/trigger.dev/pull/4491/files#diff-8a0cf82d7df088844050ccf00602e77ef6edc9d29c26a46fb81b718cb3960f5c
View file https://github.com/triggerdotdev/trigger.dev/blob/4447ebc9baf4a14766f824c5bc5169679ab58638/.server-changes/supervisor-run-pod-tolerations.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4491/{{ revealButtonHref }}
apps/supervisor/src/env.tshttps://github.com/triggerdotdev/trigger.dev/pull/4491/files#diff-5b22f3c3d43f6c9ba3f07c3af9327db486b2cf0b5b666041e6b1f72b8836c13f
View file https://github.com/triggerdotdev/trigger.dev/blob/4447ebc9baf4a14766f824c5bc5169679ab58638/apps/supervisor/src/env.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4491/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4491/files#diff-5b22f3c3d43f6c9ba3f07c3af9327db486b2cf0b5b666041e6b1f72b8836c13f
https://github.com/triggerdotdev/trigger.dev/pull/4491/files#diff-5b22f3c3d43f6c9ba3f07c3af9327db486b2cf0b5b666041e6b1f72b8836c13f
https://github.com/triggerdotdev/trigger.dev/pull/4491/files#diff-5b22f3c3d43f6c9ba3f07c3af9327db486b2cf0b5b666041e6b1f72b8836c13f
https://github.com/triggerdotdev/trigger.dev/pull/4491/files#diff-5b22f3c3d43f6c9ba3f07c3af9327db486b2cf0b5b666041e6b1f72b8836c13f
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4491/files
https://github.com/triggerdotdev/trigger.dev/pull/4491/files#diff-5b22f3c3d43f6c9ba3f07c3af9327db486b2cf0b5b666041e6b1f72b8836c13f
apps/supervisor/src/envUtil.test.tshttps://github.com/triggerdotdev/trigger.dev/pull/4491/files#diff-fb197fca3c1256b4529845afe7653514fb48d96c180e617a5f2002d3dd612dab
View file https://github.com/triggerdotdev/trigger.dev/blob/4447ebc9baf4a14766f824c5bc5169679ab58638/apps/supervisor/src/envUtil.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4491/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4491/files#diff-fb197fca3c1256b4529845afe7653514fb48d96c180e617a5f2002d3dd612dab
https://github.com/triggerdotdev/trigger.dev/pull/4491/files#diff-fb197fca3c1256b4529845afe7653514fb48d96c180e617a5f2002d3dd612dab
apps/supervisor/src/envUtil.tshttps://github.com/triggerdotdev/trigger.dev/pull/4491/files#diff-93b720756af7b46bfc155af7a901a60444d1902ec98595b21646e606e9069ae0
View file https://github.com/triggerdotdev/trigger.dev/blob/4447ebc9baf4a14766f824c5bc5169679ab58638/apps/supervisor/src/envUtil.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4491/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4491/files#diff-93b720756af7b46bfc155af7a901a60444d1902ec98595b21646e606e9069ae0
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4491/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4491/files
https://github.com/triggerdotdev/trigger.dev/pull/4491/files#diff-93b720756af7b46bfc155af7a901a60444d1902ec98595b21646e606e9069ae0
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4491/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4491/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.