René's URL Explorer Experiment


Title: fix(webapp): stop the sidebar feedback popover from canceling the submit by isshaddad · Pull Request #4445 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(webapp): stop the sidebar feedback popover from canceling the submit by isshaddad · Pull Request #4445 · triggerdotdev/trigger.dev

X Title: fix(webapp): stop the sidebar feedback popover from canceling the submit by isshaddad · Pull Request #4445 · triggerdotdev/trigger.dev

Description: The Help & Feedback → "Contact us" form in the sidebar intermittently failed to send. The dialog was nested inside the Help popover, so clicking Send closed the popover and unmounted the form mid-submit — canceling the POST /resources/feedback before it went out. The message was silently lost (the success toast still shows). A race, so it "worked sometimes"; the standalone "I'm stuck!" path was unaffected. Fix: host the Feedback dialog outside the popover (same pattern as AskAIRoot) and open it from the menu item, so closing the popover no longer tears down the form. Feedback gains an optional controlled open/setOpen mode; existing button-triggered usages are unchanged. Changes Feedback.tsx — optional controlled open/setOpen; button now optional. HelpAndFeedbackPopover.tsx — "Contact us…" opens a hosted outside PopoverContent. .server-changes/fix-sidebar-feedback.md — user-facing note. Testing Webapp typecheck passes. Sidebar "Contact us…" now sends on every attempt (Network: POST /resources/feedback → 204, never (canceled)); "I'm stuck!" and the ?feedbackPanel= open path unchanged.

Open Graph Description: The Help & Feedback → "Contact us" form in the sidebar intermittently failed to send. The <Feedback> dialog was nested inside the Help popover, so clicking Send closed the popov...

X Description: The Help &amp; Feedback → &quot;Contact us&quot; form in the sidebar intermittently failed to send. The &lt;Feedback&gt; dialog was nested inside the Help popover, so clicking S...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4445

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5584ef4a-d286-4266-4fce-a58d478522bb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB5C2:135D99:3218FA6:4757832:6AFAF4D8
html-safe-nonce876f858688bef454cabf84136397833a8a5f87954129d7902915b22a12baac6b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNUMyOjEzNUQ5OTozMjE4RkE2OjQ3NTc4MzI6NkFGQUY0RDgiLCJ2aXNpdG9yX2lkIjoiODM2NDA4NTQwMDY4NzAxNTEyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac17330036bfcecb946766d19333c4879ea3420f088a659e290d105a6392b678bf
hovercard-subject-tagpull_request:4181679207
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4445/files
twitter:imagehttps://avatars.githubusercontent.com/u/74388823?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/74388823?s=400&v=4
og:image:altThe Help & Feedback → "Contact us" form in the sidebar intermittently failed to send. The <Feedback> dialog was nested inside the Help popover, so clicking Send closed the popov...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea85e96a83bed7871993e6b1ffda24105928eee17
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4445/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4445%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4445%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4445/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4445/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4445/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
isshaddadhttps://github.com/isshaddad
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
fix/tri-12817-sidebar-feedback-popoverhttps://github.com/triggerdotdev/trigger.dev/tree/fix/tri-12817-sidebar-feedback-popover
Conversation 10 https://github.com/triggerdotdev/trigger.dev/pull/4445
Commits 5 https://github.com/triggerdotdev/trigger.dev/pull/4445/commits
Checks 41 https://github.com/triggerdotdev/trigger.dev/pull/4445/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/4445/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4445/files
fix(webapp): stop the sidebar feedback popover from canceling the submit https://github.com/triggerdotdev/trigger.dev/pull/4445/files#top
Show all changes 5 commits https://github.com/triggerdotdev/trigger.dev/pull/4445/files
3724fe3 fix(webapp): stop the sidebar feedback popover from canceling the submit isshaddad Aug 1, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4445/commits/3724fe3be0b377e488ec2431e31c5675d7cd5c2d
a2aaa36 refactor(webapp): type Feedback open/setOpen as an all-or-none pair isshaddad Aug 1, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4445/commits/a2aaa36ff557c15087de877d3785e4e57e998fa7
7f4a619 style(webapp): format Feedback with oxfmt isshaddad Aug 1, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4445/commits/7f4a6198248e2cabba4f918479dff1c6a3370265
27a8602 Merge branch 'main' into fix/tri-12817-sidebar-feedback-popover isshaddad Aug 2, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4445/commits/27a8602279c11bd0557b1ba6affc31b340355984
0fb709a fix(webapp): reset feedback topic to default when the dialog closes isshaddad Aug 2, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4445/commits/0fb709a458b75978dbcd6713dc3a453e9215ef07
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/4445/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4445/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4445/files
fix-sidebar-feedback.md https://github.com/triggerdotdev/trigger.dev/pull/4445/files#diff-393569cbe61920fa4f27d1659b10481bb0cc75bdd568b0e67deb283d87288fff
Feedback.tsx https://github.com/triggerdotdev/trigger.dev/pull/4445/files#diff-ff2957da32b85272c57be7fed70ef24e73de6e6110e1ba8958670a4f97e60819
HelpAndFeedbackPopover.tsx https://github.com/triggerdotdev/trigger.dev/pull/4445/files#diff-76ea29131765a2855b9e2e9c87dac8fa54fa5485f7145dd646cbdc7ff457512a
.server-changes/fix-sidebar-feedback.mdhttps://github.com/triggerdotdev/trigger.dev/pull/4445/files#diff-393569cbe61920fa4f27d1659b10481bb0cc75bdd568b0e67deb283d87288fff
View file https://github.com/triggerdotdev/trigger.dev/blob/0fb709a458b75978dbcd6713dc3a453e9215ef07/.server-changes/fix-sidebar-feedback.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4445/{{ revealButtonHref }}
apps/webapp/app/components/Feedback.tsxhttps://github.com/triggerdotdev/trigger.dev/pull/4445/files#diff-ff2957da32b85272c57be7fed70ef24e73de6e6110e1ba8958670a4f97e60819
View file https://github.com/triggerdotdev/trigger.dev/blob/0fb709a458b75978dbcd6713dc3a453e9215ef07/apps/webapp/app/components/Feedback.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4445/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4445/files#diff-ff2957da32b85272c57be7fed70ef24e73de6e6110e1ba8958670a4f97e60819
https://github.com/triggerdotdev/trigger.dev/pull/4445/files#diff-ff2957da32b85272c57be7fed70ef24e73de6e6110e1ba8958670a4f97e60819
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4445/files
https://github.com/triggerdotdev/trigger.dev/pull/4445/files#diff-ff2957da32b85272c57be7fed70ef24e73de6e6110e1ba8958670a4f97e60819
https://github.com/triggerdotdev/trigger.dev/pull/4445/files#diff-ff2957da32b85272c57be7fed70ef24e73de6e6110e1ba8958670a4f97e60819
https://github.com/triggerdotdev/trigger.dev/pull/4445/files#diff-ff2957da32b85272c57be7fed70ef24e73de6e6110e1ba8958670a4f97e60819
apps/webapp/app/components/navigation/HelpAndFeedbackPopover.tsxhttps://github.com/triggerdotdev/trigger.dev/pull/4445/files#diff-76ea29131765a2855b9e2e9c87dac8fa54fa5485f7145dd646cbdc7ff457512a
View file https://github.com/triggerdotdev/trigger.dev/blob/0fb709a458b75978dbcd6713dc3a453e9215ef07/apps/webapp/app/components/navigation/HelpAndFeedbackPopover.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4445/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4445/files#diff-76ea29131765a2855b9e2e9c87dac8fa54fa5485f7145dd646cbdc7ff457512a
https://github.com/triggerdotdev/trigger.dev/pull/4445/files#diff-76ea29131765a2855b9e2e9c87dac8fa54fa5485f7145dd646cbdc7ff457512a
https://github.com/triggerdotdev/trigger.dev/pull/4445/files#diff-76ea29131765a2855b9e2e9c87dac8fa54fa5485f7145dd646cbdc7ff457512a
https://github.com/triggerdotdev/trigger.dev/pull/4445/files#diff-76ea29131765a2855b9e2e9c87dac8fa54fa5485f7145dd646cbdc7ff457512a
https://github.com/triggerdotdev/trigger.dev/pull/4445/files#diff-76ea29131765a2855b9e2e9c87dac8fa54fa5485f7145dd646cbdc7ff457512a
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4445/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4445/files
https://github.com/triggerdotdev/trigger.dev/pull/4445/files#diff-76ea29131765a2855b9e2e9c87dac8fa54fa5485f7145dd646cbdc7ff457512a
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4445/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.