René's URL Explorer Experiment


Title: fix(supervisor): hold the last backpressure verdict when a read fails by nicktrn · Pull Request #4444 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(supervisor): hold the last backpressure verdict when a read fails by nicktrn · Pull Request #4444 · triggerdotdev/trigger.dev

X Title: fix(supervisor): hold the last backpressure verdict when a read fails by nicktrn · Pull Request #4444 · triggerdotdev/trigger.dev

Description: The dequeue brake released the moment its signal became unreadable. refresh() caught any error from source.read() and set the verdict to null, which computeEngaged() treats as not-engaged — so a few failed reads dropped an engaged brake, silently, with no log and no metric. That handling was symmetric while the risk is not. A source that has stopped answering correlates with the pressure the brake exists for, so releasing on read failure gives up protection at exactly the wrong moment; holding too long only costs throughput. Now a failed read keeps the last verdict instead of discarding it. The verdict then ages normally, so the existing maxVerdictAgeMs check becomes the grace window and still bounds how long a dead source can hold the brake — a permanently unreachable source releases it rather than pinning dequeuing forever. Because computeEngaged() only consults staleness for an engaged verdict, a released one is unaffected and stays released. The default grace moves from 15s to 120s, comparable to how long the brake normally stays engaged. One guard worth calling out: holding is only safe when something bounds it, so when maxVerdictAgeMs is unset the previous discard behaviour is kept. Otherwise an unbounded hold could pin the brake indefinitely. Read failures were previously invisible — the catch block neither logged nor counted. Adds a read_failures_total counter, plus an error log on the transition into failure rather than once per tick, since the refresh loop runs every second. The post-release ramp needs no change: it anchors off the engaged-to-released transition, so a grace-window release still ramps back up instead of snapping to full rate, which is what you want after a blind period. Tests cover holding while reads fail, releasing past the max age, and the existing unbounded-config paths are unchanged.

Open Graph Description: The dequeue brake released the moment its signal became unreadable. refresh() caught any error from source.read() and set the verdict to null, which computeEngaged() treats as not-engaged — so a fe...

X Description: The dequeue brake released the moment its signal became unreadable. refresh() caught any error from source.read() and set the verdict to null, which computeEngaged() treats as not-engaged — so a fe...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4444

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:344b8066-85fc-a83e-4973-acf1cc710c61
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA08C:646AE:1379574:1B8765B:6AFAF3FD
html-safe-nonceedac3ec45d4b2410f0747f42eccaa52e7b4761d5302f36ab3cb081ca00fc05d6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDhDOjY0NkFFOjEzNzk1NzQ6MUI4NzY1Qjo2QUZBRjNGRCIsInZpc2l0b3JfaWQiOiI4MDIyMzI2NzEzOTgxMjY4OTg5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9a4925756a1ff7f83fae69bebeac71514a41bc0579de51d64180c782c9e0cf22
hovercard-subject-tagpull_request:4181283085
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4444/files
twitter:imagehttps://avatars.githubusercontent.com/u/55853254?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/55853254?s=400&v=4
og:image:altThe dequeue brake released the moment its signal became unreadable. refresh() caught any error from source.read() and set the verdict to null, which computeEngaged() treats as not-engaged — so a fe...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea85e96a83bed7871993e6b1ffda24105928eee17
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4444/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4444%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4444%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4444/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4444/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4444/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
nicktrnhttps://github.com/nicktrn
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
fix/backpressure-hold-last-verdicthttps://github.com/triggerdotdev/trigger.dev/tree/fix/backpressure-hold-last-verdict
Conversation 28 https://github.com/triggerdotdev/trigger.dev/pull/4444
Commits 4 https://github.com/triggerdotdev/trigger.dev/pull/4444/commits
Checks 32 https://github.com/triggerdotdev/trigger.dev/pull/4444/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/4444/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4444/files
fix(supervisor): hold the last backpressure verdict when a read fails https://github.com/triggerdotdev/trigger.dev/pull/4444/files#top
Show all changes 4 commits https://github.com/triggerdotdev/trigger.dev/pull/4444/files
1939ad2 fix(supervisor): hold the last backpressure verdict when a read fails nicktrn Jul 31, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4444/commits/1939ad2edab536efc3ec546521569ccaf2516982
8c9c92f fix(supervisor): only hold the verdict when the read itself failed nicktrn Jul 31, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4444/commits/8c9c92fe00a39576255eb803ad593daa1ca35175
8d52acf chore(supervisor): scope the release note to all deployments, drop th… nicktrn Jul 31, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4444/commits/8d52acfa664b78e8da684067b6c6907b9fd92a4d
2cf09ff chore(supervisor): reword the release note nicktrn Jul 31, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4444/commits/2cf09ff375abb19599fb18df337d47739421072d
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/4444/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4444/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4444/files
backpressure-hold-last-verdict.md https://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-8f038a18417e6e321c67c50babeeedcfa775f453171812ac845d0c06225fd421
backpressureMetrics.ts https://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-f202dc49fb7e3125e96be606eb97a6832d36d43ccb811842a2de0eff6ca7e4ba
backpressureMonitor.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-bee8b56c953b4855f1cf7627eb278338cb5a9d6c96ba42fc835973d4e4c819b5
backpressureMonitor.ts https://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-adaa439c0fa521119454bae468d2f7242b4f369d2ff1207d41cee9a34a22e145
env.ts https://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-5b22f3c3d43f6c9ba3f07c3af9327db486b2cf0b5b666041e6b1f72b8836c13f
.server-changes/backpressure-hold-last-verdict.mdhttps://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-8f038a18417e6e321c67c50babeeedcfa775f453171812ac845d0c06225fd421
View file https://github.com/triggerdotdev/trigger.dev/blob/2cf09ff375abb19599fb18df337d47739421072d/.server-changes/backpressure-hold-last-verdict.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4444/{{ revealButtonHref }}
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4444/files
apps/supervisor/src/backpressure/backpressureMetrics.tshttps://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-f202dc49fb7e3125e96be606eb97a6832d36d43ccb811842a2de0eff6ca7e4ba
View file https://github.com/triggerdotdev/trigger.dev/blob/2cf09ff375abb19599fb18df337d47739421072d/apps/supervisor/src/backpressure/backpressureMetrics.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4444/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-f202dc49fb7e3125e96be606eb97a6832d36d43ccb811842a2de0eff6ca7e4ba
https://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-f202dc49fb7e3125e96be606eb97a6832d36d43ccb811842a2de0eff6ca7e4ba
apps/supervisor/src/backpressure/backpressureMonitor.test.tshttps://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-bee8b56c953b4855f1cf7627eb278338cb5a9d6c96ba42fc835973d4e4c819b5
View file https://github.com/triggerdotdev/trigger.dev/blob/2cf09ff375abb19599fb18df337d47739421072d/apps/supervisor/src/backpressure/backpressureMonitor.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4444/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-bee8b56c953b4855f1cf7627eb278338cb5a9d6c96ba42fc835973d4e4c819b5
https://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-bee8b56c953b4855f1cf7627eb278338cb5a9d6c96ba42fc835973d4e4c819b5
https://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-bee8b56c953b4855f1cf7627eb278338cb5a9d6c96ba42fc835973d4e4c819b5
https://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-bee8b56c953b4855f1cf7627eb278338cb5a9d6c96ba42fc835973d4e4c819b5
apps/supervisor/src/backpressure/backpressureMonitor.tshttps://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-adaa439c0fa521119454bae468d2f7242b4f369d2ff1207d41cee9a34a22e145
View file https://github.com/triggerdotdev/trigger.dev/blob/2cf09ff375abb19599fb18df337d47739421072d/apps/supervisor/src/backpressure/backpressureMonitor.ts
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4444/files
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4444/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-adaa439c0fa521119454bae468d2f7242b4f369d2ff1207d41cee9a34a22e145
https://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-adaa439c0fa521119454bae468d2f7242b4f369d2ff1207d41cee9a34a22e145
https://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-adaa439c0fa521119454bae468d2f7242b4f369d2ff1207d41cee9a34a22e145
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4444/files
https://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-adaa439c0fa521119454bae468d2f7242b4f369d2ff1207d41cee9a34a22e145
https://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-adaa439c0fa521119454bae468d2f7242b4f369d2ff1207d41cee9a34a22e145
https://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-adaa439c0fa521119454bae468d2f7242b4f369d2ff1207d41cee9a34a22e145
https://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-adaa439c0fa521119454bae468d2f7242b4f369d2ff1207d41cee9a34a22e145
https://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-adaa439c0fa521119454bae468d2f7242b4f369d2ff1207d41cee9a34a22e145
apps/supervisor/src/env.tshttps://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-5b22f3c3d43f6c9ba3f07c3af9327db486b2cf0b5b666041e6b1f72b8836c13f
View file https://github.com/triggerdotdev/trigger.dev/blob/2cf09ff375abb19599fb18df337d47739421072d/apps/supervisor/src/env.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4444/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-5b22f3c3d43f6c9ba3f07c3af9327db486b2cf0b5b666041e6b1f72b8836c13f
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4444/files
https://github.com/triggerdotdev/trigger.dev/pull/4444/files#diff-5b22f3c3d43f6c9ba3f07c3af9327db486b2cf0b5b666041e6b1f72b8836c13f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.