Title: fix(core): widen run start-attempt retry to ride out transient connection blips by nicktrn · Pull Request #4441 · triggerdotdev/trigger.dev · GitHub
Open Graph Title: fix(core): widen run start-attempt retry to ride out transient connection blips by nicktrn · Pull Request #4441 · triggerdotdev/trigger.dev
X Title: fix(core): widen run start-attempt retry to ride out transient connection blips by nicktrn · Pull Request #4441 · triggerdotdev/trigger.dev
Description: What When a run starts, the run controller's first call is startRunAttempt. It already retried transient connection errors, but only on the default short budget (~5 attempts, ~7.5s) — too short to ride out a brief blip talking to the worker (e.g. the worker being briefly unreachable). When that budget was exceeded the start was abandoned and the run went back through the queue, delaying its first attempt. This widens the retry budget on that one call to ~25-40s (jittered), matching the already-hardened continueRunExecution path, so a brief blip is ridden out in place instead of bouncing the run. Budget & the 60s stall For the case this targets — a genuine connection error (worker unreachable) — each attempt fails fast, so ~25-40s of backoff fits well inside the platform's 60s pending-execution timeout. The reachable-but-failing case is different: the worker maps an inner failure to a 500, and this outer retry (like continueRunExecution) also retries 5xx, so it stacks with the worker's own inner retry and can run past 60s. That's deliberate and safe — it degrades to the same requeue that happens today, and start-attempt is idempotent server-side (snapshot-id guarded), so a late retry after a committed start is rejected and never double-starts. Why this belongs on the SDK side The worker already retries its own hop inward, but that only helps once it has received the request. The case this fixes — the worker briefly unreachable (connection refused, e.g. a restart) — never reaches it, so only the run controller can retry. The two retries are complementary, on different hops. Scope One retry-options object on startRunAttempt; no other behavior change. Warm starts share this path and get the same resilience.
Open Graph Description: What When a run starts, the run controller's first call is startRunAttempt. It already retried transient connection errors, but only on the default short budget (~5 attempts, ~7.5s) — too short...
X Description: What When a run starts, the run controller's first call is startRunAttempt. It already retried transient connection errors, but only on the default short budget (~5 attempts, ~7.5s) — too s...
Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4441
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5fda1295-acca-94cb-14da-4da7ea4564ee |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C270:1A28DE:31149F3:45E8976:6AFAF3D2 |
| html-safe-nonce | b8ab1111b29bc726d81a5fe378c78ff1505f9ba3222408f8b1c27f4dd8a7949c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjcwOjFBMjhERTozMTE0OUYzOjQ1RTg5NzY6NkFGQUYzRDIiLCJ2aXNpdG9yX2lkIjoiMzQzMzM3NTE1MTQ1MjUxNzMzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ca862264bec7435122535060651779143116c1099860fe58dc45f654e7558e8f |
| hovercard-subject-tag | pull_request:4178098812 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4441/files |
| twitter:image | https://avatars.githubusercontent.com/u/55853254?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/55853254?s=400&v=4 |
| og:image:alt | What When a run starts, the run controller's first call is startRunAttempt. It already retried transient connection errors, but only on the default short budget (~5 attempts, ~7.5s) — too short... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git |
| octolytics-dimension-user_id | 95297378 |
| octolytics-dimension-user_login | triggerdotdev |
| octolytics-dimension-repository_id | 572570113 |
| octolytics-dimension-repository_nwo | triggerdotdev/trigger.dev |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 572570113 |
| octolytics-dimension-repository_network_root_nwo | triggerdotdev/trigger.dev |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a85e96a83bed7871993e6b1ffda24105928eee17 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width