| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:17384a75-574d-8697-6479-10b9676edc43 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EACC:29CAD0:728EBC:A98C32:6AFAF669 |
| html-safe-nonce | 6aaea3ef5c02bdd1437478af9884b3ede34ec1d50c5ffcaf7b86010effe09fcb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQUNDOjI5Q0FEMDo3MjhFQkM6QTk4QzMyOjZBRkFGNjY5IiwidmlzaXRvcl9pZCI6IjU1NjAwNjIzNDg3NjE5NTM4OTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4e702d7bbfe68edd3af098ac4aa8bb52396ac4706efeee43cc8c051b2a6afd9a |
| hovercard-subject-tag | pull_request:4120401493 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4358/files |
| twitter:image | https://avatars.githubusercontent.com/u/534?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/534?s=400&v=4 |
| og:image:alt | Summary
A single run output, trace span, or payload carrying JSON that ClickHouse can't ingest (for example nesting past its depth limit) used to fail the whole insert batch, so unrelated runs ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git |
| octolytics-dimension-user_id | 95297378 |
| octolytics-dimension-user_login | triggerdotdev |
| octolytics-dimension-repository_id | 572570113 |
| octolytics-dimension-repository_nwo | triggerdotdev/trigger.dev |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 572570113 |
| octolytics-dimension-repository_network_root_nwo | triggerdotdev/trigger.dev |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a85e96a83bed7871993e6b1ffda24105928eee17 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/triggerdotdev/trigger.dev/pull/4358/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4358%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4358%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev |
| Reload | https://github.com/triggerdotdev/trigger.dev/pull/4358/files |
| Reload | https://github.com/triggerdotdev/trigger.dev/pull/4358/files |
| Reload | https://github.com/triggerdotdev/trigger.dev/pull/4358/files |
| triggerdotdev | https://github.com/triggerdotdev |
| trigger.dev | https://github.com/triggerdotdev/trigger.dev |
| Code | https://github.com/triggerdotdev/trigger.dev |
| Issues203 (203) | https://github.com/triggerdotdev/trigger.dev/issues |
| Pull requests67 (67) | https://github.com/triggerdotdev/trigger.dev/pulls |
| Discussions | https://github.com/triggerdotdev/trigger.dev/discussions |
| Actions | https://github.com/triggerdotdev/trigger.dev/actions |
| Projects | https://github.com/triggerdotdev/trigger.dev/projects |
| Security and quality39 (39) | https://github.com/triggerdotdev/trigger.dev/security |
| Insights | https://github.com/triggerdotdev/trigger.dev/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose |
| ericallam | https://github.com/ericallam |
| main | https://github.com/triggerdotdev/trigger.dev/tree/main |
| fix/run-replication-json-parse-batch-drop | https://github.com/triggerdotdev/trigger.dev/tree/fix/run-replication-json-parse-batch-drop |
|
Conversation
44
| https://github.com/triggerdotdev/trigger.dev/pull/4358 |
|
Commits
13
| https://github.com/triggerdotdev/trigger.dev/pull/4358/commits |
|
Checks
67
| https://github.com/triggerdotdev/trigger.dev/pull/4358/checks |
|
Files changed
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files |
| Please reload this page | https://github.com/triggerdotdev/trigger.dev/pull/4358/files |
|
fix(webapp,clickhouse): keep the rest of a ClickHouse batch when one run or span has un-ingestable JSON
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files#top |
|
Show all changes
13 commits
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files |
|
be8115b
fix(webapp): keep the rest of a batch when one run or span has un-ing…
ericallam Jul 23, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/be8115b462775f2e10d27bff233e18b509df4224 |
|
29ebc5e
chore(webapp): rename batch row-isolation metric and emit run-replica…
ericallam Jul 24, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/29ebc5e16944e201bf1df0740ce00de17decf095 |
|
7b5460c
refactor(webapp): share JSON-parse recovery and keep poison rows with…
ericallam Jul 24, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/7b5460c5bfc68be21cadc7f08f68402dd9c5da5a |
|
73c447e
feat(webapp): cap row-isolation recovery cost against a poison flood
ericallam Jul 24, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/73c447e7284cc5282c1fb7afc1cd4d55061a3f8b |
|
7d26d78
fix(webapp): only count a dropped batch when nothing landed, and asse…
ericallam Jul 24, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/7d26d78a6eeab987934364390682560626bfc63a |
|
c78c5b0
test(webapp): sample benchmark ELU as a per-window delta and build po…
ericallam Jul 24, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/c78c5b0e3beac1208f3cc1e246d0adfc45991a83 |
|
535889f
fix(webapp,clickhouse): stop one un-ingestable JSON row dropping its …
ericallam Jul 24, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/535889fc04fc0e56fc8f46525ef66156e8857440 |
|
36df1a1
fix(webapp,clickhouse): keep ClickHouse row snippets out of logs
ericallam Jul 25, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/36df1a18bf430912548823154c313ecdf6cd9ac3 |
|
9da98a3
fix(clickhouse): make the patched rawMessage non-enumerable at the so…
ericallam Jul 27, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/9da98a35924fe66dcb682baef436b423b2258460 |
|
e9ecce0
fix(webapp): strip only a poison run's output, not its error
ericallam Jul 31, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/e9ecce019ea5d55a14c4f1e60c913571d2110cbc |
|
a20aed2
fix(webapp): anchor the row hint and stop rethrowing a dead batch
ericallam Jul 31, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/a20aed2f85b3518e2368573604c019cf4d976052 |
|
6b32405
fix(webapp): don't notify trace subscribers when nothing landed
ericallam Jul 31, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/6b324050ad55aea39c324ee72560fb1cf3fa6639 |
|
8357958
fix(webapp): log a whole-batch drop at error again, not warn
ericallam Jul 31, 2026
| https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/8357958e474793d96cabc0f8dcf97fa55baca75c |
|
Clear filters
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files |
| Please reload this page | https://github.com/triggerdotdev/trigger.dev/pull/4358/files |
| Please reload this page | https://github.com/triggerdotdev/trigger.dev/pull/4358/files |
|
fix-runs-list-batch-drop-on-unparseable-json.md
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files#diff-e3412a80c364de2e763f9135647cf3d7e4db9a411dfa01c8a0212a777e192a06 |
|
env.server.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files#diff-f8823615ef72da3494e74de9e62b2fa31315ed9360f17bc06ab943f4dc25f4fd |
|
runsReplicationInstance.server.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files#diff-eb6979ac5d616f99cff1238f08a6773c3d04c2506180675fd1d7bc9f9f22b510 |
|
runsReplicationService.server.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files#diff-57d6170ebedce17e6b4c66542bf89ca786d33ac432459f7e5cfec3bc7391e0b5 |
|
clickhouseEventRepository.server.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files#diff-2feda1843834eeed8bb4b12473f3b851b4c608ca6eacc4d193aca742fd6e30ad |
|
sanitizeRowsOnParseError.server.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files#diff-4d209459ebc0ff63710c764a97f46e6cfda604ee2aacaf6cc9bb255390da9891 |
|
clickhouseEventRepositoryJsonRecovery.test.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files#diff-8a282d8f868a3500d31f34ef9b7bf867cb19fa05c854367d8750e6a71feb9a65 |
|
runsReplicationBenchmark.producer.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files#diff-278004c9ee42fbd733d39a4520518b0cd31501b65fa96dbd336f2b42c88ded90 |
|
runsReplicationJsonRecoveryBenchmark.test.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files#diff-be31a16314fe6c963c6b5c73656bc1f87459030aaf5bbca5eecd8d280d3f2bf2 |
|
runsReplicationService.part10.test.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files#diff-203c5d384b47f6f1de1dd45f6c38bb2233dc24fb05609e0dc88a233687798240 |
|
sanitizeRowsOnParseError.test.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files#diff-936a199f8ad54e45d02e7068a496c1ec2543b26cbb4b5144729aaf58058cde3f |
|
client.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files#diff-10741538b9e113836bae6e267758a1fc5794f80a06960ccf4f57b43936fcb94f |
|
errors.test.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files#diff-807c74ba6d479fa7e602381aea14ebef44537320d191b7ffed62f9baaeec5ec9 |
|
errors.ts
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files#diff-1f14c9c88917c479d3bf1ace66de88c1809c4a5733117821581d5d87da5b08b7 |
|
package.json
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 |
|
@clickhouse__client-common@1.12.1.patch
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files#diff-4afb058f43fdf9f11b57b1ba2750f9a7d193444147cb9694ea90c95630ad9dcd |
|
pnpm-lock.yaml
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files#diff-32824c984905bb02bc7ffcef96a77addd1f1602cff71a11fbbfdd7f53ee026bb |
| .server-changes/fix-runs-list-batch-drop-on-unparseable-json.md | https://github.com/triggerdotdev/trigger.dev/pull/4358/files#diff-e3412a80c364de2e763f9135647cf3d7e4db9a411dfa01c8a0212a777e192a06 |
|
View file
| https://github.com/triggerdotdev/trigger.dev/blob/8357958e474793d96cabc0f8dcf97fa55baca75c/.server-changes/fix-runs-list-batch-drop-on-unparseable-json.md |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/triggerdotdev/trigger.dev/pull/4358/{{ revealButtonHref }} |
| apps/webapp/app/env.server.ts | https://github.com/triggerdotdev/trigger.dev/pull/4358/files#diff-f8823615ef72da3494e74de9e62b2fa31315ed9360f17bc06ab943f4dc25f4fd |
|
View file
| https://github.com/triggerdotdev/trigger.dev/blob/8357958e474793d96cabc0f8dcf97fa55baca75c/apps/webapp/app/env.server.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/triggerdotdev/trigger.dev/pull/4358/{{ revealButtonHref }} |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files#diff-f8823615ef72da3494e74de9e62b2fa31315ed9360f17bc06ab943f4dc25f4fd |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files#diff-f8823615ef72da3494e74de9e62b2fa31315ed9360f17bc06ab943f4dc25f4fd |
| apps/webapp/app/services/runsReplicationInstance.server.ts | https://github.com/triggerdotdev/trigger.dev/pull/4358/files#diff-eb6979ac5d616f99cff1238f08a6773c3d04c2506180675fd1d7bc9f9f22b510 |
|
View file
| https://github.com/triggerdotdev/trigger.dev/blob/8357958e474793d96cabc0f8dcf97fa55baca75c/apps/webapp/app/services/runsReplicationInstance.server.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/triggerdotdev/trigger.dev/pull/4358/{{ revealButtonHref }} |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files#diff-eb6979ac5d616f99cff1238f08a6773c3d04c2506180675fd1d7bc9f9f22b510 |
|
| https://github.com/triggerdotdev/trigger.dev/pull/4358/files#diff-eb6979ac5d616f99cff1238f08a6773c3d04c2506180675fd1d7bc9f9f22b510 |
| Please reload this page | https://github.com/triggerdotdev/trigger.dev/pull/4358/files |
| Please reload this page | https://github.com/triggerdotdev/trigger.dev/pull/4358/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |