René's URL Explorer Experiment


Title: fix(webapp,clickhouse): keep the rest of a ClickHouse batch when one run or span has un-ingestable JSON by ericallam · Pull Request #4358 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(webapp,clickhouse): keep the rest of a ClickHouse batch when one run or span has un-ingestable JSON by ericallam · Pull Request #4358 · triggerdotdev/trigger.dev

X Title: fix(webapp,clickhouse): keep the rest of a ClickHouse batch when one run or span has un-ingestable JSON by ericallam · Pull Request #4358 · triggerdotdev/trigger.dev

Description: Trigger.dev – build and deploy durable AI agents and workflows - fix(webapp,clickhouse): keep the rest of a ClickHouse batch when one run or span has un-ingestable JSON by ericallam · Pull Request #4358 · triggerdotdev/trigger.dev

Open Graph Description: Summary A single run output, trace span, or payload carrying JSON that ClickHouse can't ingest (for example nesting past its depth limit) used to fail the whole insert batch, so unrelated runs ...

X Description: Summary A single run output, trace span, or payload carrying JSON that ClickHouse can't ingest (for example nesting past its depth limit) used to fail the whole insert batch, so unrelated r...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4358

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:9c76baa9-57fd-a4f5-942e-1e5f7aed25c5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id905A:29CAD0:845660:C3C208:6AFAFC78
html-safe-noncedfc0d09586556423ccae23d9e12c8a81bf3654c3e6873886bdbf821e6ec1c8d9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDVBOjI5Q0FEMDo4NDU2NjA6QzNDMjA4OjZBRkFGQzc4IiwidmlzaXRvcl9pZCI6IjE3ODc1MDIwNzgyNzcxMjMxOTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8479aec9540b07ea5c648c43eba6b8004068d8daec7cd5fdbc70c434dbf18d29
hovercard-subject-tagpull_request:4120401493
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4358/commits
twitter:imagehttps://opengraph.githubassets.com/00f3de2fcf1d6ca1a7a81e48a253ff2c6873386c82dddf3773c2b6c94395100d/triggerdotdev/trigger.dev/pull/4358
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/00f3de2fcf1d6ca1a7a81e48a253ff2c6873386c82dddf3773c2b6c94395100d/triggerdotdev/trigger.dev/pull/4358
og:image:altSummary A single run output, trace span, or payload carrying JSON that ClickHouse can't ingest (for example nesting past its depth limit) used to fail the whole insert batch, so unrelated runs ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameericallam
hostnamegithub.com
expected-hostnamegithub.com
None54f7a6886649661c85eee945cca0773566bfb4065370e0429b7c8f7204184650
turbo-cache-controlno-cache
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecf8450eb633ec589502c42ff6f4072e40db65da3
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4358/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4358%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4358%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4358/commits
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4358/commits
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4358/commits
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
https://github.com/triggerdotdev/trigger.dev
ericallamhttps://github.com/ericallam
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
fix/run-replication-json-parse-batch-drophttps://github.com/triggerdotdev/trigger.dev/tree/fix/run-replication-json-parse-batch-drop
Conversationhttps://github.com/triggerdotdev/trigger.dev/pull/4358
Commits13 (13)https://github.com/triggerdotdev/trigger.dev/pull/4358/commits
Checkshttps://github.com/triggerdotdev/trigger.dev/pull/4358/checks
Files changedhttps://github.com/triggerdotdev/trigger.dev/pull/4358/files
fix(webapp,clickhouse): keep the rest of a ClickHouse batch when one run or span has un-ingestable JSONhttps://github.com/triggerdotdev/trigger.dev/pull/4358/commits#top
ericallamhttps://github.com/ericallam
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
fix/run-replication-json-parse-batch-drophttps://github.com/triggerdotdev/trigger.dev/tree/fix/run-replication-json-parse-batch-drop
fix(webapp): keep the rest of a batch when one run or span has un-ingestable JSONhttps://github.com/triggerdotdev/trigger.dev/pull/4358/commits/be8115b462775f2e10d27bff233e18b509df4224
https://github.com/ericallam
ericallamhttps://github.com/triggerdotdev/trigger.dev/commits?author=ericallam
be8115bhttps://github.com/triggerdotdev/trigger.dev/pull/4358/commits/be8115b462775f2e10d27bff233e18b509df4224
https://github.com/triggerdotdev/trigger.dev/tree/be8115b462775f2e10d27bff233e18b509df4224
chore(webapp): rename batch row-isolation metric and emit run-replication drop/isolation countershttps://github.com/triggerdotdev/trigger.dev/pull/4358/commits/29ebc5e16944e201bf1df0740ce00de17decf095
https://github.com/ericallam
ericallamhttps://github.com/triggerdotdev/trigger.dev/commits?author=ericallam
29ebc5ehttps://github.com/triggerdotdev/trigger.dev/pull/4358/commits/29ebc5e16944e201bf1df0740ce00de17decf095
https://github.com/triggerdotdev/trigger.dev/tree/29ebc5e16944e201bf1df0740ce00de17decf095
refactor(webapp): share JSON-parse recovery and keep poison rows with their JSON strippedhttps://github.com/triggerdotdev/trigger.dev/pull/4358/commits/7b5460c5bfc68be21cadc7f08f68402dd9c5da5a
https://github.com/ericallam
ericallamhttps://github.com/triggerdotdev/trigger.dev/commits?author=ericallam
7b5460chttps://github.com/triggerdotdev/trigger.dev/pull/4358/commits/7b5460c5bfc68be21cadc7f08f68402dd9c5da5a
https://github.com/triggerdotdev/trigger.dev/tree/7b5460c5bfc68be21cadc7f08f68402dd9c5da5a
feat(webapp): cap row-isolation recovery cost against a poison floodhttps://github.com/triggerdotdev/trigger.dev/pull/4358/commits/73c447e7284cc5282c1fb7afc1cd4d55061a3f8b
https://github.com/ericallam
ericallamhttps://github.com/triggerdotdev/trigger.dev/commits?author=ericallam
73c447ehttps://github.com/triggerdotdev/trigger.dev/pull/4358/commits/73c447e7284cc5282c1fb7afc1cd4d55061a3f8b
https://github.com/triggerdotdev/trigger.dev/tree/73c447e7284cc5282c1fb7afc1cd4d55061a3f8b
fix(webapp): only count a dropped batch when nothing landed, and assert the isolation cap bounds insertshttps://github.com/triggerdotdev/trigger.dev/pull/4358/commits/7d26d78a6eeab987934364390682560626bfc63a
https://github.com/ericallam
ericallamhttps://github.com/triggerdotdev/trigger.dev/commits?author=ericallam
7d26d78https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/7d26d78a6eeab987934364390682560626bfc63a
https://github.com/triggerdotdev/trigger.dev/tree/7d26d78a6eeab987934364390682560626bfc63a
test(webapp): sample benchmark ELU as a per-window delta and build poison JSON iterativelyhttps://github.com/triggerdotdev/trigger.dev/pull/4358/commits/c78c5b0e3beac1208f3cc1e246d0adfc45991a83
https://github.com/ericallam
ericallamhttps://github.com/triggerdotdev/trigger.dev/commits?author=ericallam
c78c5b0https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/c78c5b0e3beac1208f3cc1e246d0adfc45991a83
https://github.com/triggerdotdev/trigger.dev/tree/c78c5b0e3beac1208f3cc1e246d0adfc45991a83
fix(webapp,clickhouse): stop one un-ingestable JSON row dropping its whole ClickHouse batchhttps://github.com/triggerdotdev/trigger.dev/pull/4358/commits/535889fc04fc0e56fc8f46525ef66156e8857440
https://github.com/ericallam
ericallamhttps://github.com/triggerdotdev/trigger.dev/commits?author=ericallam
535889fhttps://github.com/triggerdotdev/trigger.dev/pull/4358/commits/535889fc04fc0e56fc8f46525ef66156e8857440
https://github.com/triggerdotdev/trigger.dev/tree/535889fc04fc0e56fc8f46525ef66156e8857440
fix(webapp,clickhouse): keep ClickHouse row snippets out of logshttps://github.com/triggerdotdev/trigger.dev/pull/4358/commits/36df1a18bf430912548823154c313ecdf6cd9ac3
https://github.com/ericallam
ericallamhttps://github.com/triggerdotdev/trigger.dev/commits?author=ericallam
36df1a1https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/36df1a18bf430912548823154c313ecdf6cd9ac3
https://github.com/triggerdotdev/trigger.dev/tree/36df1a18bf430912548823154c313ecdf6cd9ac3
fix(clickhouse): make the patched rawMessage non-enumerable at the sourcehttps://github.com/triggerdotdev/trigger.dev/pull/4358/commits/9da98a35924fe66dcb682baef436b423b2258460
https://github.com/ericallam
ericallamhttps://github.com/triggerdotdev/trigger.dev/commits?author=ericallam
9da98a3https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/9da98a35924fe66dcb682baef436b423b2258460
https://github.com/triggerdotdev/trigger.dev/tree/9da98a35924fe66dcb682baef436b423b2258460
fix(webapp): strip only a poison run's output, not its errorhttps://github.com/triggerdotdev/trigger.dev/pull/4358/commits/e9ecce019ea5d55a14c4f1e60c913571d2110cbc
https://github.com/ericallam
ericallamhttps://github.com/triggerdotdev/trigger.dev/commits?author=ericallam
e9ecce0https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/e9ecce019ea5d55a14c4f1e60c913571d2110cbc
https://github.com/triggerdotdev/trigger.dev/tree/e9ecce019ea5d55a14c4f1e60c913571d2110cbc
fix(webapp): anchor the row hint and stop rethrowing a dead batchhttps://github.com/triggerdotdev/trigger.dev/pull/4358/commits/a20aed2f85b3518e2368573604c019cf4d976052
https://github.com/ericallam
ericallamhttps://github.com/triggerdotdev/trigger.dev/commits?author=ericallam
a20aed2https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/a20aed2f85b3518e2368573604c019cf4d976052
https://github.com/triggerdotdev/trigger.dev/tree/a20aed2f85b3518e2368573604c019cf4d976052
fix(webapp): don't notify trace subscribers when nothing landedhttps://github.com/triggerdotdev/trigger.dev/pull/4358/commits/6b324050ad55aea39c324ee72560fb1cf3fa6639
https://github.com/ericallam
ericallamhttps://github.com/triggerdotdev/trigger.dev/commits?author=ericallam
6b32405https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/6b324050ad55aea39c324ee72560fb1cf3fa6639
https://github.com/triggerdotdev/trigger.dev/tree/6b324050ad55aea39c324ee72560fb1cf3fa6639
fix(webapp): log a whole-batch drop at error again, not warnhttps://github.com/triggerdotdev/trigger.dev/pull/4358/commits/8357958e474793d96cabc0f8dcf97fa55baca75c
https://github.com/ericallam
ericallamhttps://github.com/triggerdotdev/trigger.dev/commits?author=ericallam
8357958https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/8357958e474793d96cabc0f8dcf97fa55baca75c
https://github.com/triggerdotdev/trigger.dev/tree/8357958e474793d96cabc0f8dcf97fa55baca75c
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.