| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/commits(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:9c76baa9-57fd-a4f5-942e-1e5f7aed25c5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 905A:29CAD0:845660:C3C208:6AFAFC78 |
| html-safe-nonce | dfc0d09586556423ccae23d9e12c8a81bf3654c3e6873886bdbf821e6ec1c8d9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDVBOjI5Q0FEMDo4NDU2NjA6QzNDMjA4OjZBRkFGQzc4IiwidmlzaXRvcl9pZCI6IjE3ODc1MDIwNzgyNzcxMjMxOTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8479aec9540b07ea5c648c43eba6b8004068d8daec7cd5fdbc70c434dbf18d29 |
| hovercard-subject-tag | pull_request:4120401493 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/commits |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4358/commits |
| twitter:image | https://opengraph.githubassets.com/00f3de2fcf1d6ca1a7a81e48a253ff2c6873386c82dddf3773c2b6c94395100d/triggerdotdev/trigger.dev/pull/4358 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/00f3de2fcf1d6ca1a7a81e48a253ff2c6873386c82dddf3773c2b6c94395100d/triggerdotdev/trigger.dev/pull/4358 |
| og:image:alt | Summary
A single run output, trace span, or payload carrying JSON that ClickHouse can't ingest (for example nesting past its depth limit) used to fail the whole insert batch, so unrelated runs ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ericallam |
| hostname | github.com |
| expected-hostname | github.com |
| None | 54f7a6886649661c85eee945cca0773566bfb4065370e0429b7c8f7204184650 |
| turbo-cache-control | no-cache |
| go-import | github.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git |
| octolytics-dimension-user_id | 95297378 |
| octolytics-dimension-user_login | triggerdotdev |
| octolytics-dimension-repository_id | 572570113 |
| octolytics-dimension-repository_nwo | triggerdotdev/trigger.dev |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 572570113 |
| octolytics-dimension-repository_network_root_nwo | triggerdotdev/trigger.dev |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cf8450eb633ec589502c42ff6f4072e40db65da3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4358%2Fcommits |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4358%2Fcommits |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev |
| Reload | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits |
| Reload | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits |
| Reload | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits |
| triggerdotdev | https://github.com/triggerdotdev |
| trigger.dev | https://github.com/triggerdotdev/trigger.dev |
| Code | https://github.com/triggerdotdev/trigger.dev |
| Issues203 (203) | https://github.com/triggerdotdev/trigger.dev/issues |
| Pull requests67 (67) | https://github.com/triggerdotdev/trigger.dev/pulls |
| Discussions | https://github.com/triggerdotdev/trigger.dev/discussions |
| Actions | https://github.com/triggerdotdev/trigger.dev/actions |
| Projects | https://github.com/triggerdotdev/trigger.dev/projects |
| Security and quality39 (39) | https://github.com/triggerdotdev/trigger.dev/security |
| Insights | https://github.com/triggerdotdev/trigger.dev/pulse |
| https://github.com/triggerdotdev/trigger.dev |
| ericallam | https://github.com/ericallam |
| main | https://github.com/triggerdotdev/trigger.dev/tree/main |
| fix/run-replication-json-parse-batch-drop | https://github.com/triggerdotdev/trigger.dev/tree/fix/run-replication-json-parse-batch-drop |
| Conversation | https://github.com/triggerdotdev/trigger.dev/pull/4358 |
| Commits13 (13) | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits |
| Checks | https://github.com/triggerdotdev/trigger.dev/pull/4358/checks |
| Files changed | https://github.com/triggerdotdev/trigger.dev/pull/4358/files |
| fix(webapp,clickhouse): keep the rest of a ClickHouse batch when one run or span has un-ingestable JSON | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits#top |
| ericallam | https://github.com/ericallam |
| main | https://github.com/triggerdotdev/trigger.dev/tree/main |
| fix/run-replication-json-parse-batch-drop | https://github.com/triggerdotdev/trigger.dev/tree/fix/run-replication-json-parse-batch-drop |
| fix(webapp): keep the rest of a batch when one run or span has un-ingestable JSON | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/be8115b462775f2e10d27bff233e18b509df4224 |
| https://github.com/ericallam |
| ericallam | https://github.com/triggerdotdev/trigger.dev/commits?author=ericallam |
| be8115b | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/be8115b462775f2e10d27bff233e18b509df4224 |
| https://github.com/triggerdotdev/trigger.dev/tree/be8115b462775f2e10d27bff233e18b509df4224 |
| chore(webapp): rename batch row-isolation metric and emit run-replication drop/isolation counters | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/29ebc5e16944e201bf1df0740ce00de17decf095 |
| https://github.com/ericallam |
| ericallam | https://github.com/triggerdotdev/trigger.dev/commits?author=ericallam |
| 29ebc5e | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/29ebc5e16944e201bf1df0740ce00de17decf095 |
| https://github.com/triggerdotdev/trigger.dev/tree/29ebc5e16944e201bf1df0740ce00de17decf095 |
| refactor(webapp): share JSON-parse recovery and keep poison rows with their JSON stripped | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/7b5460c5bfc68be21cadc7f08f68402dd9c5da5a |
| https://github.com/ericallam |
| ericallam | https://github.com/triggerdotdev/trigger.dev/commits?author=ericallam |
| 7b5460c | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/7b5460c5bfc68be21cadc7f08f68402dd9c5da5a |
| https://github.com/triggerdotdev/trigger.dev/tree/7b5460c5bfc68be21cadc7f08f68402dd9c5da5a |
| feat(webapp): cap row-isolation recovery cost against a poison flood | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/73c447e7284cc5282c1fb7afc1cd4d55061a3f8b |
| https://github.com/ericallam |
| ericallam | https://github.com/triggerdotdev/trigger.dev/commits?author=ericallam |
| 73c447e | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/73c447e7284cc5282c1fb7afc1cd4d55061a3f8b |
| https://github.com/triggerdotdev/trigger.dev/tree/73c447e7284cc5282c1fb7afc1cd4d55061a3f8b |
| fix(webapp): only count a dropped batch when nothing landed, and assert the isolation cap bounds inserts | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/7d26d78a6eeab987934364390682560626bfc63a |
| https://github.com/ericallam |
| ericallam | https://github.com/triggerdotdev/trigger.dev/commits?author=ericallam |
| 7d26d78 | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/7d26d78a6eeab987934364390682560626bfc63a |
| https://github.com/triggerdotdev/trigger.dev/tree/7d26d78a6eeab987934364390682560626bfc63a |
| test(webapp): sample benchmark ELU as a per-window delta and build poison JSON iteratively | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/c78c5b0e3beac1208f3cc1e246d0adfc45991a83 |
| https://github.com/ericallam |
| ericallam | https://github.com/triggerdotdev/trigger.dev/commits?author=ericallam |
| c78c5b0 | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/c78c5b0e3beac1208f3cc1e246d0adfc45991a83 |
| https://github.com/triggerdotdev/trigger.dev/tree/c78c5b0e3beac1208f3cc1e246d0adfc45991a83 |
| fix(webapp,clickhouse): stop one un-ingestable JSON row dropping its whole ClickHouse batch | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/535889fc04fc0e56fc8f46525ef66156e8857440 |
| https://github.com/ericallam |
| ericallam | https://github.com/triggerdotdev/trigger.dev/commits?author=ericallam |
| 535889f | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/535889fc04fc0e56fc8f46525ef66156e8857440 |
| https://github.com/triggerdotdev/trigger.dev/tree/535889fc04fc0e56fc8f46525ef66156e8857440 |
| fix(webapp,clickhouse): keep ClickHouse row snippets out of logs | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/36df1a18bf430912548823154c313ecdf6cd9ac3 |
| https://github.com/ericallam |
| ericallam | https://github.com/triggerdotdev/trigger.dev/commits?author=ericallam |
| 36df1a1 | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/36df1a18bf430912548823154c313ecdf6cd9ac3 |
| https://github.com/triggerdotdev/trigger.dev/tree/36df1a18bf430912548823154c313ecdf6cd9ac3 |
| fix(clickhouse): make the patched rawMessage non-enumerable at the source | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/9da98a35924fe66dcb682baef436b423b2258460 |
| https://github.com/ericallam |
| ericallam | https://github.com/triggerdotdev/trigger.dev/commits?author=ericallam |
| 9da98a3 | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/9da98a35924fe66dcb682baef436b423b2258460 |
| https://github.com/triggerdotdev/trigger.dev/tree/9da98a35924fe66dcb682baef436b423b2258460 |
| fix(webapp): strip only a poison run's output, not its error | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/e9ecce019ea5d55a14c4f1e60c913571d2110cbc |
| https://github.com/ericallam |
| ericallam | https://github.com/triggerdotdev/trigger.dev/commits?author=ericallam |
| e9ecce0 | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/e9ecce019ea5d55a14c4f1e60c913571d2110cbc |
| https://github.com/triggerdotdev/trigger.dev/tree/e9ecce019ea5d55a14c4f1e60c913571d2110cbc |
| fix(webapp): anchor the row hint and stop rethrowing a dead batch | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/a20aed2f85b3518e2368573604c019cf4d976052 |
| https://github.com/ericallam |
| ericallam | https://github.com/triggerdotdev/trigger.dev/commits?author=ericallam |
| a20aed2 | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/a20aed2f85b3518e2368573604c019cf4d976052 |
| https://github.com/triggerdotdev/trigger.dev/tree/a20aed2f85b3518e2368573604c019cf4d976052 |
| fix(webapp): don't notify trace subscribers when nothing landed | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/6b324050ad55aea39c324ee72560fb1cf3fa6639 |
| https://github.com/ericallam |
| ericallam | https://github.com/triggerdotdev/trigger.dev/commits?author=ericallam |
| 6b32405 | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/6b324050ad55aea39c324ee72560fb1cf3fa6639 |
| https://github.com/triggerdotdev/trigger.dev/tree/6b324050ad55aea39c324ee72560fb1cf3fa6639 |
| fix(webapp): log a whole-batch drop at error again, not warn | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/8357958e474793d96cabc0f8dcf97fa55baca75c |
| https://github.com/ericallam |
| ericallam | https://github.com/triggerdotdev/trigger.dev/commits?author=ericallam |
| 8357958 | https://github.com/triggerdotdev/trigger.dev/pull/4358/commits/8357958e474793d96cabc0f8dcf97fa55baca75c |
| https://github.com/triggerdotdev/trigger.dev/tree/8357958e474793d96cabc0f8dcf97fa55baca75c |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |