René's URL Explorer Experiment


Title: fix(docker): stop the container entrypoint printing database connection strings in logs by ericallam · Pull Request #4346 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(docker): stop the container entrypoint printing database connection strings in logs by ericallam · Pull Request #4346 · triggerdotdev/trigger.dev

X Title: fix(docker): stop the container entrypoint printing database connection strings in logs by ericallam · Pull Request #4346 · triggerdotdev/trigger.dev

Description: Summary The container entrypoint runs under set -x, which echoes every command to the logs with its variables expanded. Several startup guards reference full database connection strings, so the DSN (including the password) was printed to the container logs on every boot. This turns tracing off around those lines so connection strings are never traced, while leaving migration behavior and ordinary startup logging unchanged. Fix The leaking lines are the [ -n "$RUN_OPS_DATABASE_URL" ] and [ -n "$RUN_OPS_LEGACY_DIRECT_URL" ] guards, and the ClickHouse block (its [ -n "$CLICKHOUSE_URL" ] guard plus the lines that build GOOSE_DBSTRING from CLICKHOUSE_URL). set -x prints each of these with the credential expanded. Tracing is now disabled around each region and restored afterward, so non-secret tracing is preserved everywhere else. The existing legacy-migration subshell already protected its own command body; this adds the missing protection for the guards and the ClickHouse block. { set +x; } 2>/dev/null if [ -n "$RUN_OPS_DATABASE_URL" ]; then set -x ... Verification Built the webapp image and ran it with dummy sentinel connection strings whose password token is S3NTINEL_PW_DoNotLog, then grepped the boot logs. Before (unmodified), the token appears in the traced guards: + [ -n postgresql://user:S3NTINEL_PW_DoNotLog@fake-host:6432/run-ops ] + [ -n postgresql://user:S3NTINEL_PW_DoNotLog@fake-host:5432/legacy ] + [ -n https://default:S3NTINEL_PW_DoNotLog@fake-host:8443 ] After, grep S3NTINEL_PW_DoNotLog on the same run returns nothing, and the normal "skipping ... migrations" lines still log.

Open Graph Description: Summary The container entrypoint runs under set -x, which echoes every command to the logs with its variables expanded. Several startup guards reference full database connection strings, so the DSN...

X Description: Summary The container entrypoint runs under set -x, which echoes every command to the logs with its variables expanded. Several startup guards reference full database connection strings, so the DSN...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4346

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:144225a5-4d86-0ebd-e444-110e915781bc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCF52:C1BA:6FA751:A677ED:6AFAF76D
html-safe-nonce94a76354f1449188d723e4a088a90cd1466f4aa08cc991e2dc67f513a2dd701a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjUyOkMxQkE6NkZBNzUxOkE2NzdFRDo2QUZBRjc2RCIsInZpc2l0b3JfaWQiOiIxODc0ODE1NTAzNTI0NjI0MjM3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8882a4c440e52aa9122d90560630e615cf4bef2ab0dbc540b724c9e018454a11
hovercard-subject-tagpull_request:4115773800
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4346/files
twitter:imagehttps://avatars.githubusercontent.com/u/534?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/534?s=400&v=4
og:image:altSummary The container entrypoint runs under set -x, which echoes every command to the logs with its variables expanded. Several startup guards reference full database connection strings, so the DSN...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea85e96a83bed7871993e6b1ffda24105928eee17
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4346/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4346%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4346%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4346/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4346/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4346/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
ericallamhttps://github.com/ericallam
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
fix/entrypoint-no-trace-db-dsnhttps://github.com/triggerdotdev/trigger.dev/tree/fix/entrypoint-no-trace-db-dsn
Conversation 2 https://github.com/triggerdotdev/trigger.dev/pull/4346
Commits 1 https://github.com/triggerdotdev/trigger.dev/pull/4346/commits
Checks 31 https://github.com/triggerdotdev/trigger.dev/pull/4346/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/4346/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4346/files
fix(docker): stop the container entrypoint printing database connection strings in logs https://github.com/triggerdotdev/trigger.dev/pull/4346/files#top
Show all changes 1 commit https://github.com/triggerdotdev/trigger.dev/pull/4346/files
690a572 fix(docker): stop the container entrypoint printing database connecti… ericallam Jul 23, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4346/commits/690a57297000b1ca4354bc9327b1cd19b2e981f5
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/4346/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4346/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4346/files
entrypoint-no-log-db-connection-strings.md https://github.com/triggerdotdev/trigger.dev/pull/4346/files#diff-589a429a4fca77414b30b29376aabcedc022e716abd32f4a3b9ad23499e3831a
entrypoint.sh https://github.com/triggerdotdev/trigger.dev/pull/4346/files#diff-89e005861019097e65391ee0215309a760cce39210b384d78faab2b661530abe
.server-changes/entrypoint-no-log-db-connection-strings.mdhttps://github.com/triggerdotdev/trigger.dev/pull/4346/files#diff-589a429a4fca77414b30b29376aabcedc022e716abd32f4a3b9ad23499e3831a
View file https://github.com/triggerdotdev/trigger.dev/blob/690a57297000b1ca4354bc9327b1cd19b2e981f5/.server-changes/entrypoint-no-log-db-connection-strings.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4346/{{ revealButtonHref }}
docker/scripts/entrypoint.shhttps://github.com/triggerdotdev/trigger.dev/pull/4346/files#diff-89e005861019097e65391ee0215309a760cce39210b384d78faab2b661530abe
View file https://github.com/triggerdotdev/trigger.dev/blob/690a57297000b1ca4354bc9327b1cd19b2e981f5/docker/scripts/entrypoint.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4346/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4346/files#diff-89e005861019097e65391ee0215309a760cce39210b384d78faab2b661530abe
https://github.com/triggerdotdev/trigger.dev/pull/4346/files#diff-89e005861019097e65391ee0215309a760cce39210b384d78faab2b661530abe
https://github.com/triggerdotdev/trigger.dev/pull/4346/files#diff-89e005861019097e65391ee0215309a760cce39210b384d78faab2b661530abe
https://github.com/triggerdotdev/trigger.dev/pull/4346/files#diff-89e005861019097e65391ee0215309a760cce39210b384d78faab2b661530abe
https://github.com/triggerdotdev/trigger.dev/pull/4346/files#diff-89e005861019097e65391ee0215309a760cce39210b384d78faab2b661530abe
https://github.com/triggerdotdev/trigger.dev/pull/4346/files#diff-89e005861019097e65391ee0215309a760cce39210b384d78faab2b661530abe
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.