René's URL Explorer Experiment


Title: fix(webapp): reuse the primary db pool for legacy run-ops when DSNs match by d-cs · Pull Request #4253 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(webapp): reuse the primary db pool for legacy run-ops when DSNs match by d-cs · Pull Request #4253 · triggerdotdev/trigger.dev

X Title: fix(webapp): reuse the primary db pool for legacy run-ops when DSNs match by d-cs · Pull Request #4253 · triggerdotdev/trigger.dev

Description: Summary When the run-ops split is enabled, the legacy run-ops database client was always constructed as its own connection pool, even when it points at the same database as the primary (control-plane) client. On setups where those two DSNs resolve to the same physical database, this opened a second, redundant pool and doubled the number of connections used against that database. This change makes the legacy client reuse the primary client's pool whenever their DSNs point at the same database, and only open a separate pool when they genuinely differ. Fix A small sameDatabaseTarget comparison (host, port, database name, user) decides whether the legacy DSN points at the same database as the primary. When it does, the legacy handle reuses the primary client by reference, so no second pool is opened. When the DSNs diverge, the legacy client is built independently as before, so the split still works once the databases are actually separate. Two smaller changes ride along: An optional per-pool limit for the run-ops read replica, which connects unpooled and so draws raw backend connections; unset, it falls back to the existing default and behaviour is unchanged. A startup warning about a missing legacy replica URL is now suppressed when the legacy client shares the primary pool, where it would be misleading. Verification Booted the webapp end-to-end in three modes and confirmed the pools opened as expected via the client's own startup logs and live backend connection counts: split off (single pool), split on with a shared database (legacy reuses the primary pool, no doubling), and split on with separate databases (legacy opens its own pool).

Open Graph Description: Summary When the run-ops split is enabled, the legacy run-ops database client was always constructed as its own connection pool, even when it points at the same database as the primary (control-pla...

X Description: Summary When the run-ops split is enabled, the legacy run-ops database client was always constructed as its own connection pool, even when it points at the same database as the primary (control-pla...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4253

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:be4f851b-6bc1-1e62-8e7b-d9be67c77ba1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD57E:1F63:A8B5A1:FC741B:6AFAF5EC
html-safe-nonce608f38cd9cec4a3bd77b8984bfd26dcb37d997728b755aee3c376879b9498b1d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTdFOjFGNjM6QThCNUExOkZDNzQxQjo2QUZBRjVFQyIsInZpc2l0b3JfaWQiOiI3ODk3NDI2OTQzMjk5NzQ1MjYwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac36749b06b3d17524987914b9349444246e8932e1f8461c69c55c635331dc0fb0
hovercard-subject-tagpull_request:4051490358
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4253/files
twitter:imagehttps://avatars.githubusercontent.com/u/45313566?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/45313566?s=400&v=4
og:image:altSummary When the run-ops split is enabled, the legacy run-ops database client was always constructed as its own connection pool, even when it points at the same database as the primary (control-pla...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea85e96a83bed7871993e6b1ffda24105928eee17
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4253/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4253%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4253%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4253/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4253/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4253/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
d-cshttps://github.com/d-cs
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
feat/run-ops-connection-pool-splithttps://github.com/triggerdotdev/trigger.dev/tree/feat/run-ops-connection-pool-split
Conversation 3 https://github.com/triggerdotdev/trigger.dev/pull/4253
Commits 2 https://github.com/triggerdotdev/trigger.dev/pull/4253/commits
Checks 39 https://github.com/triggerdotdev/trigger.dev/pull/4253/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/4253/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4253/files
fix(webapp): reuse the primary db pool for legacy run-ops when DSNs match https://github.com/triggerdotdev/trigger.dev/pull/4253/files#top
Show all changes 2 commits https://github.com/triggerdotdev/trigger.dev/pull/4253/files
0bbf20c fix(webapp): reuse the primary db pool for legacy run-ops when DSNs m… d-cs Jul 14, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4253/commits/0bbf20c67f403a7a37f7e7d71dc622e2260a36ca
6c4eed0 chore(webapp): trim run-ops pool comments d-cs Jul 14, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4253/commits/6c4eed06b2b8724171fb00896ba4c48f2b326480
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/4253/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4253/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4253/files
run-ops-legacy-shared-pool.md https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-741f84f371882aeec03ac9903b26c86498b53f53613fb1d5089eb22e36641f93
db.server.ts https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-f81e28167ca153a26ec3513924ea843f71b59992d6fddf7f66ebe131bd5b0d89
env.server.ts https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-f8823615ef72da3494e74de9e62b2fa31315ed9360f17bc06ab943f4dc25f4fd
runOpsDbTopology.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-d9c037cac29ac803f31ece9a17f81609ba950b465bfcc958b9ee1cc32b8c08db
.server-changes/run-ops-legacy-shared-pool.mdhttps://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-741f84f371882aeec03ac9903b26c86498b53f53613fb1d5089eb22e36641f93
View file https://github.com/triggerdotdev/trigger.dev/blob/6c4eed06b2b8724171fb00896ba4c48f2b326480/.server-changes/run-ops-legacy-shared-pool.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4253/{{ revealButtonHref }}
apps/webapp/app/db.server.tshttps://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-f81e28167ca153a26ec3513924ea843f71b59992d6fddf7f66ebe131bd5b0d89
View file https://github.com/triggerdotdev/trigger.dev/blob/6c4eed06b2b8724171fb00896ba4c48f2b326480/apps/webapp/app/db.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4253/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-f81e28167ca153a26ec3513924ea843f71b59992d6fddf7f66ebe131bd5b0d89
https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-f81e28167ca153a26ec3513924ea843f71b59992d6fddf7f66ebe131bd5b0d89
https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-f81e28167ca153a26ec3513924ea843f71b59992d6fddf7f66ebe131bd5b0d89
https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-f81e28167ca153a26ec3513924ea843f71b59992d6fddf7f66ebe131bd5b0d89
https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-f81e28167ca153a26ec3513924ea843f71b59992d6fddf7f66ebe131bd5b0d89
https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-f81e28167ca153a26ec3513924ea843f71b59992d6fddf7f66ebe131bd5b0d89
https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-f81e28167ca153a26ec3513924ea843f71b59992d6fddf7f66ebe131bd5b0d89
https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-f81e28167ca153a26ec3513924ea843f71b59992d6fddf7f66ebe131bd5b0d89
https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-f81e28167ca153a26ec3513924ea843f71b59992d6fddf7f66ebe131bd5b0d89
https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-f81e28167ca153a26ec3513924ea843f71b59992d6fddf7f66ebe131bd5b0d89
apps/webapp/app/env.server.tshttps://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-f8823615ef72da3494e74de9e62b2fa31315ed9360f17bc06ab943f4dc25f4fd
View file https://github.com/triggerdotdev/trigger.dev/blob/6c4eed06b2b8724171fb00896ba4c48f2b326480/apps/webapp/app/env.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4253/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-f8823615ef72da3494e74de9e62b2fa31315ed9360f17bc06ab943f4dc25f4fd
https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-f8823615ef72da3494e74de9e62b2fa31315ed9360f17bc06ab943f4dc25f4fd
apps/webapp/test/runOpsDbTopology.test.tshttps://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-d9c037cac29ac803f31ece9a17f81609ba950b465bfcc958b9ee1cc32b8c08db
View file https://github.com/triggerdotdev/trigger.dev/blob/6c4eed06b2b8724171fb00896ba4c48f2b326480/apps/webapp/test/runOpsDbTopology.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4253/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-d9c037cac29ac803f31ece9a17f81609ba950b465bfcc958b9ee1cc32b8c08db
https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-d9c037cac29ac803f31ece9a17f81609ba950b465bfcc958b9ee1cc32b8c08db
https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-d9c037cac29ac803f31ece9a17f81609ba950b465bfcc958b9ee1cc32b8c08db
https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-d9c037cac29ac803f31ece9a17f81609ba950b465bfcc958b9ee1cc32b8c08db
https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-d9c037cac29ac803f31ece9a17f81609ba950b465bfcc958b9ee1cc32b8c08db
https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-d9c037cac29ac803f31ece9a17f81609ba950b465bfcc958b9ee1cc32b8c08db
https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-d9c037cac29ac803f31ece9a17f81609ba950b465bfcc958b9ee1cc32b8c08db
https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-d9c037cac29ac803f31ece9a17f81609ba950b465bfcc958b9ee1cc32b8c08db
https://github.com/triggerdotdev/trigger.dev/pull/4253/files#diff-d9c037cac29ac803f31ece9a17f81609ba950b465bfcc958b9ee1cc32b8c08db
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.