René's URL Explorer Experiment


Title: perf(webapp): avoid unindexed fileId scan in get-background-worker-by-version by d-cs · Pull Request #4245 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: perf(webapp): avoid unindexed fileId scan in get-background-worker-by-version by d-cs · Pull Request #4245 · triggerdotdev/trigger.dev

X Title: perf(webapp): avoid unindexed fileId scan in get-background-worker-by-version by d-cs · Pull Request #4245 · triggerdotdev/trigger.dev

Description: What The GET /api/v1/projects/:projectRef/background-workers/:envSlug/:version endpoint loaded each file's tasks through the nested files.tasks relation. Prisma resolves that as a separate query: SELECT id, slug, "fileId" FROM "BackgroundWorkerTask" WHERE "fileId" IN (...) BackgroundWorkerTask.fileId is not indexed — the FK constraint exists, but Postgres does not auto-create an index for foreign keys — so on a large table this can only run as a sequential scan, which gets progressively slower as the table grows and was observed taking minutes per call in production. The loader already loads every task for the worker via tasks: true, which uses the indexed workerId relation, and those rows already include fileId. This PR groups task slugs by fileId in memory from that already-loaded data and drops the files.tasks include entirely. Behavior change (latent bug fix) The response shape is unchanged, but there is a semantic correction for source files reused across worker versions (files are de-duplicated by @@unique([projectId, contentHash]), so one file row can be linked to many workers). Before: file.tasks came from the BackgroundWorkerFile.tasks relation, i.e. every BackgroundWorkerTask with that fileId — across all workers sharing the file. So a worker's manifest could list tasks it doesn't actually have. After: file.tasks is grouped from the queried worker's own tasks, so it reflects only that worker version's tasks. Verified on a local DB: 460 files are referenced by tasks from more than one worker; of 6819 (worker, file) pairs, 6 differ — all one file where the old union leaked a task slug (cancellation-test) into worker versions that never had it. The new per-worker behavior is the correct one for a worker-version manifest. (Thanks to the automated review for flagging this.) Analysis Captured the exact SQL before/after by instrumenting Prisma against real data (a worker with 62 files): Before: 5 statements, including the WHERE "fileId" IN (...) scan. After: 4 statements; the fileId query is gone and the other four are identical. EXPLAIN of the two access paths: Before WHERE "fileId" IN (...) Seq Scan on "BackgroundWorkerTask" Filter: ("fileId" = ANY (...)) -- reads the whole table, scales with table size After WHERE "workerId" IN (...) Index Scan using "BackgroundWorkerTask_workerId_slug_key" Index Cond: ("workerId" = ...) -- bounded by matching rows, scale-independent No new index is required: the workerId access path is already covered by the existing BackgroundWorkerTask_workerId_slug_key unique index. Testing pnpm run typecheck --filter webapp passes. Query capture + EXPLAIN performed against a local database seeded with real worker/file/task data.

Open Graph Description: What The GET /api/v1/projects/:projectRef/background-workers/:envSlug/:version endpoint loaded each file's tasks through the nested files.tasks relation. Prisma resolves that as a separate quer...

X Description: What The GET /api/v1/projects/:projectRef/background-workers/:envSlug/:version endpoint loaded each file's tasks through the nested files.tasks relation. Prisma resolves that as a separate ...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4245

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f9a7e71f-d6ba-c827-4684-d2dd28eae285
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8236:2B9148:62F6DF:939DF1:6AFAF2D3
html-safe-noncef3acc9819b7d3ac5dbbb5ee9f02e90bf18f84fb2bf7286594dec1676dd76cfa8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjM2OjJCOTE0ODo2MkY2REY6OTM5REYxOjZBRkFGMkQzIiwidmlzaXRvcl9pZCI6IjYxOTY4MjUyMzY0NzAxNjYyMjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0d1ef8f075c066d76c95659965d688a06cdd54394e16943789e8f911d24cc1cf
hovercard-subject-tagpull_request:4045435826
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4245/files
twitter:imagehttps://avatars.githubusercontent.com/u/45313566?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/45313566?s=400&v=4
og:image:altWhat The GET /api/v1/projects/:projectRef/background-workers/:envSlug/:version endpoint loaded each file's tasks through the nested files.tasks relation. Prisma resolves that as a separate quer...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea85e96a83bed7871993e6b1ffda24105928eee17
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4245/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4245%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4245%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4245/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4245/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4245/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
d-cshttps://github.com/d-cs
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
perf-background-worker-version-endpointhttps://github.com/triggerdotdev/trigger.dev/tree/perf-background-worker-version-endpoint
Conversation 6 https://github.com/triggerdotdev/trigger.dev/pull/4245
Commits 2 https://github.com/triggerdotdev/trigger.dev/pull/4245/commits
Checks 45 https://github.com/triggerdotdev/trigger.dev/pull/4245/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/4245/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4245/files
perf(webapp): avoid unindexed fileId scan in get-background-worker-by-version https://github.com/triggerdotdev/trigger.dev/pull/4245/files#top
Show all changes 2 commits https://github.com/triggerdotdev/trigger.dev/pull/4245/files
39b5242 perf(webapp): avoid unindexed fileId scan in get-background-worker-by… d-cs Jul 13, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4245/commits/39b5242fc28a67fa073e186333c4c4495482e39e
3a7905d Merge branch 'main' into perf-background-worker-version-endpoint d-cs Jul 13, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4245/commits/3a7905d7c57af63fa2356a26a1f5b78207367854
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/4245/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4245/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4245/files
background-worker-version-endpoint-tasks.md https://github.com/triggerdotdev/trigger.dev/pull/4245/files#diff-ac63893c9dab59f5d5a5ed50cf7bb12f78ad8d54c81c87a5c445cfc39479067b
api.v1.projects.$projectRef.background-workers.$envSlug.$version.ts https://github.com/triggerdotdev/trigger.dev/pull/4245/files#diff-9894c4c22540b17ed51bf6f6dc09619e7f6c798c4c3f3f73e60d0c22458f1a06
.server-changes/background-worker-version-endpoint-tasks.mdhttps://github.com/triggerdotdev/trigger.dev/pull/4245/files#diff-ac63893c9dab59f5d5a5ed50cf7bb12f78ad8d54c81c87a5c445cfc39479067b
View file https://github.com/triggerdotdev/trigger.dev/blob/3a7905d7c57af63fa2356a26a1f5b78207367854/.server-changes/background-worker-version-endpoint-tasks.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4245/{{ revealButtonHref }}
apps/webapp/app/routes/api.v1.projects.$projectRef.background-workers.$envSlug.$version.tshttps://github.com/triggerdotdev/trigger.dev/pull/4245/files#diff-9894c4c22540b17ed51bf6f6dc09619e7f6c798c4c3f3f73e60d0c22458f1a06
View file https://github.com/triggerdotdev/trigger.dev/blob/3a7905d7c57af63fa2356a26a1f5b78207367854/apps/webapp/app/routes/api.v1.projects.%24projectRef.background-workers.%24envSlug.%24version.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4245/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4245/files#diff-9894c4c22540b17ed51bf6f6dc09619e7f6c798c4c3f3f73e60d0c22458f1a06
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4245/files
https://github.com/triggerdotdev/trigger.dev/pull/4245/files#diff-9894c4c22540b17ed51bf6f6dc09619e7f6c798c4c3f3f73e60d0c22458f1a06
https://github.com/triggerdotdev/trigger.dev/pull/4245/files#diff-9894c4c22540b17ed51bf6f6dc09619e7f6c798c4c3f3f73e60d0c22458f1a06
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4245/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.