René's URL Explorer Experiment


Title: fix(tsql): make JSON functions work on the output and error columns by ericallam · Pull Request #4221 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(tsql): make JSON functions work on the output and error columns by ericallam · Pull Request #4221 · triggerdotdev/trigger.dev

X Title: fix(tsql): make JSON functions work on the output and error columns by ericallam · Pull Request #4221 · triggerdotdev/trigger.dev

Description: Summary A Query page (TRQL) query that pulls fields out of a run's output with JSON functions (JSONExtractString, JSONExtractInt, JSONHas, and the rest of the family) failed with "The first argument of function ... should be a string containing JSON, illegal type: JSON". Those queries now work. Root cause and fix output is a native ClickHouse JSON column, but JSONExtract*, JSONHas, JSONLength, and JSONType all expect a String containing JSON text. The compiler already swaps in the column's String companion (output_text) when a JSON column is selected or compared, but not inside function-call arguments, so it emitted JSONExtractInt(output, 'x') against the native column. The fix prints the companion column for the first argument of these functions when it resolves to a bare JSON field, keeping the table alias when qualified (so it works in JOINs): JSONExtractInt(output, 'x') -> JSONExtractInt(output_text, 'x') JSONExtractArrayRaw(assumeNotNull(output), 'y') -> JSONExtractArrayRaw(assumeNotNull(output_text), 'y') It also reaches through value-preserving passthrough wrappers like assumeNotNull(...), while leaving value-changing wrappers like toJSONString(output) on the native column (that argument is already a String). The swap is also semantically correct, not just a type fix: output_text is the unwrapped data JSON that the TRQL output model already represents, so field paths line up. Covered by printer unit tests and a ClickHouse integration test that runs the whole family (plus the wrapped and toJSONString cases) against a real native-JSON column. Both new cases fail with the exact "illegal type: JSON" error without the fix.

Open Graph Description: Summary A Query page (TRQL) query that pulls fields out of a run's output with JSON functions (JSONExtractString, JSONExtractInt, JSONHas, and the rest of the family) failed with "The firs...

X Description: Summary A Query page (TRQL) query that pulls fields out of a run's output with JSON functions (JSONExtractString, JSONExtractInt, JSONHas, and the rest of the family) failed with "...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4221

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:406a47b6-e22f-4fe5-033e-75f0c0dd3438
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE626:263ABA:7E4637:B441C8:6AFAFC87
html-safe-noncea3fbe4907d3b8068012cb3e08c1ceef6c82731dba42f265c1790e075b235959b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjI2OjI2M0FCQTo3RTQ2Mzc6QjQ0MUM4OjZBRkFGQzg3IiwidmlzaXRvcl9pZCI6IjUxMTIxOTUxMjQ5MTM5NjIxMTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac47cc57d2a0e1606e68d62fca997f94e1dbf4f4e9ee59060200281c48a6265672
hovercard-subject-tagpull_request:4028392138
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4221/files
twitter:imagehttps://avatars.githubusercontent.com/u/534?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/534?s=400&v=4
og:image:altSummary A Query page (TRQL) query that pulls fields out of a run's output with JSON functions (JSONExtractString, JSONExtractInt, JSONHas, and the rest of the family) failed with "The firs...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None54f7a6886649661c85eee945cca0773566bfb4065370e0429b7c8f7204184650
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecf8450eb633ec589502c42ff6f4072e40db65da3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4221/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4221%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4221%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4221/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4221/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4221/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
matt-aitkenhttps://github.com/matt-aitken
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
feature/tri-11931-fixtsql-jsonextract-on-the-native-json-output-column-failshttps://github.com/triggerdotdev/trigger.dev/tree/feature/tri-11931-fixtsql-jsonextract-on-the-native-json-output-column-fails
Conversation 5 https://github.com/triggerdotdev/trigger.dev/pull/4221
Commits 2 https://github.com/triggerdotdev/trigger.dev/pull/4221/commits
Checks 53 https://github.com/triggerdotdev/trigger.dev/pull/4221/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/4221/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4221/files
fix(tsql): make JSON functions work on the output and error columns https://github.com/triggerdotdev/trigger.dev/pull/4221/files#top
Show all changes 2 commits https://github.com/triggerdotdev/trigger.dev/pull/4221/files
4581323 fix(tsql): use text column for JSON functions on native JSON columns ericallam Jul 10, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4221/commits/45813232f1454daba0b6723eac71952d1e1d5a2c
d7c0d01 fix(tsql): reach through passthrough wrappers for JSON functions on n… ericallam Jul 10, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4221/commits/d7c0d014461d4fcb7656cab844681926725cb3ef
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/4221/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4221/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4221/files
trql-json-extract-on-output.md https://github.com/triggerdotdev/trigger.dev/pull/4221/files#diff-8cc9ba0a26f880afd2fa0c7b0da022223ac969a6a9dfa55f947880875b74665b
tsqlFunctions.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4221/files#diff-d52a663929ccad84834576acca980f93d752d840df368dde469d11b374dbde95
printer.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4221/files#diff-41aff49fd1f19e8a67127ad3acc128c5ca7e50b8ee089a5381b25de7e542773c
printer.ts https://github.com/triggerdotdev/trigger.dev/pull/4221/files#diff-4962996d0428b333f8f024b10f23da4a044305e30a69d04040739db96854b0e2
.server-changes/trql-json-extract-on-output.mdhttps://github.com/triggerdotdev/trigger.dev/pull/4221/files#diff-8cc9ba0a26f880afd2fa0c7b0da022223ac969a6a9dfa55f947880875b74665b
View file https://github.com/triggerdotdev/trigger.dev/blob/d7c0d014461d4fcb7656cab844681926725cb3ef/.server-changes/trql-json-extract-on-output.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4221/{{ revealButtonHref }}
internal-packages/clickhouse/src/tsqlFunctions.test.tshttps://github.com/triggerdotdev/trigger.dev/pull/4221/files#diff-d52a663929ccad84834576acca980f93d752d840df368dde469d11b374dbde95
View file https://github.com/triggerdotdev/trigger.dev/blob/d7c0d014461d4fcb7656cab844681926725cb3ef/internal-packages/clickhouse/src/tsqlFunctions.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4221/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4221/files#diff-d52a663929ccad84834576acca980f93d752d840df368dde469d11b374dbde95
https://github.com/triggerdotdev/trigger.dev/pull/4221/files#diff-d52a663929ccad84834576acca980f93d752d840df368dde469d11b374dbde95
https://github.com/triggerdotdev/trigger.dev/pull/4221/files#diff-d52a663929ccad84834576acca980f93d752d840df368dde469d11b374dbde95
https://github.com/triggerdotdev/trigger.dev/pull/4221/files#diff-d52a663929ccad84834576acca980f93d752d840df368dde469d11b374dbde95
https://github.com/triggerdotdev/trigger.dev/pull/4221/files#diff-d52a663929ccad84834576acca980f93d752d840df368dde469d11b374dbde95
https://github.com/triggerdotdev/trigger.dev/pull/4221/files#diff-d52a663929ccad84834576acca980f93d752d840df368dde469d11b374dbde95
internal-packages/tsql/src/query/printer.test.tshttps://github.com/triggerdotdev/trigger.dev/pull/4221/files#diff-41aff49fd1f19e8a67127ad3acc128c5ca7e50b8ee089a5381b25de7e542773c
View file https://github.com/triggerdotdev/trigger.dev/blob/d7c0d014461d4fcb7656cab844681926725cb3ef/internal-packages/tsql/src/query/printer.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4221/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4221/files#diff-41aff49fd1f19e8a67127ad3acc128c5ca7e50b8ee089a5381b25de7e542773c
https://github.com/triggerdotdev/trigger.dev/pull/4221/files#diff-41aff49fd1f19e8a67127ad3acc128c5ca7e50b8ee089a5381b25de7e542773c
internal-packages/tsql/src/query/printer.tshttps://github.com/triggerdotdev/trigger.dev/pull/4221/files#diff-4962996d0428b333f8f024b10f23da4a044305e30a69d04040739db96854b0e2
View file https://github.com/triggerdotdev/trigger.dev/blob/d7c0d014461d4fcb7656cab844681926725cb3ef/internal-packages/tsql/src/query/printer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4221/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4221/files#diff-4962996d0428b333f8f024b10f23da4a044305e30a69d04040739db96854b0e2
https://github.com/triggerdotdev/trigger.dev/pull/4221/files#diff-4962996d0428b333f8f024b10f23da4a044305e30a69d04040739db96854b0e2
https://github.com/triggerdotdev/trigger.dev/pull/4221/files#diff-4962996d0428b333f8f024b10f23da4a044305e30a69d04040739db96854b0e2
https://github.com/triggerdotdev/trigger.dev/pull/4221/files#diff-4962996d0428b333f8f024b10f23da4a044305e30a69d04040739db96854b0e2
https://github.com/triggerdotdev/trigger.dev/pull/4221/files#diff-4962996d0428b333f8f024b10f23da4a044305e30a69d04040739db96854b0e2
https://github.com/triggerdotdev/trigger.dev/pull/4221/files#diff-4962996d0428b333f8f024b10f23da4a044305e30a69d04040739db96854b0e2
https://github.com/triggerdotdev/trigger.dev/pull/4221/files#diff-4962996d0428b333f8f024b10f23da4a044305e30a69d04040739db96854b0e2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.