René's URL Explorer Experiment


Title: fix(webapp): show magic link confirmation instead of reloading login by samejr · Pull Request #4215 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(webapp): show magic link confirmation instead of reloading login by samejr · Pull Request #4215 · triggerdotdev/trigger.dev

X Title: fix(webapp): show magic link confirmation instead of reloading login by samejr · Pull Request #4215 · triggerdotdev/trigger.dev

Description: Summary Submitting your email on the login page could reload back to an empty login form instead of showing the "we've sent you a magic link" confirmation. The magic link email was still sent, so it looked like nothing happened. Root cause The /login/magic route imported a server-only cookie module (magicLinkEmailCookie.server.ts) whose top-level env.NODE_ENV read got bundled into the route's client JS. On the client env is undefined, so the module threw a TypeError at module eval, which aborted Remix's client-side navigation to the confirmation and hard-reloaded back to /login. It only surfaced in production builds (local dev auto-logs-in, and local prod builds happen to tree-shake the module out), which is why it slipped through. Fix The email-link strategy already stores the submitted address in the session (auth:email), so the separate cookie was redundant. Deleted the cookie module and read the address from the session in the loader. With the module gone, nothing server-only can leak into the client bundle regardless of tree-shaking. Verified the confirmation renders with the email address, the SSO domain-policy redirect (with the email prefilled) still works, and a production build no longer bundles the module.

Open Graph Description: Summary Submitting your email on the login page could reload back to an empty login form instead of showing the "we've sent you a magic link" confirmation. The magic link email was st...

X Description: Summary Submitting your email on the login page could reload back to an empty login form instead of showing the "we've sent you a magic link" confirmation. The magic link ...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4215

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:124af5a7-2bdf-cbce-b200-bba8e709f970
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA97E:7D877:93F85:D3BD8:6AFB0B20
html-safe-nonceb4111c5cbeb4f714899be0261fca056b6ea731bf3176aa531aff7eef3ee72c43
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTdFOjdEODc3OjkzRjg1OkQzQkQ4OjZBRkIwQjIwIiwidmlzaXRvcl9pZCI6IjI2ODgyODkxNjQxNTQ4MzM2OTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbe6ff1712cc6a83a95da3f28573258ed69f13dd63ea6826bd28ae79d685a1531
hovercard-subject-tagpull_request:4023917297
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4215/files
twitter:imagehttps://avatars.githubusercontent.com/u/7555566?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7555566?s=400&v=4
og:image:altSummary Submitting your email on the login page could reload back to an empty login form instead of showing the "we've sent you a magic link" confirmation. The magic link email was st...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None76fb13cb43f1834708971f45a9cfcab5df3177a7582086613d7cdc6e98c4bfde
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseafc998826cdd963c8f91a96ae5372809ab5e296b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4215/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4215%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4215%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4215/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4215/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4215/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
samejrhttps://github.com/samejr
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
samejr/login-magic-link-redirecthttps://github.com/triggerdotdev/trigger.dev/tree/samejr/login-magic-link-redirect
Conversation 8 https://github.com/triggerdotdev/trigger.dev/pull/4215
Commits 3 https://github.com/triggerdotdev/trigger.dev/pull/4215/commits
Checks 40 https://github.com/triggerdotdev/trigger.dev/pull/4215/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/4215/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4215/files
fix(webapp): show magic link confirmation instead of reloading login https://github.com/triggerdotdev/trigger.dev/pull/4215/files#top
Show all changes 3 commits https://github.com/triggerdotdev/trigger.dev/pull/4215/files
0d6f166 fix(webapp): show magic link confirmation instead of reloading login samejr Jul 9, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4215/commits/0d6f1668294f39514f212aebf98943ef36ae42c7
59a647e Merge branch 'main' into samejr/login-magic-link-redirect samejr Jul 9, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4215/commits/59a647e153fd530c7947a11f9268d1547bc587da
50983ce fix(webapp): pin magic-link sessionEmailKey explicitly samejr Jul 9, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4215/commits/50983ce41ebcf5112f2975f6038cf604c41d75bd
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/4215/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4215/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4215/files
fix-magic-link-login-confirmation.md https://github.com/triggerdotdev/trigger.dev/pull/4215/files#diff-5316c343c132d20eceb12f3b9da9aacf23237bc372a62dc93bbe4181bd436584
magicLinkEmailCookie.server.ts https://github.com/triggerdotdev/trigger.dev/pull/4215/files#diff-3e231623c5f41aa267974b3369b4a03a599115f7f25593cadd36125b68425637
route.tsx https://github.com/triggerdotdev/trigger.dev/pull/4215/files#diff-592a74cf974d5188b0d087b78a8d64dc766d1ea47a59321125f719ad03eb3be3
emailAuth.server.tsx https://github.com/triggerdotdev/trigger.dev/pull/4215/files#diff-6a16a542c837d73d912207e88738eb567526705c8b7055470d10a0287518d80d
.server-changes/fix-magic-link-login-confirmation.mdhttps://github.com/triggerdotdev/trigger.dev/pull/4215/files#diff-5316c343c132d20eceb12f3b9da9aacf23237bc372a62dc93bbe4181bd436584
View file https://github.com/triggerdotdev/trigger.dev/blob/50983ce41ebcf5112f2975f6038cf604c41d75bd/.server-changes/fix-magic-link-login-confirmation.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4215/{{ revealButtonHref }}
apps/webapp/app/routes/login.magic/magicLinkEmailCookie.server.tshttps://github.com/triggerdotdev/trigger.dev/pull/4215/files#diff-3e231623c5f41aa267974b3369b4a03a599115f7f25593cadd36125b68425637
View file https://github.com/triggerdotdev/trigger.dev/blob/105f48927de21d9a0a09f85599f8df843077924d/apps/webapp/app/routes/login.magic/magicLinkEmailCookie.server.ts
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4215/files
apps/webapp/app/routes/login.magic/route.tsxhttps://github.com/triggerdotdev/trigger.dev/pull/4215/files#diff-592a74cf974d5188b0d087b78a8d64dc766d1ea47a59321125f719ad03eb3be3
View file https://github.com/triggerdotdev/trigger.dev/blob/50983ce41ebcf5112f2975f6038cf604c41d75bd/apps/webapp/app/routes/login.magic/route.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4215/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4215/files#diff-592a74cf974d5188b0d087b78a8d64dc766d1ea47a59321125f719ad03eb3be3
https://github.com/triggerdotdev/trigger.dev/pull/4215/files#diff-592a74cf974d5188b0d087b78a8d64dc766d1ea47a59321125f719ad03eb3be3
https://github.com/triggerdotdev/trigger.dev/pull/4215/files#diff-592a74cf974d5188b0d087b78a8d64dc766d1ea47a59321125f719ad03eb3be3
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4215/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4215/files
https://github.com/triggerdotdev/trigger.dev/pull/4215/files#diff-592a74cf974d5188b0d087b78a8d64dc766d1ea47a59321125f719ad03eb3be3
https://github.com/triggerdotdev/trigger.dev/pull/4215/files#diff-592a74cf974d5188b0d087b78a8d64dc766d1ea47a59321125f719ad03eb3be3
https://github.com/triggerdotdev/trigger.dev/pull/4215/files#diff-592a74cf974d5188b0d087b78a8d64dc766d1ea47a59321125f719ad03eb3be3
https://github.com/triggerdotdev/trigger.dev/pull/4215/files#diff-592a74cf974d5188b0d087b78a8d64dc766d1ea47a59321125f719ad03eb3be3
https://github.com/triggerdotdev/trigger.dev/pull/4215/files#diff-592a74cf974d5188b0d087b78a8d64dc766d1ea47a59321125f719ad03eb3be3
apps/webapp/app/services/emailAuth.server.tsxhttps://github.com/triggerdotdev/trigger.dev/pull/4215/files#diff-6a16a542c837d73d912207e88738eb567526705c8b7055470d10a0287518d80d
View file https://github.com/triggerdotdev/trigger.dev/blob/50983ce41ebcf5112f2975f6038cf604c41d75bd/apps/webapp/app/services/emailAuth.server.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4215/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4215/files#diff-6a16a542c837d73d912207e88738eb567526705c8b7055470d10a0287518d80d
https://github.com/triggerdotdev/trigger.dev/pull/4215/files#diff-6a16a542c837d73d912207e88738eb567526705c8b7055470d10a0287518d80d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.