René's URL Explorer Experiment


Title: fix(cli-v3): forward TRIGGER_WORKER_INSTANCE_NAME into the managed run process env by brentshulman-silkline · Pull Request #4213 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(cli-v3): forward TRIGGER_WORKER_INSTANCE_NAME into the managed run process env by brentshulman-silkline · Pull Request #4213 · triggerdotdev/trigger.dev

X Title: fix(cli-v3): forward TRIGGER_WORKER_INSTANCE_NAME into the managed run process env by brentshulman-silkline · Pull Request #4213 · triggerdotdev/trigger.dev

Description: Problem On self-hosted Kubernetes, task-run spans and logs exported over OTLP to an off-node collector (e.g. a central Datadog Agent) have an empty host. Datadog tags every such span with issue_type:empty_hostname. There is no supported way for a user's trigger.config.ts telemetry resource to recover the node, because the node identity never reaches the run process. Root cause The Kubernetes workload manager already injects the node name into the run-controller container via the downward API (apps/supervisor/src/workloadManager/kubernetes.ts): { name: "TRIGGER_WORKER_INSTANCE_NAME", valueFrom: { fieldRef: { fieldPath: "spec.nodeName" } } } But the actual task-run worker is fork()ed with an explicit, replaced env built from RunnerEnv.gatherProcessEnv() (an allowlist) plus the run's env (packages/cli-v3/src/entryPoints/managed/taskRunProcessProvider.ts → packages/cli-v3/src/executions/taskRunProcess.ts). gatherProcessEnv() returns only NODE_ENV, NODE_EXTRA_CA_CERTS, OTEL_EXPORTER_OTLP_ENDPOINT, TRIGGER_OTEL_EXPORTER_OTLP_ENDPOINT, UV_USE_IO_URING, so TRIGGER_WORKER_INSTANCE_NAME (and container-level vars generally) never reach process.env in the run process. The node identity is present in the pod but dropped before it can be used. Fix Add TRIGGER_WORKER_INSTANCE_NAME to the env returned by RunnerEnv.gatherProcessEnv() (it is already in the Env schema and has a getter). One line + comment; see change.diff. With this, a user can map it in their trigger.config.ts: const nodeName = process.env.TRIGGER_WORKER_INSTANCE_NAME; // spec.nodeName on k8s telemetry: { resource: resourceFromAttributes( nodeName ? { "host.name": nodeName, "k8s.node.name": nodeName } : {} ), // ... } which clears empty_hostname and attributes the run to its actual node. Scope / risk Additive: forwards one already-present, non-secret identity var. No behavior change when unset (the existing undefined filter drops it). Docker workload manager already passes TRIGGER_WORKER_INSTANCE_NAME to the runner (workloadManager/docker.ts), so this aligns k8s runs with that. Changeset trigger.dev: patch — see changeset.md.

Open Graph Description: Problem On self-hosted Kubernetes, task-run spans and logs exported over OTLP to an off-node collector (e.g. a central Datadog Agent) have an empty host. Datadog tags every such span with issue_typ...

X Description: Problem On self-hosted Kubernetes, task-run spans and logs exported over OTLP to an off-node collector (e.g. a central Datadog Agent) have an empty host. Datadog tags every such span with issue_typ...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4213

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bd9a293e-7f28-6749-ae06-c1333f604b39
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDFF2:1FB20:33E99ED:4A4BAF3:6AFB0743
html-safe-nonce114f925ade97b39a976f5835140cf6c0a9e62b655f91cd4910d6febfe2faa509
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERkYyOjFGQjIwOjMzRTk5RUQ6NEE0QkFGMzo2QUZCMDc0MyIsInZpc2l0b3JfaWQiOiI3MjE0MzU1MDkxMTQwODM5MjM1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac51f861a6a740044a8f454567aa04341cd7ad14ea0c33d90549c7523935c97337
hovercard-subject-tagpull_request:4023858698
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4213/files
twitter:imagehttps://avatars.githubusercontent.com/u/134343004?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/134343004?s=400&v=4
og:image:altProblem On self-hosted Kubernetes, task-run spans and logs exported over OTLP to an off-node collector (e.g. a central Datadog Agent) have an empty host. Datadog tags every such span with issue_typ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None76fb13cb43f1834708971f45a9cfcab5df3177a7582086613d7cdc6e98c4bfde
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseafc998826cdd963c8f91a96ae5372809ab5e296b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4213/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4213%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4213%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4213/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4213/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4213/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
brentshulman-silklinehttps://github.com/brentshulman-silkline
triggerdotdev:mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
brentshulman-silkline:fix/forward-worker-instance-name-to-run-processhttps://github.com/brentshulman-silkline/trigger.dev/tree/fix/forward-worker-instance-name-to-run-process
Conversation 5 https://github.com/triggerdotdev/trigger.dev/pull/4213
Commits 2 https://github.com/triggerdotdev/trigger.dev/pull/4213/commits
Checks 2 https://github.com/triggerdotdev/trigger.dev/pull/4213/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/4213/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4213/files
fix(cli-v3): forward TRIGGER_WORKER_INSTANCE_NAME into the managed run process env https://github.com/triggerdotdev/trigger.dev/pull/4213/files#top
Show all changes 2 commits https://github.com/triggerdotdev/trigger.dev/pull/4213/files
a4de2d0 fix(cli-v3): forward TRIGGER_WORKER_INSTANCE_NAME into managed run pr… brentshulman-silkline Jul 9, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4213/commits/a4de2d09e9d4b55674b8ea759ef92b6d75ef40fd
dcd100b chore: add changeset for TRIGGER_WORKER_INSTANCE_NAME env forward brentshulman-silkline Jul 9, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4213/commits/dcd100bf0927e1984f11fb6dc1bf3d59f3e67d18
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/4213/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4213/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4213/files
forward-worker-instance-name.md https://github.com/triggerdotdev/trigger.dev/pull/4213/files#diff-618bb34440bcb0149e1fcc88c43cb1f5884a90d186497a5983fb223e1c794cc7
env.ts https://github.com/triggerdotdev/trigger.dev/pull/4213/files#diff-37cff5daede6e4bfd5bc981e87c84ef3551ca309c386fc7dfc54a2d85fd7e9a9
.changeset/forward-worker-instance-name.mdhttps://github.com/triggerdotdev/trigger.dev/pull/4213/files#diff-618bb34440bcb0149e1fcc88c43cb1f5884a90d186497a5983fb223e1c794cc7
View file https://github.com/brentshulman-silkline/trigger.dev/blob/dcd100bf0927e1984f11fb6dc1bf3d59f3e67d18/.changeset/forward-worker-instance-name.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4213/{{ revealButtonHref }}
devin-ai-integrationhttps://github.com/apps/devin-ai-integration
Jul 9, 2026https://github.com/triggerdotdev/trigger.dev/pull/4213/files#r3553591731
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://app.devin.ai/review/triggerdotdev/trigger.dev/pull/4213
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4213/files
packages/cli-v3/src/entryPoints/managed/env.tshttps://github.com/triggerdotdev/trigger.dev/pull/4213/files#diff-37cff5daede6e4bfd5bc981e87c84ef3551ca309c386fc7dfc54a2d85fd7e9a9
View file https://github.com/brentshulman-silkline/trigger.dev/blob/dcd100bf0927e1984f11fb6dc1bf3d59f3e67d18/packages/cli-v3/src/entryPoints/managed/env.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4213/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4213/files#diff-37cff5daede6e4bfd5bc981e87c84ef3551ca309c386fc7dfc54a2d85fd7e9a9
https://github.com/triggerdotdev/trigger.dev/pull/4213/files#diff-37cff5daede6e4bfd5bc981e87c84ef3551ca309c386fc7dfc54a2d85fd7e9a9
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.