René's URL Explorer Experiment


Title: fix(run-engine,webapp): abort unsealed batches so blocked parents resume by matt-aitken · Pull Request #4016 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(run-engine,webapp): abort unsealed batches so blocked parents resume by matt-aitken · Pull Request #4016 · triggerdotdev/trigger.dev

X Title: fix(run-engine,webapp): abort unsealed batches so blocked parents resume by matt-aitken · Pull Request #4016 · triggerdotdev/trigger.dev

Description: Summary batchTriggerAndWait could leave the parent run suspended forever. When the item stream that populates a batch failed to complete after many retries (for example under rate limiting, a request timeout, or a crashed request), the batch was left with no runs and the parent kept waiting on a waitpoint that nothing would ever complete. Fix The parent is blocked on the batch's waitpoint as soon as the batch is created, but the batch is only sealed once all its items finish streaming. There was no recovery path if streaming never reached the seal. A seal-timeout reaper is now scheduled when the batch is created. If the batch is still unsealed after BATCH_SEAL_TIMEOUT_MS (default 30 minutes), it is marked aborted and the parent's waitpoint is completed with an error, so batchTriggerAndWait rejects in the parent instead of hanging. The reaper is idempotent and race-safe: if the stream seals the batch first, the reaper no-ops. The default timeout is sized above the SDK's worst-case stream-retry budget (max attempts x server request timeout).

Open Graph Description: Summary batchTriggerAndWait could leave the parent run suspended forever. When the item stream that populates a batch failed to complete after many retries (for example under rate limiting, a reque...

X Description: Summary batchTriggerAndWait could leave the parent run suspended forever. When the item stream that populates a batch failed to complete after many retries (for example under rate limiting, a reque...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/4016

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:24f75305-3d25-fbab-d362-cb0d067eb821
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9EE4:155E2E:31D9644:471F624:6AFAF71D
html-safe-nonce65c048f78ea2264b6a340b1a84d3b5c4697e540b19549087de9028d6810cee26
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUU0OjE1NUUyRTozMUQ5NjQ0OjQ3MUY2MjQ6NkFGQUY3MUQiLCJ2aXNpdG9yX2lkIjoiOTExMTMzMDMxNzcyMDU0OTE0OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdc44e3559eeb2376a7df7571ee7e98859edbd595ca3708cb17719d0ff4a5e582
hovercard-subject-tagpull_request:3913621741
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/4016/files
twitter:imagehttps://avatars.githubusercontent.com/u/10635986?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10635986?s=400&v=4
og:image:altSummary batchTriggerAndWait could leave the parent run suspended forever. When the item stream that populates a batch failed to complete after many retries (for example under rate limiting, a reque...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea85e96a83bed7871993e6b1ffda24105928eee17
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/4016/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4016%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F4016%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4016/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4016/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/4016/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
matt-aitkenhttps://github.com/matt-aitken
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
fix/batch-seal-timeouthttps://github.com/triggerdotdev/trigger.dev/tree/fix/batch-seal-timeout
Conversation 16 https://github.com/triggerdotdev/trigger.dev/pull/4016
Commits 2 https://github.com/triggerdotdev/trigger.dev/pull/4016/commits
Checks 45 https://github.com/triggerdotdev/trigger.dev/pull/4016/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/4016/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4016/files
fix(run-engine,webapp): abort unsealed batches so blocked parents resume https://github.com/triggerdotdev/trigger.dev/pull/4016/files#top
Show all changes 2 commits https://github.com/triggerdotdev/trigger.dev/pull/4016/files
a03dab7 fix(run-engine,webapp): abort unsealed batches so blocked parents resume matt-aitken Jun 22, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4016/commits/a03dab7a9251921be5a63a0b4c3aeb5da99b0dc2
79bd92e fix(run-engine,webapp): harden the batch seal-timeout reaper matt-aitken Jun 22, 2026 https://github.com/triggerdotdev/trigger.dev/pull/4016/commits/79bd92e17eecf7568b966a843745557238cd4737
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/4016/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4016/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4016/files
recover-stranded-batch-trigger-and-wait.md https://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-d38c389f241e48a5459acc349fc79966e35fad4ded1f5c2498118a1eb17f1b08
env.server.ts https://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-f8823615ef72da3494e74de9e62b2fa31315ed9360f17bc06ab943f4dc25f4fd
createBatch.server.ts https://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-2939e26b9f43b75642cf37d00dba17481632304d09f92bc7066eec7d1d9c8d13
index.ts https://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-d29236a78d70dd8a019a2ec308d8eab0eda9f5fbf116d19d5c99b8f573a1b5df
batchSystem.ts https://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-8598cd9b94d59afc0a40bf822766948e1e5d885ff0ac99ae768980ca9ee4c141
batchTwoPhase.test.ts https://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-299fd586051e9d2007edec740e67805221a1d4699749320b3544cfdc10ba938b
workerCatalog.ts https://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-55ab20d8af33b3a592f976001330dcd40c0bc15eae84b6e6a75d2d1c45f7c9e4
.server-changes/recover-stranded-batch-trigger-and-wait.mdhttps://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-d38c389f241e48a5459acc349fc79966e35fad4ded1f5c2498118a1eb17f1b08
View file https://github.com/triggerdotdev/trigger.dev/blob/79bd92e17eecf7568b966a843745557238cd4737/.server-changes/recover-stranded-batch-trigger-and-wait.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4016/{{ revealButtonHref }}
apps/webapp/app/env.server.tshttps://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-f8823615ef72da3494e74de9e62b2fa31315ed9360f17bc06ab943f4dc25f4fd
View file https://github.com/triggerdotdev/trigger.dev/blob/79bd92e17eecf7568b966a843745557238cd4737/apps/webapp/app/env.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4016/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-f8823615ef72da3494e74de9e62b2fa31315ed9360f17bc06ab943f4dc25f4fd
https://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-f8823615ef72da3494e74de9e62b2fa31315ed9360f17bc06ab943f4dc25f4fd
apps/webapp/app/runEngine/services/createBatch.server.tshttps://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-2939e26b9f43b75642cf37d00dba17481632304d09f92bc7066eec7d1d9c8d13
View file https://github.com/triggerdotdev/trigger.dev/blob/79bd92e17eecf7568b966a843745557238cd4737/apps/webapp/app/runEngine/services/createBatch.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4016/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-2939e26b9f43b75642cf37d00dba17481632304d09f92bc7066eec7d1d9c8d13
https://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-2939e26b9f43b75642cf37d00dba17481632304d09f92bc7066eec7d1d9c8d13
https://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-2939e26b9f43b75642cf37d00dba17481632304d09f92bc7066eec7d1d9c8d13
https://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-2939e26b9f43b75642cf37d00dba17481632304d09f92bc7066eec7d1d9c8d13
internal-packages/run-engine/src/engine/index.tshttps://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-d29236a78d70dd8a019a2ec308d8eab0eda9f5fbf116d19d5c99b8f573a1b5df
View file https://github.com/triggerdotdev/trigger.dev/blob/79bd92e17eecf7568b966a843745557238cd4737/internal-packages/run-engine/src/engine/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4016/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-d29236a78d70dd8a019a2ec308d8eab0eda9f5fbf116d19d5c99b8f573a1b5df
https://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-d29236a78d70dd8a019a2ec308d8eab0eda9f5fbf116d19d5c99b8f573a1b5df
https://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-d29236a78d70dd8a019a2ec308d8eab0eda9f5fbf116d19d5c99b8f573a1b5df
https://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-d29236a78d70dd8a019a2ec308d8eab0eda9f5fbf116d19d5c99b8f573a1b5df
internal-packages/run-engine/src/engine/systems/batchSystem.tshttps://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-8598cd9b94d59afc0a40bf822766948e1e5d885ff0ac99ae768980ca9ee4c141
View file https://github.com/triggerdotdev/trigger.dev/blob/79bd92e17eecf7568b966a843745557238cd4737/internal-packages/run-engine/src/engine/systems/batchSystem.ts
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4016/files
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/4016/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-8598cd9b94d59afc0a40bf822766948e1e5d885ff0ac99ae768980ca9ee4c141
https://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-8598cd9b94d59afc0a40bf822766948e1e5d885ff0ac99ae768980ca9ee4c141
https://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-8598cd9b94d59afc0a40bf822766948e1e5d885ff0ac99ae768980ca9ee4c141
https://github.com/triggerdotdev/trigger.dev/pull/4016/files#diff-8598cd9b94d59afc0a40bf822766948e1e5d885ff0ac99ae768980ca9ee4c141
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/4016/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.