René's URL Explorer Experiment


Title: fix(core): drop unique-symbol brand on LocalsKey to fix dual-package builds by ericallam · Pull Request #3626 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(core): drop unique-symbol brand on LocalsKey to fix dual-package builds by ericallam · Pull Request #3626 · triggerdotdev/trigger.dev

X Title: fix(core): drop unique-symbol brand on LocalsKey to fix dual-package builds by ericallam · Pull Request #3626 · triggerdotdev/trigger.dev

Description: Summary LocalsKey (the type returned by locals.create()) was branded with a module-level declare const __local: unique symbol. Each such declaration is its own nominal type, and tshy emits separate .d.ts files for the ESM and CJS outputs — each gets its own __local symbol. Under certain pnpm hoisting layouts a single TypeScript compilation can resolve LocalsKey from both the ESM source path and the CJS dist path within the same call site, producing two structurally-incompatible variants of the same type. TS surfaces this as the misleading error: Argument of type 'LocalsKey' is not assignable to parameter of type 'LocalsKey'. Property '[__local]' is missing in type 'LocalsKey' but required in type 'BrandLocal'. The error has been hitting CI on PRs opened since the chat.agent stack landed (e.g. #3625 typecheck job), but doesn't reproduce on developer machines where the pnpm node_modules layout was built up incrementally. Fix Replace the unique symbol brand with an optional phantom field that carries T at the type level: // before declare const __local: unique symbol; type BrandLocal = { [__local]: T }; export type LocalsKey = BrandLocal & { readonly id: string; readonly __type: unique symbol; }; // after export type LocalsKey = { readonly id: string; readonly __type: symbol; /** Phantom carrier for the value type — never read at runtime. */ readonly __valueType?: T; }; The ESM and CJS .d.ts outputs now produce structurally identical types, so cross-output resolution no longer produces a mismatch. T is still carried at the type level via the optional phantom field. The runtime shape is unchanged — manager.ts was already casting via as unknown, which is no longer needed. Test plan pnpm run typecheck --filter @trigger.dev/core --filter @trigger.dev/sdk pnpm run build --filter @trigger.dev/core --filter @trigger.dev/sdk (clean rebuild) — confirms the ESM and CJS dist .d.ts outputs no longer carry distinct unique symbol declarations pnpm --filter @trigger.dev/core test test/mockTaskContext.test.ts --run pnpm --filter @trigger.dev/sdk test test/mockChatAgent.test.ts --run

Open Graph Description: Summary LocalsKey<T> (the type returned by locals.create()) was branded with a module-level declare const __local: unique symbol. Each such declaration is its own nominal type, and tshy emits...

X Description: Summary LocalsKey&lt;T&gt; (the type returned by locals.create()) was branded with a module-level declare const __local: unique symbol. Each such declaration is its own nominal type, and ts...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/3626

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a1b8f7c5-f3c0-7043-59fa-99deb6904b8d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE9F4:1DBE03:12840A2:1A03CFB:6AFAE4CA
html-safe-nonce2c79095e0dc5fe489c4984fb8ca5e519b38a65d97b9973bdd744b5107fe28473
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOUY0OjFEQkUwMzoxMjg0MEEyOjFBMDNDRkI6NkFGQUU0Q0EiLCJ2aXNpdG9yX2lkIjoiODAyNjMzNzg5MzM0NDQ1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac084ab68e7fe3097574bf9d8f44c50c9ab553d327e05f800eb7202132f958df59
hovercard-subject-tagpull_request:3687831288
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/3626/files
twitter:imagehttps://avatars.githubusercontent.com/u/534?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/534?s=400&v=4
og:image:altSummary LocalsKey<T> (the type returned by locals.create()) was branded with a module-level declare const __local: unique symbol. Each such declaration is its own nominal type, and tshy emits...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release12fff95459b24b0f882a66698ee6a36a5934d247
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/3626/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F3626%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F3626%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/3626/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/3626/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/3626/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests66 (66)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
ericallamhttps://github.com/ericallam
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
fix/locals-key-dual-packagehttps://github.com/triggerdotdev/trigger.dev/tree/fix/locals-key-dual-package
Conversation 2 https://github.com/triggerdotdev/trigger.dev/pull/3626
Commits 1 https://github.com/triggerdotdev/trigger.dev/pull/3626/commits
Checks 52 https://github.com/triggerdotdev/trigger.dev/pull/3626/checks
Files changed 3 https://github.com/triggerdotdev/trigger.dev/pull/3626/files
fix(core): drop unique-symbol brand on LocalsKey to fix dual-package builds https://github.com/triggerdotdev/trigger.dev/pull/3626/files#top
Show all changes 1 commit https://github.com/triggerdotdev/trigger.dev/pull/3626/files
df1cad3 fix(core): drop unique-symbol brand on LocalsKey to fix dual-package … ericallam May 15, 2026 https://github.com/triggerdotdev/trigger.dev/pull/3626/commits/df1cad3d4ffd9b2fd4e89383c07e90d149da38b2
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/3626/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/3626/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/3626/files
locals-key-dual-package-fix.md https://github.com/triggerdotdev/trigger.dev/pull/3626/files#diff-83b8ab4ced4897b582a6952b4831c39bae2069c9399c5b9e10729f0cc2cf1334
manager.ts https://github.com/triggerdotdev/trigger.dev/pull/3626/files#diff-7a2f1a187097b3c023c9e29b5aa98563bf9faa34cd1a13a733e5bb076544e9ca
types.ts https://github.com/triggerdotdev/trigger.dev/pull/3626/files#diff-844f06f98e8235f1c064f10ab5923eff508ae752b3bd3dbc84c223fd3682fea4
.changeset/locals-key-dual-package-fix.mdhttps://github.com/triggerdotdev/trigger.dev/pull/3626/files#diff-83b8ab4ced4897b582a6952b4831c39bae2069c9399c5b9e10729f0cc2cf1334
View file https://github.com/triggerdotdev/trigger.dev/blob/df1cad3d4ffd9b2fd4e89383c07e90d149da38b2/.changeset/locals-key-dual-package-fix.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/3626/{{ revealButtonHref }}
packages/core/src/v3/locals/manager.tshttps://github.com/triggerdotdev/trigger.dev/pull/3626/files#diff-7a2f1a187097b3c023c9e29b5aa98563bf9faa34cd1a13a733e5bb076544e9ca
View file https://github.com/triggerdotdev/trigger.dev/blob/df1cad3d4ffd9b2fd4e89383c07e90d149da38b2/packages/core/src/v3/locals/manager.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/3626/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/3626/files#diff-7a2f1a187097b3c023c9e29b5aa98563bf9faa34cd1a13a733e5bb076544e9ca
https://github.com/triggerdotdev/trigger.dev/pull/3626/files#diff-7a2f1a187097b3c023c9e29b5aa98563bf9faa34cd1a13a733e5bb076544e9ca
https://github.com/triggerdotdev/trigger.dev/pull/3626/files#diff-7a2f1a187097b3c023c9e29b5aa98563bf9faa34cd1a13a733e5bb076544e9ca
packages/core/src/v3/locals/types.tshttps://github.com/triggerdotdev/trigger.dev/pull/3626/files#diff-844f06f98e8235f1c064f10ab5923eff508ae752b3bd3dbc84c223fd3682fea4
View file https://github.com/triggerdotdev/trigger.dev/blob/df1cad3d4ffd9b2fd4e89383c07e90d149da38b2/packages/core/src/v3/locals/types.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/3626/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/3626/files#diff-844f06f98e8235f1c064f10ab5923eff508ae752b3bd3dbc84c223fd3682fea4
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/3626/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.