René's URL Explorer Experiment


Title: fix(webapp): honor RevokedApiKey grace window for public access tokens by ericallam · Pull Request #3464 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(webapp): honor RevokedApiKey grace window for public access tokens by ericallam · Pull Request #3464 · triggerdotdev/trigger.dev

X Title: fix(webapp): honor RevokedApiKey grace window for public access tokens by ericallam · Pull Request #3464 · triggerdotdev/trigger.dev

Description: Summary Follow-up to #3420. PATs (public access tokens) minted before an API key rotation 401'd immediately on the realtime stream endpoints, even though the rotation flow advertises a 24h overlap. This fixes the gap. Root cause PATs are JWTs signed with the env's apiKey at mint time. When that secret is rotated, validatePublicJwtKey (apps/webapp/app/services/realtime/jwtAuth.server.ts) only verifies the signature against environment.parentEnvironment?.apiKey ?? environment.apiKey — i.e. the env's current canonical key. Any PAT in the wild signed with the previous key fails signature verification → 401, even within the grace window. #3420 wired up the grace-window fallback in two places — findEnvironmentByApiKey (raw secret-key auth) and api.v1.auth.jwt.ts (signs new JWTs with the canonical key when minting from an old one) — but the verify path for already-issued PATs was never updated. In a typical app, POST /api/v1/tasks/.../trigger (Bearer secret) keeps working through rotation because that path has the fallback, but GET /realtime/v1/streams/run_*/... and POST /realtime/v1/streams/run_*/input/... 401 for runs that were already in flight when the rotation happened. Fix After the primary validateJWT against the env's current apiKey, fall back to non-expired RevokedApiKey rows for the signing env (parent env when the request is against a child) — but only on the failure path, so the hot success path is unchanged. Uses $replica to match the rest of the auth path. Symmetrical to the findEnvironmentByApiKey two-step from #3420. Changes apps/webapp/app/services/realtime/jwtAuth.server.ts — validateAgainstRevokedApiKeys helper invoked only on !result.ok apps/webapp/app/models/runtimeEnvironment.server.ts — findEnvironmentById also selects parentEnvironment.id so we can scope the revoked-keys lookup to the correct env Test plan E2E verified locally via curl against GET /realtime/v1/runs/{runId} (PAT-authenticated): Pre-rotation, PAT signed with K1 → 200 with run body Simulate rotation (insert RevokedApiKey row + flip env apiKey to K2 in a single transaction, mirroring regenerateApiKey) Same PAT (K1) within grace window → 200 with run body — fallback hits Fresh PAT signed with K2 → 200 — current key still works Set RevokedApiKey.expiresAt to past → 401 — fallback finds no live row Bogus signature (no rotation) → 401 Cleanup verified: env apiKey restored, RevokedApiKey row deleted pnpm run typecheck --filter webapp passes

Open Graph Description: Summary Follow-up to #3420. PATs (public access tokens) minted before an API key rotation 401'd immediately on the realtime stream endpoints, even though the rotation flow advertises a 24h over...

X Description: Summary Follow-up to #3420. PATs (public access tokens) minted before an API key rotation 401'd immediately on the realtime stream endpoints, even though the rotation flow advertises a 24h ...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/3464

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0c68b7dd-6145-8efe-d68f-9b8bd11889ab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD4CC:19D56D:63C7E4E:852E3DE:6AFAF1E4
html-safe-nonce7d8dfaf9265615da5c6efc07c72edcade3a1f7bacd1f68e69e9853addcdc7991
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENENDOjE5RDU2RDo2M0M3RTRFOjg1MkUzREU6NkFGQUYxRTQiLCJ2aXNpdG9yX2lkIjoiOTgyNDg3NjkwNzQzODM3MTU2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9ec1bef5768379b929941b3ac4897d7c33ab830cfaa805463853d0c13b0ef0cc
hovercard-subject-tagpull_request:3597448469
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/3464/files
twitter:imagehttps://avatars.githubusercontent.com/u/534?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/534?s=400&v=4
og:image:altSummary Follow-up to #3420. PATs (public access tokens) minted before an API key rotation 401'd immediately on the realtime stream endpoints, even though the rotation flow advertises a 24h over...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea85e96a83bed7871993e6b1ffda24105928eee17
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/3464/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F3464%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F3464%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/3464/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/3464/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/3464/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
ericallamhttps://github.com/ericallam
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
fix/api-key-rotation-pat-grace-periodhttps://github.com/triggerdotdev/trigger.dev/tree/fix/api-key-rotation-pat-grace-period
Conversation 4 https://github.com/triggerdotdev/trigger.dev/pull/3464
Commits 1 https://github.com/triggerdotdev/trigger.dev/pull/3464/commits
Checks 50 https://github.com/triggerdotdev/trigger.dev/pull/3464/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/3464/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/3464/files
fix(webapp): honor RevokedApiKey grace window for public access tokens https://github.com/triggerdotdev/trigger.dev/pull/3464/files#top
Show all changes 1 commit https://github.com/triggerdotdev/trigger.dev/pull/3464/files
7a6c83e fix(webapp): honor RevokedApiKey grace window for public access tokens ericallam Apr 28, 2026 https://github.com/triggerdotdev/trigger.dev/pull/3464/commits/7a6c83e102ca1bd4c0eee62873905e5c61a55902
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/3464/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/3464/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/3464/files
api-key-rotation-pat-grace-period.md https://github.com/triggerdotdev/trigger.dev/pull/3464/files#diff-586ad8f95b9cdde00692b985dcb8ccdc12cd8b833bc906a30751cf7cf81a9d67
runtimeEnvironment.server.ts https://github.com/triggerdotdev/trigger.dev/pull/3464/files#diff-15cc1b2976807e5d2a9e65b1565c47ac285fa77a082e0169438173af9b125e21
jwtAuth.server.ts https://github.com/triggerdotdev/trigger.dev/pull/3464/files#diff-256b6719a2b7a60da127b1a78ac780cea50e785c21fc1326095c31467a067b6b
.server-changes/api-key-rotation-pat-grace-period.mdhttps://github.com/triggerdotdev/trigger.dev/pull/3464/files#diff-586ad8f95b9cdde00692b985dcb8ccdc12cd8b833bc906a30751cf7cf81a9d67
View file https://github.com/triggerdotdev/trigger.dev/blob/7a6c83e102ca1bd4c0eee62873905e5c61a55902/.server-changes/api-key-rotation-pat-grace-period.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/3464/{{ revealButtonHref }}
apps/webapp/app/models/runtimeEnvironment.server.tshttps://github.com/triggerdotdev/trigger.dev/pull/3464/files#diff-15cc1b2976807e5d2a9e65b1565c47ac285fa77a082e0169438173af9b125e21
View file https://github.com/triggerdotdev/trigger.dev/blob/7a6c83e102ca1bd4c0eee62873905e5c61a55902/apps/webapp/app/models/runtimeEnvironment.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/3464/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/3464/files#diff-15cc1b2976807e5d2a9e65b1565c47ac285fa77a082e0169438173af9b125e21
https://github.com/triggerdotdev/trigger.dev/pull/3464/files#diff-15cc1b2976807e5d2a9e65b1565c47ac285fa77a082e0169438173af9b125e21
https://github.com/triggerdotdev/trigger.dev/pull/3464/files#diff-15cc1b2976807e5d2a9e65b1565c47ac285fa77a082e0169438173af9b125e21
apps/webapp/app/services/realtime/jwtAuth.server.tshttps://github.com/triggerdotdev/trigger.dev/pull/3464/files#diff-256b6719a2b7a60da127b1a78ac780cea50e785c21fc1326095c31467a067b6b
View file https://github.com/triggerdotdev/trigger.dev/blob/7a6c83e102ca1bd4c0eee62873905e5c61a55902/apps/webapp/app/services/realtime/jwtAuth.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/3464/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/3464/files#diff-256b6719a2b7a60da127b1a78ac780cea50e785c21fc1326095c31467a067b6b
https://github.com/triggerdotdev/trigger.dev/pull/3464/files#diff-256b6719a2b7a60da127b1a78ac780cea50e785c21fc1326095c31467a067b6b
https://github.com/triggerdotdev/trigger.dev/pull/3464/files#diff-256b6719a2b7a60da127b1a78ac780cea50e785c21fc1326095c31467a067b6b
https://github.com/triggerdotdev/trigger.dev/pull/3464/files#diff-256b6719a2b7a60da127b1a78ac780cea50e785c21fc1326095c31467a067b6b
https://github.com/triggerdotdev/trigger.dev/pull/3464/files#diff-256b6719a2b7a60da127b1a78ac780cea50e785c21fc1326095c31467a067b6b
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/3464/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.