René's URL Explorer Experiment


Title: fix(webapp): propagate abort signal through realtime proxy fetch by ericallam · Pull Request #3442 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(webapp): propagate abort signal through realtime proxy fetch by ericallam · Pull Request #3442 · triggerdotdev/trigger.dev

X Title: fix(webapp): propagate abort signal through realtime proxy fetch by ericallam · Pull Request #3442 · triggerdotdev/trigger.dev

Description: Summary Fixes an RSS-only memory leak in the three realtime proxy routes (/realtime/v1/runs, /realtime/v1/runs/:id, /realtime/v1/batches/:id). Client disconnects during an in-flight long-poll would leave the upstream fetch to Electric running with no way to abort it, so undici kept the socket open and buffered response chunks that would never be consumed. Root cause All three routes flow through RealtimeClient.streamRun/streamRuns/streamBatch → #streamRunsWhere → #performElectricRequest → longPollingFetch(url, { signal }). The chain was already signal-aware, but #streamRunsWhere hardcoded signal=undefined when calling #performElectricRequest, so no signal ever reached longPollingFetch. When a downstream client aborts a long-poll mid-flight: Express tears down the downstream response socket. The longPollingFetch promise has already resolved (it returns as soon as upstream headers arrive) and handed back new Response(upstream.body, {...}). undici keeps the upstream socket open and continues buffering chunks into the ReadableStream that nothing will ever read from. The upstream connection is eventually closed by Electric's own poll timeout (~20s). During that window the per-request buffers stay in native memory. These buffers live below V8's accounting — no heapUsed or external growth, no sign in heap snapshots, only RSS. An isolated standalone reproducer (fetch against a slow-streaming upstream, discard the Response before consuming its body) measures ~44 KB retained per leaked request after GC. That's consistent with the undici socket + receive buffer + HTTP parser state for a long-lived chunked response. The pattern is the shape documented in nodejs/undici#1108 and #2143. What changed realtimeClient.server.ts — add optional signal parameter to streamRun, streamRuns, streamBatch, and the shared #streamRunsWhere; thread it through to #performElectricRequest instead of hardcoding undefined. realtime.v1.runs.$runId.ts, realtime.v1.runs.ts, realtime.v1.batches.$batchId.ts — pass getRequestAbortSignal() (from httpAsyncStorage.server.ts) at the call site. This is the signal wired to res.on('close') and fires reliably on downstream disconnect. longPollingFetch.ts — belt-and-suspenders: cancel the upstream body explicitly in the error path, and treat AbortError as a clean 499 instead of a 500. This both releases undici's buffers deterministically on error and avoids spurious 500s in request logs when a client legitimately walks away. Verification Standalone reproducer: slow upstream server streams 32 KB chunks every 100 ms for 5 seconds per request. The proxy does fetch(url) with varying signal/cancel strategies, creates new Response(upstream.body, ...), and discards it without consuming the body (simulating the leak path). Results from 1 000 parallel fetches per variant, measured post-GC: variant Δ heap Δ external Δ RSS A. no signal, body never consumed (the bug) +0.3 MB 0 MB +59.4 MB B. signal propagated, aborted after headers (this fix) −0.1 MB 0 MB +15.4 MB C. no signal, explicit res.body.cancel() 0 MB 0 MB −25.4 MB 10-round sustained test of variant B to distinguish accumulating retention from one-time allocator overhead: round 1/10 Δ=+3.2 MB round 6/10 Δ=-12.5 MB round 2/10 Δ=-7.6 MB round 7/10 Δ=-11.9 MB round 3/10 Δ=-11.7 MB round 8/10 Δ=-2.6 MB round 4/10 Δ=+3.2 MB round 9/10 Δ=-8.0 MB round 5/10 Δ=-1.2 MB round 10/10 Δ=-12.6 MB RSS oscillates in a 49-65 MB band with no upward trend — signal propagation fully releases the buffers. Risk Behavior change only on aborted long-polls: the upstream fetch now cancels promptly instead of running to its natural timeout. This saves both memory and outbound traffic to Electric. AbortError now surfaces as 499 rather than 500. Any dashboard or alert that counts 500s in request logs will see slightly fewer of them; this is the intended behavior. Signal-aware parameter is optional on RealtimeClient.streamRun/streamRuns/streamBatch, so callers that don't opt in get the previous behavior. Test plan Existing realtime integration tests pass Dashboard realtime views (runs list, batch details) continue working normally across tab open/close cycles Under a burst of aborted long-polls, server RSS returns to baseline rather than climbing

Open Graph Description: Summary Fixes an RSS-only memory leak in the three realtime proxy routes (/realtime/v1/runs, /realtime/v1/runs/:id, /realtime/v1/batches/:id). Client disconnects during an in-flight long-poll would...

X Description: Summary Fixes an RSS-only memory leak in the three realtime proxy routes (/realtime/v1/runs, /realtime/v1/runs/:id, /realtime/v1/batches/:id). Client disconnects during an in-flight long-poll would...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/3442

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3fa23d13-30ed-66f0-ad85-094abc99f650
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8B9A:171254:59A0DA:84CFBE:6AFAED46
html-safe-nonce846ec2ed8da66fd66cc0cc78c8ca3759c4d24928395e9c26e3fea4bad7ac1779
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QjlBOjE3MTI1NDo1OUEwREE6ODRDRkJFOjZBRkFFRDQ2IiwidmlzaXRvcl9pZCI6IjYwMzQxODU2NTI1ODMxOTgwMjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5ce84f41a139536fe81f2ee565070ec13da75a3e3085ee97c7b9ec59e67a9d0f
hovercard-subject-tagpull_request:3579521373
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/3442/files
twitter:imagehttps://avatars.githubusercontent.com/u/534?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/534?s=400&v=4
og:image:altSummary Fixes an RSS-only memory leak in the three realtime proxy routes (/realtime/v1/runs, /realtime/v1/runs/:id, /realtime/v1/batches/:id). Client disconnects during an in-flight long-poll would...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0178036d8230524a18422872393ab7e708443ae4c2047f758560a2db870c1913
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release12fff95459b24b0f882a66698ee6a36a5934d247
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/3442/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F3442%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F3442%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/3442/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/3442/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/3442/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
ericallamhttps://github.com/ericallam
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
fix/realtime-fetch-abort-signalhttps://github.com/triggerdotdev/trigger.dev/tree/fix/realtime-fetch-abort-signal
Conversation 5 https://github.com/triggerdotdev/trigger.dev/pull/3442
Commits 1 https://github.com/triggerdotdev/trigger.dev/pull/3442/commits
Checks 80 https://github.com/triggerdotdev/trigger.dev/pull/3442/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/3442/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/3442/files
fix(webapp): propagate abort signal through realtime proxy fetch https://github.com/triggerdotdev/trigger.dev/pull/3442/files#top
Show all changes 1 commit https://github.com/triggerdotdev/trigger.dev/pull/3442/files
586315b fix(webapp): propagate abort signal through realtime proxy fetch ericallam Apr 24, 2026 https://github.com/triggerdotdev/trigger.dev/pull/3442/commits/586315bb6d5f6a4e3bf2e50c9f7c764e9e1d79fa
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/3442/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/3442/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/3442/files
fix-realtime-fetch-signal-leak.md https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-5726233c5b32e8231374cf881864254c809c1df430ff1df8328f24a895adc6c3
realtime.v1.batches.$batchId.ts https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-bae3afc69d4aaa4f61b49551f08a5d6a7da325540596297719dfe44e89269523
realtime.v1.runs.$runId.ts https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-3227d7eea9eae10cfc2767b2886f4381c7fd6764dc7aa749c7b3b3d62d7b8697
realtime.v1.runs.ts https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-827f925f1d83bd11733c0800006bb6d216a36b3cee0635d15ca412f74bf5c735
realtimeClient.server.ts https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-eed141a810a7ebfa0af4f562af6db6fc825566693720659e1c9c307b59785132
longPollingFetch.ts https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-650d217c75ca0fc93b429e03347113a8c4f543a81305641bd00427b1e0be78b6
.server-changes/fix-realtime-fetch-signal-leak.mdhttps://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-5726233c5b32e8231374cf881864254c809c1df430ff1df8328f24a895adc6c3
View file https://github.com/triggerdotdev/trigger.dev/blob/586315bb6d5f6a4e3bf2e50c9f7c764e9e1d79fa/.server-changes/fix-realtime-fetch-signal-leak.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/3442/{{ revealButtonHref }}
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/3442/files
apps/webapp/app/routes/realtime.v1.batches.$batchId.tshttps://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-bae3afc69d4aaa4f61b49551f08a5d6a7da325540596297719dfe44e89269523
View file https://github.com/triggerdotdev/trigger.dev/blob/586315bb6d5f6a4e3bf2e50c9f7c764e9e1d79fa/apps/webapp/app/routes/realtime.v1.batches.%24batchId.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/3442/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-bae3afc69d4aaa4f61b49551f08a5d6a7da325540596297719dfe44e89269523
https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-bae3afc69d4aaa4f61b49551f08a5d6a7da325540596297719dfe44e89269523
apps/webapp/app/routes/realtime.v1.runs.$runId.tshttps://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-3227d7eea9eae10cfc2767b2886f4381c7fd6764dc7aa749c7b3b3d62d7b8697
View file https://github.com/triggerdotdev/trigger.dev/blob/586315bb6d5f6a4e3bf2e50c9f7c764e9e1d79fa/apps/webapp/app/routes/realtime.v1.runs.%24runId.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/3442/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-3227d7eea9eae10cfc2767b2886f4381c7fd6764dc7aa749c7b3b3d62d7b8697
https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-3227d7eea9eae10cfc2767b2886f4381c7fd6764dc7aa749c7b3b3d62d7b8697
apps/webapp/app/routes/realtime.v1.runs.tshttps://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-827f925f1d83bd11733c0800006bb6d216a36b3cee0635d15ca412f74bf5c735
View file https://github.com/triggerdotdev/trigger.dev/blob/586315bb6d5f6a4e3bf2e50c9f7c764e9e1d79fa/apps/webapp/app/routes/realtime.v1.runs.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/3442/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-827f925f1d83bd11733c0800006bb6d216a36b3cee0635d15ca412f74bf5c735
https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-827f925f1d83bd11733c0800006bb6d216a36b3cee0635d15ca412f74bf5c735
apps/webapp/app/services/realtimeClient.server.tshttps://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-eed141a810a7ebfa0af4f562af6db6fc825566693720659e1c9c307b59785132
View file https://github.com/triggerdotdev/trigger.dev/blob/586315bb6d5f6a4e3bf2e50c9f7c764e9e1d79fa/apps/webapp/app/services/realtimeClient.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/3442/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-eed141a810a7ebfa0af4f562af6db6fc825566693720659e1c9c307b59785132
https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-eed141a810a7ebfa0af4f562af6db6fc825566693720659e1c9c307b59785132
https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-eed141a810a7ebfa0af4f562af6db6fc825566693720659e1c9c307b59785132
https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-eed141a810a7ebfa0af4f562af6db6fc825566693720659e1c9c307b59785132
https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-eed141a810a7ebfa0af4f562af6db6fc825566693720659e1c9c307b59785132
https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-eed141a810a7ebfa0af4f562af6db6fc825566693720659e1c9c307b59785132
https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-eed141a810a7ebfa0af4f562af6db6fc825566693720659e1c9c307b59785132
https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-eed141a810a7ebfa0af4f562af6db6fc825566693720659e1c9c307b59785132
https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-eed141a810a7ebfa0af4f562af6db6fc825566693720659e1c9c307b59785132
apps/webapp/app/utils/longPollingFetch.tshttps://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-650d217c75ca0fc93b429e03347113a8c4f543a81305641bd00427b1e0be78b6
View file https://github.com/triggerdotdev/trigger.dev/blob/586315bb6d5f6a4e3bf2e50c9f7c764e9e1d79fa/apps/webapp/app/utils/longPollingFetch.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/3442/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-650d217c75ca0fc93b429e03347113a8c4f543a81305641bd00427b1e0be78b6
https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-650d217c75ca0fc93b429e03347113a8c4f543a81305641bd00427b1e0be78b6
https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-650d217c75ca0fc93b429e03347113a8c4f543a81305641bd00427b1e0be78b6
https://github.com/triggerdotdev/trigger.dev/pull/3442/files#diff-650d217c75ca0fc93b429e03347113a8c4f543a81305641bd00427b1e0be78b6
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/3442/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.