René's URL Explorer Experiment


Title: feat(webapp): deprecate v3 CLI deploys server-side by ericallam · Pull Request #3415 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: feat(webapp): deprecate v3 CLI deploys server-side by ericallam · Pull Request #3415 · triggerdotdev/trigger.dev

X Title: feat(webapp): deprecate v3 CLI deploys server-side by ericallam · Pull Request #3415 · triggerdotdev/trigger.dev

Description: ✅ Checklist I have followed every step in the contributing guide The PR title follows the convention. I ran and tested the code works Summary Adds a server-side gate that detects deploy attempts from v3 CLI versions (i.e. trigger.dev@3.x) at the POST /api/v1/deployments entry point and, when enabled, rejects them with a clear upgrade message. v4 CLI deploys are completely unaffected. The last 3.x CLI release was 3.3.7, which we can't update. This approach short-circuits the deploy before any DB writes, image-ref generation, S2 stream creation, or queue enqueue — no side effects in either mode. How v3 vs v4 are distinguished I pulled the published CLI tarballs for trigger.dev@3.3.7, 4.0.0, 4.0.1, 4.0.5, 4.1.0, 4.2.0, and the current 4.4.4 in the repo. The cleanest, most reliable signal is the request body to POST /api/v1/deployments: Field on initialize v3.3.7 CLI v4.x CLI type never sent always sent — "MANAGED" (run_engine_v2) or "V1" isNativeBuild / gitMeta / triggeredVia / runtime not sent sent registryHost / namespace sent (v3-only; stripped by current Zod schema) not sent Every v4 call site I inspected sets type: features.run_engine_v2 ? "MANAGED" : "V1" unconditionally. payload.type is undefined if and only if the client is a 3.x CLI. Behavior Detection always runs and emits logger.warn("Detected deploy from deprecated v3 CLI", { environmentId, projectId, organizationId, enforced }), which lets us watch how many v3 deploys are still happening before enforcement is flipped. Enforcement is gated behind DEPRECATE_V3_CLI_DEPLOYS_ENABLED (default "0", off). When "1", the server returns 400 with: The trigger.dev CLI v3 is no longer supported for deployments. Please upgrade your project to v4: https://trigger.dev/docs/migrating-from-v3 The v3 CLI surfaces this verbatim as Failed to start deployment: because zodfetch throws ApiError for non-retryable 4xx (400/422) and deploy.js in 3.3.7 prints error.message. Out of scope (intentionally) api.v1.deployments.$deploymentId.finalize.ts / FinalizeDeploymentService / createDeploymentBackgroundWorkerV3.server.ts are V1-engine paths, not the v3 CLI gate. Leaving them alone per review. Container-side createDeploymentBackgroundWorker call in managed-index-controller.ts is still used by v4's in-image indexer. Not touched. v3 trigger dev flow (different code path) — separate deprecation if/when needed. Testing Ran pnpm run typecheck --filter webapp locally — passes. Verified v4 tarballs (4.0.0, 4.0.1, 4.0.5, 4.1.0, 4.2.0, 4.4.4) all include type: in the initializeDeployment call site, so none will be accidentally blocked. Verified v3.3.7 tarball's initializeDeployment payload has no type field. Rollout plan after merge: Deploy with DEPRECATE_V3_CLI_DEPLOYS_ENABLED unset → watch Detected deploy from deprecated v3 CLI log volume. When comfortable, set DEPRECATE_V3_CLI_DEPLOYS_ENABLED=1 to enforce. Changelog Detect v3 CLI deploys on /api/v1/deployments and, when DEPRECATE_V3_CLI_DEPLOYS_ENABLED=1, reject them with an upgrade message pointing at https://trigger.dev/docs/migrating-from-v3. v4 CLI deploys are unaffected. Link to Devin session: https://app.devin.ai/sessions/b242c11bd86e4099aeec8b59bab62143 Requested by: @ericallam

Open Graph Description: ✅ Checklist I have followed every step in the contributing guide The PR title follows the convention. I ran and tested the code works Summary Adds a server-side gate that detects deploy attem...

X Description: ✅ Checklist I have followed every step in the contributing guide The PR title follows the convention. I ran and tested the code works Summary Adds a server-side gate that detects deploy attem...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/3415

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:02cf3099-0f35-fca4-3cad-0591666f8007
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB122:258E05:8BD89B:CF7097:6AFAFE1B
html-safe-noncea004b6b5dfb7bf8308147e31c58eeffa38869fa0e345b55cb24b0c2cb0cf154d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTIyOjI1OEUwNTo4QkQ4OUI6Q0Y3MDk3OjZBRkFGRTFCIiwidmlzaXRvcl9pZCI6IjI5NzE3NTQ5NTI2OTY0NjI4NzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6168b2df90bddb5bee4070382c8ea0e6140f6270d6e43cd5305beb99b0d4e086
hovercard-subject-tagpull_request:3556132864
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/3415/files
twitter:imagehttps://avatars.githubusercontent.com/u/534?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/534?s=400&v=4
og:image:alt✅ Checklist I have followed every step in the contributing guide The PR title follows the convention. I ran and tested the code works Summary Adds a server-side gate that detects deploy attem...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None54f7a6886649661c85eee945cca0773566bfb4065370e0429b7c8f7204184650
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3a69df62e401f1cbe8bd1ad791845bb4fc5b1c1d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/3415/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F3415%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F3415%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/3415/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/3415/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/3415/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests67 (67)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
ericallamhttps://github.com/ericallam
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
devin/1776690995-deprecate-v3-cli-deployshttps://github.com/triggerdotdev/trigger.dev/tree/devin/1776690995-deprecate-v3-cli-deploys
Conversation 8 https://github.com/triggerdotdev/trigger.dev/pull/3415
Commits 1 https://github.com/triggerdotdev/trigger.dev/pull/3415/commits
Checks 44 https://github.com/triggerdotdev/trigger.dev/pull/3415/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/3415/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/3415/files
feat(webapp): deprecate v3 CLI deploys server-side https://github.com/triggerdotdev/trigger.dev/pull/3415/files#top
Show all changes 1 commit https://github.com/triggerdotdev/trigger.dev/pull/3415/files
6edebde feat(webapp): deprecate v3 CLI deploys server-side ericallam Apr 20, 2026 https://github.com/triggerdotdev/trigger.dev/pull/3415/commits/6edebde22b924a4bb6a88a78707a3c313f4c31a3
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/3415/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/3415/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/3415/files
deprecate-v3-cli-deploys.md https://github.com/triggerdotdev/trigger.dev/pull/3415/files#diff-b7af3828ea8e159f30ea21148639a3dc7586479959153955200861fa94c5d5be
env.server.ts https://github.com/triggerdotdev/trigger.dev/pull/3415/files#diff-f8823615ef72da3494e74de9e62b2fa31315ed9360f17bc06ab943f4dc25f4fd
initializeDeployment.server.ts https://github.com/triggerdotdev/trigger.dev/pull/3415/files#diff-eecb353c7c3263f855cf9e89462c446a33a77edf8e41963209fda6531e67f907
.server-changes/deprecate-v3-cli-deploys.mdhttps://github.com/triggerdotdev/trigger.dev/pull/3415/files#diff-b7af3828ea8e159f30ea21148639a3dc7586479959153955200861fa94c5d5be
View file https://github.com/triggerdotdev/trigger.dev/blob/6edebde22b924a4bb6a88a78707a3c313f4c31a3/.server-changes/deprecate-v3-cli-deploys.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/3415/{{ revealButtonHref }}
apps/webapp/app/env.server.tshttps://github.com/triggerdotdev/trigger.dev/pull/3415/files#diff-f8823615ef72da3494e74de9e62b2fa31315ed9360f17bc06ab943f4dc25f4fd
View file https://github.com/triggerdotdev/trigger.dev/blob/6edebde22b924a4bb6a88a78707a3c313f4c31a3/apps/webapp/app/env.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/3415/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/3415/files#diff-f8823615ef72da3494e74de9e62b2fa31315ed9360f17bc06ab943f4dc25f4fd
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/3415/files
https://github.com/triggerdotdev/trigger.dev/pull/3415/files#diff-f8823615ef72da3494e74de9e62b2fa31315ed9360f17bc06ab943f4dc25f4fd
apps/webapp/app/v3/services/initializeDeployment.server.tshttps://github.com/triggerdotdev/trigger.dev/pull/3415/files#diff-eecb353c7c3263f855cf9e89462c446a33a77edf8e41963209fda6531e67f907
View file https://github.com/triggerdotdev/trigger.dev/blob/6edebde22b924a4bb6a88a78707a3c313f4c31a3/apps/webapp/app/v3/services/initializeDeployment.server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/3415/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/3415/files#diff-eecb353c7c3263f855cf9e89462c446a33a77edf8e41963209fda6531e67f907
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/3415/files
https://github.com/triggerdotdev/trigger.dev/pull/3415/files#diff-eecb353c7c3263f855cf9e89462c446a33a77edf8e41963209fda6531e67f907
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/3415/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.