René's URL Explorer Experiment


Title: fix(otel): exported logs and spans will now have matching trace IDs by ericallam · Pull Request #2724 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: fix(otel): exported logs and spans will now have matching trace IDs by ericallam · Pull Request #2724 · triggerdotdev/trigger.dev

X Title: fix(otel): exported logs and spans will now have matching trace IDs by ericallam · Pull Request #2724 · triggerdotdev/trigger.dev

Description: When using custom OTLP exporters via telemetry.exporters and This occurred when tasks were triggered without a parent trace context (e.g., via API or dashboard). In this scenario: - Spans were correctly rewritten to use the generated externalTraceId - Logs kept their original internal trace ID due to a bug in the early return logic Root Cause In ExternalLogRecordExporterWrapper.transformLogRecord(), the early return condition incorrectly included !this.externalTraceContext: if (!logRecord.spanContext || !this.externalTraceId || !this.externalTraceContext) { return logRecord; // Bug: Returns early when externalTraceContext is undefined } // This fallback logic was never reached: const externalTraceId = this.externalTraceContext ? this.externalTraceContext.traceId : this.externalTraceId; Fix Reordered logic in transformLogRecord(): Move the externalTraceId calculation before the early return, and check the culated value instead of this.externalTraceContext: const externalTraceId = this.externalTraceContext ? this.externalTraceContext.traceId : this.externalTraceId; if (!logRecord.spanContext || !externalTraceId) { return logRecord; } Clarified _isExternallySampled logic: Updated both ExternalSpanExporterWrapper and ExternalLogRecordExporterWrapper explicitly handle the case where there's no external trace context a generated externalTraceId exists: this._isExternallySampled = externalTraceContext ? isTraceFlagSampled(externalTraceContext.traceFlags) : !!externalTraceId; Impact Logs and spans from the same task run will now have matching trace IDs when exported to external observability tools, enabling proper trace correlation regardless of whether the task was triggered with or without a parent trace context. telemetry.logExporters in trigger.config.ts, logs and spans were exported with different trace IDs, breaking trace correlation in external observability tools like Datadog.

Open Graph Description: When using custom OTLP exporters via telemetry.exporters and This occurred when tasks were triggered without a parent trace context (e.g., via API or dashboard). In this scenario: - Spans were corr...

X Description: When using custom OTLP exporters via telemetry.exporters and This occurred when tasks were triggered without a parent trace context (e.g., via API or dashboard). In this scenario: - Spans were corr...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/pull/2724

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bedc6f83-3760-09c7-50ca-28713e565f65
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9DA4:BD35:2D3340:42CA5E:6AFAE18A
html-safe-nonce020ec17bc429480245cfbaf77906cbebaf1501a5220a23b6becc5908bf315310
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5REE0OkJEMzU6MkQzMzQwOjQyQ0E1RTo2QUZBRTE4QSIsInZpc2l0b3JfaWQiOiI2Nzk3NTg2NzU0ODIwNTYzMzM4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7b506cdcbc307452355b08bd3baf93f164015943cffff32cdeedcdce6f1acc25
hovercard-subject-tagpull_request:3063702715
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/triggerdotdev/trigger.dev/pull/2724/files
twitter:imagehttps://avatars.githubusercontent.com/u/534?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/534?s=400&v=4
og:image:altWhen using custom OTLP exporters via telemetry.exporters and This occurred when tasks were triggered without a parent trace context (e.g., via API or dashboard). In this scenario: - Spans were corr...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None9d9bd51a568909a83d1abb9d6f74d68f0c87ca85fe3a56d3f5d70d8b89add9f2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a7ae932999cc6d511008dbf980ff9efad2a31f7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/pull/2724/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F2724%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fpull%2F2724%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/2724/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/2724/files
Reloadhttps://github.com/triggerdotdev/trigger.dev/pull/2724/files
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests66 (66)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2Fnew%2Fchoose
ericallamhttps://github.com/ericallam
mainhttps://github.com/triggerdotdev/trigger.dev/tree/main
ea-branch-105https://github.com/triggerdotdev/trigger.dev/tree/ea-branch-105
Conversation 3 https://github.com/triggerdotdev/trigger.dev/pull/2724
Commits 1 https://github.com/triggerdotdev/trigger.dev/pull/2724/commits
Checks 30 https://github.com/triggerdotdev/trigger.dev/pull/2724/checks
Files changed https://github.com/triggerdotdev/trigger.dev/pull/2724/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/2724/files
fix(otel): exported logs and spans will now have matching trace IDs https://github.com/triggerdotdev/trigger.dev/pull/2724/files#top
Show all changes 1 commit https://github.com/triggerdotdev/trigger.dev/pull/2724/files
ee457aa fix(otel): exported logs and spans will now have matching trace IDs ericallam Dec 2, 2025 https://github.com/triggerdotdev/trigger.dev/pull/2724/commits/ee457aae12282d26480abc2d20875f4e18a0b222
Clear filters https://github.com/triggerdotdev/trigger.dev/pull/2724/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/2724/files
Please reload this pagehttps://github.com/triggerdotdev/trigger.dev/pull/2724/files
brown-pots-beg.md https://github.com/triggerdotdev/trigger.dev/pull/2724/files#diff-3460fc6d4b8930527aa46768e337da1c18f539ed3dfe9aff3ab3539d3ea314bd
tracingSDK.ts https://github.com/triggerdotdev/trigger.dev/pull/2724/files#diff-ce510b575f0568e5e9854cedbca289205f363324a89085ae9b668c3cc334cd93
.changeset/brown-pots-beg.mdhttps://github.com/triggerdotdev/trigger.dev/pull/2724/files#diff-3460fc6d4b8930527aa46768e337da1c18f539ed3dfe9aff3ab3539d3ea314bd
View file https://github.com/triggerdotdev/trigger.dev/blob/ee457aae12282d26480abc2d20875f4e18a0b222/.changeset/brown-pots-beg.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/2724/{{ revealButtonHref }}
packages/core/src/v3/otel/tracingSDK.tshttps://github.com/triggerdotdev/trigger.dev/pull/2724/files#diff-ce510b575f0568e5e9854cedbca289205f363324a89085ae9b668c3cc334cd93
View file https://github.com/triggerdotdev/trigger.dev/blob/ee457aae12282d26480abc2d20875f4e18a0b222/packages/core/src/v3/otel/tracingSDK.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/triggerdotdev/trigger.dev/pull/2724/{{ revealButtonHref }}
https://github.com/triggerdotdev/trigger.dev/pull/2724/files#diff-ce510b575f0568e5e9854cedbca289205f363324a89085ae9b668c3cc334cd93
https://github.com/triggerdotdev/trigger.dev/pull/2724/files#diff-ce510b575f0568e5e9854cedbca289205f363324a89085ae9b668c3cc334cd93
https://github.com/triggerdotdev/trigger.dev/pull/2724/files#diff-ce510b575f0568e5e9854cedbca289205f363324a89085ae9b668c3cc334cd93
https://github.com/triggerdotdev/trigger.dev/pull/2724/files#diff-ce510b575f0568e5e9854cedbca289205f363324a89085ae9b668c3cc334cd93
https://github.com/triggerdotdev/trigger.dev/pull/2724/files#diff-ce510b575f0568e5e9854cedbca289205f363324a89085ae9b668c3cc334cd93
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.