René's URL Explorer Experiment


Title: bug: mergeOrgFeatureFlags drops all valid org feature flags when one stored flag is invalid · Issue #5058 · triggerdotdev/trigger.dev · GitHub

Open Graph Title: bug: mergeOrgFeatureFlags drops all valid org feature flags when one stored flag is invalid · Issue #5058 · triggerdotdev/trigger.dev

X Title: bug: mergeOrgFeatureFlags drops all valid org feature flags when one stored flag is invalid · Issue #5058 · triggerdotdev/trigger.dev

Description: Provide environment information System: OS: Linux 6.8 Ubuntu Binaries: Node: 22.14.0 pnpm: 9.15.0 Describe the bug In a7f0f90e ("show stored org values for locked flags in the admin flags dialog"), the v1 and v2 admin org feature-flag ro...

Open Graph Description: Provide environment information System: OS: Linux 6.8 Ubuntu Binaries: Node: 22.14.0 pnpm: 9.15.0 Describe the bug In a7f0f90e ("show stored org values for locked flags in the admin flags dialog"),...

X Description: Provide environment information System: OS: Linux 6.8 Ubuntu Binaries: Node: 22.14.0 pnpm: 9.15.0 Describe the bug In a7f0f90e ("show stored org values for locked flags in the admin flags dial...

Opengraph URL: https://github.com/triggerdotdev/trigger.dev/issues/5058

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"bug: mergeOrgFeatureFlags drops all valid org feature flags when one stored flag is invalid","articleBody":"### Provide environment information\n\nSystem:\n  OS: Linux 6.8 Ubuntu\nBinaries:\n  Node: 22.14.0\n  pnpm: 9.15.0\n\n### Describe the bug\n\nIn `a7f0f90e` (\"show stored org values for locked flags in the admin flags dialog\"), the v1 and v2 admin org feature-flag routes were updated to read stored flags key-by-key via `parseStoredOrgFlags(organization.featureFlags).valid`, and saves now intentionally keep untouched invalid values and unknown keys from newer releases in `Organization.featureFlags`.\n\nHowever, `mergeOrgFeatureFlags` in `apps/webapp/app/v3/featureFlags.server.ts` (used by `resolveOrganizationFeatureFlags`) still validates the entire `orgFeatureFlags` object at once with `validatePartialFeatureFlags(orgFeatureFlags)`:\n\n```ts\nexport function mergeOrgFeatureFlags(\n  globalFlags: Partial\u003cFeatureFlagCatalog>,\n  orgFeatureFlags: unknown\n) {\n  const parsed = orgFeatureFlags\n    ? validatePartialFeatureFlags(orgFeatureFlags as Record\u003cstring, unknown>)\n    : ({ success: false } as const);\n  return { ...globalFlags, ...(parsed.success ? parsed.data : {}) };\n}\n```\n\nIf an org has one invalid stored flag value in `Organization.featureFlags` (which admin saves now keep), `validatePartialFeatureFlags` fails for the whole blob and `mergeOrgFeatureFlags` drops all of the org's valid overrides (`hasWebhooksAccess`, `hasQueryAccess`, `hasLogsPageAccess`, `hasAiAccess`, etc.), even though the admin flags dialog and `/admin/api/v1/orgs/:orgId/feature-flags` show them as active.\n\nTwo small related issues in `FeatureFlagsDialog.tsx`:\n- `unsetFlag(key)` only deletes `next[key]` without clearing `derivedFlagsClearedWith(key)`, so unsetting `runOpsMintKind` leaves `runOpsMintKindPrev` and `runOpsMintKindFlippedAt` shown as set in the dialog list and JSON preview.\n- Checking \"Unlock read-only flags\" unlocks `effect === \"derived\"` grace-stamp rows (`runOpsMintKindPrev`, `runOpsMintKindFlippedAt`, `runOpsMintShardSetPrev`, `runOpsMintShardSetFlippedAt`) into editable controls, even though the server strips and recomputes them on save.\n\n### Reproduction repo\n\nhttps://github.com/triggerdotdev/trigger.dev/blob/main/apps/webapp/app/v3/featureFlags.server.ts#L307-L314\n\n### To reproduce\n\n1. Call `mergeOrgFeatureFlags({ hasLogsPageAccess: false }, { hasLogsPageAccess: true, realtimeBackend: \"not-a-backend\" })` (or save a valid flag via `/admin/api/v2/orgs/:organizationId/feature-flags` on an org that has an existing invalid flag).\n2. `mergeOrgFeatureFlags` returns `{ hasLogsPageAccess: false }` instead of `{ hasLogsPageAccess: true }` because `validatePartialFeatureFlags` fails on `realtimeBackend`.\n\n### Suggested fix\n\nUse `parseStoredOrgFlags(orgFeatureFlags).valid` in `mergeOrgFeatureFlags`, and in `FeatureFlagsDialog.tsx` clear `derivedFlagsClearedWith(key)` in `unsetFlag` and keep `effect === \"derived\"` flags read-only when unlocked.\n\n### Additional information\n\n_No response_\n\n\u003cimg width=\"960\" height=\"440\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/420343d9-97da-4b6c-925b-5bfdf0c7fc1a\" />","author":{"url":"https://github.com/shafiktanbir","@type":"Person","name":"shafiktanbir"},"datePublished":"2026-10-24T11:46:40Z","url":"https://github.com/triggerdotdev/trigger.dev/issues/5058"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:685d32c9-a3e1-abd5-fdb1-3a6ea1416f52
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8916:268853:5F52787:7E9B2FC:6AFAD885
html-safe-nonce1dd50ec9aa12dcda89b42e22f0f85a32ba5b6ce0a6d5b4e093e6870a2ab6b004
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTE2OjI2ODg1Mzo1RjUyNzg3OjdFOUIyRkM6NkFGQUQ4ODUiLCJ2aXNpdG9yX2lkIjoiMTU1MjgwNjA1OTk5MzM4OTE4OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac12c7165904619e955bda87b367b3d2a9440766b27e872cb58e16035a2bf72bf8
hovercard-subject-tagissue:6012584705
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/triggerdotdev/trigger.dev/5058/issue_layout
twitter:imagehttps://opengraph.githubassets.com/7e160263dc99906db12e28dc1343310fafe97e942621d8e22465e6bb5c69aa38/triggerdotdev/trigger.dev/issues/5058
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7e160263dc99906db12e28dc1343310fafe97e942621d8e22465e6bb5c69aa38/triggerdotdev/trigger.dev/issues/5058
og:image:altProvide environment information System: OS: Linux 6.8 Ubuntu Binaries: Node: 22.14.0 pnpm: 9.15.0 Describe the bug In a7f0f90e ("show stored org values for locked flags in the admin flags dialog"),...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameshafiktanbir
hostnamegithub.com
expected-hostnamegithub.com
None02f4c00e74911c7cd779fc232c3130cee49eb39fd0ed4bfe3eea3b82c7c18084
turbo-cache-controlno-preview
go-importgithub.com/triggerdotdev/trigger.dev git https://github.com/triggerdotdev/trigger.dev.git
octolytics-dimension-user_id95297378
octolytics-dimension-user_logintriggerdotdev
octolytics-dimension-repository_id572570113
octolytics-dimension-repository_nwotriggerdotdev/trigger.dev
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id572570113
octolytics-dimension-repository_network_root_nwotriggerdotdev/trigger.dev
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release33c41e9d150e44415272934d676dc63c57d89c3b
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/triggerdotdev/trigger.dev/issues/5058#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2F5058
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftriggerdotdev%2Ftrigger.dev%2Fissues%2F5058
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=triggerdotdev%2Ftrigger.dev
Reloadhttps://github.com/triggerdotdev/trigger.dev/issues/5058
Reloadhttps://github.com/triggerdotdev/trigger.dev/issues/5058
Reloadhttps://github.com/triggerdotdev/trigger.dev/issues/5058
triggerdotdevhttps://github.com/triggerdotdev
trigger.devhttps://github.com/triggerdotdev/trigger.dev
Codehttps://github.com/triggerdotdev/trigger.dev
Issues203 (203)https://github.com/triggerdotdev/trigger.dev/issues
Pull requests65 (65)https://github.com/triggerdotdev/trigger.dev/pulls
Discussionshttps://github.com/triggerdotdev/trigger.dev/discussions
Actionshttps://github.com/triggerdotdev/trigger.dev/actions
Projectshttps://github.com/triggerdotdev/trigger.dev/projects
Security and quality39 (39)https://github.com/triggerdotdev/trigger.dev/security
Insightshttps://github.com/triggerdotdev/trigger.dev/pulse
https://github.com/triggerdotdev/trigger.dev
New issuehttps://github.com/login?return_to=https://github.com/triggerdotdev/trigger.dev/issues/5058
New issuehttps://github.com/login?return_to=https://github.com/triggerdotdev/trigger.dev/issues/5058
bug: mergeOrgFeatureFlags drops all valid org feature flags when one stored flag is invalidhttps://github.com/triggerdotdev/trigger.dev/issues/5058#top
https://github.com/shafiktanbir
shafiktanbirhttps://github.com/shafiktanbir
on Oct 24, 2026https://github.com/triggerdotdev/trigger.dev/issues/5058#issue-6012584705
https://github.com/triggerdotdev/trigger.dev/blob/main/apps/webapp/app/v3/featureFlags.server.ts#L307-L314https://github.com/triggerdotdev/trigger.dev/blob/main/apps/webapp/app/v3/featureFlags.server.ts#L307-L314
https://private-user-images.githubusercontent.com/58387559/683669078-420343d9-97da-4b6c-925b-5bfdf0c7fc1a.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTQ4MjQ2MjYsIm5iZiI6MTc5NDgyNDMyNiwicGF0aCI6Ii81ODM4NzU1OS82ODM2NjkwNzgtNDIwMzQzZDktOTdkYS00YjZjLTkyNWItNWJmZGYwYzdmYzFhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjExMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYxMTE2VDEwMTg0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY2MjMwMDc5OThlYTJlMTE2NThkMmY3ZDg2NTI4MTRlZDlhMjM4ZGMyYzUzZGE1ODMyNDBhZGU3YTMwNjNlNzEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.jazxa3T03nBIzhYznWekwUAYkH9S14gX1C4or76Qjms
https://github.com/ghazy2001
ghazy2001https://github.com/ghazy2001
on Oct 29, 2026https://github.com/triggerdotdev/trigger.dev/issues/5058#issuecomment-6502445841
#5086https://github.com/triggerdotdev/trigger.dev/pull/5086
Sign up for freehttps://github.com/signup?return_to=https://github.com/triggerdotdev/trigger.dev/issues/5058
Sign in to commenthttps://github.com/login?return_to=https://github.com/triggerdotdev/trigger.dev/issues/5058
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.