René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"bug: getRunIdForOptions function is duplicated, contains inconsistent fallback behavior","articleBody":"### Provide environment information\n\nSystem:\n    OS: macOS 15.7.3\n    CPU: (16) arm64 Apple M4 Max\n    Memory: 1.99 GB / 64.00 GB\n    Shell: 5.9 - /bin/zsh\n\n  Binaries:\n    Node: 22.16.0 - \n    Yarn: 1.22.22 \n    npm: 10.9.2 \n    pnpm: 10.26.2 \n    Watchman: 2026.01.05.00 \n\n### Describe the bug\n\nThe `getRunIdForOptions` function is duplicated in two locations with inconsistent fallback behavior. The SDK version (`packages/trigger-sdk/src/v3/streams.ts`) lacks fallback logic that exists in the core implementation (`packages/core/src/v3/realtimeStreams/manager.ts`).\n\nWhen calling `streams.pipe(\"key\", stream, { target: \"root\" })` from a root task (a task not triggered by another task), the SDK throws an error instead of falling back to the current run ID. The semantic meaning of target: \"root\" is \"send to the root of this task tree\" - if the current task IS the root, it should behave the same as target: \"self\".\n\n\n### Reproduction repo\n\nThis can be reproduced in any Trigger.dev project using the SDK's streams.pipe() API with target: \"root\" from a directly-triggered task.\n\n### To reproduce\n\n```typescript\nimport { streams, task } from \"@trigger.dev/sdk\";\n\n  // This task is triggered directly (not a child of another task)\n  export const rootTask = task({\n    id: \"root-task\",\n    run: async (payload) =\u003e {\n      const myStream = createSomeAsyncGenerator();\n\n      // This will throw an error even though it should work\n      const { waitUntilComplete } = streams.pipe(\"output\", myStream, {\n        target: \"root\"  // Fails because rootTaskRunId is undefined for root tasks\n      });\n\n      await waitUntilComplete();\n    },\n  });\n```\n\n  **Steps:**\n  1. Create a task that is triggered directly (not as a child of another task)\n  2. Call streams.pipe() with { target: \"root\" }\n  3. Observe the error is thrown\n\n\n### Additional information\n\n**Root Cause:** Two `getRunIdForOptions` functions exist with different behavior:\n\n  | File | Fallback for `\"root\"`/`\"parent\"`? |\n  |------|----------------------------------|\n  | `packages/trigger-sdk/src/v3/streams.ts:665-683` | ❌ No |\n  | `packages/core/src/v3/realtimeStreams/manager.ts:141-159` | ✅ Yes |\n\n  **Why the core fallback is unreachable:** The SDK resolves targets to string IDs FIRST, then passes them to the core. By the time `StandardRealtimeStreamsManager.pipe()` is called, it receives a string ID (or an error was already thrown), so its fallback logic is dead code for SDK callers.\n\n  **Evidence the fallback is intended:**\n  - Documentation (`docs/tasks/streams.mdx:374,399`) shows `target: \"root\"` as valid usage\n  - Internal API (`packages/core/src/v3/runMetadata/manager.ts:330-333`) passes semantic targets directly and relies on the fallback\n\n  **Origin:** Both functions introduced in same commit (`536d9fa21` - \"feat(realtime): Realtime streams v2 #2632\"). Inconsistency was present from creation.\n\n  **Affected functions:** `streams.pipe()`, `streams.append()`, `streams.writer()` - all use the same `getRunIdForOptions` in `streams.ts`","author":{"url":"https://github.com/robraux","@type":"Person","name":"robraux"},"datePublished":"2026-01-08T15:11:57.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/2852/trigger.dev/issues/2852"}