René's URL Explorer Experiment


Title: Builder: Use `shutil.get_terminal_size()` by tony · Pull Request #926 · tmux-python/tmuxp · GitHub

Open Graph Title: Builder: Use `shutil.get_terminal_size()` by tony · Pull Request #926 · tmux-python/tmuxp

X Title: Builder: Use `shutil.get_terminal_size()` by tony · Pull Request #926 · tmux-python/tmuxp

Description: 🖥️ Session manager for tmux, built on libtmux. Contribute to tmux-python/tmuxp development by creating an account on GitHub.

Open Graph Description: in re: #667, #704, #737 WarningThis would definitely be breaking behavior. Test instructions Latest (1.46.0a0): pipx install --suffix=@builder-sizes 'tmuxp >= 1.46.0a0' Outdated: pipx i...

X Description: in re: #667, #704, #737 WarningThis would definitely be breaking behavior. Test instructions Latest (1.46.0a0): pipx install --suffix=@builder-sizes 'tmuxp >= 1.46.0a0' Outd...

Opengraph URL: https://github.com/tmux-python/tmuxp/pull/926

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d6591949-1464-988a-4ef2-c381783e5ccb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC3C8:1D18A:32D388:45775F:6B006BF7
html-safe-nonce660b6a414cfb1a1418780a0ba96742b96e85b202d8be03444cbed6788d38e81f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDM0M4OjFEMThBOjMyRDM4ODo0NTc3NUY6NkIwMDZCRjciLCJ2aXNpdG9yX2lkIjoiMzYzNzAyMzk4NTAyNTE4MjcxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac56de416fbf8918c96378f7e50fbe5c9b4e34e7e7b2c02030864c47a0362af34f
hovercard-subject-tagpull_request:1810895221
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/tmux-python/tmuxp/926/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ef85b1acedd0d6720d054cc8676c6612d7133ceb9ee7f5d1bd6d44a11d67bdee/tmux-python/tmuxp/pull/926
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ef85b1acedd0d6720d054cc8676c6612d7133ceb9ee7f5d1bd6d44a11d67bdee/tmux-python/tmuxp/pull/926
og:image:altin re: #667, #704, #737 WarningThis would definitely be breaking behavior. Test instructions Latest (1.46.0a0): pipx install --suffix=@builder-sizes 'tmuxp >= 1.46.0a0' Outdated: pipx i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametony
hostnamegithub.com
expected-hostnamegithub.com
None6527e91c60c0b29d16606ff32ac5df8ecdc37a2a62205ea057a14d7762c870fa
turbo-cache-controlno-cache
go-importgithub.com/tmux-python/tmuxp git https://github.com/tmux-python/tmuxp.git
octolytics-dimension-user_id37234308
octolytics-dimension-user_logintmux-python
octolytics-dimension-repository_id12398170
octolytics-dimension-repository_nwotmux-python/tmuxp
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id12398170
octolytics-dimension-repository_network_root_nwotmux-python/tmuxp
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release46f1cd2ae3cd8ae1a81019b5d619742e76f13bbd
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/tmux-python/tmuxp/pull/926#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftmux-python%2Ftmuxp%2Fpull%2F926
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftmux-python%2Ftmuxp%2Fpull%2F926
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=tmux-python%2Ftmuxp
Reloadhttps://github.com/tmux-python/tmuxp/pull/926
Reloadhttps://github.com/tmux-python/tmuxp/pull/926
Reloadhttps://github.com/tmux-python/tmuxp/pull/926
tmux-pythonhttps://github.com/tmux-python
tmuxphttps://github.com/tmux-python/tmuxp
Codehttps://github.com/tmux-python/tmuxp
Issues113 (113)https://github.com/tmux-python/tmuxp/issues
Pull requests29 (29)https://github.com/tmux-python/tmuxp/pulls
Discussionshttps://github.com/tmux-python/tmuxp/discussions
Actionshttps://github.com/tmux-python/tmuxp/actions
Security and qualityhttps://github.com/tmux-python/tmuxp/security
Insightshttps://github.com/tmux-python/tmuxp/insights
https://github.com/tmux-python/tmuxp
tonyhttps://github.com/tony
masterhttps://github.com/tmux-python/tmuxp/tree/master
builder-sizeshttps://github.com/tmux-python/tmuxp/tree/builder-sizes
Conversationhttps://github.com/tmux-python/tmuxp/pull/926
Commits10 (10)https://github.com/tmux-python/tmuxp/pull/926/commits
Checkshttps://github.com/tmux-python/tmuxp/pull/926/checks
Files changedhttps://github.com/tmux-python/tmuxp/pull/926/files
Builder: Use shutil.get_terminal_size()https://github.com/tmux-python/tmuxp/pull/926#top
tonyhttps://github.com/tony
masterhttps://github.com/tmux-python/tmuxp/tree/master
builder-sizeshttps://github.com/tmux-python/tmuxp/tree/builder-sizes
https://github.com/tony
tonyhttps://github.com/tony
Apr 7, 2024https://github.com/tmux-python/tmuxp/pull/926#issue-2229833378
Please reload this pagehttps://github.com/tmux-python/tmuxp/pull/926
#667https://github.com/tmux-python/tmuxp/issues/667
#704https://github.com/tmux-python/tmuxp/issues/704
#737https://github.com/tmux-python/tmuxp/issues/737
1.46.0a0https://pypi.org/project/tmuxp/1.46.0a0/
https://private-user-images.githubusercontent.com/26336/320300355-4ed06713-d9db-4b4d-97dc-474ebe1e8487.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTUxOTAwNTEsIm5iZiI6MTc5NTE4OTc1MSwicGF0aCI6Ii8yNjMzNi8zMjAzMDAzNTUtNGVkMDY3MTMtZDlkYi00YjRkLTk3ZGMtNDc0ZWJlMWU4NDg3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjExMjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYxMTIwVDE1NDkxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ5MGQ5Y2Q2MDc5MmYwZGRhOTVhYTc3ODA3NmUyNGQzYjE5ZDRlNGE2YmU5YzQ5YzhlODg4OWQ5MmY1ZGJiMDQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.MqOaflFvgNDbmb5x9cag0oqROZDUAs3KL2EDdDajbWg
shutil.get_terminal_sizehttps://docs.python.org/3/library/shutil.html#shutil.get_terminal_size
Please reload this pagehttps://github.com/tmux-python/tmuxp/pull/926
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Apr 7, 2024https://github.com/tmux-python/tmuxp/pull/926#issuecomment-2041522422
Please reload this pagehttps://github.com/tmux-python/tmuxp/pull/926
Codecovhttps://app.codecov.io/gh/tmux-python/tmuxp/pull/926?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tmux-python
(f4b392c)https://app.codecov.io/gh/tmux-python/tmuxp/commit/f4b392c070a391dda882875dd6e96b142a54474a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tmux-python
(cd5d114)https://app.codecov.io/gh/tmux-python/tmuxp/pull/926?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tmux-python
Fileshttps://app.codecov.io/gh/tmux-python/tmuxp/pull/926?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tmux-python
src/tmuxp/workspace/builder.pyhttps://app.codecov.io/gh/tmux-python/tmuxp/pull/926?src=pr&el=tree&filepath=src%2Ftmuxp%2Fworkspace%2Fbuilder.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tmux-python#diff-c3JjL3RtdXhwL3dvcmtzcGFjZS9idWlsZGVyLnB5
0 Missing and 1 partial ⚠️ https://app.codecov.io/gh/tmux-python/tmuxp/pull/926?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tmux-python
☔ View full report in Codecov by Sentryhttps://app.codecov.io/gh/tmux-python/tmuxp/pull/926?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tmux-python
Share it herehttps://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tmux-python
Please reload this pagehttps://github.com/tmux-python/tmuxp/pull/926
tonyhttps://github.com/tony
April 7, 2024 11:31https://github.com/tmux-python/tmuxp/pull/926#commits-pushed-3f1e933
https://github.com/tony
.tmuxp.{json,yaml}: Use percent for main-pane-heighthttps://github.com/tmux-python/tmuxp/pull/926/commits/3f1e933fdd761a01170d5c0c92d3472a4fa7ba45
3f1e933https://github.com/tmux-python/tmuxp/pull/926/commits/3f1e933fdd761a01170d5c0c92d3472a4fa7ba45
https://github.com/tony
builder: Use shutil.get_terminal_size()https://github.com/tmux-python/tmuxp/pull/926/commits/0777c3bbef652c4d4a595606f6d8987f686a08a2
0777c3bhttps://github.com/tmux-python/tmuxp/pull/926/commits/0777c3bbef652c4d4a595606f6d8987f686a08a2
https://docs.python.org/3/library/shutil.html#shutil.get_terminal_sizehttps://docs.python.org/3/library/shutil.html#shutil.get_terminal_size
https://docs.python.org/3/library/os.html#os.get_terminal_sizehttps://docs.python.org/3/library/os.html#os.get_terminal_size
https://github.com/tony
builder: Column and row size defaultshttps://github.com/tmux-python/tmuxp/pull/926/commits/63ac676d29d3be19ab7ae79e7866849ef764bde9
63ac676https://github.com/tmux-python/tmuxp/pull/926/commits/63ac676d29d3be19ab7ae79e7866849ef764bde9
https://github.com/tony
tonyhttps://github.com/tony
force-pushedhttps://github.com/tmux-python/tmuxp/compare/3f076f9437fb561d91e5a4011e61b3170ec6de59..07a45abe64853dca8199a7f62181fb508842e900
3f076f9https://github.com/tmux-python/tmuxp/commit/3f076f9437fb561d91e5a4011e61b3170ec6de59
07a45abhttps://github.com/tmux-python/tmuxp/commit/07a45abe64853dca8199a7f62181fb508842e900
Compare https://github.com/tmux-python/tmuxp/compare/3f076f9437fb561d91e5a4011e61b3170ec6de59..07a45abe64853dca8199a7f62181fb508842e900
April 7, 2024 16:44https://github.com/tmux-python/tmuxp/pull/926#event-12384547891
Layout broken #737 https://github.com/tmux-python/tmuxp/issues/737
WorkspaceBuilder creates "main-horizontal" layout with a very thin main pane #667 https://github.com/tmux-python/tmuxp/issues/667
Layout is broken with 1.9.2 #704 https://github.com/tmux-python/tmuxp/issues/704
https://github.com/tony
tonyhttps://github.com/tony
April 7, 2024 22:35https://github.com/tmux-python/tmuxp/pull/926#event-12385283037
tonyhttps://github.com/tony
April 7, 2024 17:36https://github.com/tmux-python/tmuxp/pull/926#commits-pushed-8df1621
https://github.com/tony
py(builder): Remove DEFAULT_SIZE (unused variable)https://github.com/tmux-python/tmuxp/pull/926/commits/8df1621951fb009ea5be8a7067f507236e3e30e1
8df1621https://github.com/tmux-python/tmuxp/pull/926/commits/8df1621951fb009ea5be8a7067f507236e3e30e1
https://github.com/tony
builder: TMUXP_DETECT_TERMINAL_SIZE=0 to disable new behaviorhttps://github.com/tmux-python/tmuxp/pull/926/commits/8e80c6edae926897bb7995c40ee415b01158c263
8e80c6ehttps://github.com/tmux-python/tmuxp/pull/926/commits/8e80c6edae926897bb7995c40ee415b01158c263
https://github.com/tony
test(builder): Fixes for size limitshttps://github.com/tmux-python/tmuxp/pull/926/commits/498e6fab26adbdc184ae35e87f94d7a9de39931a
498e6fahttps://github.com/tmux-python/tmuxp/pull/926/commits/498e6fab26adbdc184ae35e87f94d7a9de39931a
https://github.com/tony
cli(load): Remove set_layout_hook()https://github.com/tmux-python/tmuxp/pull/926/commits/fdda3d7b08585745ae3f4f67f7b85177c4a23593
fdda3d7https://github.com/tmux-python/tmuxp/pull/926/commits/fdda3d7b08585745ae3f4f67f7b85177c4a23593
https://github.com/tony
tests(builder): Remove unused setenvhttps://github.com/tmux-python/tmuxp/pull/926/commits/93b368bfb8cd16bf8f02b3cfe45087856c5d8096
93b368bhttps://github.com/tmux-python/tmuxp/pull/926/commits/93b368bfb8cd16bf8f02b3cfe45087856c5d8096
https://github.com/tony
docs(CHANGES): Note builder terminal size detectionhttps://github.com/tmux-python/tmuxp/pull/926/commits/5f91934e09a36fecc7e00d34fbef259d88f0413a
5f91934https://github.com/tmux-python/tmuxp/pull/926/commits/5f91934e09a36fecc7e00d34fbef259d88f0413a
https://github.com/tony
docs(examples): main-pane-height percentagehttps://github.com/tmux-python/tmuxp/pull/926/commits/cd5d114d1816684e06aeabe42ed7c262f55a4594
cd5d114https://github.com/tmux-python/tmuxp/pull/926/commits/cd5d114d1816684e06aeabe42ed7c262f55a4594
https://github.com/tony
tonyhttps://github.com/tony
force-pushedhttps://github.com/tmux-python/tmuxp/compare/7396257098da6cc2919465bb37caecb06f44e56a..cd5d114d1816684e06aeabe42ed7c262f55a4594
7396257https://github.com/tmux-python/tmuxp/commit/7396257098da6cc2919465bb37caecb06f44e56a
cd5d114https://github.com/tmux-python/tmuxp/commit/cd5d114d1816684e06aeabe42ed7c262f55a4594
Compare https://github.com/tmux-python/tmuxp/compare/7396257098da6cc2919465bb37caecb06f44e56a..cd5d114d1816684e06aeabe42ed7c262f55a4594
April 7, 2024 22:36https://github.com/tmux-python/tmuxp/pull/926#event-12385283870
https://github.com/tony
tonyhttps://github.com/tony
913ca89https://github.com/tmux-python/tmuxp/commit/913ca896676b4d18a0c69f73b8635f7818bd12d1
Apr 7, 2024https://github.com/tmux-python/tmuxp/pull/926#event-12385291925
tonyhttps://github.com/tony
Apr 7, 2024 https://github.com/tmux-python/tmuxp/pull/926#ref-commit-ec52d16
https://github.com/tony
Tag v1.46.0a0 (alpha 0, withhttps://github.com/tmux-python/tmuxp/commit/ec52d16f06316a50aef453c0e10c60744bf8aefe
#926https://github.com/tmux-python/tmuxp/pull/926
terminal detection)https://github.com/tmux-python/tmuxp/commit/ec52d16f06316a50aef453c0e10c60744bf8aefe
ec52d16https://github.com/tmux-python/tmuxp/commit/ec52d16f06316a50aef453c0e10c60744bf8aefe
https://github.com/tony
tonyhttps://github.com/tony
April 7, 2024 22:42https://github.com/tmux-python/tmuxp/pull/926#event-12385293850
tonyhttps://github.com/tony
Apr 13, 2024 https://github.com/tmux-python/tmuxp/pull/926#ref-commit-c23aa92
https://github.com/tony
Tag v1.46.0 (fix fromhttps://github.com/tmux-python/tmuxp/commit/c23aa92293f28df4df12cb465a5e24b3f18f6691
#926https://github.com/tmux-python/tmuxp/pull/926
)https://github.com/tmux-python/tmuxp/commit/c23aa92293f28df4df12cb465a5e24b3f18f6691
c23aa92https://github.com/tmux-python/tmuxp/commit/c23aa92293f28df4df12cb465a5e24b3f18f6691
https://github.co/hiddenchars
https://github.com/tmux-python/tmuxp/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftmux-python%2Ftmuxp%2Fpull%2F926
Please reload this pagehttps://github.com/tmux-python/tmuxp/pull/926
Please reload this pagehttps://github.com/tmux-python/tmuxp/pull/926
https://github.com/tony
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.