| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d6591949-1464-988a-4ef2-c381783e5ccb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C3C8:1D18A:32D388:45775F:6B006BF7 |
| html-safe-nonce | 660b6a414cfb1a1418780a0ba96742b96e85b202d8be03444cbed6788d38e81f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDM0M4OjFEMThBOjMyRDM4ODo0NTc3NUY6NkIwMDZCRjciLCJ2aXNpdG9yX2lkIjoiMzYzNzAyMzk4NTAyNTE4MjcxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 56de416fbf8918c96378f7e50fbe5c9b4e34e7e7b2c02030864c47a0362af34f |
| hovercard-subject-tag | pull_request:1810895221 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/tmux-python/tmuxp/926/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ef85b1acedd0d6720d054cc8676c6612d7133ceb9ee7f5d1bd6d44a11d67bdee/tmux-python/tmuxp/pull/926 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ef85b1acedd0d6720d054cc8676c6612d7133ceb9ee7f5d1bd6d44a11d67bdee/tmux-python/tmuxp/pull/926 |
| og:image:alt | in re: #667, #704, #737
WarningThis would definitely be breaking behavior.
Test instructions
Latest (1.46.0a0):
pipx install --suffix=@builder-sizes 'tmuxp >= 1.46.0a0'
Outdated:
pipx i... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tony |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6527e91c60c0b29d16606ff32ac5df8ecdc37a2a62205ea057a14d7762c870fa |
| turbo-cache-control | no-cache |
| go-import | github.com/tmux-python/tmuxp git https://github.com/tmux-python/tmuxp.git |
| octolytics-dimension-user_id | 37234308 |
| octolytics-dimension-user_login | tmux-python |
| octolytics-dimension-repository_id | 12398170 |
| octolytics-dimension-repository_nwo | tmux-python/tmuxp |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 12398170 |
| octolytics-dimension-repository_network_root_nwo | tmux-python/tmuxp |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 46f1cd2ae3cd8ae1a81019b5d619742e76f13bbd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/tmux-python/tmuxp/pull/926#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftmux-python%2Ftmuxp%2Fpull%2F926 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftmux-python%2Ftmuxp%2Fpull%2F926 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=tmux-python%2Ftmuxp |
| Reload | https://github.com/tmux-python/tmuxp/pull/926 |
| Reload | https://github.com/tmux-python/tmuxp/pull/926 |
| Reload | https://github.com/tmux-python/tmuxp/pull/926 |
| tmux-python | https://github.com/tmux-python |
| tmuxp | https://github.com/tmux-python/tmuxp |
| Code | https://github.com/tmux-python/tmuxp |
| Issues113 (113) | https://github.com/tmux-python/tmuxp/issues |
| Pull requests29 (29) | https://github.com/tmux-python/tmuxp/pulls |
| Discussions | https://github.com/tmux-python/tmuxp/discussions |
| Actions | https://github.com/tmux-python/tmuxp/actions |
| Security and quality | https://github.com/tmux-python/tmuxp/security |
| Insights | https://github.com/tmux-python/tmuxp/insights |
| https://github.com/tmux-python/tmuxp |
| tony | https://github.com/tony |
| master | https://github.com/tmux-python/tmuxp/tree/master |
| builder-sizes | https://github.com/tmux-python/tmuxp/tree/builder-sizes |
| Conversation | https://github.com/tmux-python/tmuxp/pull/926 |
| Commits10 (10) | https://github.com/tmux-python/tmuxp/pull/926/commits |
| Checks | https://github.com/tmux-python/tmuxp/pull/926/checks |
| Files changed | https://github.com/tmux-python/tmuxp/pull/926/files |
| Builder: Use shutil.get_terminal_size() | https://github.com/tmux-python/tmuxp/pull/926#top |
| tony | https://github.com/tony |
| master | https://github.com/tmux-python/tmuxp/tree/master |
| builder-sizes | https://github.com/tmux-python/tmuxp/tree/builder-sizes |
|
| https://github.com/tony |
| tony | https://github.com/tony |
| Apr 7, 2024 | https://github.com/tmux-python/tmuxp/pull/926#issue-2229833378 |
| Please reload this page | https://github.com/tmux-python/tmuxp/pull/926 |
| #667 | https://github.com/tmux-python/tmuxp/issues/667 |
| #704 | https://github.com/tmux-python/tmuxp/issues/704 |
| #737 | https://github.com/tmux-python/tmuxp/issues/737 |
| 1.46.0a0 | https://pypi.org/project/tmuxp/1.46.0a0/ |
| https://private-user-images.githubusercontent.com/26336/320300355-4ed06713-d9db-4b4d-97dc-474ebe1e8487.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTUxOTAwNTEsIm5iZiI6MTc5NTE4OTc1MSwicGF0aCI6Ii8yNjMzNi8zMjAzMDAzNTUtNGVkMDY3MTMtZDlkYi00YjRkLTk3ZGMtNDc0ZWJlMWU4NDg3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjExMjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYxMTIwVDE1NDkxMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ5MGQ5Y2Q2MDc5MmYwZGRhOTVhYTc3ODA3NmUyNGQzYjE5ZDRlNGE2YmU5YzQ5YzhlODg4OWQ5MmY1ZGJiMDQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.MqOaflFvgNDbmb5x9cag0oqROZDUAs3KL2EDdDajbWg |
| shutil.get_terminal_size | https://docs.python.org/3/library/shutil.html#shutil.get_terminal_size |
| Please reload this page | https://github.com/tmux-python/tmuxp/pull/926 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Apr 7, 2024 | https://github.com/tmux-python/tmuxp/pull/926#issuecomment-2041522422 |
| Please reload this page | https://github.com/tmux-python/tmuxp/pull/926 |
| Codecov | https://app.codecov.io/gh/tmux-python/tmuxp/pull/926?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tmux-python |
| (f4b392c) | https://app.codecov.io/gh/tmux-python/tmuxp/commit/f4b392c070a391dda882875dd6e96b142a54474a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tmux-python |
| (cd5d114) | https://app.codecov.io/gh/tmux-python/tmuxp/pull/926?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tmux-python |
| Files | https://app.codecov.io/gh/tmux-python/tmuxp/pull/926?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tmux-python |
| src/tmuxp/workspace/builder.py | https://app.codecov.io/gh/tmux-python/tmuxp/pull/926?src=pr&el=tree&filepath=src%2Ftmuxp%2Fworkspace%2Fbuilder.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tmux-python#diff-c3JjL3RtdXhwL3dvcmtzcGFjZS9idWlsZGVyLnB5 |
| 0 Missing and 1 partial ⚠️ | https://app.codecov.io/gh/tmux-python/tmuxp/pull/926?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tmux-python |
| ☔ View full report in Codecov by Sentry | https://app.codecov.io/gh/tmux-python/tmuxp/pull/926?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tmux-python |
| Share it here | https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tmux-python |
| Please reload this page | https://github.com/tmux-python/tmuxp/pull/926 |
| tony | https://github.com/tony |
| April 7, 2024 11:31 | https://github.com/tmux-python/tmuxp/pull/926#commits-pushed-3f1e933 |
|
| https://github.com/tony |
| .tmuxp.{json,yaml}: Use percent for main-pane-height | https://github.com/tmux-python/tmuxp/pull/926/commits/3f1e933fdd761a01170d5c0c92d3472a4fa7ba45 |
| 3f1e933 | https://github.com/tmux-python/tmuxp/pull/926/commits/3f1e933fdd761a01170d5c0c92d3472a4fa7ba45 |
|
| https://github.com/tony |
| builder: Use shutil.get_terminal_size() | https://github.com/tmux-python/tmuxp/pull/926/commits/0777c3bbef652c4d4a595606f6d8987f686a08a2 |
| 0777c3b | https://github.com/tmux-python/tmuxp/pull/926/commits/0777c3bbef652c4d4a595606f6d8987f686a08a2 |
| https://docs.python.org/3/library/shutil.html#shutil.get_terminal_size | https://docs.python.org/3/library/shutil.html#shutil.get_terminal_size |
| https://docs.python.org/3/library/os.html#os.get_terminal_size | https://docs.python.org/3/library/os.html#os.get_terminal_size |
|
| https://github.com/tony |
| builder: Column and row size defaults | https://github.com/tmux-python/tmuxp/pull/926/commits/63ac676d29d3be19ab7ae79e7866849ef764bde9 |
| 63ac676 | https://github.com/tmux-python/tmuxp/pull/926/commits/63ac676d29d3be19ab7ae79e7866849ef764bde9 |
| https://github.com/tony |
| tony | https://github.com/tony |
| force-pushed | https://github.com/tmux-python/tmuxp/compare/3f076f9437fb561d91e5a4011e61b3170ec6de59..07a45abe64853dca8199a7f62181fb508842e900 |
| 3f076f9 | https://github.com/tmux-python/tmuxp/commit/3f076f9437fb561d91e5a4011e61b3170ec6de59 |
| 07a45ab | https://github.com/tmux-python/tmuxp/commit/07a45abe64853dca8199a7f62181fb508842e900 |
|
Compare
| https://github.com/tmux-python/tmuxp/compare/3f076f9437fb561d91e5a4011e61b3170ec6de59..07a45abe64853dca8199a7f62181fb508842e900 |
| April 7, 2024 16:44 | https://github.com/tmux-python/tmuxp/pull/926#event-12384547891 |
|
Layout broken
#737
| https://github.com/tmux-python/tmuxp/issues/737 |
|
WorkspaceBuilder creates "main-horizontal" layout with a very thin main pane
#667
| https://github.com/tmux-python/tmuxp/issues/667 |
|
Layout is broken with 1.9.2
#704
| https://github.com/tmux-python/tmuxp/issues/704 |
| https://github.com/tony |
| tony | https://github.com/tony |
| April 7, 2024 22:35 | https://github.com/tmux-python/tmuxp/pull/926#event-12385283037 |
| tony | https://github.com/tony |
| April 7, 2024 17:36 | https://github.com/tmux-python/tmuxp/pull/926#commits-pushed-8df1621 |
|
| https://github.com/tony |
| py(builder): Remove DEFAULT_SIZE (unused variable) | https://github.com/tmux-python/tmuxp/pull/926/commits/8df1621951fb009ea5be8a7067f507236e3e30e1 |
| 8df1621 | https://github.com/tmux-python/tmuxp/pull/926/commits/8df1621951fb009ea5be8a7067f507236e3e30e1 |
|
| https://github.com/tony |
| builder: TMUXP_DETECT_TERMINAL_SIZE=0 to disable new behavior | https://github.com/tmux-python/tmuxp/pull/926/commits/8e80c6edae926897bb7995c40ee415b01158c263 |
| 8e80c6e | https://github.com/tmux-python/tmuxp/pull/926/commits/8e80c6edae926897bb7995c40ee415b01158c263 |
|
| https://github.com/tony |
| test(builder): Fixes for size limits | https://github.com/tmux-python/tmuxp/pull/926/commits/498e6fab26adbdc184ae35e87f94d7a9de39931a |
| 498e6fa | https://github.com/tmux-python/tmuxp/pull/926/commits/498e6fab26adbdc184ae35e87f94d7a9de39931a |
|
| https://github.com/tony |
| cli(load): Remove set_layout_hook() | https://github.com/tmux-python/tmuxp/pull/926/commits/fdda3d7b08585745ae3f4f67f7b85177c4a23593 |
| fdda3d7 | https://github.com/tmux-python/tmuxp/pull/926/commits/fdda3d7b08585745ae3f4f67f7b85177c4a23593 |
|
| https://github.com/tony |
| tests(builder): Remove unused setenv | https://github.com/tmux-python/tmuxp/pull/926/commits/93b368bfb8cd16bf8f02b3cfe45087856c5d8096 |
| 93b368b | https://github.com/tmux-python/tmuxp/pull/926/commits/93b368bfb8cd16bf8f02b3cfe45087856c5d8096 |
|
| https://github.com/tony |
| docs(CHANGES): Note builder terminal size detection | https://github.com/tmux-python/tmuxp/pull/926/commits/5f91934e09a36fecc7e00d34fbef259d88f0413a |
| 5f91934 | https://github.com/tmux-python/tmuxp/pull/926/commits/5f91934e09a36fecc7e00d34fbef259d88f0413a |
|
| https://github.com/tony |
| docs(examples): main-pane-height percentage | https://github.com/tmux-python/tmuxp/pull/926/commits/cd5d114d1816684e06aeabe42ed7c262f55a4594 |
| cd5d114 | https://github.com/tmux-python/tmuxp/pull/926/commits/cd5d114d1816684e06aeabe42ed7c262f55a4594 |
| https://github.com/tony |
| tony | https://github.com/tony |
| force-pushed | https://github.com/tmux-python/tmuxp/compare/7396257098da6cc2919465bb37caecb06f44e56a..cd5d114d1816684e06aeabe42ed7c262f55a4594 |
| 7396257 | https://github.com/tmux-python/tmuxp/commit/7396257098da6cc2919465bb37caecb06f44e56a |
| cd5d114 | https://github.com/tmux-python/tmuxp/commit/cd5d114d1816684e06aeabe42ed7c262f55a4594 |
|
Compare
| https://github.com/tmux-python/tmuxp/compare/7396257098da6cc2919465bb37caecb06f44e56a..cd5d114d1816684e06aeabe42ed7c262f55a4594 |
| April 7, 2024 22:36 | https://github.com/tmux-python/tmuxp/pull/926#event-12385283870 |
| https://github.com/tony |
| tony | https://github.com/tony |
| 913ca89 | https://github.com/tmux-python/tmuxp/commit/913ca896676b4d18a0c69f73b8635f7818bd12d1 |
| Apr 7, 2024 | https://github.com/tmux-python/tmuxp/pull/926#event-12385291925 |
| tony | https://github.com/tony |
|
Apr 7, 2024
| https://github.com/tmux-python/tmuxp/pull/926#ref-commit-ec52d16 |
|
| https://github.com/tony |
| Tag v1.46.0a0 (alpha 0, with | https://github.com/tmux-python/tmuxp/commit/ec52d16f06316a50aef453c0e10c60744bf8aefe |
| #926 | https://github.com/tmux-python/tmuxp/pull/926 |
| terminal detection) | https://github.com/tmux-python/tmuxp/commit/ec52d16f06316a50aef453c0e10c60744bf8aefe |
| ec52d16 | https://github.com/tmux-python/tmuxp/commit/ec52d16f06316a50aef453c0e10c60744bf8aefe |
| https://github.com/tony |
| tony | https://github.com/tony |
| April 7, 2024 22:42 | https://github.com/tmux-python/tmuxp/pull/926#event-12385293850 |
| tony | https://github.com/tony |
|
Apr 13, 2024
| https://github.com/tmux-python/tmuxp/pull/926#ref-commit-c23aa92 |
|
| https://github.com/tony |
| Tag v1.46.0 (fix from | https://github.com/tmux-python/tmuxp/commit/c23aa92293f28df4df12cb465a5e24b3f18f6691 |
| #926 | https://github.com/tmux-python/tmuxp/pull/926 |
| ) | https://github.com/tmux-python/tmuxp/commit/c23aa92293f28df4df12cb465a5e24b3f18f6691 |
| c23aa92 | https://github.com/tmux-python/tmuxp/commit/c23aa92293f28df4df12cb465a5e24b3f18f6691 |
| https://github.co/hiddenchars |
| https://github.com/tmux-python/tmuxp/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftmux-python%2Ftmuxp%2Fpull%2F926 |
| Please reload this page | https://github.com/tmux-python/tmuxp/pull/926 |
| Please reload this page | https://github.com/tmux-python/tmuxp/pull/926 |
|
| https://github.com/tony |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |