René's URL Explorer Experiment


Title: Pass start_directory to new_session when building a session by heindsight · Pull Request #829 · tmux-python/tmuxp · GitHub

Open Graph Title: Pass start_directory to new_session when building a session by heindsight · Pull Request #829 · tmux-python/tmuxp

X Title: Pass start_directory to new_session when building a session by heindsight · Pull Request #829 · tmux-python/tmuxp

Description: This fixes a bug introduced in 2a4714e76b3a85b3391b05413f36623bcb1493f9 (#809) whereby the start_directory session config was no longer passed to the new_session method when building a session. This resulted in the session working directory is not being set correctly, so new windows/panes created in the session, would not start in the expected directory.

Open Graph Description: This fixes a bug introduced in 2a4714e76b3a85b3391b05413f36623bcb1493f9 (#809) whereby the start_directory session config was no longer passed to the new_session method when building a session. Thi...

X Description: This fixes a bug introduced in 2a4714e76b3a85b3391b05413f36623bcb1493f9 (#809) whereby the start_directory session config was no longer passed to the new_session method when building a session. Thi...

Opengraph URL: https://github.com/tmux-python/tmuxp/pull/829

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a8050367-82c9-2503-7020-f6f552df845e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD8E4:62828:7D4669:AAE53C:6B007651
html-safe-nonce9fab43117acf2b0e00553b80b3c08e62b4567246b909a0ad28d54fd00c81728e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOEU0OjYyODI4OjdENDY2OTpBQUU1M0M6NkIwMDc2NTEiLCJ2aXNpdG9yX2lkIjoiMTI1NjAxMDEzNjA3NDM1MjIwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace9ac1fb9b8c6d6d9a9b9efb3e0df097fc7e80ce2278cca7b04651e46555c525c
hovercard-subject-tagpull_request:1073580946
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/tmux-python/tmuxp/pull/829/files
twitter:imagehttps://avatars.githubusercontent.com/u/3329919?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3329919?s=400&v=4
og:image:altThis fixes a bug introduced in 2a4714e76b3a85b3391b05413f36623bcb1493f9 (#809) whereby the start_directory session config was no longer passed to the new_session method when building a session. Thi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None75c2b65dd205f26961d0c29afed1a8d0bb7cca9f05780571dfd1ef93eb539d16
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/tmux-python/tmuxp git https://github.com/tmux-python/tmuxp.git
octolytics-dimension-user_id37234308
octolytics-dimension-user_logintmux-python
octolytics-dimension-repository_id12398170
octolytics-dimension-repository_nwotmux-python/tmuxp
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id12398170
octolytics-dimension-repository_network_root_nwotmux-python/tmuxp
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84e563eb4b55f8fa102f325f117533cee9e3df4a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/tmux-python/tmuxp/pull/829/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftmux-python%2Ftmuxp%2Fpull%2F829%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftmux-python%2Ftmuxp%2Fpull%2F829%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=tmux-python%2Ftmuxp
Reloadhttps://github.com/tmux-python/tmuxp/pull/829/files
Reloadhttps://github.com/tmux-python/tmuxp/pull/829/files
Reloadhttps://github.com/tmux-python/tmuxp/pull/829/files
tmux-pythonhttps://github.com/tmux-python
tmuxphttps://github.com/tmux-python/tmuxp
Codehttps://github.com/tmux-python/tmuxp
Issues113 (113)https://github.com/tmux-python/tmuxp/issues
Pull requests29 (29)https://github.com/tmux-python/tmuxp/pulls
Discussionshttps://github.com/tmux-python/tmuxp/discussions
Actionshttps://github.com/tmux-python/tmuxp/actions
Security and qualityhttps://github.com/tmux-python/tmuxp/security
Insightshttps://github.com/tmux-python/tmuxp/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ftmux-python%2Ftmuxp%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftmux-python%2Ftmuxp%2Fissues%2Fnew%2Fchoose
tonyhttps://github.com/tony
tmux-python:masterhttps://github.com/tmux-python/tmuxp/tree/master
Conversation 8 https://github.com/tmux-python/tmuxp/pull/829
Commits 2 https://github.com/tmux-python/tmuxp/pull/829/commits
Checks 0 https://github.com/tmux-python/tmuxp/pull/829/checks
Files changed https://github.com/tmux-python/tmuxp/pull/829/files
Please reload this pagehttps://github.com/tmux-python/tmuxp/pull/829/files
Pass start_directory to new_session when building a session https://github.com/tmux-python/tmuxp/pull/829/files#top
Show all changes 2 commits https://github.com/tmux-python/tmuxp/pull/829/files
bb5869f Pass start_directory to new_session when building a session heindsight Oct 1, 2022 https://github.com/tmux-python/tmuxp/pull/829/commits/bb5869fe2afcaf2a396443107dda8c4820fc9a0c
9e36d41 Merge branch 'master' into fix-start-dir heindsight Oct 1, 2022 https://github.com/tmux-python/tmuxp/pull/829/commits/9e36d41ede3cb9922cae73ae57d4bc92de567956
Clear filters https://github.com/tmux-python/tmuxp/pull/829/files
Please reload this pagehttps://github.com/tmux-python/tmuxp/pull/829/files
Please reload this pagehttps://github.com/tmux-python/tmuxp/pull/829/files
workspacebuilder.py https://github.com/tmux-python/tmuxp/pull/829/files#diff-a151220311e0855ccf5ead5edffad996a7946290de98bcda5d07a97a1c18c797
start_directory_session_path.yaml https://github.com/tmux-python/tmuxp/pull/829/files#diff-7117e0146be2e139b5d60a235da723ce1bd7a2f2394fdc5bb604582d0cec73e6
test_workspacebuilder.py https://github.com/tmux-python/tmuxp/pull/829/files#diff-3e48381360600bc6bc310f9ede3e4f8cc1af7d8b3db57587c893686e250966da
src/tmuxp/workspacebuilder.pyhttps://github.com/tmux-python/tmuxp/pull/829/files#diff-a151220311e0855ccf5ead5edffad996a7946290de98bcda5d07a97a1c18c797
View file https://github.com/tmux-python/tmuxp/blob/9e36d41ede3cb9922cae73ae57d4bc92de567956/src/tmuxp/workspacebuilder.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/tmux-python/tmuxp/pull/829/{{ revealButtonHref }}
https://github.com/tmux-python/tmuxp/pull/829/files#diff-a151220311e0855ccf5ead5edffad996a7946290de98bcda5d07a97a1c18c797
https://github.com/tmux-python/tmuxp/pull/829/files#diff-a151220311e0855ccf5ead5edffad996a7946290de98bcda5d07a97a1c18c797
tests/fixtures/workspacebuilder/start_directory_session_path.yamlhttps://github.com/tmux-python/tmuxp/pull/829/files#diff-7117e0146be2e139b5d60a235da723ce1bd7a2f2394fdc5bb604582d0cec73e6
View file https://github.com/tmux-python/tmuxp/blob/9e36d41ede3cb9922cae73ae57d4bc92de567956/tests/fixtures/workspacebuilder/start_directory_session_path.yaml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/tmux-python/tmuxp/pull/829/{{ revealButtonHref }}
tests/test_workspacebuilder.pyhttps://github.com/tmux-python/tmuxp/pull/829/files#diff-3e48381360600bc6bc310f9ede3e4f8cc1af7d8b3db57587c893686e250966da
View file https://github.com/tmux-python/tmuxp/blob/9e36d41ede3cb9922cae73ae57d4bc92de567956/tests/test_workspacebuilder.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/tmux-python/tmuxp/pull/829/{{ revealButtonHref }}
https://github.com/tmux-python/tmuxp/pull/829/files#diff-3e48381360600bc6bc310f9ede3e4f8cc1af7d8b3db57587c893686e250966da
https://github.com/tmux-python/tmuxp/pull/829/files#diff-3e48381360600bc6bc310f9ede3e4f8cc1af7d8b3db57587c893686e250966da
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.