René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Cython version leaks all handles","articleBody":"In the Cython version, the handles are closed in `__del__` both for DTraceConsumer and DTraceContinuousConsumer (used by DTraceConsumerThread). However, these are extension types, and Cython [does not use `__del__` for extension types][1] (for whatever reason), so they will never be called (the explicit `del self.consumer` in DTraceConsumerThread's destructor, which *is* called as it's a normal Python object, just ensures the DTraceContinuousConsumer gets deallocated, but the consumer's `__del__` still won't be called). I believe using `__dealloc__` for the two extension classes would work (though `handle` must be checked for being non-null first).\r\n\r\nThis has also exposed a (minor) potential issue: with Cython, [`__init__` can end up being called multiple times][2], so technically `handle` could be initialised twice, leaking the old return from `dtrace_open`. To be truly correct, either `__init__` should guard against this, or `__cinit__` should be used instead, which will only ever be called once.\r\n\r\n[1]: http://docs.cython.org/en/latest/src/userguide/special_methods.html#finalization-method-dealloc\r\n[2]: http://docs.cython.org/en/latest/src/userguide/special_methods.html#initialisation-methods-cinit-and-init","author":{"url":"https://github.com/jrtc27","@type":"Person","name":"jrtc27"},"datePublished":"2017-11-07T01:04:00.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/8/python-dtrace/issues/8"}