Title: refactor sidechain writing function by mixmix · Pull Request #2 · tinySSB/python-client · GitHub
Open Graph Title: refactor sidechain writing function by mixmix · Pull Request #2 · tinySSB/python-client
X Title: refactor sidechain writing function by mixmix · Pull Request #2 · tinySSB/python-client
Description: I refactored this code on a call with @nanomonkey - we're using it to try and write a spec, and found it very hard to read in it's native state. This PR is opened so that we have a clearer reference for spec writing we have an example of what more accessible code looks like (IMO) comments grouping of code into more coherent chunks collecting related code putting white space in to aid reading 🔥 TODO before merge: write tests over this function (check they pass before + after) resolve duplication across simplechat + simplepub folders 😭
Open Graph Description: I refactored this code on a call with @nanomonkey - we're using it to try and write a spec, and found it very hard to read in it's native state. This PR is opened so that we have a clearer...
X Description: I refactored this code on a call with @nanomonkey - we're using it to try and write a spec, and found it very hard to read in it's native state. This PR is opened so that we have a...
Opengraph URL: https://github.com/tinySSB/python-client/pull/2
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:78740ba5-bd98-db33-5717-e6e6cce06dd2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E5BE:198664:27C72CC:36B79E8:6A60B0FA |
| html-safe-nonce | ecada7a44c52acc78f3b2170cce2cd8787eb2b2ea9b0634da29b5fa91da76e87 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNUJFOjE5ODY2NDoyN0M3MkNDOjM2Qjc5RTg6NkE2MEIwRkEiLCJ2aXNpdG9yX2lkIjoiNTY0NjEzNTc2MTEwNjQxNTg2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0931b88f2f4feff8c3c5773d022ee6ae562187f1973fada8b368691c2982c2a0 |
| hovercard-subject-tag | pull_request:2408144548 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/tinySSB/python-client/pull/2/files |
| twitter:image | https://avatars.githubusercontent.com/u/2665886?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/2665886?s=400&v=4 |
| og:image:alt | I refactored this code on a call with @nanomonkey - we're using it to try and write a spec, and found it very hard to read in it's native state. This PR is opened so that we have a clearer... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 35671f8a6946a7a2a81d51ae49f5465bdc5f925c23c9cb839206b24345dbe8d9 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/tinySSB/python-client git https://github.com/tinySSB/python-client.git |
| octolytics-dimension-user_id | 186508170 |
| octolytics-dimension-user_login | tinySSB |
| octolytics-dimension-repository_id | 920777587 |
| octolytics-dimension-repository_nwo | tinySSB/python-client |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 920777587 |
| octolytics-dimension-repository_network_root_nwo | tinySSB/python-client |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 746dc49090e6e3995bb502dce0f8807393e36eda |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width