Title: Incorrect minRunLength() computing minRun to be too small · Issue #33 · timsort/cpp-TimSort · GitHub
Open Graph Title: Incorrect minRunLength() computing minRun to be too small · Issue #33 · timsort/cpp-TimSort
X Title: Incorrect minRunLength() computing minRun to be too small · Issue #33 · timsort/cpp-TimSort
Description: The following line seems incorrect. Since MIN_MERGE is 32, the loop would end with n containing the 5 most significant bits instead of 6 most significant bits. Therefore, the function would return [0, 32], which is less than what Python ...
Open Graph Description: The following line seems incorrect. Since MIN_MERGE is 32, the loop would end with n containing the 5 most significant bits instead of 6 most significant bits. Therefore, the function would return ...
X Description: The following line seems incorrect. Since MIN_MERGE is 32, the loop would end with n containing the 5 most significant bits instead of 6 most significant bits. Therefore, the function would return ...
Opengraph URL: https://github.com/timsort/cpp-TimSort/issues/33
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Incorrect minRunLength() computing minRun to be too small","articleBody":"The [following line](https://github.com/timsort/cpp-TimSort/blob/298928ce37e2954956320e764a862b9b1dbc51a7/include/gfx/timsort.hpp#L174) seems incorrect.\r\n\r\nSince MIN_MERGE is 32, the loop would end with n containing the 5 most significant bits instead of 6 most significant bits.\r\nTherefore, the function would return [0, 32], which is less than what Python is doing [here](https://github.com/python/cpython/blob/a42759351bff7b07fa8bf2cece0088f8539721d1/Objects/listobject.c#L1983)\r\n\r\nThe Python detailed description of Timsort in the readme [here](http://svn.python.org/projects/python/trunk/Objects/listsort.txt) also corresponds to returning a size of [32, 64] when possible.\r\n","author":{"url":"https://github.com/CovetingEpiphany2152","@type":"Person","name":"CovetingEpiphany2152"},"datePublished":"2020-10-10T12:11:03.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/33/cpp-TimSort/issues/33"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:10f36e13-daf6-f03e-d54a-91924716b75b |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A4F4:C3FF9:2101E32:2F3F929:6A4BE499 |
| html-safe-nonce | b0705eb09eb9ff4a3d6451d8a6eaf187aece92422694be544b21bd18cac600a1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNEY0OkMzRkY5OjIxMDFFMzI6MkYzRjkyOTo2QTRCRTQ5OSIsInZpc2l0b3JfaWQiOiI0MTQzNzg3NTc1NzAwMzUwMTA1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7d3a356f9715d478207c22144fae738874f0f0bd05c9645f6f282406f9ce4ec4 |
| hovercard-subject-tag | issue:718606810 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/timsort/cpp-TimSort/33/issue_layout |
| twitter:image | https://opengraph.githubassets.com/d569704d45d4eae54b6eecf4840a6fd85ed511c364dd2f65ec72bae84f58b166/timsort/cpp-TimSort/issues/33 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d569704d45d4eae54b6eecf4840a6fd85ed511c364dd2f65ec72bae84f58b166/timsort/cpp-TimSort/issues/33 |
| og:image:alt | The following line seems incorrect. Since MIN_MERGE is 32, the loop would end with n containing the 5 most significant bits instead of 6 most significant bits. Therefore, the function would return ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | CovetingEpiphany2152 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0f5d3ba365b3985d75c32a5957c8635488d58dcf027ae6ae958eee7edaa306a2 |
| turbo-cache-control | no-preview |
| go-import | github.com/timsort/cpp-TimSort git https://github.com/timsort/cpp-TimSort.git |
| octolytics-dimension-user_id | 55249341 |
| octolytics-dimension-user_login | timsort |
| octolytics-dimension-repository_id | 2423322 |
| octolytics-dimension-repository_nwo | timsort/cpp-TimSort |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 2423322 |
| octolytics-dimension-repository_network_root_nwo | timsort/cpp-TimSort |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 253920ac2dc35b0849cca4633895f1f2e5f03051 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width