| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9b92a5ad-4358-427d-e8a2-1e1de43916bb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BFE4:3B1E25:1C4B21:29CE54:6AFC6B2C |
| html-safe-nonce | e0f538d23a097372e48b1a555dae34b6f8191541c7b3528d6044c69e4b055701 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRkU0OjNCMUUyNToxQzRCMjE6MjlDRTU0OjZBRkM2QjJDIiwidmlzaXRvcl9pZCI6IjM5NDc4MTEyMDcyOTI2NzY5MDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 15b075641967280e32b0180382cddabb708289416e4bfb5efdf8750d5b448806 |
| hovercard-subject-tag | pull_request:268897360 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/thesofproject/sof/1248/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/181c130d2c8f9eefe713861823d0d5ee199d4896d496389c2ad5356741a979c1/thesofproject/sof/pull/1248 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/181c130d2c8f9eefe713861823d0d5ee199d4896d496389c2ad5356741a979c1/thesofproject/sof/pull/1248 |
| og:image:alt | On specific Intel platforms, we have to use a private key which is not
shared with the rest of the world.
Extended xtensa-build-all.sh with an option, and pass the key path
explicitly to cmake.
Sig... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | plbossart |
| hostname | github.com |
| expected-hostname | github.com |
| None | 70a7e1972ba67881db0411d676e97455aa21c3f3dd866ccba1e1c32fb9c8a04e |
| turbo-cache-control | no-cache |
| go-import | github.com/thesofproject/sof git https://github.com/thesofproject/sof.git |
| octolytics-dimension-user_id | 39773507 |
| octolytics-dimension-user_login | thesofproject |
| octolytics-dimension-repository_id | 135623245 |
| octolytics-dimension-repository_nwo | thesofproject/sof |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135623245 |
| octolytics-dimension-repository_network_root_nwo | thesofproject/sof |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7de95a0365c2894414eb47078bb1a54e816fff50 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/thesofproject/sof/pull/1248#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fthesofproject%2Fsof%2Fpull%2F1248 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fthesofproject%2Fsof%2Fpull%2F1248 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=thesofproject%2Fsof |
| Reload | https://github.com/thesofproject/sof/pull/1248 |
| Reload | https://github.com/thesofproject/sof/pull/1248 |
| Reload | https://github.com/thesofproject/sof/pull/1248 |
| thesofproject | https://github.com/thesofproject |
| sof | https://github.com/thesofproject/sof |
| Code | https://github.com/thesofproject/sof |
| Issues87 (87) | https://github.com/thesofproject/sof/issues |
| Pull requests130 (130) | https://github.com/thesofproject/sof/pulls |
| Discussions | https://github.com/thesofproject/sof/discussions |
| Actions | https://github.com/thesofproject/sof/actions |
| Projects | https://github.com/thesofproject/sof/projects |
| Security and quality | https://github.com/thesofproject/sof/security |
| Insights | https://github.com/thesofproject/sof/pulse |
| https://github.com/thesofproject/sof |
| tlauda | https://github.com/tlauda |
| thesofproject:master | https://github.com/thesofproject/sof/tree/master |
| plbossart:fix/private-key | https://github.com/plbossart/sof/tree/fix/private-key |
| Conversation | https://github.com/thesofproject/sof/pull/1248 |
| Commits1 (1) | https://github.com/thesofproject/sof/pull/1248/commits |
| Checks | https://github.com/thesofproject/sof/pull/1248/checks |
| Files changed | https://github.com/thesofproject/sof/pull/1248/files |
| CMake/rimage: add option to use out-of-tree private key | https://github.com/thesofproject/sof/pull/1248#top |
| tlauda | https://github.com/tlauda |
| thesofproject:master | https://github.com/thesofproject/sof/tree/master |
| plbossart:fix/private-key | https://github.com/plbossart/sof/tree/fix/private-key |
|
| https://github.com/plbossart |
| plbossart | https://github.com/plbossart |
| Apr 9, 2019 | https://github.com/thesofproject/sof/pull/1248#issue-431162985 |
| Please reload this page | https://github.com/thesofproject/sof/pull/1248 |
| https://github.com/plbossart |
| plbossart | https://github.com/plbossart |
| jajanusz | https://github.com/jajanusz |
| ranj063 | https://github.com/ranj063 |
| xiulipan | https://github.com/xiulipan |
| April 9, 2019 19:57 | https://github.com/thesofproject/sof/pull/1248#event-2264041916 |
| https://github.com/jajanusz |
| jajanusz | https://github.com/jajanusz |
|
Apr 9, 2019
| https://github.com/thesofproject/sof/pull/1248#pullrequestreview-224625711 |
|
View reviewed changes
| https://github.com/thesofproject/sof/pull/1248/files |
| jajanusz | https://github.com/jajanusz |
| https://github.com/thesofproject/sof/pull/1248#pullrequestreview-224625711 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #1239 | https://github.com/thesofproject/sof/pull/1239 |
| #1240 | https://github.com/thesofproject/sof/pull/1240 |
| Please reload this page | https://github.com/thesofproject/sof/pull/1248 |
| src/arch/xtensa/CMakeLists.txt | https://github.com/thesofproject/sof/pull/1248/files#diff-683eb297c9345deed52929e9f3bb890b17f919d27cc4689cb72bc78fb7b210d8 |
| Please reload this page | https://github.com/thesofproject/sof/pull/1248 |
| scripts/xtensa-build-all.sh | https://github.com/thesofproject/sof/pull/1248/files#diff-d8100c681a5485d790927496fcd13f2d866a44342d234816f63c613bea3a5261 |
| Please reload this page | https://github.com/thesofproject/sof/pull/1248 |
|
| https://github.com/plbossart |
| CMake/rimage: add option to use out-of-tree private key | https://github.com/thesofproject/sof/pull/1248/commits/7f03c8462b5e00a9e8a6f641bb831cd981ab8702 |
| 7f03c84 | https://github.com/thesofproject/sof/pull/1248/commits/7f03c8462b5e00a9e8a6f641bb831cd981ab8702 |
| https://github.com/plbossart |
| plbossart | https://github.com/plbossart |
| force-pushed | https://github.com/thesofproject/sof/compare/da9b685c27e12ba62a29be842363f75f70f3121e..7f03c8462b5e00a9e8a6f641bb831cd981ab8702 |
| da9b685 | https://github.com/thesofproject/sof/commit/da9b685c27e12ba62a29be842363f75f70f3121e |
| 7f03c84 | https://github.com/thesofproject/sof/commit/7f03c8462b5e00a9e8a6f641bb831cd981ab8702 |
|
Compare
| https://github.com/thesofproject/sof/compare/da9b685c27e12ba62a29be842363f75f70f3121e..7f03c8462b5e00a9e8a6f641bb831cd981ab8702 |
| April 9, 2019 21:54 | https://github.com/thesofproject/sof/pull/1248#event-2264342226 |
| https://github.com/plbossart |
| plbossart | https://github.com/plbossart |
| jajanusz | https://github.com/jajanusz |
| April 9, 2019 21:54 | https://github.com/thesofproject/sof/pull/1248#event-2264342707 |
| https://github.com/jajanusz |
| jajanusz | https://github.com/jajanusz |
|
Apr 9, 2019
| https://github.com/thesofproject/sof/pull/1248#pullrequestreview-224682895 |
|
View reviewed changes
| https://github.com/thesofproject/sof/pull/1248/files/7f03c8462b5e00a9e8a6f641bb831cd981ab8702 |
| jajanusz | https://github.com/jajanusz |
| https://github.com/thesofproject/sof/pull/1248#pullrequestreview-224682895 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/thesofproject/sof/pull/1248 |
| https://github.com/xiulipan |
| xiulipan | https://github.com/xiulipan |
| Apr 10, 2019 | https://github.com/thesofproject/sof/pull/1248#issuecomment-481507155 |
| Please reload this page | https://github.com/thesofproject/sof/pull/1248 |
| https://github.com/jajanusz |
| jajanusz | https://github.com/jajanusz |
|
Apr 10, 2019
| https://github.com/thesofproject/sof/pull/1248#ref-pullrequest-430797315 |
|
cmake: enable CMake option to set key used for rimage
#1239
| https://github.com/thesofproject/sof/pull/1239 |
| https://github.com/thesofproject |
| thesofproject | https://github.com/thesofproject |
| sofci | https://github.com/sofci |
| Apr 10, 2019 | https://github.com/thesofproject/sof/pull/1248#event-2265668341 |
| https://github.com/tlauda |
| tlauda | https://github.com/tlauda |
|
Apr 10, 2019
| https://github.com/thesofproject/sof/pull/1248#pullrequestreview-224985223 |
|
View reviewed changes
| https://github.com/thesofproject/sof/pull/1248/files/7f03c8462b5e00a9e8a6f641bb831cd981ab8702 |
| https://github.com/tlauda |
| tlauda | https://github.com/tlauda |
| 826e361 | https://github.com/thesofproject/sof/commit/826e361e7a0c0d41cdf200ce16a62d734370b49e |
| Apr 10, 2019 | https://github.com/thesofproject/sof/pull/1248#event-2266174060 |
| https://github.com/jajanusz |
| jajanusz | https://github.com/jajanusz |
|
Apr 15, 2019
| https://github.com/thesofproject/sof/pull/1248#ref-issue-433226933 |
|
CMake arguments description: RIMAGE_IMR_TYPE, RIMAGE_PRIVATE_KEY
thesofproject/sof-docs#107
| https://github.com/thesofproject/sof-docs/issues/107 |
| https://github.com/wenqingfu |
| wenqingfu | https://github.com/wenqingfu |
|
Apr 16, 2019
| https://github.com/thesofproject/sof/pull/1248#ref-issue-430694788 |
|
[BUG] Cmake/rimage: cannot change default key used by rimage
#1238
| https://github.com/thesofproject/sof/issues/1238 |
| https://github.co/hiddenchars |
| https://github.com/thesofproject/sof/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fthesofproject%2Fsof%2Fpull%2F1248 |
|
| https://github.com/ranj063 |
|
ranj063
| https://github.com/ranj063 |
|
| https://github.com/xiulipan |
|
xiulipan
| https://github.com/xiulipan |
|
| https://github.com/tlauda |
|
tlauda
| https://github.com/tlauda |
|
| https://github.com/thesofproject/sof/pull/1248/files/7f03c8462b5e00a9e8a6f641bb831cd981ab8702 |
|
| https://github.com/jajanusz |
|
jajanusz
| https://github.com/jajanusz |
|
| https://github.com/thesofproject/sof/pull/1248/files/7f03c8462b5e00a9e8a6f641bb831cd981ab8702 |
| Please reload this page | https://github.com/thesofproject/sof/pull/1248 |
| Please reload this page | https://github.com/thesofproject/sof/pull/1248 |
|
| https://github.com/plbossart |
|
| https://github.com/xiulipan |
|
| https://github.com/tlauda |
|
| https://github.com/jajanusz |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |