René's URL Explorer Experiment


Title: feat: refactor network setup by mgorsk1 · Pull Request #678 · testcontainers/testcontainers-python · GitHub

Open Graph Title: feat: refactor network setup by mgorsk1 · Pull Request #678 · testcontainers/testcontainers-python

X Title: feat: refactor network setup by mgorsk1 · Pull Request #678 · testcontainers/testcontainers-python

Description: Testcontainers is a Python library that providing a friendly API to run Docker container. It is designed to create runtime environment to use during your automatic tests. - feat: refactor network setup by mgorsk1 · Pull Request #678 · testcontainers/testcontainers-python

Open Graph Description: fixes #645 - network should be attached as the container is started, not as a post-start action. This will make sure port binding and exposing works correctly.

X Description: fixes #645 - network should be attached as the container is started, not as a post-start action. This will make sure port binding and exposing works correctly.

Opengraph URL: https://github.com/testcontainers/testcontainers-python/pull/678

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:45d3f66e-6ecf-fae6-9274-69ddc908a688
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDCF8:2B6B99:B1F07C:F52D72:6A53A0BF
html-safe-noncefe5a76e4085b40a0df501043ca35b418797cddb6ed53269109482dc4a80eb3bf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0Y4OjJCNkI5OTpCMUYwN0M6RjUyRDcyOjZBNTNBMEJGIiwidmlzaXRvcl9pZCI6IjE4NjY2NjQ2NDc3MjMyOTQ5MTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8f68ce3b2f48ea2e4e77e61e23de19b9735cca87130ed2bfe55654612eb54791
hovercard-subject-tagpull_request:2016361057
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/testcontainers/testcontainers-python/678/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8389740c20ecdfb79b92c7a916b368bc24ccc859b4c61322dbfcef7f45536d63/testcontainers/testcontainers-python/pull/678
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8389740c20ecdfb79b92c7a916b368bc24ccc859b4c61322dbfcef7f45536d63/testcontainers/testcontainers-python/pull/678
og:image:altfixes #645 - network should be attached as the container is started, not as a post-start action. This will make sure port binding and exposing works correctly.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemgorsk1
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/testcontainers/testcontainers-python git https://github.com/testcontainers/testcontainers-python.git
octolytics-dimension-user_id13393021
octolytics-dimension-user_logintestcontainers
octolytics-dimension-repository_id85802819
octolytics-dimension-repository_nwotestcontainers/testcontainers-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id85802819
octolytics-dimension-repository_network_root_nwotestcontainers/testcontainers-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/testcontainers/testcontainers-python/pull/678#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftestcontainers%2Ftestcontainers-python%2Fpull%2F678
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftestcontainers%2Ftestcontainers-python%2Fpull%2F678
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=testcontainers%2Ftestcontainers-python
Reloadhttps://github.com/testcontainers/testcontainers-python/pull/678
Reloadhttps://github.com/testcontainers/testcontainers-python/pull/678
Reloadhttps://github.com/testcontainers/testcontainers-python/pull/678
Please reload this pagehttps://github.com/testcontainers/testcontainers-python/pull/678
testcontainers https://github.com/testcontainers
testcontainers-pythonhttps://github.com/testcontainers/testcontainers-python
Notifications https://github.com/login?return_to=%2Ftestcontainers%2Ftestcontainers-python
Fork 375 https://github.com/login?return_to=%2Ftestcontainers%2Ftestcontainers-python
Star 2.3k https://github.com/login?return_to=%2Ftestcontainers%2Ftestcontainers-python
Code https://github.com/testcontainers/testcontainers-python
Issues 131 https://github.com/testcontainers/testcontainers-python/issues
Pull requests 35 https://github.com/testcontainers/testcontainers-python/pulls
Discussions https://github.com/testcontainers/testcontainers-python/discussions
Actions https://github.com/testcontainers/testcontainers-python/actions
Security and quality 0 https://github.com/testcontainers/testcontainers-python/security
Insights https://github.com/testcontainers/testcontainers-python/pulse
Code https://github.com/testcontainers/testcontainers-python
Issues https://github.com/testcontainers/testcontainers-python/issues
Pull requests https://github.com/testcontainers/testcontainers-python/pulls
Discussions https://github.com/testcontainers/testcontainers-python/discussions
Actions https://github.com/testcontainers/testcontainers-python/actions
Security and quality https://github.com/testcontainers/testcontainers-python/security
Insights https://github.com/testcontainers/testcontainers-python/pulse
alexanderankinhttps://github.com/alexanderankin
testcontainers:mainhttps://github.com/testcontainers/testcontainers-python/tree/main
mgorsk1:feat/645-fix-network-port-mappinghttps://github.com/mgorsk1/testcontainers-python/tree/feat/645-fix-network-port-mapping
Conversationhttps://github.com/testcontainers/testcontainers-python/pull/678
Commits3 (3)https://github.com/testcontainers/testcontainers-python/pull/678/commits
Checkshttps://github.com/testcontainers/testcontainers-python/pull/678/checks
Files changedhttps://github.com/testcontainers/testcontainers-python/pull/678/files
feat: refactor network setuphttps://github.com/testcontainers/testcontainers-python/pull/678#top
alexanderankinhttps://github.com/alexanderankin
testcontainers:mainhttps://github.com/testcontainers/testcontainers-python/tree/main
mgorsk1:feat/645-fix-network-port-mappinghttps://github.com/mgorsk1/testcontainers-python/tree/feat/645-fix-network-port-mapping
https://github.com/mgorsk1
mgorsk1https://github.com/mgorsk1
Aug 13, 2024https://github.com/testcontainers/testcontainers-python/pull/678#issue-2462447176
Please reload this pagehttps://github.com/testcontainers/testcontainers-python/pull/678
#645https://github.com/testcontainers/testcontainers-python/issues/645
Please reload this pagehttps://github.com/testcontainers/testcontainers-python/pull/678
mgorsk1https://github.com/mgorsk1
August 13, 2024 07:54https://github.com/testcontainers/testcontainers-python/pull/678#commits-pushed-b5c69f1
https://github.com/mgorsk1
refactor network setuphttps://github.com/testcontainers/testcontainers-python/pull/678/commits/b5c69f15eca954cfdc170d147c8fac3dbef04c6f
b5c69f1https://github.com/testcontainers/testcontainers-python/pull/678/commits/b5c69f15eca954cfdc170d147c8fac3dbef04c6f
https://github.com/mgorsk1
make linter happyhttps://github.com/testcontainers/testcontainers-python/pull/678/commits/eb30486874b1a3a5701cd36e8edecce4b6f1178d
eb30486https://github.com/testcontainers/testcontainers-python/pull/678/commits/eb30486874b1a3a5701cd36e8edecce4b6f1178d
https://github.com/mgorsk1
mgorsk1https://github.com/mgorsk1
Aug 13, 2024 https://github.com/testcontainers/testcontainers-python/pull/678#ref-issue-2403119507
Bug: port mapping not working with with_network (with_exposed_ports) #645 https://github.com/testcontainers/testcontainers-python/issues/645
https://github.com/mgorsk1
extend testshttps://github.com/testcontainers/testcontainers-python/pull/678/commits/44186f02ed8548f0c3326113d68b7c19feb5ee7b
44186f0https://github.com/testcontainers/testcontainers-python/pull/678/commits/44186f02ed8548f0c3326113d68b7c19feb5ee7b
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 13, 2024https://github.com/testcontainers/testcontainers-python/pull/678#issuecomment-2285962719
Codecovhttps://app.codecov.io/gh/testcontainers/testcontainers-python/pull/678?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=testcontainers
uploadhttps://docs.codecov.com/docs/codecov-uploader
Learn morehttps://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=testcontainers#section-missing-base-commit
☔ View full report in Codecov by Sentryhttps://app.codecov.io/gh/testcontainers/testcontainers-python/pull/678?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=testcontainers
Share it herehttps://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=testcontainers
Please reload this pagehttps://github.com/testcontainers/testcontainers-python/pull/678
https://github.com/alexanderankin
alexanderankinhttps://github.com/alexanderankin
d5de0aahttps://github.com/testcontainers/testcontainers-python/commit/d5de0aa01c7d3ba304446dd73347a1a7ec1facc7
Aug 13, 2024https://github.com/testcontainers/testcontainers-python/pull/678#event-13861667727
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 13, 2024 https://github.com/testcontainers/testcontainers-python/pull/678#ref-pullrequest-2440035296
chore(main): release testcontainers 4.8.0 #658 https://github.com/testcontainers/testcontainers-python/pull/658
alexanderankinhttps://github.com/alexanderankin
Aug 13, 2024 https://github.com/testcontainers/testcontainers-python/pull/678#ref-commit-fefaae4
https://github.com/mgorsk1
feat: refactor network setup (https://github.com/testcontainers/testcontainers-python/commit/fefaae4d91084194b7f034e7a76e11432421459e
#678https://github.com/testcontainers/testcontainers-python/pull/678
)https://github.com/testcontainers/testcontainers-python/commit/fefaae4d91084194b7f034e7a76e11432421459e
fefaae4https://github.com/testcontainers/testcontainers-python/commit/fefaae4d91084194b7f034e7a76e11432421459e
#645https://github.com/testcontainers/testcontainers-python/issues/645
alexanderankinhttps://github.com/alexanderankin
Aug 14, 2024 https://github.com/testcontainers/testcontainers-python/pull/678#ref-commit-c7d9b81
https://github.com/apps/github-actions
chore(main): release testcontainers 4.8.0 (https://github.com/testcontainers/testcontainers-python/commit/c7d9b814fd0a9ab254b0f7d7f3fe09a76453d2c7
#658https://github.com/testcontainers/testcontainers-python/pull/658
)https://github.com/testcontainers/testcontainers-python/commit/c7d9b814fd0a9ab254b0f7d7f3fe09a76453d2c7
c7d9b81https://github.com/testcontainers/testcontainers-python/commit/c7d9b814fd0a9ab254b0f7d7f3fe09a76453d2c7
testcontainers-v4.7.2...testcontainers-v4.8.0https://github.com/testcontainers/testcontainers-python/compare/testcontainers-v4.7.2...testcontainers-v4.8.0
#167https://github.com/testcontainers/testcontainers-python/pull/167
#167https://github.com/testcontainers/testcontainers-python/pull/167
2d8bc11https://github.com/testcontainers/testcontainers-python/commit/2d8bc11c8e151af66456ebad156afc4a87822676
2d8bc11https://github.com/testcontainers/testcontainers-python/commit/2d8bc11c8e151af66456ebad156afc4a87822676
#659https://github.com/testcontainers/testcontainers-python/pull/659
#659https://github.com/testcontainers/testcontainers-python/pull/659
e1e3d13https://github.com/testcontainers/testcontainers-python/commit/e1e3d13b47923dd7124196e6b743799bd87b6885
e1e3d13https://github.com/testcontainers/testcontainers-python/commit/e1e3d13b47923dd7124196e6b743799bd87b6885
#669https://github.com/testcontainers/testcontainers-python/pull/669
#669https://github.com/testcontainers/testcontainers-python/pull/669
8c28a86https://github.com/testcontainers/testcontainers-python/commit/8c28a861ce4ade9e8204783e2ef2fd99013c90ea
8c28a86https://github.com/testcontainers/testcontainers-python/commit/8c28a861ce4ade9e8204783e2ef2fd99013c90ea
#661https://github.com/testcontainers/testcontainers-python/pull/661
#661https://github.com/testcontainers/testcontainers-python/pull/661
b1453e8https://github.com/testcontainers/testcontainers-python/commit/b1453e87e1f5443f0f8d04c9b30a278aa835ca9b
b1453e8https://github.com/testcontainers/testcontainers-python/commit/b1453e87e1f5443f0f8d04c9b30a278aa835ca9b
#655https://github.com/testcontainers/testcontainers-python/pull/655
#655https://github.com/testcontainers/testcontainers-python/pull/655
9161cb6https://github.com/testcontainers/testcontainers-python/commit/9161cb64a0a13b54a981b2b846a4d073db8c30a2
9161cb6https://github.com/testcontainers/testcontainers-python/commit/9161cb64a0a13b54a981b2b846a4d073db8c30a2
#678https://github.com/testcontainers/testcontainers-python/pull/678
#678https://github.com/testcontainers/testcontainers-python/pull/678
d5de0aahttps://github.com/testcontainers/testcontainers-python/commit/d5de0aa01c7d3ba304446dd73347a1a7ec1facc7
d5de0aahttps://github.com/testcontainers/testcontainers-python/commit/d5de0aa01c7d3ba304446dd73347a1a7ec1facc7
#673https://github.com/testcontainers/testcontainers-python/pull/673
#673https://github.com/testcontainers/testcontainers-python/pull/673
1e43923https://github.com/testcontainers/testcontainers-python/commit/1e439232e35ce0091f20993273e1f01d8c0119c4
1e43923https://github.com/testcontainers/testcontainers-python/commit/1e439232e35ce0091f20993273e1f01d8c0119c4
#680https://github.com/testcontainers/testcontainers-python/pull/680
#680https://github.com/testcontainers/testcontainers-python/pull/680
71c3a1ahttps://github.com/testcontainers/testcontainers-python/commit/71c3a1a29e1839de91f05c6bcd4c620122195a94
71c3a1ahttps://github.com/testcontainers/testcontainers-python/commit/71c3a1a29e1839de91f05c6bcd4c620122195a94
#656https://github.com/testcontainers/testcontainers-python/pull/656
#656https://github.com/testcontainers/testcontainers-python/pull/656
fa2081ahttps://github.com/testcontainers/testcontainers-python/commit/fa2081a7b325cdd316de28c99b029150022db203
fa2081ahttps://github.com/testcontainers/testcontainers-python/commit/fa2081a7b325cdd316de28c99b029150022db203
#654https://github.com/testcontainers/testcontainers-python/pull/654
#654https://github.com/testcontainers/testcontainers-python/pull/654
e02c1b3https://github.com/testcontainers/testcontainers-python/commit/e02c1b37a651374f47abe72bc17941849c1fd12e
e02c1b3https://github.com/testcontainers/testcontainers-python/commit/e02c1b37a651374f47abe72bc17941849c1fd12e
#652https://github.com/testcontainers/testcontainers-python/issues/652
#652https://github.com/testcontainers/testcontainers-python/issues/652
https://github.com/googleapis/release-pleasehttps://github.com/googleapis/release-please
https://github.com/googleapis/release-please#release-pleasehttps://github.com/googleapis/release-please#release-please
https://github.com/alexanderankin
alexanderankinhttps://github.com/alexanderankin
Aug 14, 2024 https://github.com/testcontainers/testcontainers-python/pull/678#ref-issue-2385876376
Bug: Running Container with_network makes get_exposed_port unreliable #633 https://github.com/testcontainers/testcontainers-python/issues/633
https://github.com/skeletorXVI
skeletorXVIhttps://github.com/skeletorXVI
Sep 24, 2024 https://github.com/testcontainers/testcontainers-python/pull/678#ref-issue-2288272687
Bug: concurrency causes Premature destruction of containers and networks (e.g. w/pytest-xdist) #567 https://github.com/testcontainers/testcontainers-python/issues/567
https://github.co/hiddenchars
https://github.com/testcontainers/testcontainers-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftestcontainers%2Ftestcontainers-python%2Fpull%2F678
Bug: port mapping not working with with_network (with_exposed_ports) https://github.com/testcontainers/testcontainers-python/issues/645
Please reload this pagehttps://github.com/testcontainers/testcontainers-python/pull/678
https://github.com/mgorsk1
https://github.com/alexanderankin
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.