Title: Security: Hardcoded Encryption Key in EncryptionCodec by tomaioo · Pull Request #322 · temporalio/samples-python · GitHub
Open Graph Title: Security: Hardcoded Encryption Key in EncryptionCodec by tomaioo · Pull Request #322 · temporalio/samples-python
X Title: Security: Hardcoded Encryption Key in EncryptionCodec by tomaioo · Pull Request #322 · temporalio/samples-python
Description: Summary Security: Hardcoded Encryption Key in EncryptionCodec Problem Severity: Critical | File: encryption/codec.py:L9 The EncryptionCodec class in encryption/codec.py contains a hardcoded default encryption key (default_key = b"test-key-test-key-test-key-test!") and key ID (default_key_id = "test-key-id"). This is a critical security vulnerability as it allows anyone with access to the code to decrypt payloads. The key is also only 32 bytes which while acceptable for AES-256, the hardcoded nature makes it completely insecure for any real usage. Solution Remove hardcoded defaults and require keys to be passed via environment variables, secure key management service, or other secure configuration. Add documentation warnings that this is sample code only. Changes encryption/codec.py (modified)
Open Graph Description: Summary Security: Hardcoded Encryption Key in EncryptionCodec Problem Severity: Critical | File: encryption/codec.py:L9 The EncryptionCodec class in encryption/codec.py contains a hardcoded default...
X Description: Summary Security: Hardcoded Encryption Key in EncryptionCodec Problem Severity: Critical | File: encryption/codec.py:L9 The EncryptionCodec class in encryption/codec.py contains a hardcoded default...
Opengraph URL: https://github.com/temporalio/samples-python/pull/322
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ac0d0bff-8bc9-adcc-e1ab-c0c43cc3a769 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 93CE:1FF1F4:63408B:864B7A:6A4D4094 |
| html-safe-nonce | b09e290e221515f8d82156fd9335efcc28c485ebc05e8e57e5bd46599e07e834 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5M0NFOjFGRjFGNDo2MzQwOEI6ODY0QjdBOjZBNEQ0MDk0IiwidmlzaXRvcl9pZCI6Ijc1MTc5NDMyODY3ODQxNDc2MDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d2c8d5f029e40025cc5298cc94684c1d481500508ea2d7fff69449ae06dcc284 |
| hovercard-subject-tag | pull_request:3937383295 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/temporalio/samples-python/pull/322/files |
| twitter:image | https://avatars.githubusercontent.com/u/203048277?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/203048277?s=400&v=4 |
| og:image:alt | Summary Security: Hardcoded Encryption Key in EncryptionCodec Problem Severity: Critical | File: encryption/codec.py:L9 The EncryptionCodec class in encryption/codec.py contains a hardcoded default... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 92571a8944142227b7e19cd10918b1ddd06e5066c1ad5bc7e4769cf6140a87e6 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/temporalio/samples-python git https://github.com/temporalio/samples-python.git |
| octolytics-dimension-user_id | 56493103 |
| octolytics-dimension-user_login | temporalio |
| octolytics-dimension-repository_id | 454557884 |
| octolytics-dimension-repository_nwo | temporalio/samples-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 454557884 |
| octolytics-dimension-repository_network_root_nwo | temporalio/samples-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 56fc8347865a14e2ec811533d68f929cf4e0ec19 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width