| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ec58fd88-67da-56c9-357a-aeed9813bcf7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 89B6:1EDE:18C34BA:23A8764:6A4D0817 |
| html-safe-nonce | aa174d22e4790357d998c41649ccb2df130f71c3c7a24867643c4455036d417d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OUI2OjFFREU6MThDMzRCQToyM0E4NzY0OjZBNEQwODE3IiwidmlzaXRvcl9pZCI6IjQwMDA1MzM3OTA1NjA0MjE5MTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ce1832e992a3b4c2b5257d66d167eb5eb971d8b744586f3ce6edcd36faeabb0c |
| hovercard-subject-tag | pull_request:2191068017 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/temporalio/samples-python/150/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/44f1ce18adf56e0c5e59d7f88d2647d957ad8bf7601a2a00e9a13df95b7abf9b/temporalio/samples-python/pull/150 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/44f1ce18adf56e0c5e59d7f88d2647d957ad8bf7601a2a00e9a13df95b7abf9b/temporalio/samples-python/pull/150 |
| og:image:alt | What was changed
Fix the polling/infrequent sample. It wasn't correctly calculating attempts and was therefore running forever.
Why?
Checklist
Test plan:
Verify that it works:
poetry run p... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | drewhoskins-temporal |
| hostname | github.com |
| expected-hostname | github.com |
| None | 31e4db13a9e20081f2fac78f441659a6576e582bbb15e153f9c7fb6473aa29f5 |
| turbo-cache-control | no-cache |
| go-import | github.com/temporalio/samples-python git https://github.com/temporalio/samples-python.git |
| octolytics-dimension-user_id | 56493103 |
| octolytics-dimension-user_login | temporalio |
| octolytics-dimension-repository_id | 454557884 |
| octolytics-dimension-repository_nwo | temporalio/samples-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 454557884 |
| octolytics-dimension-repository_network_root_nwo | temporalio/samples-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | fb70bd3c4b2bec429781b65419e912c66e2d5581 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/temporalio/samples-python/pull/150#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftemporalio%2Fsamples-python%2Fpull%2F150 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftemporalio%2Fsamples-python%2Fpull%2F150 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=temporalio%2Fsamples-python |
| Reload | https://github.com/temporalio/samples-python/pull/150 |
| Reload | https://github.com/temporalio/samples-python/pull/150 |
| Reload | https://github.com/temporalio/samples-python/pull/150 |
| Please reload this page | https://github.com/temporalio/samples-python/pull/150 |
|
temporalio
| https://github.com/temporalio |
| samples-python | https://github.com/temporalio/samples-python |
|
Notifications
| https://github.com/login?return_to=%2Ftemporalio%2Fsamples-python |
|
Fork
112
| https://github.com/login?return_to=%2Ftemporalio%2Fsamples-python |
|
Star
358
| https://github.com/login?return_to=%2Ftemporalio%2Fsamples-python |
|
Code
| https://github.com/temporalio/samples-python |
|
Issues
28
| https://github.com/temporalio/samples-python/issues |
|
Pull requests
54
| https://github.com/temporalio/samples-python/pulls |
|
Actions
| https://github.com/temporalio/samples-python/actions |
|
Security and quality
0
| https://github.com/temporalio/samples-python/security |
|
Insights
| https://github.com/temporalio/samples-python/pulse |
|
Code
| https://github.com/temporalio/samples-python |
|
Issues
| https://github.com/temporalio/samples-python/issues |
|
Pull requests
| https://github.com/temporalio/samples-python/pulls |
|
Actions
| https://github.com/temporalio/samples-python/actions |
|
Security and quality
| https://github.com/temporalio/samples-python/security |
|
Insights
| https://github.com/temporalio/samples-python/pulse |
| drewhoskins-temporal | https://github.com/drewhoskins-temporal |
| main | https://github.com/temporalio/samples-python/tree/main |
| drewhoskins_polling | https://github.com/temporalio/samples-python/tree/drewhoskins_polling |
| Conversation | https://github.com/temporalio/samples-python/pull/150 |
| Commits4 (4) | https://github.com/temporalio/samples-python/pull/150/commits |
| Checks | https://github.com/temporalio/samples-python/pull/150/checks |
| Files changed | https://github.com/temporalio/samples-python/pull/150/files |
| Fix Infrequent Polling sample | https://github.com/temporalio/samples-python/pull/150#top |
| drewhoskins-temporal | https://github.com/drewhoskins-temporal |
| main | https://github.com/temporalio/samples-python/tree/main |
| drewhoskins_polling | https://github.com/temporalio/samples-python/tree/drewhoskins_polling |
|
| https://github.com/drewhoskins-temporal |
| drewhoskins-temporal | https://github.com/drewhoskins-temporal |
| Nov 21, 2024 | https://github.com/temporalio/samples-python/pull/150#issue-2677646265 |
| Please reload this page | https://github.com/temporalio/samples-python/pull/150 |
| https://github.com/drewhoskins-temporal |
| drewhoskins-temporal | https://github.com/drewhoskins-temporal |
| Sushisource | https://github.com/Sushisource |
| Nov 21, 2024 | https://github.com/temporalio/samples-python/pull/150#event-15374451400 |
| https://github.com/drewhoskins-temporal |
| drewhoskins-temporal | https://github.com/drewhoskins-temporal |
| force-pushed | https://github.com/temporalio/samples-python/compare/1573d7cb2f1860bffd6ae596c3aee2856e9a6c31..0a183abe507ade8fb2e87e3df95e5d722704f811 |
| 1573d7c | https://github.com/temporalio/samples-python/commit/1573d7cb2f1860bffd6ae596c3aee2856e9a6c31 |
| 0a183ab | https://github.com/temporalio/samples-python/commit/0a183abe507ade8fb2e87e3df95e5d722704f811 |
|
Compare
| https://github.com/temporalio/samples-python/compare/1573d7cb2f1860bffd6ae596c3aee2856e9a6c31..0a183abe507ade8fb2e87e3df95e5d722704f811 |
| November 21, 2024 00:57 | https://github.com/temporalio/samples-python/pull/150#event-15374455953 |
| https://github.com/drewhoskins-temporal |
| drewhoskins-temporal | https://github.com/drewhoskins-temporal |
| dandavison | https://github.com/dandavison |
| Sushisource | https://github.com/Sushisource |
| Nov 21, 2024 | https://github.com/temporalio/samples-python/pull/150#event-15374552904 |
| https://github.com/drewhoskins-temporal |
| drewhoskins-temporal | https://github.com/drewhoskins-temporal |
|
Nov 21, 2024
| https://github.com/temporalio/samples-python/pull/150#pullrequestreview-2450023581 |
|
View reviewed changes
| https://github.com/temporalio/samples-python/pull/150/files |
| tests/polling/infrequent/workflow_test.py | https://github.com/temporalio/samples-python/pull/150/files#diff-aeade2921e5aabf8e703c7a2514b7b04915a3d3f612835561b3c90929c5b0039 |
| Please reload this page | https://github.com/temporalio/samples-python/pull/150 |
| https://github.com/dandavison |
| dandavison | https://github.com/dandavison |
|
Nov 21, 2024
| https://github.com/temporalio/samples-python/pull/150#pullrequestreview-2450023636 |
|
View reviewed changes
| https://github.com/temporalio/samples-python/pull/150/files |
| polling/test_service.py | https://github.com/temporalio/samples-python/pull/150/files#diff-f8c8df5afe3970ca34562313b13b684e2892538b8fe1926b748f3867c5e15188 |
| Please reload this page | https://github.com/temporalio/samples-python/pull/150 |
| https://github.com/dandavison |
| dandavison | https://github.com/dandavison |
|
Nov 21, 2024
| https://github.com/temporalio/samples-python/pull/150#pullrequestreview-2450026531 |
|
View reviewed changes
| https://github.com/temporalio/samples-python/pull/150/files |
| polling/test_service.py | https://github.com/temporalio/samples-python/pull/150/files#diff-f8c8df5afe3970ca34562313b13b684e2892538b8fe1926b748f3867c5e15188 |
| dandavison | https://github.com/dandavison |
| Nov 21, 2024 | https://github.com/temporalio/samples-python/pull/150#discussion_r1851185997 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/temporalio/samples-python/pull/150 |
| drewhoskins-temporal | https://github.com/drewhoskins-temporal |
| Nov 21, 2024 | https://github.com/temporalio/samples-python/pull/150#discussion_r1851230919 |
| Please reload this page | https://github.com/temporalio/samples-python/pull/150 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/temporalio/samples-python/pull/150 |
| https://github.com/dandavison |
| dandavison | https://github.com/dandavison |
|
Nov 21, 2024
| https://github.com/temporalio/samples-python/pull/150#pullrequestreview-2450028594 |
|
View reviewed changes
| https://github.com/temporalio/samples-python/pull/150/files |
| polling/test_service.py | https://github.com/temporalio/samples-python/pull/150/files#diff-f8c8df5afe3970ca34562313b13b684e2892538b8fe1926b748f3867c5e15188 |
| Please reload this page | https://github.com/temporalio/samples-python/pull/150 |
| https://github.com/drewhoskins-temporal |
| drewhoskins-temporal | https://github.com/drewhoskins-temporal |
| force-pushed | https://github.com/temporalio/samples-python/compare/94415784ad8cf03d3ce42fef351024cea80c3f8b..b054fd8d743c014bb457d4fa6ce771c893a4e615 |
| 9441578 | https://github.com/temporalio/samples-python/commit/94415784ad8cf03d3ce42fef351024cea80c3f8b |
| b054fd8 | https://github.com/temporalio/samples-python/commit/b054fd8d743c014bb457d4fa6ce771c893a4e615 |
|
Compare
| https://github.com/temporalio/samples-python/compare/94415784ad8cf03d3ce42fef351024cea80c3f8b..b054fd8d743c014bb457d4fa6ce771c893a4e615 |
| November 21, 2024 02:29 | https://github.com/temporalio/samples-python/pull/150#event-15374987141 |
| https://github.com/dandavison |
| dandavison | https://github.com/dandavison |
|
Nov 21, 2024
| https://github.com/temporalio/samples-python/pull/150#pullrequestreview-2450146870 |
|
View reviewed changes
| https://github.com/temporalio/samples-python/pull/150/files |
| polling/frequent/activities.py | https://github.com/temporalio/samples-python/pull/150/files#diff-3cdc567024527d7d1251a773e21a4c61d9d3f47fc672d285e756d6e910b2a36b |
| dandavison | https://github.com/dandavison |
| Nov 21, 2024 | https://github.com/temporalio/samples-python/pull/150#discussion_r1851267015 |
| Please reload this page | https://github.com/temporalio/samples-python/pull/150 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/temporalio/samples-python/pull/150 |
| drewhoskins-temporal | https://github.com/drewhoskins-temporal |
| Nov 21, 2024 | https://github.com/temporalio/samples-python/pull/150#discussion_r1852633639 |
| Please reload this page | https://github.com/temporalio/samples-python/pull/150 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/temporalio/samples-python/pull/150 |
| dandavison | https://github.com/dandavison |
| Nov 21, 2024 | https://github.com/temporalio/samples-python/pull/150#discussion_r1852690736 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #152 | https://github.com/temporalio/samples-python/pull/152 |
| Please reload this page | https://github.com/temporalio/samples-python/pull/150 |
| drewhoskins-temporal | https://github.com/drewhoskins-temporal |
| Nov 22, 2024 | https://github.com/temporalio/samples-python/pull/150#discussion_r1854820621 |
| Please reload this page | https://github.com/temporalio/samples-python/pull/150 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/temporalio/samples-python/pull/150 |
| dandavison | https://github.com/dandavison |
| Nov 25, 2024 | https://github.com/temporalio/samples-python/pull/150#discussion_r1856966394 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/temporalio/samples-python/pull/150 |
| dandavison | https://github.com/dandavison |
| Nov 25, 2024 | https://github.com/temporalio/samples-python/pull/150#discussion_r1856989663 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #152 | https://github.com/temporalio/samples-python/pull/152 |
| Please reload this page | https://github.com/temporalio/samples-python/pull/150 |
| https://github.com/dandavison |
| dandavison | https://github.com/dandavison |
|
Nov 21, 2024
| https://github.com/temporalio/samples-python/pull/150#ref-pullrequest-2680545302 |
|
Fix polling sample 2
#152
| https://github.com/temporalio/samples-python/pull/152 |
| drewhoskins-temporal | https://github.com/drewhoskins-temporal |
| November 22, 2024 18:07 | https://github.com/temporalio/samples-python/pull/150#commits-pushed-fb2f927 |
|
| https://github.com/drewhoskins-temporal |
|
| https://github.com/dandavison |
| Fix Infrequent Polling sample | https://github.com/temporalio/samples-python/pull/150/commits/fb2f927e392a704e9ada34f2e1ca70aaee86b6b3 |
| fb2f927 | https://github.com/temporalio/samples-python/pull/150/commits/fb2f927e392a704e9ada34f2e1ca70aaee86b6b3 |
|
| https://github.com/drewhoskins-temporal |
|
| https://github.com/dandavison |
| poe format | https://github.com/temporalio/samples-python/pull/150/commits/0204af5b6c236fd8e2ec849e6e42417fc7daa2bc |
| 0204af5 | https://github.com/temporalio/samples-python/pull/150/commits/0204af5b6c236fd8e2ec849e6e42417fc7daa2bc |
|
| https://github.com/drewhoskins-temporal |
|
| https://github.com/dandavison |
| Add __init__.py | https://github.com/temporalio/samples-python/pull/150/commits/61cb1bf2ddd6a871783cf97adad9e14bc904d3c6 |
| 61cb1bf | https://github.com/temporalio/samples-python/pull/150/commits/61cb1bf2ddd6a871783cf97adad9e14bc904d3c6 |
|
| https://github.com/drewhoskins-temporal |
|
| https://github.com/dandavison |
| Apply suggestions from code review | https://github.com/temporalio/samples-python/pull/150/commits/f77df0aaa1c0da4fb3325e8dfa7aaf65274b7660 |
| f77df0a | https://github.com/temporalio/samples-python/pull/150/commits/f77df0aaa1c0da4fb3325e8dfa7aaf65274b7660 |
| https://github.com/dandavison |
| dandavison | https://github.com/dandavison |
| force-pushed | https://github.com/temporalio/samples-python/compare/b054fd8d743c014bb457d4fa6ce771c893a4e615..f77df0aaa1c0da4fb3325e8dfa7aaf65274b7660 |
| b054fd8 | https://github.com/temporalio/samples-python/commit/b054fd8d743c014bb457d4fa6ce771c893a4e615 |
| f77df0a | https://github.com/temporalio/samples-python/commit/f77df0aaa1c0da4fb3325e8dfa7aaf65274b7660 |
|
Compare
| https://github.com/temporalio/samples-python/compare/b054fd8d743c014bb457d4fa6ce771c893a4e615..f77df0aaa1c0da4fb3325e8dfa7aaf65274b7660 |
| November 22, 2024 23:07 | https://github.com/temporalio/samples-python/pull/150#event-15405059819 |
| https://github.com/dandavison |
| dandavison | https://github.com/dandavison |
| Nov 25, 2024 | https://github.com/temporalio/samples-python/pull/150#event-15423591613 |
| https://github.co/hiddenchars |
| https://github.com/temporalio/samples-python/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftemporalio%2Fsamples-python%2Fpull%2F150 |
|
| https://github.com/dandavison |
|
dandavison
| https://github.com/dandavison |
|
| https://github.com/temporalio/samples-python/pull/150/files/b054fd8d743c014bb457d4fa6ce771c893a4e615 |
|
| https://github.com/dandavison |
|
dandavison
| https://github.com/dandavison |
| Please reload this page | https://github.com/temporalio/samples-python/pull/150 |
|
| https://github.com/drewhoskins-temporal |
|
| https://github.com/dandavison |
|
| https://github.com/Sushisource |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |