René's URL Explorer Experiment


Title: Unable to apply patches with trailing blank line removed · Issue #59 · techtonik/python-patch · GitHub

Open Graph Title: Unable to apply patches with trailing blank line removed · Issue #59 · techtonik/python-patch

X Title: Unable to apply patches with trailing blank line removed · Issue #59 · techtonik/python-patch

Description: Given a.txt: 1 2 3 and broken.patch (note that it's missing the third line of context): --- a.txt 2019-03-28 17:02:04.832004033 -0700 +++ b.txt 2019-03-28 17:02:34.999576803 -0700 @@ -1,4 +1,4 @@ -1 +0 2 3 one can get to b.txt: 0 2 3 usi...

Open Graph Description: Given a.txt: 1 2 3 and broken.patch (note that it's missing the third line of context): --- a.txt 2019-03-28 17:02:04.832004033 -0700 +++ b.txt 2019-03-28 17:02:34.999576803 -0700 @@ -1,4 +1,4 @@ -...

X Description: Given a.txt: 1 2 3 and broken.patch (note that it's missing the third line of context): --- a.txt 2019-03-28 17:02:04.832004033 -0700 +++ b.txt 2019-03-28 17:02:34.999576803 -0700 @@ -1,4 +1,4 ...

Opengraph URL: https://github.com/techtonik/python-patch/issues/59

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Unable to apply patches with trailing blank line removed","articleBody":"Given `a.txt`:\r\n\r\n```\r\n1\r\n2\r\n3\r\n\r\n```\r\n\r\nand `broken.patch` (note that it's missing the third line of context):\r\n\r\n```\r\n--- a.txt\t2019-03-28 17:02:04.832004033 -0700\r\n+++ b.txt\t2019-03-28 17:02:34.999576803 -0700\r\n@@ -1,4 +1,4 @@\r\n-1\r\n+0\r\n 2\r\n 3\r\n```\r\n\r\none can get to `b.txt`:\r\n\r\n```\r\n0\r\n2\r\n3\r\n\r\n```\r\n\r\nusing `patch -p0 \u003c broken.patch` but not with python-patch:\r\n\r\n```\r\n$ ./patch.py --debug broken.patch \r\n   DEBUG reading broken.patch\r\n WARNING error: patch stream is incomplete!\r\n   DEBUG -  0 hunks for a.txt\r\n   DEBUG total files: 1  total hunks: 0\r\n   DEBUG normalize filenames\r\n   DEBUG     patch type = plain\r\n   DEBUG     source = a.txt\r\n   DEBUG     target = b.txt\r\nTraceback (most recent call last):\r\n  File \"./patch.py\", line 1193, in \u003cmodule\u003e\r\n    main()\r\n  File \"./patch.py\", line 1186, in main\r\n    patch.apply(options.strip, root=options.directory) or sys.exit(-1)\r\nAttributeError: 'bool' object has no attribute 'apply'\r\n```\r\n\r\nTo patch `a.txt` correctly using python-patch, one needs to provide the non-truncated patch file which contains the full three lines of context (with the last line consisting of a single trailing space):\r\n\r\n```\r\n--- a.txt\t2019-03-28 17:02:04.832004033 -0700\r\n+++ b.txt\t2019-03-28 17:02:34.999576803 -0700\r\n@@ -1,4 +1,4 @@\r\n-1\r\n+0\r\n 2\r\n 3\r\n \r\n```\r\n\r\nThis can be a problem since `git` is commonly configured to remove \"unnecessary trailing whitespace\" via the following option in `~/.gitconfig`:\r\n\r\n```\r\n[apply]\r\n        whitespace = fix\r\n```","author":{"url":"https://github.com/fmarier","@type":"Person","name":"fmarier"},"datePublished":"2019-03-29T00:13:21.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/59/python-patch/issues/59"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8ffc0cc2-ad23-4c50-e31a-b73cec2fef6f
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB12E:356387:8059B2:A5DD3D:696B17FF
html-safe-nonce0edccb3d4d46914103ec6bb6fb30806c59059d29ebf7ebc52e2ece33972aeaf5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTJFOjM1NjM4Nzo4MDU5QjI6QTVERDNEOjY5NkIxN0ZGIiwidmlzaXRvcl9pZCI6IjM1NTI0NDkxMTU1MzYxNTg3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc4aa3edc5b7bc95c1e0e6d18e21a45fc6a925c18750c05354597a9b752811e09
hovercard-subject-tagissue:426759416
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/techtonik/python-patch/59/issue_layout
twitter:imagehttps://opengraph.githubassets.com/ac04941f510272c9414bbb683528db881f112e574aa3ad43aa1a074f2e934541/techtonik/python-patch/issues/59
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ac04941f510272c9414bbb683528db881f112e574aa3ad43aa1a074f2e934541/techtonik/python-patch/issues/59
og:image:altGiven a.txt: 1 2 3 and broken.patch (note that it's missing the third line of context): --- a.txt 2019-03-28 17:02:04.832004033 -0700 +++ b.txt 2019-03-28 17:02:34.999576803 -0700 @@ -1,4 +1,4 @@ -...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefmarier
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/techtonik/python-patch git https://github.com/techtonik/python-patch.git
octolytics-dimension-user_id515889
octolytics-dimension-user_logintechtonik
octolytics-dimension-repository_id34159484
octolytics-dimension-repository_nwotechtonik/python-patch
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id34159484
octolytics-dimension-repository_network_root_nwotechtonik/python-patch
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/techtonik/python-patch/issues/59#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftechtonik%2Fpython-patch%2Fissues%2F59
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftechtonik%2Fpython-patch%2Fissues%2F59
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=techtonik%2Fpython-patch
Reloadhttps://github.com/techtonik/python-patch/issues/59
Reloadhttps://github.com/techtonik/python-patch/issues/59
Reloadhttps://github.com/techtonik/python-patch/issues/59
techtonik https://github.com/techtonik
python-patchhttps://github.com/techtonik/python-patch
Notifications https://github.com/login?return_to=%2Ftechtonik%2Fpython-patch
Fork 67 https://github.com/login?return_to=%2Ftechtonik%2Fpython-patch
Star 121 https://github.com/login?return_to=%2Ftechtonik%2Fpython-patch
Code https://github.com/techtonik/python-patch
Issues 29 https://github.com/techtonik/python-patch/issues
Pull requests 10 https://github.com/techtonik/python-patch/pulls
Actions https://github.com/techtonik/python-patch/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/techtonik/python-patch/security
Please reload this pagehttps://github.com/techtonik/python-patch/issues/59
Insights https://github.com/techtonik/python-patch/pulse
Code https://github.com/techtonik/python-patch
Issues https://github.com/techtonik/python-patch/issues
Pull requests https://github.com/techtonik/python-patch/pulls
Actions https://github.com/techtonik/python-patch/actions
Security https://github.com/techtonik/python-patch/security
Insights https://github.com/techtonik/python-patch/pulse
New issuehttps://github.com/login?return_to=https://github.com/techtonik/python-patch/issues/59
New issuehttps://github.com/login?return_to=https://github.com/techtonik/python-patch/issues/59
Unable to apply patches with trailing blank line removedhttps://github.com/techtonik/python-patch/issues/59#top
https://github.com/fmarier
https://github.com/fmarier
fmarierhttps://github.com/fmarier
on Mar 29, 2019https://github.com/techtonik/python-patch/issues/59#issue-426759416
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.