Title: fromfile leaks file pointer in case parse raises exception · Issue #58 · techtonik/python-patch · GitHub
Open Graph Title: fromfile leaks file pointer in case parse raises exception · Issue #58 · techtonik/python-patch
X Title: fromfile leaks file pointer in case parse raises exception · Issue #58 · techtonik/python-patch
Description: the opening of the patch file needs a context manager, otherwise if patchset.parse raises an exception, the fp is never closed.
Open Graph Description: the opening of the patch file needs a context manager, otherwise if patchset.parse raises an exception, the fp is never closed.
X Description: the opening of the patch file needs a context manager, otherwise if patchset.parse raises an exception, the fp is never closed.
Opengraph URL: https://github.com/techtonik/python-patch/issues/58
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"fromfile leaks file pointer in case parse raises exception","articleBody":"the opening of the patch file needs a context manager, otherwise if patchset.parse raises an exception, the fp is never closed.\r\n","author":{"url":"https://github.com/stefanoborini","@type":"Person","name":"stefanoborini"},"datePublished":"2019-01-14T14:20:29.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/58/python-patch/issues/58"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:a0853969-c1ee-4ca3-5ee3-055acdecfe82 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8FF8:10252F:BAAD35:FF08FE:696A8962 |
| html-safe-nonce | ecd1b2f49136d90779e02ec8431a95353400c03522e3166dd8d952c87e36e362 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RkY4OjEwMjUyRjpCQUFEMzU6RkYwOEZFOjY5NkE4OTYyIiwidmlzaXRvcl9pZCI6IjQ2NDI4MTY1NDMxOTAyNDQ4MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f3a4989ff0ce9d2b7acc986e8276f016fd159370d912d7231057f689014b5f85 |
| hovercard-subject-tag | issue:398908896 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/techtonik/python-patch/58/issue_layout |
| twitter:image | https://opengraph.githubassets.com/e2a502f4fa2188dfeb72b62dca0933e6f732e1f44d085ec97eafd5d5d630b23b/techtonik/python-patch/issues/58 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e2a502f4fa2188dfeb72b62dca0933e6f732e1f44d085ec97eafd5d5d630b23b/techtonik/python-patch/issues/58 |
| og:image:alt | the opening of the patch file needs a context manager, otherwise if patchset.parse raises an exception, the fp is never closed. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | stefanoborini |
| hostname | github.com |
| expected-hostname | github.com |
| None | d2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825 |
| turbo-cache-control | no-preview |
| go-import | github.com/techtonik/python-patch git https://github.com/techtonik/python-patch.git |
| octolytics-dimension-user_id | 515889 |
| octolytics-dimension-user_login | techtonik |
| octolytics-dimension-repository_id | 34159484 |
| octolytics-dimension-repository_nwo | techtonik/python-patch |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 34159484 |
| octolytics-dimension-repository_network_root_nwo | techtonik/python-patch |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c1dbca8981c5e3d6a69bce2f1d289e732b86241d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width