René's URL Explorer Experiment


Title: patch.py adds extra newline at EOF · Issue #50 · techtonik/python-patch · GitHub

Open Graph Title: patch.py adds extra newline at EOF · Issue #50 · techtonik/python-patch

X Title: patch.py adds extra newline at EOF · Issue #50 · techtonik/python-patch

Description: I have observed that patch.py adds an extra newline at the end of the patched file even though the unified patch doesn't alter the line at all. I know it is good behavior on Linux to have a newline at the end of the file. Some C/C++ codi...

Open Graph Description: I have observed that patch.py adds an extra newline at the end of the patched file even though the unified patch doesn't alter the line at all. I know it is good behavior on Linux to have a newline...

X Description: I have observed that patch.py adds an extra newline at the end of the patched file even though the unified patch doesn't alter the line at all. I know it is good behavior on Linux to have a new...

Opengraph URL: https://github.com/techtonik/python-patch/issues/50

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"patch.py adds extra newline at EOF","articleBody":"I have observed that patch.py adds an extra newline at the end of the patched file even though the unified patch doesn't alter the line at all.\r\n\r\nI know it is good behavior on Linux to have a newline at the end of the file. Some C/C++ coding standards make this even mandatory. But with PHP and some other web technologies, there are strong reasons to NOT have a newline at the end of the file, as it may result in undesired additional newline output to the client, possibly breaking everything.\r\n\r\nSmall example for illustration, including [LF] as newline ('\\n') and [EOF] as the end of the file.\r\n\r\noriginal file (old/test.php):\r\n```\r\n\u003c?php[LF]\r\n[LF]\r\necho \"\u003chtml\u003e\u003ctitle\u003easdf\u003c/title\u003e\u003cbody\u003easdf\u003c/body\u003e\u003c/html\u003e\";[LF]\r\n[LF]\r\n?\u003e[EOF]\r\n```\r\nwith patch file (without [LF] and [EOF], generated via `diff -Naur old/test.php new/test.php \u003e test.php.patch`):\r\n```\r\n--- old/test.php\t2017-03-29 11:19:36.103349100 +0200\r\n+++ new/test.php\t2017-03-29 11:20:16.270349100 +0200\r\n@@ -1,5 +1,5 @@\r\n \u003c?php\r\n \r\n-echo \"\u003chtml\u003e\u003ctitle\u003easdf\u003c/title\u003e\u003cbody\u003easdf\u003c/body\u003e\u003c/html\u003e\";\r\n+echo \"\u003chtml\u003e\u003ctitle\u003eA real title\u003c/title\u003e\u003cbody\u003eA real body\u003c/body\u003e\u003c/html\u003e\";\r\n \r\n ?\u003e\r\n\\ No newline at end of file\r\n\r\n```\r\nbecomes:\r\n```\r\n\u003c?php[LF]\r\n[LF]\r\necho \"\u003chtml\u003e\u003ctitle\u003eA real title\u003c/title\u003e\u003cbody\u003eA real body\u003c/body\u003e\u003c/html\u003e\";[LF]\r\n[LF]\r\n?\u003e[LF][EOF]\r\n```\r\n\r\nbut should be (new/test.php):\r\n```\r\n\u003c?php[LF]\r\n[LF]\r\necho \"\u003chtml\u003e\u003ctitle\u003eA real title\u003c/title\u003e\u003cbody\u003eA real body\u003c/body\u003e\u003c/html\u003e\";[LF]\r\n[LF]\r\n?\u003e[EOF]\r\n```\r\n","author":{"url":"https://github.com/nils-ballmann","@type":"Person","name":"nils-ballmann"},"datePublished":"2017-03-29T09:55:08.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/50/python-patch/issues/50"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:3b4c9946-4983-8869-6a02-b2cbe1503bd1
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8904:1D772C:471586:608B8A:696AAA24
html-safe-nonce5daccc99dd73d6c25f64e054805d09694ee0efa7238e879fbfcae7ebbcffce1b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTA0OjFENzcyQzo0NzE1ODY6NjA4QjhBOjY5NkFBQTI0IiwidmlzaXRvcl9pZCI6IjM3NDc1MzYxODIxNzQxOTgzMDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac61cf7ded9f87d5c1b6c2e9d5c7566db9098729823fdf96b177c2cc8db879801b
hovercard-subject-tagissue:217823632
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/techtonik/python-patch/50/issue_layout
twitter:imagehttps://opengraph.githubassets.com/c33c9a1e1c3bf40270e4635490ae983b49ca4f37cfff631d9d939fa426f0c850/techtonik/python-patch/issues/50
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c33c9a1e1c3bf40270e4635490ae983b49ca4f37cfff631d9d939fa426f0c850/techtonik/python-patch/issues/50
og:image:altI have observed that patch.py adds an extra newline at the end of the patched file even though the unified patch doesn't alter the line at all. I know it is good behavior on Linux to have a newline...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenils-ballmann
hostnamegithub.com
expected-hostnamegithub.com
None3eaf9b8cf1badcd7041a8ad480b9d9b28bea0ef1cc821ca9ff20f2cc7f4fe4b9
turbo-cache-controlno-preview
go-importgithub.com/techtonik/python-patch git https://github.com/techtonik/python-patch.git
octolytics-dimension-user_id515889
octolytics-dimension-user_logintechtonik
octolytics-dimension-repository_id34159484
octolytics-dimension-repository_nwotechtonik/python-patch
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id34159484
octolytics-dimension-repository_network_root_nwotechtonik/python-patch
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedd9a979046e6382bd084e2bd873bf65f797125ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/techtonik/python-patch/issues/50#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftechtonik%2Fpython-patch%2Fissues%2F50
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftechtonik%2Fpython-patch%2Fissues%2F50
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=techtonik%2Fpython-patch
Reloadhttps://github.com/techtonik/python-patch/issues/50
Reloadhttps://github.com/techtonik/python-patch/issues/50
Reloadhttps://github.com/techtonik/python-patch/issues/50
techtonik https://github.com/techtonik
python-patchhttps://github.com/techtonik/python-patch
Notifications https://github.com/login?return_to=%2Ftechtonik%2Fpython-patch
Fork 67 https://github.com/login?return_to=%2Ftechtonik%2Fpython-patch
Star 121 https://github.com/login?return_to=%2Ftechtonik%2Fpython-patch
Code https://github.com/techtonik/python-patch
Issues 29 https://github.com/techtonik/python-patch/issues
Pull requests 10 https://github.com/techtonik/python-patch/pulls
Actions https://github.com/techtonik/python-patch/actions
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/techtonik/python-patch/security
Please reload this pagehttps://github.com/techtonik/python-patch/issues/50
Insights https://github.com/techtonik/python-patch/pulse
Code https://github.com/techtonik/python-patch
Issues https://github.com/techtonik/python-patch/issues
Pull requests https://github.com/techtonik/python-patch/pulls
Actions https://github.com/techtonik/python-patch/actions
Security https://github.com/techtonik/python-patch/security
Insights https://github.com/techtonik/python-patch/pulse
New issuehttps://github.com/login?return_to=https://github.com/techtonik/python-patch/issues/50
New issuehttps://github.com/login?return_to=https://github.com/techtonik/python-patch/issues/50
patch.py adds extra newline at EOFhttps://github.com/techtonik/python-patch/issues/50#top
https://github.com/nils-ballmann
https://github.com/nils-ballmann
nils-ballmannhttps://github.com/nils-ballmann
on Mar 29, 2017https://github.com/techtonik/python-patch/issues/50#issue-217823632
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.