René's URL Explorer Experiment


Title: fix: Custom reader should read till endblock by svaningelgem · Pull Request #61 · tcalmant/python-javaobj · GitHub

Open Graph Title: fix: Custom reader should read till endblock by svaningelgem · Pull Request #61 · tcalmant/python-javaobj

X Title: fix: Custom reader should read till endblock by svaningelgem · Pull Request #61 · tcalmant/python-javaobj

Description: Made it a recursive loop while sticking to the current code as close as possible. All tests pass without any change, and my new test works now too. (didn't work with the old code). (afterwards I realized this is only an issue under v1, not v2. so I moved the test to v1)

Open Graph Description: Made it a recursive loop while sticking to the current code as close as possible. All tests pass without any change, and my new test works now too. (didn't work with the old code). (afterwards ...

X Description: Made it a recursive loop while sticking to the current code as close as possible. All tests pass without any change, and my new test works now too. (didn't work with the old code). (afterwa...

Opengraph URL: https://github.com/tcalmant/python-javaobj/pull/61

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bf58681c-bfff-3f40-0020-43522f375a7e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id873E:B7306:1E60C25:29F0EF9:696AB0BA
html-safe-nonce2a03f60c936d955e7130f9055539a77a01a34681d1112a1b9c3b4c41ebac43ef
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzNFOkI3MzA2OjFFNjBDMjU6MjlGMEVGOTo2OTZBQjBCQSIsInZpc2l0b3JfaWQiOiIyMDk3ODAyMTk1MzkyNzA0Njk4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7ca204f6cbd7fcadde6fa1c28e111ef1e74bfac6d7a6c9dd55eaefd96969eca8
hovercard-subject-tagpull_request:2577840865
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/tcalmant/python-javaobj/pull/61/files
twitter:imagehttps://avatars.githubusercontent.com/u/199434?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/199434?s=400&v=4
og:image:altMade it a recursive loop while sticking to the current code as close as possible. All tests pass without any change, and my new test works now too. (didn't work with the old code). (afterwards ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4fa1799b6a53c2d30c950d74230781bef9e7f61138c72c7727e4b83f0743752b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/tcalmant/python-javaobj git https://github.com/tcalmant/python-javaobj.git
octolytics-dimension-user_id1540582
octolytics-dimension-user_logintcalmant
octolytics-dimension-repository_id15333794
octolytics-dimension-repository_nwotcalmant/python-javaobj
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id15333794
octolytics-dimension-repository_network_root_nwotcalmant/python-javaobj
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release41f276818bd204c4a30a0281fb3c576298d9474c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/tcalmant/python-javaobj/pull/61/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftcalmant%2Fpython-javaobj%2Fpull%2F61%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftcalmant%2Fpython-javaobj%2Fpull%2F61%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=tcalmant%2Fpython-javaobj
Reloadhttps://github.com/tcalmant/python-javaobj/pull/61/files
Reloadhttps://github.com/tcalmant/python-javaobj/pull/61/files
Reloadhttps://github.com/tcalmant/python-javaobj/pull/61/files
tcalmant https://github.com/tcalmant
python-javaobjhttps://github.com/tcalmant/python-javaobj
Notifications https://github.com/login?return_to=%2Ftcalmant%2Fpython-javaobj
Fork 20 https://github.com/login?return_to=%2Ftcalmant%2Fpython-javaobj
Star 86 https://github.com/login?return_to=%2Ftcalmant%2Fpython-javaobj
Code https://github.com/tcalmant/python-javaobj
Issues 9 https://github.com/tcalmant/python-javaobj/issues
Pull requests 1 https://github.com/tcalmant/python-javaobj/pulls
Actions https://github.com/tcalmant/python-javaobj/actions
Wiki https://github.com/tcalmant/python-javaobj/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/tcalmant/python-javaobj/security
Please reload this pagehttps://github.com/tcalmant/python-javaobj/pull/61/files
Insights https://github.com/tcalmant/python-javaobj/pulse
Code https://github.com/tcalmant/python-javaobj
Issues https://github.com/tcalmant/python-javaobj/issues
Pull requests https://github.com/tcalmant/python-javaobj/pulls
Actions https://github.com/tcalmant/python-javaobj/actions
Wiki https://github.com/tcalmant/python-javaobj/wiki
Security https://github.com/tcalmant/python-javaobj/security
Insights https://github.com/tcalmant/python-javaobj/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftcalmant%2Fpython-javaobj%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftcalmant%2Fpython-javaobj%2Fissues%2Fnew%2Fchoose
svaningelgemhttps://github.com/svaningelgem
tcalmant:masterhttps://github.com/tcalmant/python-javaobj/tree/master
svaningelgem:fix-for-custom-readerhttps://github.com/svaningelgem/python-javaobj/tree/fix-for-custom-reader
Conversation 0 https://github.com/tcalmant/python-javaobj/pull/61
Commits 4 https://github.com/tcalmant/python-javaobj/pull/61/commits
Checks 0 https://github.com/tcalmant/python-javaobj/pull/61/checks
Files changed https://github.com/tcalmant/python-javaobj/pull/61/files
Please reload this pagehttps://github.com/tcalmant/python-javaobj/pull/61/files
fix: Custom reader should read till endblock https://github.com/tcalmant/python-javaobj/pull/61/files#top
Show all changes 4 commits https://github.com/tcalmant/python-javaobj/pull/61/files
14aa441 Adding test data svaningelgem Jun 9, 2025 https://github.com/tcalmant/python-javaobj/pull/61/commits/14aa44172355dec4c674af9a0263480813e5fcec
67c629f Changed code svaningelgem Jun 9, 2025 https://github.com/tcalmant/python-javaobj/pull/61/commits/67c629f9f777b828faa59a47c3c070fe3ac56d1e
eebea7e Fixed the issue. svaningelgem Jun 9, 2025 https://github.com/tcalmant/python-javaobj/pull/61/commits/eebea7ef53f8303a076a66075ffd8457f8ab9412
1bf2a23 Only an issue under v1, not v2 svaningelgem Jun 9, 2025 https://github.com/tcalmant/python-javaobj/pull/61/commits/1bf2a236d93142965cf9aafb4eb554f8bcca8e8b
Clear filters https://github.com/tcalmant/python-javaobj/pull/61/files
Please reload this pagehttps://github.com/tcalmant/python-javaobj/pull/61/files
Please reload this pagehttps://github.com/tcalmant/python-javaobj/pull/61/files
unmarshaller.py https://github.com/tcalmant/python-javaobj/pull/61/files#diff-37533c74aaa9fc31b901cdbea4f492394e51e3d11ba1a68bb83d1848c3b75787
issue60_custom_reader_endblock.ser https://github.com/tcalmant/python-javaobj/pull/61/files#diff-a3561a23f3046c32ef8f14de802c3cd341ede80d43c82a69042d6d496acff925
Issue60CustomReaderEndblock.java https://github.com/tcalmant/python-javaobj/pull/61/files#diff-7e69e5bcfbc9164762eefe705867c386510bce2bc1914f8491990af6077f5dd2
test_v1.py https://github.com/tcalmant/python-javaobj/pull/61/files#diff-8d8ba22e73ee4a9ada85d578f878761d988f380fdc122d93d74261329d5a4b48
test_v2.py https://github.com/tcalmant/python-javaobj/pull/61/files#diff-2fc73b82a61be77fee23554509c68e8a8a2599b3b820f57fb46bb5d90d4cbd9f
javaobj/v1/unmarshaller.pyhttps://github.com/tcalmant/python-javaobj/pull/61/files#diff-37533c74aaa9fc31b901cdbea4f492394e51e3d11ba1a68bb83d1848c3b75787
View file https://github.com/tcalmant/python-javaobj/blob/1bf2a236d93142965cf9aafb4eb554f8bcca8e8b/javaobj/v1/unmarshaller.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/tcalmant/python-javaobj/pull/61/{{ revealButtonHref }}
https://github.com/tcalmant/python-javaobj/pull/61/files#diff-37533c74aaa9fc31b901cdbea4f492394e51e3d11ba1a68bb83d1848c3b75787
https://github.com/tcalmant/python-javaobj/pull/61/files#diff-37533c74aaa9fc31b901cdbea4f492394e51e3d11ba1a68bb83d1848c3b75787
https://github.com/tcalmant/python-javaobj/pull/61/files#diff-37533c74aaa9fc31b901cdbea4f492394e51e3d11ba1a68bb83d1848c3b75787
https://github.com/tcalmant/python-javaobj/pull/61/files#diff-37533c74aaa9fc31b901cdbea4f492394e51e3d11ba1a68bb83d1848c3b75787
tests/issue60_custom_reader_endblock.serhttps://github.com/tcalmant/python-javaobj/pull/61/files#diff-a3561a23f3046c32ef8f14de802c3cd341ede80d43c82a69042d6d496acff925
View file https://github.com/tcalmant/python-javaobj/blob/1bf2a236d93142965cf9aafb4eb554f8bcca8e8b/tests/issue60_custom_reader_endblock.ser
Open in desktop https://desktop.github.com
tests/java/src/test/java/Issue60CustomReaderEndblock.javahttps://github.com/tcalmant/python-javaobj/pull/61/files#diff-7e69e5bcfbc9164762eefe705867c386510bce2bc1914f8491990af6077f5dd2
View file https://github.com/tcalmant/python-javaobj/blob/1bf2a236d93142965cf9aafb4eb554f8bcca8e8b/tests/java/src/test/java/Issue60CustomReaderEndblock.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/tcalmant/python-javaobj/pull/61/{{ revealButtonHref }}
tests/test_v1.pyhttps://github.com/tcalmant/python-javaobj/pull/61/files#diff-8d8ba22e73ee4a9ada85d578f878761d988f380fdc122d93d74261329d5a4b48
View file https://github.com/tcalmant/python-javaobj/blob/1bf2a236d93142965cf9aafb4eb554f8bcca8e8b/tests/test_v1.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/tcalmant/python-javaobj/pull/61/{{ revealButtonHref }}
https://github.com/tcalmant/python-javaobj/pull/61/files#diff-8d8ba22e73ee4a9ada85d578f878761d988f380fdc122d93d74261329d5a4b48
https://github.com/tcalmant/python-javaobj/pull/61/files#diff-8d8ba22e73ee4a9ada85d578f878761d988f380fdc122d93d74261329d5a4b48
tests/test_v2.pyhttps://github.com/tcalmant/python-javaobj/pull/61/files#diff-2fc73b82a61be77fee23554509c68e8a8a2599b3b820f57fb46bb5d90d4cbd9f
View file https://github.com/tcalmant/python-javaobj/blob/1bf2a236d93142965cf9aafb4eb554f8bcca8e8b/tests/test_v2.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/tcalmant/python-javaobj/pull/61/{{ revealButtonHref }}
https://github.com/tcalmant/python-javaobj/pull/61/files#diff-2fc73b82a61be77fee23554509c68e8a8a2599b3b820f57fb46bb5d90d4cbd9f
https://github.com/tcalmant/python-javaobj/pull/61/files#diff-2fc73b82a61be77fee23554509c68e8a8a2599b3b820f57fb46bb5d90d4cbd9f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.