René's URL Explorer Experiment


Title: Class flags by j8spencer · Pull Request #20 · tcalmant/python-javaobj · GitHub

Open Graph Title: Class flags by j8spencer · Pull Request #20 · tcalmant/python-javaobj

X Title: Class flags by j8spencer · Pull Request #20 · tcalmant/python-javaobj

Description: I've noticed that when a class has sever super-classes (ImmutableListMultimap in my specific example) and one of those has the SC_WRITE_METHOD flag set, it does not get folded together so that custom object data gets read. OR-ing the flags together for all super-classes seems to address. I've also changed the java byte-array unit test to test the output as a tuple of ints rather than a python bytestring. Tested mostly under python 2.7, all UTs pass (though there's still a warning about 5 unused bytes coming from one of the tests.) Updated Author attributions as well.

Open Graph Description: I've noticed that when a class has sever super-classes (ImmutableListMultimap in my specific example) and one of those has the SC_WRITE_METHOD flag set, it does not get folded together so that ...

X Description: I've noticed that when a class has sever super-classes (ImmutableListMultimap in my specific example) and one of those has the SC_WRITE_METHOD flag set, it does not get folded together so t...

Opengraph URL: https://github.com/tcalmant/python-javaobj/pull/20

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:5efb4db5-a3d2-ab0d-2bf8-22dceb0f3ee7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBAA0:26CD5C:24CA86C:319A85B:699594BC
html-safe-nonce7091a401e2acb900696321580833c10e3c5d2718c9dd65ac9d22568a66869863
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQUEwOjI2Q0Q1QzoyNENBODZDOjMxOUE4NUI6Njk5NTk0QkMiLCJ2aXNpdG9yX2lkIjoiMjU3NTI0OTE4MTEzMzYwODEyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacea437289e284b8186551985abae69c247b55c496c12bd0db62045aefe07b2fe7
hovercard-subject-tagpull_request:163501756
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/tcalmant/python-javaobj/pull/20/commits/a58988f5a3e12329f59746b726ad9ef29ccc70e3
twitter:imagehttps://avatars.githubusercontent.com/u/3871892?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3871892?s=400&v=4
og:image:altI've noticed that when a class has sever super-classes (ImmutableListMultimap in my specific example) and one of those has the SC_WRITE_METHOD flag set, it does not get folded together so that ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4bd759bc5f83244e2a0de29b937365905c0fefd238b6f077c24a49830375b4df
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/tcalmant/python-javaobj git https://github.com/tcalmant/python-javaobj.git
octolytics-dimension-user_id1540582
octolytics-dimension-user_logintcalmant
octolytics-dimension-repository_id15333794
octolytics-dimension-repository_nwotcalmant/python-javaobj
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id15333794
octolytics-dimension-repository_network_root_nwotcalmant/python-javaobj
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84938599335a8dc49305d1a140adf6e19877540a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/tcalmant/python-javaobj/pull/20/commits/a58988f5a3e12329f59746b726ad9ef29ccc70e3#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftcalmant%2Fpython-javaobj%2Fpull%2F20%2Fcommits%2Fa58988f5a3e12329f59746b726ad9ef29ccc70e3
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftcalmant%2Fpython-javaobj%2Fpull%2F20%2Fcommits%2Fa58988f5a3e12329f59746b726ad9ef29ccc70e3
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=tcalmant%2Fpython-javaobj
Reloadhttps://github.com/tcalmant/python-javaobj/pull/20/commits/a58988f5a3e12329f59746b726ad9ef29ccc70e3
Reloadhttps://github.com/tcalmant/python-javaobj/pull/20/commits/a58988f5a3e12329f59746b726ad9ef29ccc70e3
Reloadhttps://github.com/tcalmant/python-javaobj/pull/20/commits/a58988f5a3e12329f59746b726ad9ef29ccc70e3
tcalmant https://github.com/tcalmant
python-javaobjhttps://github.com/tcalmant/python-javaobj
Notifications https://github.com/login?return_to=%2Ftcalmant%2Fpython-javaobj
Fork 20 https://github.com/login?return_to=%2Ftcalmant%2Fpython-javaobj
Star 85 https://github.com/login?return_to=%2Ftcalmant%2Fpython-javaobj
Code https://github.com/tcalmant/python-javaobj
Issues 9 https://github.com/tcalmant/python-javaobj/issues
Pull requests 1 https://github.com/tcalmant/python-javaobj/pulls
Actions https://github.com/tcalmant/python-javaobj/actions
Wiki https://github.com/tcalmant/python-javaobj/wiki
Security 0 https://github.com/tcalmant/python-javaobj/security
Insights https://github.com/tcalmant/python-javaobj/pulse
Code https://github.com/tcalmant/python-javaobj
Issues https://github.com/tcalmant/python-javaobj/issues
Pull requests https://github.com/tcalmant/python-javaobj/pulls
Actions https://github.com/tcalmant/python-javaobj/actions
Wiki https://github.com/tcalmant/python-javaobj/wiki
Security https://github.com/tcalmant/python-javaobj/security
Insights https://github.com/tcalmant/python-javaobj/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ftcalmant%2Fpython-javaobj%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ftcalmant%2Fpython-javaobj%2Fissues%2Fnew%2Fchoose
tcalmanthttps://github.com/tcalmant
masterhttps://github.com/tcalmant/python-javaobj/tree/master
classFlagshttps://github.com/tcalmant/python-javaobj/tree/classFlags
Conversation 3 https://github.com/tcalmant/python-javaobj/pull/20
Commits 3 https://github.com/tcalmant/python-javaobj/pull/20/commits
Checks 0 https://github.com/tcalmant/python-javaobj/pull/20/checks
Files changed https://github.com/tcalmant/python-javaobj/pull/20/files
Please reload this pagehttps://github.com/tcalmant/python-javaobj/pull/20/commits/a58988f5a3e12329f59746b726ad9ef29ccc70e3
Class flags https://github.com/tcalmant/python-javaobj/pull/20/commits/a58988f5a3e12329f59746b726ad9ef29ccc70e3#top
Show all changes 3 commits https://github.com/tcalmant/python-javaobj/pull/20/files
a58988f OR together all flags for base classes; change byte array unit test c… ggjspencer Jan 16, 2018 https://github.com/tcalmant/python-javaobj/pull/20/commits/a58988f5a3e12329f59746b726ad9ef29ccc70e3
9f51d88 add author attribution ggjspencer Jan 16, 2018 https://github.com/tcalmant/python-javaobj/pull/20/commits/9f51d880cd281b176f3a6d799f9d320d81db35ef
7b77e22 fix spacing ggjspencer Jan 17, 2018 https://github.com/tcalmant/python-javaobj/pull/20/commits/7b77e22009c72f2fc1e3d9b7f15539520ff968f5
Clear filters https://github.com/tcalmant/python-javaobj/pull/20/commits/a58988f5a3e12329f59746b726ad9ef29ccc70e3
Please reload this pagehttps://github.com/tcalmant/python-javaobj/pull/20/commits/a58988f5a3e12329f59746b726ad9ef29ccc70e3
Please reload this pagehttps://github.com/tcalmant/python-javaobj/pull/20/commits/a58988f5a3e12329f59746b726ad9ef29ccc70e3
javaobj.py https://github.com/tcalmant/python-javaobj/pull/20/commits/a58988f5a3e12329f59746b726ad9ef29ccc70e3#diff-7558002049ed53689f18491d1bfc63c76d12287e2c29b9a2acf11fc6de8f4756
tests.py https://github.com/tcalmant/python-javaobj/pull/20/commits/a58988f5a3e12329f59746b726ad9ef29ccc70e3#diff-6337f0a34289544e437f2604c7c78f4455c4e211183b8bf450df853e0cff9efb
Next https://github.com/tcalmant/python-javaobj/pull/20/commits/9f51d880cd281b176f3a6d799f9d320d81db35ef
Please reload this pagehttps://github.com/tcalmant/python-javaobj/pull/20/commits/a58988f5a3e12329f59746b726ad9ef29ccc70e3
https://github.com/ggjspencer
ggjspencerhttps://github.com/tcalmant/python-javaobj/commits?author=ggjspencer
javaobj.pyhttps://github.com/tcalmant/python-javaobj/pull/20/commits/a58988f5a3e12329f59746b726ad9ef29ccc70e3#diff-7558002049ed53689f18491d1bfc63c76d12287e2c29b9a2acf11fc6de8f4756
View file https://github.com/tcalmant/python-javaobj/blob/a58988f5a3e12329f59746b726ad9ef29ccc70e3/javaobj.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/tcalmant/python-javaobj/pull/20/commits/{{ revealButtonHref }}
https://github.com/tcalmant/python-javaobj/pull/20/commits/a58988f5a3e12329f59746b726ad9ef29ccc70e3#diff-7558002049ed53689f18491d1bfc63c76d12287e2c29b9a2acf11fc6de8f4756
https://github.com/tcalmant/python-javaobj/pull/20/commits/a58988f5a3e12329f59746b726ad9ef29ccc70e3#diff-7558002049ed53689f18491d1bfc63c76d12287e2c29b9a2acf11fc6de8f4756
tests/tests.pyhttps://github.com/tcalmant/python-javaobj/pull/20/commits/a58988f5a3e12329f59746b726ad9ef29ccc70e3#diff-6337f0a34289544e437f2604c7c78f4455c4e211183b8bf450df853e0cff9efb
View file https://github.com/tcalmant/python-javaobj/blob/a58988f5a3e12329f59746b726ad9ef29ccc70e3/tests/tests.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/tcalmant/python-javaobj/pull/20/commits/{{ revealButtonHref }}
https://github.com/tcalmant/python-javaobj/pull/20/commits/a58988f5a3e12329f59746b726ad9ef29ccc70e3#diff-6337f0a34289544e437f2604c7c78f4455c4e211183b8bf450df853e0cff9efb
https://github.com/tcalmant/python-javaobj/pull/20/commits/a58988f5a3e12329f59746b726ad9ef29ccc70e3#diff-6337f0a34289544e437f2604c7c78f4455c4e211183b8bf450df853e0cff9efb
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.