| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e5bd4787-d4d4-6635-c2f0-4f81ca9212e0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8056:8A91C:154A67:1D5C16:6AFBBC2D |
| html-safe-nonce | 4f828fe5295e329861fb1baaf927d301452c99fd843c1fa47c94e0643d107a35 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDU2OjhBOTFDOjE1NEE2NzoxRDVDMTY6NkFGQkJDMkQiLCJ2aXNpdG9yX2lkIjoiNjg5NDkxODE0ODMzNjM2ODY4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | bdcdd1fcbdfe427af46c412b79d76fd56b81eae4a1431a7c72459016b1a1a6ef |
| hovercard-subject-tag | pull_request:140993447 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/tabulapdf/tabula-java/187/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3d69f039002781230491a3dd93938a5c829b5e2882c1dcae15b3e39361b48389/tabulapdf/tabula-java/pull/187 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3d69f039002781230491a3dd93938a5c829b5e2882c1dcae15b3e39361b48389/tabulapdf/tabula-java/pull/187 |
| og:image:alt | Done some work towards removing the use of sorting when not 100% appropriate (see #116).
Also, removed unnecessary generic type parameters (eg: List<X> = new ArrayList<X>()) and done so... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | giorgiga |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2b2ef9c1578c18d8ed27027940544c958743213cf4461659f14d3ccdf51e162c |
| turbo-cache-control | no-cache |
| go-import | github.com/tabulapdf/tabula-java git https://github.com/tabulapdf/tabula-java.git |
| octolytics-dimension-user_id | 8267906 |
| octolytics-dimension-user_login | tabulapdf |
| octolytics-dimension-repository_id | 20046106 |
| octolytics-dimension-repository_nwo | tabulapdf/tabula-java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20046106 |
| octolytics-dimension-repository_network_root_nwo | tabulapdf/tabula-java |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e4cce0e99cf61481a318ff12c2e8580153a6c7c6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/tabulapdf/tabula-java/pull/187#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftabulapdf%2Ftabula-java%2Fpull%2F187 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftabulapdf%2Ftabula-java%2Fpull%2F187 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=tabulapdf%2Ftabula-java |
| Reload | https://github.com/tabulapdf/tabula-java/pull/187 |
| Reload | https://github.com/tabulapdf/tabula-java/pull/187 |
| Reload | https://github.com/tabulapdf/tabula-java/pull/187 |
| tabulapdf | https://github.com/tabulapdf |
| tabula-java | https://github.com/tabulapdf/tabula-java |
| Code | https://github.com/tabulapdf/tabula-java |
| Issues182 (182) | https://github.com/tabulapdf/tabula-java/issues |
| Pull requests15 (15) | https://github.com/tabulapdf/tabula-java/pulls |
| Actions | https://github.com/tabulapdf/tabula-java/actions |
| Projects | https://github.com/tabulapdf/tabula-java/projects |
| Wiki | https://github.com/tabulapdf/tabula-java/wiki |
| Security and quality | https://github.com/tabulapdf/tabula-java/security |
| Insights | https://github.com/tabulapdf/tabula-java/pulse |
| https://github.com/tabulapdf/tabula-java |
| jazzido | https://github.com/jazzido |
| tabulapdf:master | https://github.com/tabulapdf/tabula-java/tree/master |
| Conversation | https://github.com/tabulapdf/tabula-java/pull/187 |
| Commits19 (19) | https://github.com/tabulapdf/tabula-java/pull/187/commits |
| Checks | https://github.com/tabulapdf/tabula-java/pull/187/checks |
| Files changed | https://github.com/tabulapdf/tabula-java/pull/187/files |
| General cleanup and refactoring | https://github.com/tabulapdf/tabula-java/pull/187#top |
| jazzido | https://github.com/jazzido |
| tabulapdf:master | https://github.com/tabulapdf/tabula-java/tree/master |
|
| https://github.com/giorgiga |
| giorgiga | https://github.com/giorgiga |
| Sep 14, 2017 | https://github.com/tabulapdf/tabula-java/pull/187#issue-257610551 |
| #116 | https://github.com/tabulapdf/tabula-java/issues/116 |
| Please reload this page | https://github.com/tabulapdf/tabula-java/pull/187 |
| giorgiga | https://github.com/giorgiga |
| August 29, 2017 21:04 | https://github.com/tabulapdf/tabula-java/pull/187#commits-pushed-2b8a16e |
|
| https://github.com/giorgiga |
| Merged the implementations of compareTo in Rectangle and TextChunk | https://github.com/tabulapdf/tabula-java/pull/187/commits/2b8a16ef39c22916cdfd4b691bf31b4fe5a40c0a |
| 2b8a16e | https://github.com/tabulapdf/tabula-java/pull/187/commits/2b8a16ef39c22916cdfd4b691bf31b4fe5a40c0a |
|
| https://github.com/giorgiga |
| Added test cases for the Rectangle.coparateTo() transitivity issue | https://github.com/tabulapdf/tabula-java/pull/187/commits/b0613f7b6ad23e353e55747a1e7dc2a0fde4e0bf |
| b0613f7 | https://github.com/tabulapdf/tabula-java/pull/187/commits/b0613f7b6ad23e353e55747a1e7dc2a0fde4e0bf |
|
| https://github.com/giorgiga |
| Cleaned up classes CSVWriter and TSVWriter | https://github.com/tabulapdf/tabula-java/pull/187/commits/0a5fccc039bc2bcfd8e28bf2643fb021ee484798 |
| 0a5fccc | https://github.com/tabulapdf/tabula-java/pull/187/commits/0a5fccc039bc2bcfd8e28bf2643fb021ee484798 |
|
| https://github.com/giorgiga |
| Cleanup of JSONWriter and related classes | https://github.com/tabulapdf/tabula-java/pull/187/commits/88eb34d5dbfc650008220a7549a4b55997f79a78 |
| 88eb34d | https://github.com/tabulapdf/tabula-java/pull/187/commits/88eb34d5dbfc650008220a7549a4b55997f79a78 |
|
| https://github.com/giorgiga |
| JSONWriter clanup | https://github.com/tabulapdf/tabula-java/pull/187/commits/2b5ef5c551668324bc261c0beaf2aa53797e24bc |
| 2b5ef5c | https://github.com/tabulapdf/tabula-java/pull/187/commits/2b5ef5c551668324bc261c0beaf2aa53797e24bc |
|
| https://github.com/giorgiga |
| More cleanup | https://github.com/tabulapdf/tabula-java/pull/187/commits/7efdcd778883bdc9a4f914c0d68905862105708d |
| 7efdcd7 | https://github.com/tabulapdf/tabula-java/pull/187/commits/7efdcd778883bdc9a4f914c0d68905862105708d |
|
| https://github.com/giorgiga |
| Even more cleanup | https://github.com/tabulapdf/tabula-java/pull/187/commits/88f85d482a597cf5e3c1dd441eb18630483279a0 |
| 88f85d4 | https://github.com/tabulapdf/tabula-java/pull/187/commits/88f85d482a597cf5e3c1dd441eb18630483279a0 |
|
| https://github.com/giorgiga |
| Additional test case for | https://github.com/tabulapdf/tabula-java/pull/187/commits/3f5e3eaa04c4f305649a30d27a90a1af9e0e7bc5 |
| #116 | https://github.com/tabulapdf/tabula-java/issues/116 |
| 3f5e3ea | https://github.com/tabulapdf/tabula-java/pull/187/commits/3f5e3eaa04c4f305649a30d27a90a1af9e0e7bc5 |
|
| https://github.com/giorgiga |
| mvn eclipse:eclipse will now download sources | https://github.com/tabulapdf/tabula-java/pull/187/commits/90d3bc327fe719c1a63c6b20ea400ac2ea09c0e8 |
| 90d3bc3 | https://github.com/tabulapdf/tabula-java/pull/187/commits/90d3bc327fe719c1a63c6b20ea400ac2ea09c0e8 |
|
| https://github.com/giorgiga |
| deprecated a few seemengly unused methods in Page | https://github.com/tabulapdf/tabula-java/pull/187/commits/125dc3dab9fc5259663bd42f493a18e8ed98d807 |
| 125dc3d | https://github.com/tabulapdf/tabula-java/pull/187/commits/125dc3dab9fc5259663bd42f493a18e8ed98d807 |
|
| https://github.com/giorgiga |
| Redundant type arguments removed | https://github.com/tabulapdf/tabula-java/pull/187/commits/996073623c16e3ff231ad22106f8e1d4761c915c |
| 9960736 | https://github.com/tabulapdf/tabula-java/pull/187/commits/996073623c16e3ff231ad22106f8e1d4761c915c |
|
| https://github.com/giorgiga |
| Cosmetic changes | https://github.com/tabulapdf/tabula-java/pull/187/commits/e2076b6070873c32bff1c000e7d06cca7bcb4fc7 |
| e2076b6 | https://github.com/tabulapdf/tabula-java/pull/187/commits/e2076b6070873c32bff1c000e7d06cca7bcb4fc7 |
|
| https://github.com/giorgiga |
| Table.CellPosition made a static inner class | https://github.com/tabulapdf/tabula-java/pull/187/commits/76c2b1e58d5d2ddeb28a71b14984d710fec6e53e |
| 76c2b1e | https://github.com/tabulapdf/tabula-java/pull/187/commits/76c2b1e58d5d2ddeb28a71b14984d710fec6e53e |
|
| https://github.com/giorgiga |
| TestCellPosition removed (superfluous tests) | https://github.com/tabulapdf/tabula-java/pull/187/commits/f5f8a740ea354ecaa56b73052412fd21f9efe89a |
| f5f8a74 | https://github.com/tabulapdf/tabula-java/pull/187/commits/f5f8a740ea354ecaa56b73052412fd21f9efe89a |
|
| https://github.com/giorgiga |
| Started cleaning up Table | https://github.com/tabulapdf/tabula-java/pull/187/commits/48e16e45c7c0139795d4ff85a547e6c010f1d8bb |
| 48e16e4 | https://github.com/tabulapdf/tabula-java/pull/187/commits/48e16e45c7c0139795d4ff85a547e6c010f1d8bb |
|
| https://github.com/giorgiga |
| Rectangle no longer Comparable | https://github.com/tabulapdf/tabula-java/pull/187/commits/3436d20af2dbfeab6892d355940c6b076dce2754 |
| 3436d20 | https://github.com/tabulapdf/tabula-java/pull/187/commits/3436d20af2dbfeab6892d355940c6b076dce2754 |
|
| https://github.com/giorgiga |
| Refactoring | https://github.com/tabulapdf/tabula-java/pull/187/commits/948c1584a2412decbaa342debe1ed7292b75e79b |
| 948c158 | https://github.com/tabulapdf/tabula-java/pull/187/commits/948c1584a2412decbaa342debe1ed7292b75e79b |
|
| https://github.com/giorgiga |
| fixed for jdk 7 | https://github.com/tabulapdf/tabula-java/pull/187/commits/9ca4dc6f11f08d4e46a1cbe15977f1ef65f7e7ec |
| 9ca4dc6 | https://github.com/tabulapdf/tabula-java/pull/187/commits/9ca4dc6f11f08d4e46a1cbe15977f1ef65f7e7ec |
| https://github.com/giorgiga |
| giorgiga | https://github.com/giorgiga |
|
Sep 14, 2017
| https://github.com/tabulapdf/tabula-java/pull/187#ref-issue-187330541 |
|
New Java sort Algorithm: "Comparison method violates its general contract"
#116
| https://github.com/tabulapdf/tabula-java/issues/116 |
| https://github.com/jazzido |
| jazzido | https://github.com/jazzido |
|
Sep 14, 2017
| https://github.com/tabulapdf/tabula-java/pull/187#pullrequestreview-62811344 |
|
View reviewed changes
| https://github.com/tabulapdf/tabula-java/pull/187/files/125dc3dab9fc5259663bd42f493a18e8ed98d807 |
| src/main/java/technology/tabula/Page.java | https://github.com/tabulapdf/tabula-java/pull/187/files/90d3bc327fe719c1a63c6b20ea400ac2ea09c0e8..125dc3dab9fc5259663bd42f493a18e8ed98d807#diff-966fb8ec1fe0c70bd5ba9ed4e615c1fafd0bb134b1f1c89c483f4aada03e20ac |
| jazzido | https://github.com/jazzido |
| Sep 14, 2017 | https://github.com/tabulapdf/tabula-java/pull/187#discussion_r138946077 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/tabulapdf/tabula/blob/master/lib/tabula_java_wrapper.rb#L102 | https://github.com/tabulapdf/tabula/blob/master/lib/tabula_java_wrapper.rb#L102 |
| Please reload this page | https://github.com/tabulapdf/tabula-java/pull/187 |
|
| https://github.com/giorgiga |
| removed deprecation from Page.getRotation() as it is used in the ruby… | https://github.com/tabulapdf/tabula-java/pull/187/commits/41b916ebe09f21d807ec4f3e7ed5a6de84069f22 |
| 41b916e | https://github.com/tabulapdf/tabula-java/pull/187/commits/41b916ebe09f21d807ec4f3e7ed5a6de84069f22 |
| https://github.com/jazzido |
| jazzido | https://github.com/jazzido |
|
Sep 14, 2017
| https://github.com/tabulapdf/tabula-java/pull/187#pullrequestreview-62816003 |
|
View reviewed changes
| https://github.com/tabulapdf/tabula-java/pull/187/files/41b916ebe09f21d807ec4f3e7ed5a6de84069f22 |
| https://github.com/jazzido |
| jazzido | https://github.com/jazzido |
| 1d0d797 | https://github.com/tabulapdf/tabula-java/commit/1d0d79773773a00bee1bf7cb81c6d7d5a9776a9f |
| Sep 14, 2017 | https://github.com/tabulapdf/tabula-java/pull/187#event-1249623848 |
| https://github.com/jazzido |
| jazzido | https://github.com/jazzido |
| Sep 14, 2017 | https://github.com/tabulapdf/tabula-java/pull/187#issuecomment-329544694 |
| Please reload this page | https://github.com/tabulapdf/tabula-java/pull/187 |
| https://github.co/hiddenchars |
| https://github.com/tabulapdf/tabula-java/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ftabulapdf%2Ftabula-java%2Fpull%2F187 |
|
| https://github.com/jazzido |
|
jazzido
| https://github.com/jazzido |
|
| https://github.com/tabulapdf/tabula-java/pull/187/files/41b916ebe09f21d807ec4f3e7ed5a6de84069f22 |
| Please reload this page | https://github.com/tabulapdf/tabula-java/pull/187 |
| Please reload this page | https://github.com/tabulapdf/tabula-java/pull/187 |
|
| https://github.com/giorgiga |
|
| https://github.com/jazzido |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |