René's URL Explorer Experiment


Title: Fix wrong deallocation management for JSClosure with FinalizationRegistry by kateinoigakukun · Pull Request #393 · swiftwasm/JavaScriptKit · GitHub

Open Graph Title: Fix wrong deallocation management for JSClosure with FinalizationRegistry by kateinoigakukun · Pull Request #393 · swiftwasm/JavaScriptKit

X Title: Fix wrong deallocation management for JSClosure with FinalizationRegistry by kateinoigakukun · Pull Request #393 · swiftwasm/JavaScriptKit

Description: In FinalizationRegistry mode, the swjs_free_host_function should be called with the Swift heap object ID, not the JS closure object ID. The wrong argument was causing: Swift closures to be leaked,...

Open Graph Description: In FinalizationRegistry mode, the swjs_free_host_function should be called with the Swift heap object ID, not the JS closure object ID. The wrong argument was causing: Swift closures to be leaked,...

X Description: In FinalizationRegistry mode, the swjs_free_host_function should be called with the Swift heap object ID, not the JS closure object ID. The wrong argument was causing: Swift closures to be leaked,...

Opengraph URL: https://github.com/swiftwasm/JavaScriptKit/pull/393

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ea746832-0c66-2e4b-b299-33ee2742672d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAB6C:1EC1C6:1D8607E:27C1294:69799012
html-safe-noncee42755d0e492c4a4f8f3a2c5aa25344ccb4f9d9b6b2190adc450ce9e14c20c82
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjZDOjFFQzFDNjoxRDg2MDdFOjI3QzEyOTQ6Njk3OTkwMTIiLCJ2aXNpdG9yX2lkIjoiODYzMjI3OTAyNDIzMzE4OTM5NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8ae3574bccd8db6798e73d593f33080c58c85fb9d417de779573e155ac1692a2
hovercard-subject-tagpull_request:2716058007
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/swiftwasm/JavaScriptKit/393/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8b2aabb192aab4b9320b15344fe56d5c1a769bfbfd809667575bdf4adf107da5/swiftwasm/JavaScriptKit/pull/393
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8b2aabb192aab4b9320b15344fe56d5c1a769bfbfd809667575bdf4adf107da5/swiftwasm/JavaScriptKit/pull/393
og:image:altIn FinalizationRegistry mode, the swjs_free_host_function should be called with the Swift heap object ID, not the JS closure object ID. The wrong argument was causing: Swift closures to be leaked,...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekateinoigakukun
hostnamegithub.com
expected-hostnamegithub.com
Nonec049b65ec7e54cbf2521f5a560b6527714c612b0bd169188e2ea6e16f83bd5f4
turbo-cache-controlno-preview
go-importgithub.com/swiftwasm/JavaScriptKit git https://github.com/swiftwasm/JavaScriptKit.git
octolytics-dimension-user_id49500752
octolytics-dimension-user_loginswiftwasm
octolytics-dimension-repository_id244832006
octolytics-dimension-repository_nwoswiftwasm/JavaScriptKit
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id244832006
octolytics-dimension-repository_network_root_nwoswiftwasm/JavaScriptKit
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release87b137883e35e2766c3d0f6a257c4044f6390b83
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/swiftwasm/JavaScriptKit/pull/393#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fswiftwasm%2FJavaScriptKit%2Fpull%2F393
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fswiftwasm%2FJavaScriptKit%2Fpull%2F393
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=swiftwasm%2FJavaScriptKit
Reloadhttps://github.com/swiftwasm/JavaScriptKit/pull/393
Reloadhttps://github.com/swiftwasm/JavaScriptKit/pull/393
Reloadhttps://github.com/swiftwasm/JavaScriptKit/pull/393
swiftwasm https://github.com/swiftwasm
JavaScriptKithttps://github.com/swiftwasm/JavaScriptKit
Please reload this pagehttps://github.com/swiftwasm/JavaScriptKit/pull/393
Notifications https://github.com/login?return_to=%2Fswiftwasm%2FJavaScriptKit
Fork 61 https://github.com/login?return_to=%2Fswiftwasm%2FJavaScriptKit
Star 833 https://github.com/login?return_to=%2Fswiftwasm%2FJavaScriptKit
Code https://github.com/swiftwasm/JavaScriptKit
Issues 26 https://github.com/swiftwasm/JavaScriptKit/issues
Pull requests 10 https://github.com/swiftwasm/JavaScriptKit/pulls
Actions https://github.com/swiftwasm/JavaScriptKit/actions
Projects 0 https://github.com/swiftwasm/JavaScriptKit/projects
Security 0 https://github.com/swiftwasm/JavaScriptKit/security
Insights https://github.com/swiftwasm/JavaScriptKit/pulse
Code https://github.com/swiftwasm/JavaScriptKit
Issues https://github.com/swiftwasm/JavaScriptKit/issues
Pull requests https://github.com/swiftwasm/JavaScriptKit/pulls
Actions https://github.com/swiftwasm/JavaScriptKit/actions
Projects https://github.com/swiftwasm/JavaScriptKit/projects
Security https://github.com/swiftwasm/JavaScriptKit/security
Insights https://github.com/swiftwasm/JavaScriptKit/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fswiftwasm%2FJavaScriptKit%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fswiftwasm%2FJavaScriptKit%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/swiftwasm/JavaScriptKit/pull/393#issue-comment-box
kateinoigakukunhttps://github.com/kateinoigakukun
mainhttps://github.com/swiftwasm/JavaScriptKit/tree/main
yt/jsclosure-fixhttps://github.com/swiftwasm/JavaScriptKit/tree/yt/jsclosure-fix
Fix wrong deallocation management for JSClosure with FinalizationRegistry https://github.com/swiftwasm/JavaScriptKit/pull/393#top
kateinoigakukunhttps://github.com/kateinoigakukun
mainhttps://github.com/swiftwasm/JavaScriptKit/tree/main
yt/jsclosure-fixhttps://github.com/swiftwasm/JavaScriptKit/tree/yt/jsclosure-fix
Conversation 0 https://github.com/swiftwasm/JavaScriptKit/pull/393
Commits 4 https://github.com/swiftwasm/JavaScriptKit/pull/393/commits
Checks 8 https://github.com/swiftwasm/JavaScriptKit/pull/393/checks
Files changed https://github.com/swiftwasm/JavaScriptKit/pull/393/files
Please reload this pagehttps://github.com/swiftwasm/JavaScriptKit/pull/393
https://github.co/hiddenchars
https://github.com/swiftwasm/JavaScriptKit/pull/{{ revealButtonHref }}
https://github.com/kateinoigakukun
kateinoigakukunhttps://github.com/kateinoigakukun
Aug 3, 2025https://github.com/swiftwasm/JavaScriptKit/pull/393#issue-3287222644
Please reload this pagehttps://github.com/swiftwasm/JavaScriptKit/pull/393
Please reload this pagehttps://github.com/swiftwasm/JavaScriptKit/pull/393
kateinoigakukunhttps://github.com/kateinoigakukun
August 4, 2025 01:16https://github.com/swiftwasm/JavaScriptKit/pull/393#commits-pushed-825f947
https://github.com/kateinoigakukun
Add test case to kill the wrong deallocation issue of JSClosurehttps://github.com/swiftwasm/JavaScriptKit/pull/393/commits/825f9471f64b75aa1af71b45ce5391a31cbf050c
825f947https://github.com/swiftwasm/JavaScriptKit/pull/393/commits/825f9471f64b75aa1af71b45ce5391a31cbf050c
https://github.com/kateinoigakukun
Fix wrong deallocation management for JSClosure with FinalizationRegi…https://github.com/swiftwasm/JavaScriptKit/pull/393/commits/db3a6e24f35dcf78d292def086816ef2ce6fb8c7
db3a6e2https://github.com/swiftwasm/JavaScriptKit/pull/393/commits/db3a6e24f35dcf78d292def086816ef2ce6fb8c7
https://github.com/kateinoigakukun
Stop managing JSOneshotClosure by FinalizationRegistryhttps://github.com/swiftwasm/JavaScriptKit/pull/393/commits/7f9094e7ba0ea797d26df7a16b5ffcd2be61be05
7f9094ehttps://github.com/swiftwasm/JavaScriptKit/pull/393/commits/7f9094e7ba0ea797d26df7a16b5ffcd2be61be05
https://github.com/kateinoigakukun
Add Swift closure heap address in the invalid closure reference errorhttps://github.com/swiftwasm/JavaScriptKit/pull/393/commits/5f01593f4c3eb0421b62fcefdf6de09fc0ba6b6b
5f01593https://github.com/swiftwasm/JavaScriptKit/pull/393/commits/5f01593f4c3eb0421b62fcefdf6de09fc0ba6b6b
https://github.com/kateinoigakukun
kateinoigakukunhttps://github.com/kateinoigakukun
force-pushedhttps://github.com/swiftwasm/JavaScriptKit/compare/75da16570dc7cff84c94e6366e4b46fa27607a99..5f01593f4c3eb0421b62fcefdf6de09fc0ba6b6b
75da165https://github.com/swiftwasm/JavaScriptKit/commit/75da16570dc7cff84c94e6366e4b46fa27607a99
5f01593https://github.com/swiftwasm/JavaScriptKit/commit/5f01593f4c3eb0421b62fcefdf6de09fc0ba6b6b
Compare https://github.com/swiftwasm/JavaScriptKit/compare/75da16570dc7cff84c94e6366e4b46fa27607a99..5f01593f4c3eb0421b62fcefdf6de09fc0ba6b6b
August 3, 2025 16:16https://github.com/swiftwasm/JavaScriptKit/pull/393#event-18958214069
https://github.com/lowkahonn
lowkahonnhttps://github.com/lowkahonn
Aug 4, 2025 https://github.com/swiftwasm/JavaScriptKit/pull/393#pullrequestreview-3082517202
View reviewed changes https://github.com/swiftwasm/JavaScriptKit/pull/393/files/5f01593f4c3eb0421b62fcefdf6de09fc0ba6b6b
https://github.com/kateinoigakukun
kateinoigakukunhttps://github.com/kateinoigakukun
4504e13https://github.com/swiftwasm/JavaScriptKit/commit/4504e13a5a87227c43e181f69279c8c7d05f1209
Aug 4, 2025https://github.com/swiftwasm/JavaScriptKit/pull/393#event-18960989641
Please reload this pagehttps://github.com/swiftwasm/JavaScriptKit/pull/393
https://github.com/kateinoigakukun
kateinoigakukunhttps://github.com/kateinoigakukun
August 4, 2025 02:46https://github.com/swiftwasm/JavaScriptKit/pull/393#event-18960989866
https://github.com/kateinoigakukun
kateinoigakukunhttps://github.com/kateinoigakukun
Aug 9, 2025 https://github.com/swiftwasm/JavaScriptKit/pull/393#ref-pullrequest-3305984377
Add memory stress tests for JSObject and JSClosure #399 https://github.com/swiftwasm/JavaScriptKit/pull/399
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fswiftwasm%2FJavaScriptKit%2Fpull%2F393
https://github.com/lowkahonn
lowkahonn https://github.com/lowkahonn
https://github.com/swiftwasm/JavaScriptKit/pull/393/files/5f01593f4c3eb0421b62fcefdf6de09fc0ba6b6b
Please reload this pagehttps://github.com/swiftwasm/JavaScriptKit/pull/393
https://github.com/kateinoigakukun
https://github.com/lowkahonn
https://github.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.