Title: c++ libs using hash.c instead of scl_hash.cc · Issue #144 · stepcode/stepcode · GitHub
Open Graph Title: c++ libs using hash.c instead of scl_hash.cc · Issue #144 · stepcode/stepcode
X Title: c++ libs using hash.c instead of scl_hash.cc · Issue #144 · stepcode/stepcode
Description: Going through the memory warnings from the dw/memmgr branch, I noticed that p21read was using functions in hash.c instead of scl_hash.cc. I don't think that p21read or the step* libs should be linked to libexpress. However, I get a linke...
Open Graph Description: Going through the memory warnings from the dw/memmgr branch, I noticed that p21read was using functions in hash.c instead of scl_hash.cc. I don't think that p21read or the step* libs should be link...
X Description: Going through the memory warnings from the dw/memmgr branch, I noticed that p21read was using functions in hash.c instead of scl_hash.cc. I don't think that p21read or the step* libs should be ...
Opengraph URL: https://github.com/stepcode/stepcode/issues/144
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"c++ libs using hash.c instead of scl_hash.cc","articleBody":"Going through the memory warnings from the dw/memmgr branch, I noticed that p21read was using functions in `hash.c` instead of `scl_hash.cc`. I don't think that `p21read` or the `step*` libs should be linked to libexpress. However, I get a linker error when I make the following change.\n\n``` diff\n\ndiff --git a/data/CMakeLists.txt b/data/CMakeLists.txt\nindex e7382d2..aae45b5 100644\n--- a/data/CMakeLists.txt\n+++ b/data/CMakeLists.txt\n@@ -72,7 +72,7 @@ FUNCTION(BUILD_A_SCHEMA SCHEMA_FILE)\n add_definitions( -DSCL_EDITOR_DLL_IMPORTS )\n endif()\n add_library( ${PROJECT_NAME} SHARED ${FEDEX_OUT} )\n- target_link_libraries(${PROJECT_NAME} stepdai stepcore express stepeditor steputils )\n+ target_link_libraries(${PROJECT_NAME} stepdai stepcore stepeditor steputils )\n add_dependencies( ${PROJECT_NAME} generate_cpp_${SCHEMA_SHORT_NAME} )\n set_target_properties( ${PROJECT_NAME} PROPERTIES COMPILE_FLAGS\n ${${PROJECT_NAME}_COMPILE_FLAGS} )\ndiff --git a/src/clstepcore/CMakeLists.txt b/src/clstepcore/CMakeLists.txt\nindex 2faa888..1065026 100644\n--- a/src/clstepcore/CMakeLists.txt\n+++ b/src/clstepcore/CMakeLists.txt\n@@ -83,7 +83,7 @@ include_directories(\n ${SCL_SOURCE_DIR}/src/clutils\n )\n\n-SCL_ADDLIB(stepcore \"${LIBSTEPCORE_SRCS} ${LIBDEPEND_SRCS}\" \"express steputils stepdai\")\n+SCL_ADDLIB(stepcore \"${LIBSTEPCORE_SRCS} ${LIBDEPEND_SRCS}\" \"steputils stepdai\")\n if(APPLE)\n set_target_properties(stepcore PROPERTIES LINK_FLAGS \"-flat_namespace -undefined suppress\")\n endif(APPLE)\n```\n\nlinker error:\n\n```\nLinking CXX executable ../bin/p21read_sdai_ap227\n../lib/libstepcore.so.3.2: undefined reference to `HASHinitialize' \n```\n\nI think that it should find the function in `steputils` - that lib is linked - but it doesn't.\n","author":{"url":"https://github.com/mpictor","@type":"Person","name":"mpictor"},"datePublished":"2012-02-22T10:01:48.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":12},"url":"https://github.com/144/stepcode/issues/144"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e59011ec-6723-c6b1-d272-87f39bff26e5 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C330:3D45D4:379FC3:45FD06:69751F11 |
| html-safe-nonce | c52a7602bca44b0aa892178e13680ded13ff1120ca42ff0fca7be4ddc73643f0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzMwOjNENDVENDozNzlGQzM6NDVGRDA2OjY5NzUxRjExIiwidmlzaXRvcl9pZCI6IjY3NjM0MTIyNjY5NTY0MzExMjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b8b8ece16aeb65fbfc1dc525f57322204f1f5a8324b05a13f7c70b6daed62f71 |
| hovercard-subject-tag | issue:3330294 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/stepcode/stepcode/144/issue_layout |
| twitter:image | https://opengraph.githubassets.com/dd99770228f514f272c59b333d277110fe5b95bda91624489508ffb298b1eb44/stepcode/stepcode/issues/144 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/dd99770228f514f272c59b333d277110fe5b95bda91624489508ffb298b1eb44/stepcode/stepcode/issues/144 |
| og:image:alt | Going through the memory warnings from the dw/memmgr branch, I noticed that p21read was using functions in hash.c instead of scl_hash.cc. I don't think that p21read or the step* libs should be link... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mpictor |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4a4bf5f4e28041a9d2e5c107d7d20b78b4294ba261cab243b28167c16a623a1f |
| turbo-cache-control | no-preview |
| go-import | github.com/stepcode/stepcode git https://github.com/stepcode/stepcode.git |
| octolytics-dimension-user_id | 1761770 |
| octolytics-dimension-user_login | stepcode |
| octolytics-dimension-repository_id | 1975387 |
| octolytics-dimension-repository_nwo | stepcode/stepcode |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1975387 |
| octolytics-dimension-repository_network_root_nwo | stepcode/stepcode |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 488b30e96dfd057fbbe44c6665ccbc030b729dde |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width